From: patchwork-bot+netdevbpf@kernel.org
To: Yige Jiang <yigejiang86@gmail.com>
Cc: netdev@vger.kernel.org, ilias.apalodimas@linaro.org,
kojima.masahisa@socionext.com, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] net: netsec: fix device_node reference leak on phy_np
Date: Thu, 17 Sep 2026 00:40:08 +0000 [thread overview]
Message-ID: <178960560887.3354472.8942406926487476518.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20260913064102.37452-1-yigejiang86@gmail.com>
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Sun, 13 Sep 2026 14:41:02 +0800 you wrote:
> netsec_of_probe() takes a reference on the PHY device_node with
> of_parse_phandle() and stores it in priv->phy_np, but the driver never
> drops it. One device_node reference is leaked per probe, on the success
> path as well as on every error path reached after netsec_of_probe().
>
> Neither consumer takes ownership. of_mdio_parse_addr() is a static
> inline taking a const struct device_node * that only reads the "reg"
> property. of_phy_connect() borrows as well: of_phy_get_and_connect() in
> drivers/net/mdio/of_mdio.c brackets its own call with of_node_get() at
> :364 and of_node_put() at :373, which would be a double put if
> of_phy_connect() consumed the reference.
>
> [...]
Here is the summary with links:
- [net-next] net: netsec: fix device_node reference leak on phy_np
https://git.kernel.org/netdev/net/c/5ae916fabca1
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2026-09-17 0:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-13 6:41 [PATCH net-next] net: netsec: fix device_node reference leak on phy_np Yige Jiang
2026-09-14 10:41 ` Simon Horman
2026-09-16 2:28 ` kojima.masahisa
2026-09-17 0:40 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178960560887.3354472.8942406926487476518.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=ilias.apalodimas@linaro.org \
--cc=kojima.masahisa@socionext.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=yigejiang86@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.