From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 054D6C982E1 for ; Thu, 17 Sep 2026 18:38:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Cc:To:From:Subject:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dXs7VhDwtdL95tCK+BPnxCnRT1+LJncuHxLqSN2nH18=; b=17NMnXcCAuK6Il PwmcRVvVNN6Sxloyxoj3FD1lW2gTW5fJeRbp0Kt6c8stcFsnPbIGgT67oI0r5aKKtT3YIbCjE3/OJ FUPCn2GbxWl6kmShNCaV6Wx3cgVFrtmxjzwcKXkOIkcUV8At30+Hhb4ubeIVeJxIkt/f+EFUdRoKD v9nMu2FyfxNTVNZX/P205EMGI6W7aBb5p38oJIzbuA8v8ozBk9DCpaktKoAVgfWSFqKgcr2geu+7r K+0qhbMF3s4/Vc+Vs5YmCdI8LBszSZx3bpZ/h6ly0yH0mPvtFoA/CUM3bbUdBK/+yQm4wSw0coaSW AH6VS3ZjEshOCgQ7YNmQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x7H08-0000000CFQT-3Zu3; Thu, 17 Sep 2026 18:38:28 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x7H02-0000000CFJZ-19oo; Thu, 17 Sep 2026 18:38:22 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 0B44643E24; Thu, 17 Sep 2026 18:38:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7D2E31F000FF; Thu, 17 Sep 2026 18:38:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1789670301; bh=7/HZTASVkqKaji0QyjTNpQOcpYSX+5MHinbb2iPHtgk=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=DzUy4DNsPs6KVxt3KwqIt7hsBJPGJfY5+jH/P+/NawPmKCuwHebVhj5iWmcMGZab0 ivWn04rnlTtaofhzwCPdSwq0X6GdxAydr7CYNce8WNGUsE5uYRw712OW7NVlP+nyqt y+VISEl3gdx6iVV3h3pAG3y/kUgYM6UZex7J3xOwH7CS45MpkR238mqmq7cbCGQhAC hHvYz0hVDC0FiObk0dp3wjKiJkIMqZAvKHmY2T2uz+AyucMQGh++gjX3Axmhzm0v0M IbJu6pq1XWBIVbMX9pzHBNlM84TCf2lOZhIFGYwB1I6vB/2rGzD3h0E2OdqJ0RvXDy N6T9w5dr/lBpw== Subject: Re: [PATCH net-next v6 08/11] dt-bindings: net: rockchip-dwmac: document pcs-handle From: netdev-bot+sashiko@kernel.org To: coiaprant@gmail.com Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, heiko@sntech.de, vkoul@kernel.org, maxime.chevallier@bootlin.com, mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com, prabhakar.mahadev-lad.rj@bp.renesas.com, romain.gantois@bootlin.com, hkallweit1@gmail.com, neil.armstrong@linaro.org, linux@armlinux.org.uk, shawn.lin@rock-chips.com, david@ixit.cz, netdev@vger.kernel.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-renesas-soc@vger.kernel.org Date: Thu, 17 Sep 2026 18:38:20 +0000 Message-ID: <178967030009.22033.606150817628079939@kernel.org> In-Reply-To: <20260915123802.1561724-9-coiaprant@gmail.com> References: <20260915123802.1561724-9-coiaprant@gmail.com> X-sashiko-severity: Low MIME-Version: 1.0 X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MiBwb3RlbnRpYWwKaXNzdWUocykgdG8gY29uc2lkZXI6CgpDcml0aWNhbDogMCDCtyBIaWdoOiAw IMK3IE1lZGl1bTogMCDCtyBMb3c6IDIKCi0gW0xvd10gQ29tbWl0IG1lc3NhZ2UgZGVzY3JpYmVz IGNvZGUgdGhhdCBkb2VzIG5vdCBleGlzdCBhdCB0aGlzIGNvbW1pdDoKICB0aGUgbWVzc2FnZSBz dGF0ZXMgdGhlIFJvY2tjaGlwIGR3bWFjIGdsdWUgIm5vdyBzdXBwb3J0cyBTR01JSSBvbuKApgot IFtMb3ddIFRoZSBuZXcgYGFsbE9mYCBjb25kaXRpb25hbCBpbgogIERvY3VtZW50YXRpb24vZGV2 aWNldHJlZS9iaW5kaW5ncy9uZXQvcm9ja2NoaXAtZHdtYWMueWFtbCBrZXlzIG9ubHkgb27igKYK Ci0tCgpkdC1iaW5kaW5nczogbmV0OiByb2NrY2hpcC1kd21hYzogZG9jdW1lbnQgcGNzLWhhbmRs ZQoKVGhpcyBhZGRzIGEgcGNzLWhhbmRsZSBwcm9wZXJ0eSB0byB0aGUgUm9ja2NoaXAgR01BQyBi aW5kaW5nIGFuZCBhIG5ldwphbGxPZiBjb25kaXRpb25hbCBtYWtpbmcgaXQgcmVxdWlyZWQgd2hl bmV2ZXIgcGh5LW1vZGUgaXMgInNnbWlpIi4gIFR3bwpvYnNlcnZhdGlvbnMgYmVsb3csIG9uZSBh Ym91dCB0aGUgY29tbWl0IG1lc3NhZ2Ugd29yZGluZyBhbmQgb25lIGFib3V0CnRoZSBzY29wZSBv ZiB0aGUgbmV3IGNvbmRpdGlvbmFsLgoKPiAgICAgVGhlIFJvY2tjaGlwIGR3bWFjIGdsdWUgZHJp dmVyIG5vdyBzdXBwb3J0cyBTR01JSSBvbiBSSzM1NjggYW5kCj4gICAgIHJlcXVpcmVzIGEgUENT LCByZWZlcmVuY2VkIHRocm91Z2ggdGhlICJwY3MtaGFuZGxlIiBwcm9wZXJ0eS4gIFRoZQo+ICAg ICBwcm9wZXJ0eSBpcyBwYXJzZWQgYnkgcmtfcGNzX2luaXQoKSBhbmQgYSBtaXNzaW5nIHBoYW5k bGUgZmFpbHMgdGhlCj4gICAgIHByb2JlLCBzbyBkZXNjcmliZSBpdCBpbiB0aGUgYmluZGluZyBh bmQgcmVxdWlyZSBpdCB3aGVuIHBoeS1tb2RlCj4gICAgIGlzICJzZ21paSIuCgpbU2V2ZXJpdHk6 IExvd10KVGhpcyBpc24ndCBhIGJ1ZywgYnV0IHRoZSB3b3JkaW5nIGlzIGluIHRoZSBwYXN0IHRl bnNlIGZvciBjb2RlIHRoYXQgaXMgbm90CnByZXNlbnQgeWV0IGF0IHRoaXMgY29tbWl0LiAgQXQg ZmMyZTE5MDY2ZDA4LApkcml2ZXJzL25ldC9ldGhlcm5ldC9zdG1pY3JvL3N0bW1hYy9kd21hYy1y ay5jIGhhcyBubyBya19wY3NfaW5pdCgpLCBubwoicGNzLWhhbmRsZSIgcGFyc2luZywgYW5kIG5v IHBjc19pbml0L3Bjc19leGl0L3NlbGVjdF9wY3MgY2FsbGJhY2tzIG9yClNHTUlJIHN1cHBvcnQu CgpDaGVja2luZyB0aGUgZW5kIG9mIHRoZSBzZXJpZXMsIHRob3NlIGFsbCBhcnJpdmUgaW4gdGhl IGZvbGxvd2luZyBwYXRjaAooIm5ldDogc3RtbWFjOiBkd21hYy1yazogYWRkIFNHTUlJIHN1cHBv cnQgZm9yIFJLMzU2OCIpLCB3aGljaCBhZGRzCnJrX3Bjc19pbml0KCkgd2l0aDoKCglwY3Nfbm9k ZSA9IG9mX3BhcnNlX3BoYW5kbGUobnAsICJwY3MtaGFuZGxlIiwgMCk7CglpZiAoIXBjc19ub2Rl KQoJCXJldHVybiAtRU5PREVWOwoKYW5kIGluc3RhbGxzIHRoZSBjYWxsYmFja3MgaW4gcmtfZ21h Y19wcm9iZSgpIGZvcgpQSFlfSU5URVJGQUNFX01PREVfU0dNSUkuCgpQdXR0aW5nIHRoZSBiaW5k aW5nIGJlZm9yZSB0aGUgZHJpdmVyIGlzIHRoZSB1c3VhbCBjb252ZW50aW9uLCBzbyB3b3VsZCBp dApiZSB3b3J0aCByZXdvcmRpbmcgdG8gc2F5IHRoZSBwcm9wZXJ0eSB3aWxsIGJlIHBhcnNlZCBi eSBya19wY3NfaW5pdCgpIGluCnRoZSBmb2xsb3dpbmcgcGF0Y2gsIHJhdGhlciB0aGFuIHRoYXQg aXQgYWxyZWFkeSBpcz8KCj4gZGlmZiAtLWdpdCBhL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9i aW5kaW5ncy9uZXQvcm9ja2NoaXAtZHdtYWMueWFtbCBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJl ZS9iaW5kaW5ncy9uZXQvcm9ja2NoaXAtZHdtYWMueWFtbAo+IGluZGV4IDgwYzI1Mjg0NTM0OWMu LjY3YjIxZWE3N2VjOTYgMTAwNjQ0Cj4gLS0tIGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2Jp bmRpbmdzL25ldC9yb2NrY2hpcC1kd21hYy55YW1sCj4gKysrIGIvRG9jdW1lbnRhdGlvbi9kZXZp Y2V0cmVlL2JpbmRpbmdzL25ldC9yb2NrY2hpcC1kd21hYy55YW1sCj4gQEAgLTEyMCw2ICsxMjAs MTIgQEAgcHJvcGVydGllczoKPiAgICAgIG1heGltdW06IDB4N0YKPiAgICAgIGRlZmF1bHQ6IDB4 MTAKPiAgCj4gKyAgcGNzLWhhbmRsZToKPiArICAgIGRlc2NyaXB0aW9uOgo+ICsgICAgICBTcGVj aWZpZXMgYSByZWZlcmVuY2UgdG8gYSBub2RlIHJlcHJlc2VudGluZyB0aGUgUENTIGRldmljZQo+ ICsgICAgICBjb25uZWN0ZWQgdG8gdGhpcyBHTUFDLiBSZXF1aXJlZCB3aGVuIHBoeS1tb2RlIGlz ICJzZ21paSIuCj4gKyAgICBtYXhJdGVtczogMQo+ICsKPiAgcGh5LXN1cHBseToKPiAgICAgIGRl c2NyaXB0aW9uOiBQSFkgcmVndWxhdG9yCj4gIAo+IEBAIC0xNTksNiArMTY1LDE1IEBAIGFsbE9m Ogo+ICAgICAgICAgIGNsb2NrczoKPiAgICAgICAgICAgIG1pbkl0ZW1zOiA1Cj4gIAo+ICsgIC0g aWY6Cj4gKyAgICAgIHByb3BlcnRpZXM6Cj4gKyAgICAgICAgcGh5LW1vZGU6Cj4gKyAgICAgICAg ICBjb250YWluczoKPiArICAgICAgICAgICAgY29uc3Q6IHNnbWlpCj4gKyAgICB0aGVuOgo+ICsg ICAgICByZXF1aXJlZDoKPiArICAgICAgICAtIHBjcy1oYW5kbGUKPiArCgpbU2V2ZXJpdHk6IExv d10KU2hvdWxkIHRoaXMgY29uZGl0aW9uYWwgYWxzbyBrZXkgb24gY29tcGF0aWJsZT8gIEFzIHdy aXR0ZW4gaXQga2V5cyBvbmx5IG9uCnBoeS1tb2RlLCBzbyByZXF1aXJlZDogW3Bjcy1oYW5kbGVd IGFwcGxpZXMgdG8gYWxsIHNpeHRlZW4gY29tcGF0aWJsZXMgdGhpcwpzY2hlbWEgc2VsZWN0cyAo cHgzMCwgcmszMTI4LCByazMyMjgsIHJrMzI4OCwgcmszMzA4LCByazMzMjgsIHJrMzM2NiwKcmsz MzY4LCByazMzOTksIHJrMzUwNiwgcmszNTI4LCByazM1NjgsIHJrMzU3NiwgcmszNTg4LCBydjEx MDgsIHJ2MTEyNikuCgpBdCB0aGUgZW5kIG9mIHRoZSBzZXJpZXMgb25seSByazM1Njhfb3BzIHBy b3ZpZGVzIC5zZXRfdG9fc2dtaWksIGFuZApkd21hYy1yay5jIGRlcml2ZXMgdGhlIGNhcGFiaWxp dHkgZnJvbSBpdDoKCglic3BfcHJpdi0+c3VwcG9ydHNfc2dtaWkgPSBvcHMtPnN1cHBvcnRzX3Nn bWlpIHx8ICEhb3BzLT5zZXRfdG9fc2dtaWk7CgpzbyB0aGUgUENTIHJlcXVpcmVtZW50IGxvb2tz IHNwZWNpZmljIHRvIHJvY2tjaGlwLHJrMzU2OC1nbWFjLgoKVGhlIHJldmVyc2UgZGlyZWN0aW9u IGlzIG9wZW4gdG9vOiBwY3MtaGFuZGxlIGlzIGFkZGVkIHVuY29uZGl0aW9uYWxseSwgc28gYQpH TUFDIG5vZGUgb24gYSBSb2NrY2hpcCBTb0Mgd2l0aCBubyBYUENTIGNhbiBjYXJyeSBhIHBjcy1o YW5kbGUgYW5kIHN0aWxsCnBhc3MgZHRfYmluZGluZ19jaGVjay4gIFRoZSByZXN0IG9mIHRoaXMg ZmlsZSBhbHJlYWR5IGdhdGVzIFNvQy1zcGVjaWZpYwpjb25zdHJhaW50cyBvbiBjb21wYXRpYmxl IHdpdGggYSBuZWdhdGl2ZSBlbHNlIGJyYW5jaCwgZm9yIGV4YW1wbGU6CgogIC0gaWY6CiAgICAg IHByb3BlcnRpZXM6CiAgICAgICAgY29tcGF0aWJsZToKICAgICAgICAgIGNvbnRhaW5zOgogICAg ICAgICAgICBlbnVtOgogICAgICAgICAgICAgIC0gcm9ja2NoaXAscmszNTc2LWdtYWMKICAgICAg ICAgICAgICAtIHJvY2tjaGlwLHJrMzU4OC1nbWFjCiAgICB0aGVuOgogICAgICByZXF1aXJlZDoK ICAgICAgICAtIHJvY2tjaGlwLHBocC1ncmYKICAgIGVsc2U6CiAgICAgIHByb3BlcnRpZXM6CiAg ICAgICAgcm9ja2NoaXAscGhwLWdyZjogZmFsc2UKCkRvY3VtZW50YXRpb24vZGV2aWNldHJlZS9i aW5kaW5ncy9uZXQvcmVuZXNhcyxyenYyaC1nYmV0aC55YW1sIHVzZXMKInBjcy1oYW5kbGU6IGZh bHNlIiBpbiB0aGUgZWxzZSBicmFuY2ggZm9yIHRoZSBzYW1lIHB1cnBvc2UuICBXb3VsZCBuZXN0 aW5nCnRoZSBuZXcgYmxvY2sgdW5kZXIgYSBjaGVjayBmb3Igcm9ja2NoaXAscmszNTY4LWdtYWMs IHBsdXMKInBjcy1oYW5kbGU6IGZhbHNlIiBmb3IgdGhlIHZhcmlhbnRzIHdpdGhvdXQgYSBQQ1Ms IGRlc2NyaWJlIHRoZSBoYXJkd2FyZQptb3JlIGFjY3VyYXRlbHk/CgpObyBpbi10cmVlIERUIGlz IGFmZmVjdGVkIHRvZGF5OiB0aGUgb25seSBSb2NrY2hpcCBHTUFDIG5vZGUgd2l0aApwaHktbW9k ZSA9ICJzZ21paSIgaXMgaW4gcmszNTY4LXBob3RvbmljYXQuZHRzLCBhbmQgaXQgYWxyZWFkeSBw cm92aWRlcwpwY3MtaGFuZGxlID0gPCZ4cGNzX21paTA+LgoKPiAgdW5ldmFsdWF0ZWRQcm9wZXJ0 aWVzOiBmYWxzZQo+ICAKPiAgZXhhbXBsZXM6CgotLSAKU2FzaGlrbyBBSSByZXZpZXcgwrcgaHR0 cHM6Ly9uZXRkZXYtYWkuYm90cy5saW51eC5kZXYvc2FzaGlrby8jL3BhdGNoc2V0LzIwMjYwOTE1 MTIzODAyLjE1NjE3MjQtMS1jb2lhcHJhbnQlNDBnbWFpbC5jb20KCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkxpbnV4LXJvY2tjaGlwIG1haWxpbmcgbGlz dApMaW51eC1yb2NrY2hpcEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRl YWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtcm9ja2NoaXAK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 074ECC982DB for ; Thu, 17 Sep 2026 18:38:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Cc:To:From:Subject:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Xcm70OUSukEU0i3vGTUC9VnRRFiEmVeGd9EEtWT2KI0=; b=OL16yOobv6Xsh8 g7yyHBOebwWG+S0Nox6XKB3xbSX/PuAcD1pLWvWZxzyulZYP/2Lqm0lAOXGXtbaAYdeHp7uLCWgIF gBMNmESWYYCNIqOsOsRWS2MctecIbLMOldkMhtIo0TuJwDRsfTclrCTjtFrrZAejauCr5hsFNH860 +jGOr8sF+7nouUQFERouXGKEpIslOdFT81gyktKGT8ve+yTlvFiyg2o77gcrauObDcAmQwpNMZzRr YqImf7kWzBC7pz6x4DWCdRtm2OE2xe245rgwC07l3lwf1a5FSCNz67KF1/9G54VBJfE6plOyldb9c xRwykEcs4gYReFp5rCwg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x7H08-0000000CFQD-30md; Thu, 17 Sep 2026 18:38:28 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x7H02-0000000CFJZ-19oo; Thu, 17 Sep 2026 18:38:22 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 0B44643E24; Thu, 17 Sep 2026 18:38:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7D2E31F000FF; Thu, 17 Sep 2026 18:38:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1789670301; bh=7/HZTASVkqKaji0QyjTNpQOcpYSX+5MHinbb2iPHtgk=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=DzUy4DNsPs6KVxt3KwqIt7hsBJPGJfY5+jH/P+/NawPmKCuwHebVhj5iWmcMGZab0 ivWn04rnlTtaofhzwCPdSwq0X6GdxAydr7CYNce8WNGUsE5uYRw712OW7NVlP+nyqt y+VISEl3gdx6iVV3h3pAG3y/kUgYM6UZex7J3xOwH7CS45MpkR238mqmq7cbCGQhAC hHvYz0hVDC0FiObk0dp3wjKiJkIMqZAvKHmY2T2uz+AyucMQGh++gjX3Axmhzm0v0M IbJu6pq1XWBIVbMX9pzHBNlM84TCf2lOZhIFGYwB1I6vB/2rGzD3h0E2OdqJ0RvXDy N6T9w5dr/lBpw== Subject: Re: [PATCH net-next v6 08/11] dt-bindings: net: rockchip-dwmac: document pcs-handle From: netdev-bot+sashiko@kernel.org To: coiaprant@gmail.com Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, heiko@sntech.de, vkoul@kernel.org, maxime.chevallier@bootlin.com, mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com, prabhakar.mahadev-lad.rj@bp.renesas.com, romain.gantois@bootlin.com, hkallweit1@gmail.com, neil.armstrong@linaro.org, linux@armlinux.org.uk, shawn.lin@rock-chips.com, david@ixit.cz, netdev@vger.kernel.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-renesas-soc@vger.kernel.org Date: Thu, 17 Sep 2026 18:38:20 +0000 Message-ID: <178967030009.22033.606150817628079939@kernel.org> In-Reply-To: <20260915123802.1561724-9-coiaprant@gmail.com> References: <20260915123802.1561724-9-coiaprant@gmail.com> X-sashiko-severity: Low MIME-Version: 1.0 X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MiBwb3RlbnRpYWwKaXNzdWUocykgdG8gY29uc2lkZXI6CgpDcml0aWNhbDogMCDCtyBIaWdoOiAw IMK3IE1lZGl1bTogMCDCtyBMb3c6IDIKCi0gW0xvd10gQ29tbWl0IG1lc3NhZ2UgZGVzY3JpYmVz IGNvZGUgdGhhdCBkb2VzIG5vdCBleGlzdCBhdCB0aGlzIGNvbW1pdDoKICB0aGUgbWVzc2FnZSBz dGF0ZXMgdGhlIFJvY2tjaGlwIGR3bWFjIGdsdWUgIm5vdyBzdXBwb3J0cyBTR01JSSBvbuKApgot IFtMb3ddIFRoZSBuZXcgYGFsbE9mYCBjb25kaXRpb25hbCBpbgogIERvY3VtZW50YXRpb24vZGV2 aWNldHJlZS9iaW5kaW5ncy9uZXQvcm9ja2NoaXAtZHdtYWMueWFtbCBrZXlzIG9ubHkgb27igKYK Ci0tCgpkdC1iaW5kaW5nczogbmV0OiByb2NrY2hpcC1kd21hYzogZG9jdW1lbnQgcGNzLWhhbmRs ZQoKVGhpcyBhZGRzIGEgcGNzLWhhbmRsZSBwcm9wZXJ0eSB0byB0aGUgUm9ja2NoaXAgR01BQyBi aW5kaW5nIGFuZCBhIG5ldwphbGxPZiBjb25kaXRpb25hbCBtYWtpbmcgaXQgcmVxdWlyZWQgd2hl bmV2ZXIgcGh5LW1vZGUgaXMgInNnbWlpIi4gIFR3bwpvYnNlcnZhdGlvbnMgYmVsb3csIG9uZSBh Ym91dCB0aGUgY29tbWl0IG1lc3NhZ2Ugd29yZGluZyBhbmQgb25lIGFib3V0CnRoZSBzY29wZSBv ZiB0aGUgbmV3IGNvbmRpdGlvbmFsLgoKPiAgICAgVGhlIFJvY2tjaGlwIGR3bWFjIGdsdWUgZHJp dmVyIG5vdyBzdXBwb3J0cyBTR01JSSBvbiBSSzM1NjggYW5kCj4gICAgIHJlcXVpcmVzIGEgUENT LCByZWZlcmVuY2VkIHRocm91Z2ggdGhlICJwY3MtaGFuZGxlIiBwcm9wZXJ0eS4gIFRoZQo+ICAg ICBwcm9wZXJ0eSBpcyBwYXJzZWQgYnkgcmtfcGNzX2luaXQoKSBhbmQgYSBtaXNzaW5nIHBoYW5k bGUgZmFpbHMgdGhlCj4gICAgIHByb2JlLCBzbyBkZXNjcmliZSBpdCBpbiB0aGUgYmluZGluZyBh bmQgcmVxdWlyZSBpdCB3aGVuIHBoeS1tb2RlCj4gICAgIGlzICJzZ21paSIuCgpbU2V2ZXJpdHk6 IExvd10KVGhpcyBpc24ndCBhIGJ1ZywgYnV0IHRoZSB3b3JkaW5nIGlzIGluIHRoZSBwYXN0IHRl bnNlIGZvciBjb2RlIHRoYXQgaXMgbm90CnByZXNlbnQgeWV0IGF0IHRoaXMgY29tbWl0LiAgQXQg ZmMyZTE5MDY2ZDA4LApkcml2ZXJzL25ldC9ldGhlcm5ldC9zdG1pY3JvL3N0bW1hYy9kd21hYy1y ay5jIGhhcyBubyBya19wY3NfaW5pdCgpLCBubwoicGNzLWhhbmRsZSIgcGFyc2luZywgYW5kIG5v IHBjc19pbml0L3Bjc19leGl0L3NlbGVjdF9wY3MgY2FsbGJhY2tzIG9yClNHTUlJIHN1cHBvcnQu CgpDaGVja2luZyB0aGUgZW5kIG9mIHRoZSBzZXJpZXMsIHRob3NlIGFsbCBhcnJpdmUgaW4gdGhl IGZvbGxvd2luZyBwYXRjaAooIm5ldDogc3RtbWFjOiBkd21hYy1yazogYWRkIFNHTUlJIHN1cHBv cnQgZm9yIFJLMzU2OCIpLCB3aGljaCBhZGRzCnJrX3Bjc19pbml0KCkgd2l0aDoKCglwY3Nfbm9k ZSA9IG9mX3BhcnNlX3BoYW5kbGUobnAsICJwY3MtaGFuZGxlIiwgMCk7CglpZiAoIXBjc19ub2Rl KQoJCXJldHVybiAtRU5PREVWOwoKYW5kIGluc3RhbGxzIHRoZSBjYWxsYmFja3MgaW4gcmtfZ21h Y19wcm9iZSgpIGZvcgpQSFlfSU5URVJGQUNFX01PREVfU0dNSUkuCgpQdXR0aW5nIHRoZSBiaW5k aW5nIGJlZm9yZSB0aGUgZHJpdmVyIGlzIHRoZSB1c3VhbCBjb252ZW50aW9uLCBzbyB3b3VsZCBp dApiZSB3b3J0aCByZXdvcmRpbmcgdG8gc2F5IHRoZSBwcm9wZXJ0eSB3aWxsIGJlIHBhcnNlZCBi eSBya19wY3NfaW5pdCgpIGluCnRoZSBmb2xsb3dpbmcgcGF0Y2gsIHJhdGhlciB0aGFuIHRoYXQg aXQgYWxyZWFkeSBpcz8KCj4gZGlmZiAtLWdpdCBhL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9i aW5kaW5ncy9uZXQvcm9ja2NoaXAtZHdtYWMueWFtbCBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJl ZS9iaW5kaW5ncy9uZXQvcm9ja2NoaXAtZHdtYWMueWFtbAo+IGluZGV4IDgwYzI1Mjg0NTM0OWMu LjY3YjIxZWE3N2VjOTYgMTAwNjQ0Cj4gLS0tIGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2Jp bmRpbmdzL25ldC9yb2NrY2hpcC1kd21hYy55YW1sCj4gKysrIGIvRG9jdW1lbnRhdGlvbi9kZXZp Y2V0cmVlL2JpbmRpbmdzL25ldC9yb2NrY2hpcC1kd21hYy55YW1sCj4gQEAgLTEyMCw2ICsxMjAs MTIgQEAgcHJvcGVydGllczoKPiAgICAgIG1heGltdW06IDB4N0YKPiAgICAgIGRlZmF1bHQ6IDB4 MTAKPiAgCj4gKyAgcGNzLWhhbmRsZToKPiArICAgIGRlc2NyaXB0aW9uOgo+ICsgICAgICBTcGVj aWZpZXMgYSByZWZlcmVuY2UgdG8gYSBub2RlIHJlcHJlc2VudGluZyB0aGUgUENTIGRldmljZQo+ ICsgICAgICBjb25uZWN0ZWQgdG8gdGhpcyBHTUFDLiBSZXF1aXJlZCB3aGVuIHBoeS1tb2RlIGlz ICJzZ21paSIuCj4gKyAgICBtYXhJdGVtczogMQo+ICsKPiAgcGh5LXN1cHBseToKPiAgICAgIGRl c2NyaXB0aW9uOiBQSFkgcmVndWxhdG9yCj4gIAo+IEBAIC0xNTksNiArMTY1LDE1IEBAIGFsbE9m Ogo+ICAgICAgICAgIGNsb2NrczoKPiAgICAgICAgICAgIG1pbkl0ZW1zOiA1Cj4gIAo+ICsgIC0g aWY6Cj4gKyAgICAgIHByb3BlcnRpZXM6Cj4gKyAgICAgICAgcGh5LW1vZGU6Cj4gKyAgICAgICAg ICBjb250YWluczoKPiArICAgICAgICAgICAgY29uc3Q6IHNnbWlpCj4gKyAgICB0aGVuOgo+ICsg ICAgICByZXF1aXJlZDoKPiArICAgICAgICAtIHBjcy1oYW5kbGUKPiArCgpbU2V2ZXJpdHk6IExv d10KU2hvdWxkIHRoaXMgY29uZGl0aW9uYWwgYWxzbyBrZXkgb24gY29tcGF0aWJsZT8gIEFzIHdy aXR0ZW4gaXQga2V5cyBvbmx5IG9uCnBoeS1tb2RlLCBzbyByZXF1aXJlZDogW3Bjcy1oYW5kbGVd IGFwcGxpZXMgdG8gYWxsIHNpeHRlZW4gY29tcGF0aWJsZXMgdGhpcwpzY2hlbWEgc2VsZWN0cyAo cHgzMCwgcmszMTI4LCByazMyMjgsIHJrMzI4OCwgcmszMzA4LCByazMzMjgsIHJrMzM2NiwKcmsz MzY4LCByazMzOTksIHJrMzUwNiwgcmszNTI4LCByazM1NjgsIHJrMzU3NiwgcmszNTg4LCBydjEx MDgsIHJ2MTEyNikuCgpBdCB0aGUgZW5kIG9mIHRoZSBzZXJpZXMgb25seSByazM1Njhfb3BzIHBy b3ZpZGVzIC5zZXRfdG9fc2dtaWksIGFuZApkd21hYy1yay5jIGRlcml2ZXMgdGhlIGNhcGFiaWxp dHkgZnJvbSBpdDoKCglic3BfcHJpdi0+c3VwcG9ydHNfc2dtaWkgPSBvcHMtPnN1cHBvcnRzX3Nn bWlpIHx8ICEhb3BzLT5zZXRfdG9fc2dtaWk7CgpzbyB0aGUgUENTIHJlcXVpcmVtZW50IGxvb2tz IHNwZWNpZmljIHRvIHJvY2tjaGlwLHJrMzU2OC1nbWFjLgoKVGhlIHJldmVyc2UgZGlyZWN0aW9u IGlzIG9wZW4gdG9vOiBwY3MtaGFuZGxlIGlzIGFkZGVkIHVuY29uZGl0aW9uYWxseSwgc28gYQpH TUFDIG5vZGUgb24gYSBSb2NrY2hpcCBTb0Mgd2l0aCBubyBYUENTIGNhbiBjYXJyeSBhIHBjcy1o YW5kbGUgYW5kIHN0aWxsCnBhc3MgZHRfYmluZGluZ19jaGVjay4gIFRoZSByZXN0IG9mIHRoaXMg ZmlsZSBhbHJlYWR5IGdhdGVzIFNvQy1zcGVjaWZpYwpjb25zdHJhaW50cyBvbiBjb21wYXRpYmxl IHdpdGggYSBuZWdhdGl2ZSBlbHNlIGJyYW5jaCwgZm9yIGV4YW1wbGU6CgogIC0gaWY6CiAgICAg IHByb3BlcnRpZXM6CiAgICAgICAgY29tcGF0aWJsZToKICAgICAgICAgIGNvbnRhaW5zOgogICAg ICAgICAgICBlbnVtOgogICAgICAgICAgICAgIC0gcm9ja2NoaXAscmszNTc2LWdtYWMKICAgICAg ICAgICAgICAtIHJvY2tjaGlwLHJrMzU4OC1nbWFjCiAgICB0aGVuOgogICAgICByZXF1aXJlZDoK ICAgICAgICAtIHJvY2tjaGlwLHBocC1ncmYKICAgIGVsc2U6CiAgICAgIHByb3BlcnRpZXM6CiAg ICAgICAgcm9ja2NoaXAscGhwLWdyZjogZmFsc2UKCkRvY3VtZW50YXRpb24vZGV2aWNldHJlZS9i aW5kaW5ncy9uZXQvcmVuZXNhcyxyenYyaC1nYmV0aC55YW1sIHVzZXMKInBjcy1oYW5kbGU6IGZh bHNlIiBpbiB0aGUgZWxzZSBicmFuY2ggZm9yIHRoZSBzYW1lIHB1cnBvc2UuICBXb3VsZCBuZXN0 aW5nCnRoZSBuZXcgYmxvY2sgdW5kZXIgYSBjaGVjayBmb3Igcm9ja2NoaXAscmszNTY4LWdtYWMs IHBsdXMKInBjcy1oYW5kbGU6IGZhbHNlIiBmb3IgdGhlIHZhcmlhbnRzIHdpdGhvdXQgYSBQQ1Ms IGRlc2NyaWJlIHRoZSBoYXJkd2FyZQptb3JlIGFjY3VyYXRlbHk/CgpObyBpbi10cmVlIERUIGlz IGFmZmVjdGVkIHRvZGF5OiB0aGUgb25seSBSb2NrY2hpcCBHTUFDIG5vZGUgd2l0aApwaHktbW9k ZSA9ICJzZ21paSIgaXMgaW4gcmszNTY4LXBob3RvbmljYXQuZHRzLCBhbmQgaXQgYWxyZWFkeSBw cm92aWRlcwpwY3MtaGFuZGxlID0gPCZ4cGNzX21paTA+LgoKPiAgdW5ldmFsdWF0ZWRQcm9wZXJ0 aWVzOiBmYWxzZQo+ICAKPiAgZXhhbXBsZXM6CgotLSAKU2FzaGlrbyBBSSByZXZpZXcgwrcgaHR0 cHM6Ly9uZXRkZXYtYWkuYm90cy5saW51eC5kZXYvc2FzaGlrby8jL3BhdGNoc2V0LzIwMjYwOTE1 MTIzODAyLjE1NjE3MjQtMS1jb2lhcHJhbnQlNDBnbWFpbC5jb20KCi0tIApsaW51eC1waHkgbWFp bGluZyBsaXN0CmxpbnV4LXBoeUBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHBzOi8vbGlzdHMuaW5m cmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LXBoeQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A7DA14ABBD6; Thu, 17 Sep 2026 18:38:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789670305; cv=none; b=PQ3Drblog7ztU0goWPrYIcka7vgoFjk8hM3xsaNXOatfXLsuUSUkw9lqWenp6pNHUKOxguNsnzrg1htz8StzQ/qsndW6jqRASDotEpbVgpiLcCtg7q+3A+eZa9XIqrfp+aG4TSGoZd0UpVvcgpXKzKEyX4lRpudiY6l3eHsse3A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789670305; c=relaxed/simple; bh=yuXQrfsfKwSA3bTby0PRCwmEC9sGLGom3zawGAZX57w=; h=Subject:From:To:Cc:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=flE4+mZOQSYGZQBRCIPOaLqVHhubRKTuVeiWy1Olu8NQAPc/HH8aN03q9Iy5nR9cU65K+NWIB6LgVJPmzAK7OCcvD/aAjf0UP+B3zwtAsBo7CBY/Ql/1ibp5ukdn0AXZD7j9R+NVpS39IwTn4W+RUz7+rBGeTYI/vT2JhZuwqrs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=DzUy4DNs; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="DzUy4DNs" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7D2E31F000FF; Thu, 17 Sep 2026 18:38:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1789670301; bh=7/HZTASVkqKaji0QyjTNpQOcpYSX+5MHinbb2iPHtgk=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=DzUy4DNsPs6KVxt3KwqIt7hsBJPGJfY5+jH/P+/NawPmKCuwHebVhj5iWmcMGZab0 ivWn04rnlTtaofhzwCPdSwq0X6GdxAydr7CYNce8WNGUsE5uYRw712OW7NVlP+nyqt y+VISEl3gdx6iVV3h3pAG3y/kUgYM6UZex7J3xOwH7CS45MpkR238mqmq7cbCGQhAC hHvYz0hVDC0FiObk0dp3wjKiJkIMqZAvKHmY2T2uz+AyucMQGh++gjX3Axmhzm0v0M IbJu6pq1XWBIVbMX9pzHBNlM84TCf2lOZhIFGYwB1I6vB/2rGzD3h0E2OdqJ0RvXDy N6T9w5dr/lBpw== Subject: Re: [PATCH net-next v6 08/11] dt-bindings: net: rockchip-dwmac: document pcs-handle From: netdev-bot+sashiko@kernel.org To: coiaprant@gmail.com Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, heiko@sntech.de, vkoul@kernel.org, maxime.chevallier@bootlin.com, mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com, prabhakar.mahadev-lad.rj@bp.renesas.com, romain.gantois@bootlin.com, hkallweit1@gmail.com, neil.armstrong@linaro.org, linux@armlinux.org.uk, shawn.lin@rock-chips.com, david@ixit.cz, netdev@vger.kernel.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-renesas-soc@vger.kernel.org Date: Thu, 17 Sep 2026 18:38:20 +0000 Message-ID: <178967030009.22033.606150817628079939@kernel.org> In-Reply-To: <20260915123802.1561724-9-coiaprant@gmail.com> References: <20260915123802.1561724-9-coiaprant@gmail.com> X-sashiko-severity: Low Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider: Critical: 0 · High: 0 · Medium: 0 · Low: 2 - [Low] Commit message describes code that does not exist at this commit: the message states the Rockchip dwmac glue "now supports SGMII on… - [Low] The new `allOf` conditional in Documentation/devicetree/bindings/net/rockchip-dwmac.yaml keys only on… -- dt-bindings: net: rockchip-dwmac: document pcs-handle This adds a pcs-handle property to the Rockchip GMAC binding and a new allOf conditional making it required whenever phy-mode is "sgmii". Two observations below, one about the commit message wording and one about the scope of the new conditional. > The Rockchip dwmac glue driver now supports SGMII on RK3568 and > requires a PCS, referenced through the "pcs-handle" property. The > property is parsed by rk_pcs_init() and a missing phandle fails the > probe, so describe it in the binding and require it when phy-mode > is "sgmii". [Severity: Low] This isn't a bug, but the wording is in the past tense for code that is not present yet at this commit. At fc2e19066d08, drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c has no rk_pcs_init(), no "pcs-handle" parsing, and no pcs_init/pcs_exit/select_pcs callbacks or SGMII support. Checking the end of the series, those all arrive in the following patch ("net: stmmac: dwmac-rk: add SGMII support for RK3568"), which adds rk_pcs_init() with: pcs_node = of_parse_phandle(np, "pcs-handle", 0); if (!pcs_node) return -ENODEV; and installs the callbacks in rk_gmac_probe() for PHY_INTERFACE_MODE_SGMII. Putting the binding before the driver is the usual convention, so would it be worth rewording to say the property will be parsed by rk_pcs_init() in the following patch, rather than that it already is? > diff --git a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml > index 80c252845349c..67b21ea77ec96 100644 > --- a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml > +++ b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml > @@ -120,6 +120,12 @@ properties: > maximum: 0x7F > default: 0x10 > > + pcs-handle: > + description: > + Specifies a reference to a node representing the PCS device > + connected to this GMAC. Required when phy-mode is "sgmii". > + maxItems: 1 > + > phy-supply: > description: PHY regulator > > @@ -159,6 +165,15 @@ allOf: > clocks: > minItems: 5 > > + - if: > + properties: > + phy-mode: > + contains: > + const: sgmii > + then: > + required: > + - pcs-handle > + [Severity: Low] Should this conditional also key on compatible? As written it keys only on phy-mode, so required: [pcs-handle] applies to all sixteen compatibles this schema selects (px30, rk3128, rk3228, rk3288, rk3308, rk3328, rk3366, rk3368, rk3399, rk3506, rk3528, rk3568, rk3576, rk3588, rv1108, rv1126). At the end of the series only rk3568_ops provides .set_to_sgmii, and dwmac-rk.c derives the capability from it: bsp_priv->supports_sgmii = ops->supports_sgmii || !!ops->set_to_sgmii; so the PCS requirement looks specific to rockchip,rk3568-gmac. The reverse direction is open too: pcs-handle is added unconditionally, so a GMAC node on a Rockchip SoC with no XPCS can carry a pcs-handle and still pass dt_binding_check. The rest of this file already gates SoC-specific constraints on compatible with a negative else branch, for example: - if: properties: compatible: contains: enum: - rockchip,rk3576-gmac - rockchip,rk3588-gmac then: required: - rockchip,php-grf else: properties: rockchip,php-grf: false Documentation/devicetree/bindings/net/renesas,rzv2h-gbeth.yaml uses "pcs-handle: false" in the else branch for the same purpose. Would nesting the new block under a check for rockchip,rk3568-gmac, plus "pcs-handle: false" for the variants without a PCS, describe the hardware more accurately? No in-tree DT is affected today: the only Rockchip GMAC node with phy-mode = "sgmii" is in rk3568-photonicat.dts, and it already provides pcs-handle = <&xpcs_mii0>. > unevaluatedProperties: false > > examples: -- Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20260915123802.1561724-1-coiaprant%40gmail.com