From: Thomas Monjalon <thomas@monjalon.net>
To: "Iremonger, Bernard" <bernard.iremonger@intel.com>
Cc: Stephen Hemminger <stephen@networkplumber.org>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [PATCH v3 3/3] examples/l3fwd: format the IP addresses for printing
Date: Fri, 22 Jun 2018 15:44:51 +0200 [thread overview]
Message-ID: <1789949.7rL1TaZSp4@xps> (raw)
In-Reply-To: <8CEF83825BEC744B83065625E567D7C260CB71A8@IRSMSX108.ger.corp.intel.com>
22/06/2018 12:23, Iremonger, Bernard:
> Hi Stephen,
>
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Stephen Hemminger
> > Sent: Monday, June 18, 2018 10:36 PM
> > To: dev@dpdk.org
> > Cc: Stephen Hemminger <stephen@networkplumber.org>
> > Subject: [dpdk-dev] [PATCH v3 3/3] examples/l3fwd: format the IP addresses for
> > printing
> >
> > It is better user experience to print standard format for addresses rather than
> > raw hex.
> >
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> > ---
> > examples/l3fwd/l3fwd_lpm.c | 15 ++++++++++-----
>
> <snip>
>
> dpdk/devtools/check-git-log.sh -1
> Wrong beginning of commit message:
> It is better user experience to print standard format for addresses
>
> It is complaining about "It" in the commit message, not sure why.
>
> Hi Thomas,
>
> Could this be a bug in the check-git-log script.
No it is not a bug, just a pedantic warning :)
Look at this commit for the explanation:
http://git.dpdk.org/dpdk/commit/?id=9c24780f0d5efd
prev parent reply other threads:[~2018-06-22 13:44 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-18 21:35 [PATCH v3 0/3] use RFC addresses for testing Stephen Hemminger
2018-06-18 21:35 ` [PATCH v3 1/3] testpmd: add ability to set tx IP and UDP parameters Stephen Hemminger
2018-06-22 9:12 ` Iremonger, Bernard
2018-10-29 2:25 ` Thomas Monjalon
2018-06-26 11:47 ` Shahaf Shuler
2018-06-26 11:51 ` Shahaf Shuler
2019-04-02 20:39 ` [PATCH v4 0/3] use RFC addresses in test applications Stephen Hemminger
2019-04-02 20:39 ` [PATCH v4 1/3] app/testpmd: add ability to set Tx IP and UDP parameters Stephen Hemminger
2019-04-08 12:51 ` [dpdk-dev] " Iremonger, Bernard
2019-04-02 20:39 ` [PATCH v4 2/3] examples/l3fwd: use reserved IPv4/IPv6 addresses Stephen Hemminger
2019-04-08 13:07 ` [dpdk-dev] " Iremonger, Bernard
2019-04-09 17:14 ` Stephen Hemminger
2019-04-02 20:39 ` [PATCH v4 3/3] examples/l3fwd: format the IP addresses for printing Stephen Hemminger
2019-04-08 13:14 ` [dpdk-dev] " Iremonger, Bernard
2019-04-09 18:20 ` [dpdk-dev] [PATCH v5 0/3] use RFC addresses in test applications Stephen Hemminger
2019-04-09 18:20 ` [dpdk-dev] [PATCH v5 1/3] app/testpmd: add ability to set Tx IP and UDP parameters Stephen Hemminger
2019-04-10 10:07 ` Iremonger, Bernard
2019-04-09 18:20 ` [dpdk-dev] [PATCH v5 2/3] examples/l3fwd: use reserved IPv4/IPv6 addresses Stephen Hemminger
2019-04-10 8:56 ` Iremonger, Bernard
2019-04-09 18:20 ` [dpdk-dev] [PATCH v5 3/3] examples/l3fwd: format the IP addresses for printing Stephen Hemminger
2019-04-10 17:41 ` [dpdk-dev] [PATCH v6 0/3] use IPv4 addresses reserved for testing Stephen Hemminger
2019-04-10 17:41 ` [dpdk-dev] [PATCH v6 1/3] app/testpmd: add ability to set Tx IP and UDP parameters Stephen Hemminger
2019-04-11 9:02 ` Iremonger, Bernard
2019-04-10 17:41 ` [dpdk-dev] [PATCH v6 2/3] examples/l3fwd: use reserved IPv4/IPv6 addresses Stephen Hemminger
2019-04-11 9:08 ` Iremonger, Bernard
2019-04-10 17:41 ` [dpdk-dev] [PATCH v6 3/3] examples/l3fwd: format the IP addresses for printing Stephen Hemminger
2019-04-21 21:55 ` [dpdk-dev] [PATCH v6 0/3] use IPv4 addresses reserved for testing Thomas Monjalon
2018-06-18 21:35 ` [PATCH v3 2/3] examples/l3fwd: use reserved IPv4/IPv6 addresses Stephen Hemminger
2018-06-22 9:19 ` Iremonger, Bernard
2018-06-18 21:35 ` [PATCH v3 3/3] examples/l3fwd: format the IP addresses for printing Stephen Hemminger
2018-06-22 10:23 ` Iremonger, Bernard
2018-06-22 13:44 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1789949.7rL1TaZSp4@xps \
--to=thomas@monjalon.net \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.