From: patchwork-bot+netdevbpf@kernel.org
To: Ivan Vecera <ivecera@redhat.com>
Cc: netdev@vger.kernel.org, pabeni@redhat.com,
vadim.fedorenko@linux.dev, arkadiusz.kubalewski@intel.com,
jiri@resnulli.us, kuba@kernel.org, przemyslaw.kitszel@intel.com,
milena.olech@intel.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] dpll: use exact lookup for reference sync pin id
Date: Tue, 22 Sep 2026 00:30:05 +0000 [thread overview]
Message-ID: <179003700515.3305732.7157422558298107250.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20260917143736.526221-1-ivecera@redhat.com>
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Thu, 17 Sep 2026 16:37:36 +0200 you wrote:
> dpll_pin_ref_sync_state_set() looks up the reference sync pin in the
> pin->ref_sync_pins xarray, which is keyed by the sync pin's id (see
> dpll_pin_ref_sync_pair_add() using xa_insert() with ref_sync_pin->id).
> The pin id to operate on is supplied by userspace via DPLL_A_PIN_ID.
>
> The lookup however used xa_find() with a ULONG_MAX limit, which returns
> the first present entry with an index greater than or equal to the
> requested id, not the entry stored exactly at that id. If userspace
> passes an id that is not paired as a reference sync pin, but another
> pin with a higher id is present in the xarray, xa_find() silently
> returns that wrong pin and the subsequent ref_sync_set() operates on
> it. The request only fails when the given id is larger than every
> present key.
>
> [...]
Here is the summary with links:
- [net] dpll: use exact lookup for reference sync pin id
https://git.kernel.org/netdev/net/c/7cce782d8327
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2026-09-22 0:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-17 14:37 [PATCH net] dpll: use exact lookup for reference sync pin id Ivan Vecera
2026-09-22 0:20 ` Jakub Kicinski
2026-09-22 0:30 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179003700515.3305732.7157422558298107250.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=arkadiusz.kubalewski@intel.com \
--cc=ivecera@redhat.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=milena.olech@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=vadim.fedorenko@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.