From: patchwork-bot+netdevbpf@kernel.org
To: Yilin Zhang <yilinzhang@moonshot.ai>
Cc: davem@davemloft.net, kuba@kernel.org, edumazet@google.com,
ncardwell@google.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, bug-report@moonshot.ai,
shiweiming@moonshot.ai
Subject: Re: [PATCH v2] tcp: fix use-after-free of retransmit_skb_hint in tcp_send_synack()
Date: Thu, 24 Sep 2026 16:30:06 +0000 [thread overview]
Message-ID: <179026740614.1641283.16358381114334311829.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <8a9dff4063a2745653b7e88ceb745d75efa16e68.1790224474.git.yilinzhang@moonshot.ai>
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Thu, 24 Sep 2026 12:49:00 +0800 you wrote:
> When tcp_send_synack() replaces the cloned SYN skb at the head of the
> retransmit queue with a copy, it frees the original with
> tcp_rtx_queue_unlink_and_free() and only repairs tp->highest_sack.
> tp->retransmit_skb_hint keeps pointing at the freed
> skbuff_fclone_cache object.
>
> The dangling hint is read in tcp_verify_retransmit_hint() and used as
> the root of the rbtree walk in tcp_xmit_retransmit_queue(). An
> unprivileged TFO client (sendmsg(MSG_FASTOPEN)) can arm the hint with
> an attacker-supplied ICMP fragmentation-needed message, after which a
> simultaneous open frees the armed SYN skb:
>
> [...]
Here is the summary with links:
- [v2] tcp: fix use-after-free of retransmit_skb_hint in tcp_send_synack()
https://git.kernel.org/netdev/net/c/fe99bbeee5c5
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2026-09-24 16:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-20 6:34 [PATCH] tcp: fix use-after-free of retransmit_skb_hint in tcp_send_synack() Yilin Zhang
2026-09-23 2:09 ` Jakub Kicinski
2026-09-23 2:49 ` Eric Dumazet
2026-09-23 2:57 ` Eric Dumazet
2026-09-24 4:49 ` [PATCH v2] " Yilin Zhang
2026-09-24 9:35 ` Eric Dumazet
2026-09-24 16:30 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179026740614.1641283.16358381114334311829.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=bug-report@moonshot.ai \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=shiweiming@moonshot.ai \
--cc=yilinzhang@moonshot.ai \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.