From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 62DDAC98325 for ; Fri, 25 Sep 2026 02:03:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Cc:To:From:Subject:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/KPQtFG6xFAG67QIViVcN6k102sPbm6Sc9cZYbyVoa0=; b=F7/df41OJWqtaR NW/KxFHGMtMXlo1EloFZbBLq0eUyzcyahjoc5JQamJ1mvpASLjYnf8tRy1qOUihyT9Dsu/3RX5np1 HD1uM7Pd8qKCgUWCHgs9qzqy3zk4z1cDRui20g4twMjuRKw2aNaI51w1x+FHJG21pc6xbE54p9ENf hYsAbXgYD1Xp7SXf1fUeDkqKXlNjZihlLReA1NkQyH9oZs0mVN03dYYSZ5VGjqccT2gPJrk23R8Pa 9AwbDVMbH/cPN/pIIaoBgdOwIiHy893152ixJQDjcW8I+6qVWFikUoHAMDHfPlh8X14LQ75V28HCK RDvONxkqXRXH/z/AJLgw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x9vHo-0000000CVjb-1a7b; Fri, 25 Sep 2026 02:03:40 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x9vHm-0000000CVjG-02wd; Fri, 25 Sep 2026 02:03:38 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 477D540DEF; Fri, 25 Sep 2026 02:03:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C4C891F000FF; Fri, 25 Sep 2026 02:03:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1790301817; bh=XbfLt567UruTanIr/tJZNwrVVvx5lCkEUIU6u9TuyOc=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=QcLGa2sI2CSFd+1OYFPqtvbpBgmOTP3N190z13MvZcnWpLL3h3ZTDtQ3Y6Wujbb9j ZDD4qzR0OYXQKF5vHa+lrjv0GfT7A2CAijea5tALLiO41vORmdCMBNXHtEDCkf8auC aIRJZtRUHFiGGM4NdVuW62rokrRWRndcIRzw42AvY6QyK1cxQeNRkE3maPME4O4HEb Z9fFkewi6U2HVuRNoUgpToVf9Zg4H5pdJEFS7u6NSKlD/QD+HAUHWLmY+MdHEn7AFX /ilwNJShqcpYrpjsJq9blWOUIAM0yphSACBZMW+hgQhqhuPydtDSHjkqEy5JL7JuoU wQZ7nuMr/eUKA== Subject: Re: [PATCH net-next v10 01/11] net: stmmac: move XPCS lifetime management to platform drivers From: netdev-bot+sashiko@kernel.org To: coiaprant@gmail.com Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, heiko@sntech.de, vkoul@kernel.org, maxime.chevallier@bootlin.com, mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com, prabhakar.mahadev-lad.rj@bp.renesas.com, romain.gantois@bootlin.com, hkallweit1@gmail.com, neil.armstrong@linaro.org, linux@armlinux.org.uk, shawn.lin@rock-chips.com, david@ixit.cz, netdev@vger.kernel.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-renesas-soc@vger.kernel.org Date: Fri, 25 Sep 2026 02:03:35 +0000 Message-ID: <179030181534.2160803.2909836028801902052@kernel.org> In-Reply-To: <20260922200336.2201212-2-coiaprant@gmail.com> References: <20260922200336.2201212-2-coiaprant@gmail.com> X-sashiko-severity: Low MIME-Version: 1.0 X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg bW9yZSBzZXZlcmUKaXNzdWUocykgaW4gb3RoZXIgcGF0Y2hlcyBvZiB0aGlzIHNlcmllcy4gVGhp cyBtYWlsIGlzIG9ubHkgYW4gRllJLCBpbiBjYXNlCnlvdSB3YW50IHRvIGFkZHJlc3MgdGhlIG5p dCBwaWNrcyBiZWxvdyB3aGVuIHlvdSByZXNwaW4uCgpMb3cgcHJpb3JpdHkgLyBuaXQgcGlja3Mg Zm9yIHlvdXIgY29uc2lkZXJhdGlvbjoKCi0gW0xvd10gQ29tbWl0IG1lc3NhZ2UgYXVkaXQgY2xh aW06ICJldmVyeSBEVFMgdGhhdCBwYWlycyBhIGR3bWFjIG5vZGUKICB3aXRoIGEgUENTIGdvZXMg dGhyb3VnaCBhIGdsdWUgdGhhdCBzZXRzIHBjc19pbml0KCkgKEludGVsLCBSZW5lc2FzLOKApgot IFtMb3ddIENvbW1pdCBtZXNzYWdlIGZyYW1pbmc6IHRoZSByZW1vdmFsIG9mIHRoZSB1bmNvbmRp dGlvbmFsCiAgYHByaXYtPmh3LT54cGNzID0geHBjcztgIGluIHN0bW1hY19wY3Nfc2V0dXAoKSBp cyBkZXNjcmliZWQgYXMgZml4aW5n4oCmCgotLQoKbmV0OiBzdG1tYWM6IG1vdmUgWFBDUyBsaWZl dGltZSBtYW5hZ2VtZW50IHRvIHBsYXRmb3JtIGRyaXZlcnMKClRoaXMgbW92ZXMgWFBDUyBjcmVh dGlvbiBhbmQgZGVzdHJ1Y3Rpb24gb3V0IG9mIHRoZSBjb21tb24Kc3RtbWFjX3Bjc19zZXR1cCgp IGFuZCBzdG1tYWNfcGNzX2NsZWFuKCksIHdoaWNoIG5vdyBvbmx5IGRpc3BhdGNoIHRvCnBsYXQt PnBjc19pbml0KCkgYW5kIHBsYXQtPnBjc19leGl0KCkuIFRoZSBJbnRlbCBtR2JFIGdsdWUgZ2Fp bnMgaXRzIG93bgpwY3NfaW5pdCgpL3Bjc19leGl0KCkgcGFpciwgYW5kIHRoZSByZW5lc2FzLWdi ZXRoLCByem4xIGFuZCBzb2NmcGdhCnBjc19leGl0KCkgY2FsbGJhY2tzIGNsZWFyIHByaXYtPmh3 LT5waHlsaW5rX3BjcyBhZnRlciBkZXN0cm95aW5nIHRoZSBQQ1MuCgpObyBMaW5rOiB0YWdzIGFy ZSBwcmVzZW50IGluIHRoZSBjb21taXQgaGVhZGVyLgoKSSBsb29rZWQgYXQgdGhlIHR3byBwbGFj ZXMgaW4gc3RtbWFjX3Bjc19zZXR1cCgpIHRoYXQgc2VlbWVkIHdvcnRoIGRvdWJsZQpjaGVja2lu ZyBhbmQgZGlkIG5vdCBmaW5kIGFueXRoaW5nIHRvIHJlcG9ydC4KCj4gZGlmZiAtLWdpdCBhL2Ry aXZlcnMvbmV0L2V0aGVybmV0L3N0bWljcm8vc3RtbWFjL3N0bW1hY19tZGlvLmMgYi9kcml2ZXJz L25ldC9ldGhlcm5ldC9zdG1pY3JvL3N0bW1hYy9zdG1tYWNfbWRpby5jCj4gaW5kZXggYWZlOThm ZjViZGNiMC4uNzM5NmI2ODg5OWM2NiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL25ldC9ldGhlcm5l dC9zdG1pY3JvL3N0bW1hYy9zdG1tYWNfbWRpby5jCj4gKysrIGIvZHJpdmVycy9uZXQvZXRoZXJu ZXQvc3RtaWNyby9zdG1tYWMvc3RtbWFjX21kaW8uYwo+IEBAIC00MjYsMzUgKzQyNiwxNCBAQCBp bnQgc3RtbWFjX21kaW9fcmVzZXQoc3RydWN0IG1paV9idXMgKmJ1cykKPiAgaW50IHN0bW1hY19w Y3Nfc2V0dXAoc3RydWN0IG5ldF9kZXZpY2UgKm5kZXYpCj4gIHsKPiAgCXN0cnVjdCBzdG1tYWNf cHJpdiAqcHJpdiA9IG5ldGRldl9wcml2KG5kZXYpOwo+IC0Jc3RydWN0IGZ3bm9kZV9oYW5kbGUg KmRldm5vZGUsICpwY3Nub2RlOwo+IC0Jc3RydWN0IGR3X3hwY3MgKnhwY3MgPSBOVUxMOwo+IC0J aW50IGFkZHIsIHJldDsKPiAtCj4gLQlkZXZub2RlID0gZGV2X2Z3bm9kZShwcml2LT5kZXZpY2Up Owo+IC0KPiAtCWlmIChwcml2LT5wbGF0LT5wY3NfaW5pdCkgewo+IC0JCXJldCA9IHByaXYtPnBs YXQtPnBjc19pbml0KHByaXYpOwo+IC0JfSBlbHNlIGlmIChmd25vZGVfcHJvcGVydHlfcHJlc2Vu dChkZXZub2RlLCAicGNzLWhhbmRsZSIpKSB7Cj4gLQkJcGNzbm9kZSA9IGZ3bm9kZV9maW5kX3Jl ZmVyZW5jZShkZXZub2RlLCAicGNzLWhhbmRsZSIsIDApOwo+IC0JCXhwY3MgPSB4cGNzX2NyZWF0 ZV9md25vZGUocGNzbm9kZSk7Cj4gLQkJZndub2RlX2hhbmRsZV9wdXQocGNzbm9kZSk7Cj4gLQkJ cmV0ID0gUFRSX0VSUl9PUl9aRVJPKHhwY3MpOwo+IC0JfSBlbHNlIGlmIChwcml2LT5wbGF0LT5t ZGlvX2J1c19kYXRhICYmCj4gLQkJICAgcHJpdi0+cGxhdC0+bWRpb19idXNfZGF0YS0+cGNzX21h c2spIHsKPiAtCQlhZGRyID0gZmZzKHByaXYtPnBsYXQtPm1kaW9fYnVzX2RhdGEtPnBjc19tYXNr KSAtIDE7Cj4gLQkJeHBjcyA9IHhwY3NfY3JlYXRlX21kaW9kZXYocHJpdi0+bWlpLCBhZGRyKTsK PiAtCQlyZXQgPSBQVFJfRVJSX09SX1pFUk8oeHBjcyk7Cj4gLQl9IGVsc2Ugewo+ICsJaW50IHJl dDsKPiArCj4gKwlpZiAoIXByaXYtPnBsYXQtPnBjc19pbml0KQo+ICAJCXJldHVybiAwOwo+IC0J fQoKRHJvcHBpbmcgdGhlIGdlbmVyaWMgInBjcy1oYW5kbGUiIGFuZCBwY3NfbWFzayBwYXJzaW5n IGhlcmUgbWF0Y2hlcyB0aGUKaW4tdHJlZSB1c2VycyBJIGNvdWxkIGZpbmQ6IHRoZSBvbmx5IGR3 bWFjIG5vZGVzIGNhcnJ5aW5nIHBjcy1oYW5kbGUgZ28KdGhyb3VnaCBkd21hYy1yem4xIChyOWEw NmcwMzIuZHRzaSkgYW5kIGR3bWFjLXJlbmVzYXMtZ2JldGgsIGJvdGggb2Ygd2hpY2gKc2V0IHBs YXQtPnBjc19pbml0KCksIGFuZCBkd21hYy1pbnRlbCBnYWlucyBwY3NfaW5pdCgpIGluIHRoaXMg c2FtZSBwYXRjaC4KCj4gIAo+ICsJcmV0ID0gcHJpdi0+cGxhdC0+cGNzX2luaXQocHJpdik7Cj4g IAlpZiAocmV0KQo+IC0JCXJldHVybiBkZXZfZXJyX3Byb2JlKHByaXYtPmRldmljZSwgcmV0LCAi Tm8geFBDUyBmb3VuZFxuIik7Cj4gLQo+IC0JaWYgKHhwY3MpCj4gLQkJeHBjc19jb25maWdfZWVl X211bHRfZmFjdCh4cGNzLCBwcml2LT5wbGF0LT5tdWx0X2ZhY3RfMTAwbnMpOwo+IC0KPiAtCXBy aXYtPmh3LT54cGNzID0geHBjczsKPiArCQlyZXR1cm4gZGV2X2Vycl9wcm9iZShwcml2LT5kZXZp Y2UsIHJldCwgIkZhaWxlZCB0byBpbml0aWFsaXplIFBDU1xuIik7Cj4gIAo+ICAJcmV0dXJuIDA7 Cj4gIH0KClJlbW92aW5nIHRoZSB0cmFpbGluZyBwcml2LT5ody0+eHBjcyBhc3NpZ25tZW50IGFs c28gbG9va3MgcmlnaHQuIE5vbmUgb2YKdGhlIHBjc19pbml0KCkgaW1wbGVtZW50YXRpb25zIHBy ZXNlbnQgYmVmb3JlIHRoaXMgcGF0Y2ggdG91Y2gKcHJpdi0+aHctPnhwY3MgKHJlbmVzYXNfZ21h Y19wY3NfaW5pdCgpLCByem4xX2R3bWFjX3Bjc19pbml0KCkgYW5kCnNvY2ZwZ2FfZHdtYWNfcGNz X2luaXQoKSBhbGwgc2V0IHByaXYtPmh3LT5waHlsaW5rX3BjcyksIHNvIG5vIGV4aXN0aW5nCnBs YXRmb3JtIGNoYW5nZXMgYmVoYXZpb3VyLCBhbmQgYSBnbHVlIHRoYXQgZG9lcyBzZXQgcHJpdi0+ aHctPnhwY3MgZnJvbQpwY3NfaW5pdCgpIHdvdWxkIHByZXZpb3VzbHkgaGF2ZSBoYWQgaXQgY2xv YmJlcmVkLgoKPiBAQCAtNDYzLDE0ICs0NDIsMTAgQEAgdm9pZCBzdG1tYWNfcGNzX2NsZWFuKHN0 cnVjdCBuZXRfZGV2aWNlICpuZGV2KQo+ICB7Cj4gIAlzdHJ1Y3Qgc3RtbWFjX3ByaXYgKnByaXYg PSBuZXRkZXZfcHJpdihuZGV2KTsKPiAgCj4gLQlpZiAocHJpdi0+cGxhdC0+cGNzX2V4aXQpCj4g LQkJcHJpdi0+cGxhdC0+cGNzX2V4aXQocHJpdik7Cj4gLQo+IC0JaWYgKCFwcml2LT5ody0+eHBj cykKPiArCWlmICghcHJpdi0+cGxhdC0+cGNzX2V4aXQpCj4gIAkJcmV0dXJuOwo+ICAKPiAtCXhw Y3NfZGVzdHJveShwcml2LT5ody0+eHBjcyk7Cj4gLQlwcml2LT5ody0+eHBjcyA9IE5VTEw7Cj4g Kwlwcml2LT5wbGF0LT5wY3NfZXhpdChwcml2KTsKPiAgfQoKVGhlIEludGVsIHNpZGUgcGFpcnMg dGhpcyB3aXRoIGludGVsX21nYmVfcGNzX2V4aXQoKSwgd2hpY2ggY2FsbHMKeHBjc19kZXN0cm95 KCkgYW5kIGNsZWFycyBwcml2LT5ody0+eHBjcywgc28gdGhlIGRlc3Ryb3kgcGF0aCBpcyBwcmVz ZXJ2ZWQKZm9yIHRoZSBvbmx5IHBsYXRmb3JtIHRoYXQgd2FzIHJlbHlpbmcgb24gdGhlIGNvbW1v biBjb2RlLgoKLS0gClNhc2hpa28gQUkgcmV2aWV3IMK3IGh0dHBzOi8vbmV0ZGV2LWFpLmJvdHMu bGludXguZGV2L3Nhc2hpa28vIy9wYXRjaHNldC8yMDI2MDkyMjIwMDMzNi4yMjAxMjEyLTEtY29p YXByYW50JTQwZ21haWwuY29tCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpMaW51eC1yb2NrY2hpcCBtYWlsaW5nIGxpc3QKTGludXgtcm9ja2NoaXBAbGlz dHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2xpbnV4LXJvY2tjaGlwCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F16BEC9831E for ; Fri, 25 Sep 2026 02:03:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Cc:To:From:Subject:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wiDKUuLXZBmbUOCw0zhXHgrNmA01A6Z/DnMRwzFKITU=; b=si6lBqvFN1AVMg rdzJkIKDrWJI2H0Sx8KOOLmc4ESGdyMvidyCDJ/NJgEgxUD4GnflhqzfA4gmcEreItxdm98EhUNdB vh+niVES+JuxYhXMLvze6Pp3I1CQP2YYI9MYWy2sKyMEuv9hKVLhJ626ce52jErgYQmJgiz7C1Gxz LSEwlq2amIpWKmKBCbCLJxD7uCgwqIrfck+ZhN5YasMFiGsoEFJBNdMcNQIV3t/HEIHoyJtV4IQQ0 w6PPHPkyvIZj8ZwpRF/a3yJ4XXabJ4tj6fESe3Zc/bU3Wwfea89Vs6kVg23N+raG9WwJj2m+sZcST wTRm0PsZ93prLGCq6L9g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x9vHo-0000000CVjX-1MrA; Fri, 25 Sep 2026 02:03:40 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x9vHm-0000000CVjG-02wd; Fri, 25 Sep 2026 02:03:38 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 477D540DEF; Fri, 25 Sep 2026 02:03:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C4C891F000FF; Fri, 25 Sep 2026 02:03:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1790301817; bh=XbfLt567UruTanIr/tJZNwrVVvx5lCkEUIU6u9TuyOc=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=QcLGa2sI2CSFd+1OYFPqtvbpBgmOTP3N190z13MvZcnWpLL3h3ZTDtQ3Y6Wujbb9j ZDD4qzR0OYXQKF5vHa+lrjv0GfT7A2CAijea5tALLiO41vORmdCMBNXHtEDCkf8auC aIRJZtRUHFiGGM4NdVuW62rokrRWRndcIRzw42AvY6QyK1cxQeNRkE3maPME4O4HEb Z9fFkewi6U2HVuRNoUgpToVf9Zg4H5pdJEFS7u6NSKlD/QD+HAUHWLmY+MdHEn7AFX /ilwNJShqcpYrpjsJq9blWOUIAM0yphSACBZMW+hgQhqhuPydtDSHjkqEy5JL7JuoU wQZ7nuMr/eUKA== Subject: Re: [PATCH net-next v10 01/11] net: stmmac: move XPCS lifetime management to platform drivers From: netdev-bot+sashiko@kernel.org To: coiaprant@gmail.com Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, heiko@sntech.de, vkoul@kernel.org, maxime.chevallier@bootlin.com, mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com, prabhakar.mahadev-lad.rj@bp.renesas.com, romain.gantois@bootlin.com, hkallweit1@gmail.com, neil.armstrong@linaro.org, linux@armlinux.org.uk, shawn.lin@rock-chips.com, david@ixit.cz, netdev@vger.kernel.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-renesas-soc@vger.kernel.org Date: Fri, 25 Sep 2026 02:03:35 +0000 Message-ID: <179030181534.2160803.2909836028801902052@kernel.org> In-Reply-To: <20260922200336.2201212-2-coiaprant@gmail.com> References: <20260922200336.2201212-2-coiaprant@gmail.com> X-sashiko-severity: Low MIME-Version: 1.0 X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg bW9yZSBzZXZlcmUKaXNzdWUocykgaW4gb3RoZXIgcGF0Y2hlcyBvZiB0aGlzIHNlcmllcy4gVGhp cyBtYWlsIGlzIG9ubHkgYW4gRllJLCBpbiBjYXNlCnlvdSB3YW50IHRvIGFkZHJlc3MgdGhlIG5p dCBwaWNrcyBiZWxvdyB3aGVuIHlvdSByZXNwaW4uCgpMb3cgcHJpb3JpdHkgLyBuaXQgcGlja3Mg Zm9yIHlvdXIgY29uc2lkZXJhdGlvbjoKCi0gW0xvd10gQ29tbWl0IG1lc3NhZ2UgYXVkaXQgY2xh aW06ICJldmVyeSBEVFMgdGhhdCBwYWlycyBhIGR3bWFjIG5vZGUKICB3aXRoIGEgUENTIGdvZXMg dGhyb3VnaCBhIGdsdWUgdGhhdCBzZXRzIHBjc19pbml0KCkgKEludGVsLCBSZW5lc2FzLOKApgot IFtMb3ddIENvbW1pdCBtZXNzYWdlIGZyYW1pbmc6IHRoZSByZW1vdmFsIG9mIHRoZSB1bmNvbmRp dGlvbmFsCiAgYHByaXYtPmh3LT54cGNzID0geHBjcztgIGluIHN0bW1hY19wY3Nfc2V0dXAoKSBp cyBkZXNjcmliZWQgYXMgZml4aW5n4oCmCgotLQoKbmV0OiBzdG1tYWM6IG1vdmUgWFBDUyBsaWZl dGltZSBtYW5hZ2VtZW50IHRvIHBsYXRmb3JtIGRyaXZlcnMKClRoaXMgbW92ZXMgWFBDUyBjcmVh dGlvbiBhbmQgZGVzdHJ1Y3Rpb24gb3V0IG9mIHRoZSBjb21tb24Kc3RtbWFjX3Bjc19zZXR1cCgp IGFuZCBzdG1tYWNfcGNzX2NsZWFuKCksIHdoaWNoIG5vdyBvbmx5IGRpc3BhdGNoIHRvCnBsYXQt PnBjc19pbml0KCkgYW5kIHBsYXQtPnBjc19leGl0KCkuIFRoZSBJbnRlbCBtR2JFIGdsdWUgZ2Fp bnMgaXRzIG93bgpwY3NfaW5pdCgpL3Bjc19leGl0KCkgcGFpciwgYW5kIHRoZSByZW5lc2FzLWdi ZXRoLCByem4xIGFuZCBzb2NmcGdhCnBjc19leGl0KCkgY2FsbGJhY2tzIGNsZWFyIHByaXYtPmh3 LT5waHlsaW5rX3BjcyBhZnRlciBkZXN0cm95aW5nIHRoZSBQQ1MuCgpObyBMaW5rOiB0YWdzIGFy ZSBwcmVzZW50IGluIHRoZSBjb21taXQgaGVhZGVyLgoKSSBsb29rZWQgYXQgdGhlIHR3byBwbGFj ZXMgaW4gc3RtbWFjX3Bjc19zZXR1cCgpIHRoYXQgc2VlbWVkIHdvcnRoIGRvdWJsZQpjaGVja2lu ZyBhbmQgZGlkIG5vdCBmaW5kIGFueXRoaW5nIHRvIHJlcG9ydC4KCj4gZGlmZiAtLWdpdCBhL2Ry aXZlcnMvbmV0L2V0aGVybmV0L3N0bWljcm8vc3RtbWFjL3N0bW1hY19tZGlvLmMgYi9kcml2ZXJz L25ldC9ldGhlcm5ldC9zdG1pY3JvL3N0bW1hYy9zdG1tYWNfbWRpby5jCj4gaW5kZXggYWZlOThm ZjViZGNiMC4uNzM5NmI2ODg5OWM2NiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL25ldC9ldGhlcm5l dC9zdG1pY3JvL3N0bW1hYy9zdG1tYWNfbWRpby5jCj4gKysrIGIvZHJpdmVycy9uZXQvZXRoZXJu ZXQvc3RtaWNyby9zdG1tYWMvc3RtbWFjX21kaW8uYwo+IEBAIC00MjYsMzUgKzQyNiwxNCBAQCBp bnQgc3RtbWFjX21kaW9fcmVzZXQoc3RydWN0IG1paV9idXMgKmJ1cykKPiAgaW50IHN0bW1hY19w Y3Nfc2V0dXAoc3RydWN0IG5ldF9kZXZpY2UgKm5kZXYpCj4gIHsKPiAgCXN0cnVjdCBzdG1tYWNf cHJpdiAqcHJpdiA9IG5ldGRldl9wcml2KG5kZXYpOwo+IC0Jc3RydWN0IGZ3bm9kZV9oYW5kbGUg KmRldm5vZGUsICpwY3Nub2RlOwo+IC0Jc3RydWN0IGR3X3hwY3MgKnhwY3MgPSBOVUxMOwo+IC0J aW50IGFkZHIsIHJldDsKPiAtCj4gLQlkZXZub2RlID0gZGV2X2Z3bm9kZShwcml2LT5kZXZpY2Up Owo+IC0KPiAtCWlmIChwcml2LT5wbGF0LT5wY3NfaW5pdCkgewo+IC0JCXJldCA9IHByaXYtPnBs YXQtPnBjc19pbml0KHByaXYpOwo+IC0JfSBlbHNlIGlmIChmd25vZGVfcHJvcGVydHlfcHJlc2Vu dChkZXZub2RlLCAicGNzLWhhbmRsZSIpKSB7Cj4gLQkJcGNzbm9kZSA9IGZ3bm9kZV9maW5kX3Jl ZmVyZW5jZShkZXZub2RlLCAicGNzLWhhbmRsZSIsIDApOwo+IC0JCXhwY3MgPSB4cGNzX2NyZWF0 ZV9md25vZGUocGNzbm9kZSk7Cj4gLQkJZndub2RlX2hhbmRsZV9wdXQocGNzbm9kZSk7Cj4gLQkJ cmV0ID0gUFRSX0VSUl9PUl9aRVJPKHhwY3MpOwo+IC0JfSBlbHNlIGlmIChwcml2LT5wbGF0LT5t ZGlvX2J1c19kYXRhICYmCj4gLQkJICAgcHJpdi0+cGxhdC0+bWRpb19idXNfZGF0YS0+cGNzX21h c2spIHsKPiAtCQlhZGRyID0gZmZzKHByaXYtPnBsYXQtPm1kaW9fYnVzX2RhdGEtPnBjc19tYXNr KSAtIDE7Cj4gLQkJeHBjcyA9IHhwY3NfY3JlYXRlX21kaW9kZXYocHJpdi0+bWlpLCBhZGRyKTsK PiAtCQlyZXQgPSBQVFJfRVJSX09SX1pFUk8oeHBjcyk7Cj4gLQl9IGVsc2Ugewo+ICsJaW50IHJl dDsKPiArCj4gKwlpZiAoIXByaXYtPnBsYXQtPnBjc19pbml0KQo+ICAJCXJldHVybiAwOwo+IC0J fQoKRHJvcHBpbmcgdGhlIGdlbmVyaWMgInBjcy1oYW5kbGUiIGFuZCBwY3NfbWFzayBwYXJzaW5n IGhlcmUgbWF0Y2hlcyB0aGUKaW4tdHJlZSB1c2VycyBJIGNvdWxkIGZpbmQ6IHRoZSBvbmx5IGR3 bWFjIG5vZGVzIGNhcnJ5aW5nIHBjcy1oYW5kbGUgZ28KdGhyb3VnaCBkd21hYy1yem4xIChyOWEw NmcwMzIuZHRzaSkgYW5kIGR3bWFjLXJlbmVzYXMtZ2JldGgsIGJvdGggb2Ygd2hpY2gKc2V0IHBs YXQtPnBjc19pbml0KCksIGFuZCBkd21hYy1pbnRlbCBnYWlucyBwY3NfaW5pdCgpIGluIHRoaXMg c2FtZSBwYXRjaC4KCj4gIAo+ICsJcmV0ID0gcHJpdi0+cGxhdC0+cGNzX2luaXQocHJpdik7Cj4g IAlpZiAocmV0KQo+IC0JCXJldHVybiBkZXZfZXJyX3Byb2JlKHByaXYtPmRldmljZSwgcmV0LCAi Tm8geFBDUyBmb3VuZFxuIik7Cj4gLQo+IC0JaWYgKHhwY3MpCj4gLQkJeHBjc19jb25maWdfZWVl X211bHRfZmFjdCh4cGNzLCBwcml2LT5wbGF0LT5tdWx0X2ZhY3RfMTAwbnMpOwo+IC0KPiAtCXBy aXYtPmh3LT54cGNzID0geHBjczsKPiArCQlyZXR1cm4gZGV2X2Vycl9wcm9iZShwcml2LT5kZXZp Y2UsIHJldCwgIkZhaWxlZCB0byBpbml0aWFsaXplIFBDU1xuIik7Cj4gIAo+ICAJcmV0dXJuIDA7 Cj4gIH0KClJlbW92aW5nIHRoZSB0cmFpbGluZyBwcml2LT5ody0+eHBjcyBhc3NpZ25tZW50IGFs c28gbG9va3MgcmlnaHQuIE5vbmUgb2YKdGhlIHBjc19pbml0KCkgaW1wbGVtZW50YXRpb25zIHBy ZXNlbnQgYmVmb3JlIHRoaXMgcGF0Y2ggdG91Y2gKcHJpdi0+aHctPnhwY3MgKHJlbmVzYXNfZ21h Y19wY3NfaW5pdCgpLCByem4xX2R3bWFjX3Bjc19pbml0KCkgYW5kCnNvY2ZwZ2FfZHdtYWNfcGNz X2luaXQoKSBhbGwgc2V0IHByaXYtPmh3LT5waHlsaW5rX3BjcyksIHNvIG5vIGV4aXN0aW5nCnBs YXRmb3JtIGNoYW5nZXMgYmVoYXZpb3VyLCBhbmQgYSBnbHVlIHRoYXQgZG9lcyBzZXQgcHJpdi0+ aHctPnhwY3MgZnJvbQpwY3NfaW5pdCgpIHdvdWxkIHByZXZpb3VzbHkgaGF2ZSBoYWQgaXQgY2xv YmJlcmVkLgoKPiBAQCAtNDYzLDE0ICs0NDIsMTAgQEAgdm9pZCBzdG1tYWNfcGNzX2NsZWFuKHN0 cnVjdCBuZXRfZGV2aWNlICpuZGV2KQo+ICB7Cj4gIAlzdHJ1Y3Qgc3RtbWFjX3ByaXYgKnByaXYg PSBuZXRkZXZfcHJpdihuZGV2KTsKPiAgCj4gLQlpZiAocHJpdi0+cGxhdC0+cGNzX2V4aXQpCj4g LQkJcHJpdi0+cGxhdC0+cGNzX2V4aXQocHJpdik7Cj4gLQo+IC0JaWYgKCFwcml2LT5ody0+eHBj cykKPiArCWlmICghcHJpdi0+cGxhdC0+cGNzX2V4aXQpCj4gIAkJcmV0dXJuOwo+ICAKPiAtCXhw Y3NfZGVzdHJveShwcml2LT5ody0+eHBjcyk7Cj4gLQlwcml2LT5ody0+eHBjcyA9IE5VTEw7Cj4g Kwlwcml2LT5wbGF0LT5wY3NfZXhpdChwcml2KTsKPiAgfQoKVGhlIEludGVsIHNpZGUgcGFpcnMg dGhpcyB3aXRoIGludGVsX21nYmVfcGNzX2V4aXQoKSwgd2hpY2ggY2FsbHMKeHBjc19kZXN0cm95 KCkgYW5kIGNsZWFycyBwcml2LT5ody0+eHBjcywgc28gdGhlIGRlc3Ryb3kgcGF0aCBpcyBwcmVz ZXJ2ZWQKZm9yIHRoZSBvbmx5IHBsYXRmb3JtIHRoYXQgd2FzIHJlbHlpbmcgb24gdGhlIGNvbW1v biBjb2RlLgoKLS0gClNhc2hpa28gQUkgcmV2aWV3IMK3IGh0dHBzOi8vbmV0ZGV2LWFpLmJvdHMu bGludXguZGV2L3Nhc2hpa28vIy9wYXRjaHNldC8yMDI2MDkyMjIwMDMzNi4yMjAxMjEyLTEtY29p YXByYW50JTQwZ21haWwuY29tCgotLSAKbGludXgtcGh5IG1haWxpbmcgbGlzdApsaW51eC1waHlA bGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwczovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9s aXN0aW5mby9saW51eC1waHkK From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 917EF54785; Fri, 25 Sep 2026 02:03:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790301818; cv=none; b=pGJ2oAwt5HTw6GQMY0DsoBYjxbkqB/U9358nMPQBQq7Eh5Jjj1IZKbrI+Av5Ed5lpvC37SIIrCeUL9f8g20Q2cflGf3Zzgfvptl0CAM8SDLO/o6DCE6udEMqzob307qwicVWQrHFABCAtpR74KrMweSNNDQ76SKh7byFMS6U1NE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790301818; c=relaxed/simple; bh=N/PSO4fYDWazwFi2PhBtRLxtBhEs6MeOLHx6NjfSSAQ=; h=Subject:From:To:Cc:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=kXi/yGRkoq03Ri7y/RmMVzJsPUoFhcpCsJpTskGpNoFs4PyVKLlEiB8O2n+5Tl8Z8b+R1ibh4bu1fPfoRTtqW96cyOhHI+wkm6XtVZK1z5tLjRQvC8toPojuucqNbF+RRDHxH3JBxAeV5G2x7CyRewidJDO+rqsEJnpbGNXmjvk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=QcLGa2sI; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="QcLGa2sI" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C4C891F000FF; Fri, 25 Sep 2026 02:03:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1790301817; bh=XbfLt567UruTanIr/tJZNwrVVvx5lCkEUIU6u9TuyOc=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=QcLGa2sI2CSFd+1OYFPqtvbpBgmOTP3N190z13MvZcnWpLL3h3ZTDtQ3Y6Wujbb9j ZDD4qzR0OYXQKF5vHa+lrjv0GfT7A2CAijea5tALLiO41vORmdCMBNXHtEDCkf8auC aIRJZtRUHFiGGM4NdVuW62rokrRWRndcIRzw42AvY6QyK1cxQeNRkE3maPME4O4HEb Z9fFkewi6U2HVuRNoUgpToVf9Zg4H5pdJEFS7u6NSKlD/QD+HAUHWLmY+MdHEn7AFX /ilwNJShqcpYrpjsJq9blWOUIAM0yphSACBZMW+hgQhqhuPydtDSHjkqEy5JL7JuoU wQZ7nuMr/eUKA== Subject: Re: [PATCH net-next v10 01/11] net: stmmac: move XPCS lifetime management to platform drivers From: netdev-bot+sashiko@kernel.org To: coiaprant@gmail.com Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, heiko@sntech.de, vkoul@kernel.org, maxime.chevallier@bootlin.com, mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com, prabhakar.mahadev-lad.rj@bp.renesas.com, romain.gantois@bootlin.com, hkallweit1@gmail.com, neil.armstrong@linaro.org, linux@armlinux.org.uk, shawn.lin@rock-chips.com, david@ixit.cz, netdev@vger.kernel.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-renesas-soc@vger.kernel.org Date: Fri, 25 Sep 2026 02:03:35 +0000 Message-ID: <179030181534.2160803.2909836028801902052@kernel.org> In-Reply-To: <20260922200336.2201212-2-coiaprant@gmail.com> References: <20260922200336.2201212-2-coiaprant@gmail.com> X-sashiko-severity: Low Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Thank you for your contribution! Sashiko AI review found more severe issue(s) in other patches of this series. This mail is only an FYI, in case you want to address the nit picks below when you respin. Low priority / nit picks for your consideration: - [Low] Commit message audit claim: "every DTS that pairs a dwmac node with a PCS goes through a glue that sets pcs_init() (Intel, Renesas,… - [Low] Commit message framing: the removal of the unconditional `priv->hw->xpcs = xpcs;` in stmmac_pcs_setup() is described as fixing… -- net: stmmac: move XPCS lifetime management to platform drivers This moves XPCS creation and destruction out of the common stmmac_pcs_setup() and stmmac_pcs_clean(), which now only dispatch to plat->pcs_init() and plat->pcs_exit(). The Intel mGbE glue gains its own pcs_init()/pcs_exit() pair, and the renesas-gbeth, rzn1 and socfpga pcs_exit() callbacks clear priv->hw->phylink_pcs after destroying the PCS. No Link: tags are present in the commit header. I looked at the two places in stmmac_pcs_setup() that seemed worth double checking and did not find anything to report. > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c > index afe98ff5bdcb0..7396b68899c66 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c > @@ -426,35 +426,14 @@ int stmmac_mdio_reset(struct mii_bus *bus) > int stmmac_pcs_setup(struct net_device *ndev) > { > struct stmmac_priv *priv = netdev_priv(ndev); > - struct fwnode_handle *devnode, *pcsnode; > - struct dw_xpcs *xpcs = NULL; > - int addr, ret; > - > - devnode = dev_fwnode(priv->device); > - > - if (priv->plat->pcs_init) { > - ret = priv->plat->pcs_init(priv); > - } else if (fwnode_property_present(devnode, "pcs-handle")) { > - pcsnode = fwnode_find_reference(devnode, "pcs-handle", 0); > - xpcs = xpcs_create_fwnode(pcsnode); > - fwnode_handle_put(pcsnode); > - ret = PTR_ERR_OR_ZERO(xpcs); > - } else if (priv->plat->mdio_bus_data && > - priv->plat->mdio_bus_data->pcs_mask) { > - addr = ffs(priv->plat->mdio_bus_data->pcs_mask) - 1; > - xpcs = xpcs_create_mdiodev(priv->mii, addr); > - ret = PTR_ERR_OR_ZERO(xpcs); > - } else { > + int ret; > + > + if (!priv->plat->pcs_init) > return 0; > - } Dropping the generic "pcs-handle" and pcs_mask parsing here matches the in-tree users I could find: the only dwmac nodes carrying pcs-handle go through dwmac-rzn1 (r9a06g032.dtsi) and dwmac-renesas-gbeth, both of which set plat->pcs_init(), and dwmac-intel gains pcs_init() in this same patch. > > + ret = priv->plat->pcs_init(priv); > if (ret) > - return dev_err_probe(priv->device, ret, "No xPCS found\n"); > - > - if (xpcs) > - xpcs_config_eee_mult_fact(xpcs, priv->plat->mult_fact_100ns); > - > - priv->hw->xpcs = xpcs; > + return dev_err_probe(priv->device, ret, "Failed to initialize PCS\n"); > > return 0; > } Removing the trailing priv->hw->xpcs assignment also looks right. None of the pcs_init() implementations present before this patch touch priv->hw->xpcs (renesas_gmac_pcs_init(), rzn1_dwmac_pcs_init() and socfpga_dwmac_pcs_init() all set priv->hw->phylink_pcs), so no existing platform changes behaviour, and a glue that does set priv->hw->xpcs from pcs_init() would previously have had it clobbered. > @@ -463,14 +442,10 @@ void stmmac_pcs_clean(struct net_device *ndev) > { > struct stmmac_priv *priv = netdev_priv(ndev); > > - if (priv->plat->pcs_exit) > - priv->plat->pcs_exit(priv); > - > - if (!priv->hw->xpcs) > + if (!priv->plat->pcs_exit) > return; > > - xpcs_destroy(priv->hw->xpcs); > - priv->hw->xpcs = NULL; > + priv->plat->pcs_exit(priv); > } The Intel side pairs this with intel_mgbe_pcs_exit(), which calls xpcs_destroy() and clears priv->hw->xpcs, so the destroy path is preserved for the only platform that was relying on the common code. -- Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20260922200336.2201212-1-coiaprant%40gmail.com