From: patchwork-bot+netdevbpf@kernel.org
To: =?utf-8?q?Th=C3=A9o_Lebrun_=3Ctheo=2Elebrun=40bootlin=2Ecom=3E?=@aws-us-west-2-korg-oddjob-rhel9-1.codeaurora.org
Cc: conor.dooley@microchip.com, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, nb@tipi-net.de,
vladimir.kondratiev@mobileye.com, gregory.clement@bootlin.com,
benoit.monin@bootlin.com, tawfik.bayouk@mobileye.com,
thomas.petazzoni@bootlin.com
Subject: Re: [PATCH net-next] net: macb: move printk() calls out of bp->lock critical section
Date: Mon, 05 Oct 2026 23:30:15 +0000 [thread overview]
Message-ID: <179124301502.1937173.6589668234241813148.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20260930-macb-irq-v1-1-8994a4c8f3bb@bootlin.com>
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Wed, 30 Sep 2026 20:35:36 +0200 you wrote:
> printk() call while bp->lock is acquired might be a bad idea:
>
> - It grows the spinlock atomic section.
>
> - If netconsole is active on the same interface (and we run on the
> queue's CPU), we risk a deadlock because macb_poll_controller()
> calls macb_interrupt() which grab bp->lock if an IRQ is pending.
>
> [...]
Here is the summary with links:
- [net-next] net: macb: move printk() calls out of bp->lock critical section
https://git.kernel.org/netdev/net-next/c/3c9d88b04e6c
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2026-10-05 23:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-30 18:35 [PATCH net-next] net: macb: move printk() calls out of bp->lock critical section Théo Lebrun
2026-09-30 18:38 ` netdev-bot+sinfo
2026-09-30 18:55 ` Théo Lebrun
2026-10-05 23:19 ` Jakub Kicinski
2026-10-02 9:53 ` Nicolai Buchwitz
2026-10-05 23:30 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179124301502.1937173.6589668234241813148.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc==?utf-8?q?Th=C3=A9o_Lebrun_=3Ctheo=2Elebrun=40bootlin=2Ecom=3E?=@aws-us-west-2-korg-oddjob-rhel9-1.codeaurora.org \
--cc=andrew+netdev@lunn.ch \
--cc=benoit.monin@bootlin.com \
--cc=conor.dooley@microchip.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gregory.clement@bootlin.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nb@tipi-net.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=tawfik.bayouk@mobileye.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=vladimir.kondratiev@mobileye.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.