Re: [PATCH net-next 19/37] dt-bindings: can: renesas,rcar-canfd: Document RZ/G3L SoC

[netdev-bot+sashiko@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential
issue(s) to consider.

Critical: 0 · High: 0 · Medium: 2 · Low: 0

If you believe none of the issues are legitimate, please reply to each
issue of Medium severity or higher and explain why the AI is wrong.
If any of them are legitimate and you plan to respin, please let patchwork
know by including "pw-bot: cr" as a separate line at the end of your reply
(one such reply per series is enough).

- [Medium] The schema does not make `resets` or `reset-names` required
  for the new RZ/G3L compatible `renesas,r9a08g046-canfd`.
- [Medium] dt-bindings: missing maxItems constraint for RZ/G3L interrupts

--

dt-bindings: can: renesas,rcar-canfd: Document RZ/G3L SoC

This adds the RZ/G3L (R9A08G046) compatible to the renesas,rcar-canfd
binding. It adds a conditional block for 11 interrupts, 2 resets and 3
channels, and puts the new compatible in the block that disallows
renesas,no-can-fd and renesas,fd-only.

Link: https://patch.msgid.link/20261001075742.21961-2-biju.das.jz@bp.renesas.com

> diff --git a/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml b/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml
> index 1a7a9ce45e97..4b94bc8d911b 100644
> --- a/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml
> +++ b/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml

[ ... ]

> @@ -294,6 +295,25 @@ allOf:
>        patternProperties:
>          "^channel[6-7]$": false
>  
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: renesas,r9a08g046-canfd
> +    then:
> +      properties:
> +        interrupts:
> +          minItems: 11
> +
> +        interrupt-names:
> +          minItems: 11
> +
> +        resets:
> +          minItems: 2

[Severity: Medium]
Should this block also cap interrupts and interrupt-names at 11?

The commit message says RZ/G3L has exactly 11 interrupts, but only
minItems: 11 is set here. The upper bound therefore comes from the
top-level interrupts and interrupt-names items lists. Those allow up to
20 entries to cover the six channel parts.

As a result, a renesas,r9a08g046-canfd node listing anywhere from 12 to
20 interrupts, with the matching names for channels 3 to 5, passes
dt_binding_check and dtbs_check. That is inconsistent with this same
block rejecting "^channel[3-7]$" for the SoC, since the extra
interrupts describe channels that cannot exist.

Was the intent to add maxItems: 11 next to minItems: 11 for both
interrupts and interrupt-names? That would pin the count exactly, the
way the other variant blocks bound their interrupt counts.

[Severity: Medium]
Should renesas,r9a08g046-canfd also be in the existing allOf block that
makes resets and reset-names required? Right now that block lists only the
other RZ variants:

  - if:
      properties:
        compatible:
          contains:
            enum:
              - renesas,r9a08g045-canfd
              - renesas,r9a09g047-canfd
              - renesas,rzg2l-canfd
    then:
      required:
        - resets
        - reset-names

The minItems: 2 constraint above only applies when resets is present. The
top-level required list has neither resets nor reset-names. As a result,
an RZ/G3L canfd node with no resets passes dt_binding_check and
dtbs_check.

The driver will not catch the mistake either. rcar_canfd_probe() gets both
resets as optional:

	gpriv->rstc1 = devm_reset_control_get_optional_exclusive(dev, "rstp_n");
	...
	gpriv->rstc2 = devm_reset_control_get_optional_exclusive(dev, "rstc_n");

If the DT leaves out the reset lines, both handles come back NULL. Probe
still succeeds, but the controller is never explicitly taken out of reset.

This is still the case at the end of the series. The required-resets enum
does not include r9a08g046, even after "can: rcar_canfd: Add support for
Renesas RZ/G3L" adds the driver match entry.

> +
> +      patternProperties:
> +        "^channel[3-7]$": false
> +

[ ... ]

-- 
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20261015015336.816543-2-mkl%40pengutronix.de