All of lore.kernel.org
 help / color / mirror / Atom feed
From: patchwork-bot+netdevbpf@kernel.org
To: Jamal Hadi Salim <jhs@mojatatu.com>
Cc: netdev@vger.kernel.org, jiri@resnulli.us, davem@davemloft.net,
	edumazet@kernel.org, kuba@kernel.org, pabeni@redhat.com,
	horms@kernel.org, victor@mojatatu.com, ast@kernel.org,
	daniel@iogearbox.net, andrii@kernel.org, eddyz87@gmail.com,
	memxor@gmail.com, martin.lau@linux.dev, song@kernel.org,
	yonghong.song@linux.dev, jolsa@kernel.org, emil@etsalapatis.com,
	ihor.solodrai@linux.dev, john.fastabend@gmail.com,
	sdf@fomichev.me, bpf@vger.kernel.org, vinicius.gomes@intel.com,
	olteanv@gmail.com, vladimir.oltean@nxp.com, p@1g4.org,
	eadavis@qq.com, dcaratti@redhat.com, sashiko-bot@kernel.org
Subject: Re: [PATCH net-next v3 0/5] net/sched: reject oversized action dumps and cap unbounded entry lists
Date: Tue, 20 Oct 2026 20:10:14 +0000	[thread overview]
Message-ID: <179252701452.186787.8173064049574810392.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <QDISC-H19Z.v3.r0.20261012193813@mojatatu.com>

Hello:

This series was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Tue, 13 Oct 2026 04:54:26 -0400 you wrote:
> An action dump is carried inside nested netlink attributes whose lengths
> are u16. When a single action's dump does not fit, a plain nla_nest_end()
> writes a wrapped length and the kernel hands userspace a corrupt reply; on
> the classifier path the -EMSGSIZE this produces is mistaken for socket
> buffer exhaustion and retried in a loop that can never succeed.
> 
> Patch 1 makes every nest an action dump can be carried in fail cleanly
> (-EMSGSIZE) instead of wrapping, bounds the tfilter_notify_prep() retry,
> and stops a notification that cannot be built from vetoing a filter or
> action delete. Patch 2 stops an action add whose actions were already
> committed from being reported as a failure when the notification cannot
> be built. Patch 3 caps the number of gate scheduling entries at 1024,
> rejected with -E2BIG and an extack message. Patch 4 caps the number of
> taprio schedule entries at 1024 in the same way. Patch 5 makes the action
> dump report an action that cannot be serialized into one dump skb as
> -EMSGSIZE instead of returning success and silently dropping the rest of
> the list.
> 
> [...]

Here is the summary with links:
  - [net-next,v3,1/5] net/sched: act_gate: reject oversized dumps instead of wrapping them
    https://git.kernel.org/netdev/net-next/c/ed9e404dcf9b
  - [net-next,v3,2/5] net/sched: act_api: keep an add that created its actions from failing
    https://git.kernel.org/netdev/net-next/c/1a49567560a1
  - [net-next,v3,3/5] net/sched: act_gate: cap the number of scheduling entries
    https://git.kernel.org/netdev/net-next/c/150167ea4d7a
  - [net-next,v3,4/5] net/sched: sch_taprio: cap the number of schedule entries
    https://git.kernel.org/netdev/net-next/c/2bc124a5f8df
  - [net-next,v3,5/5] net/sched: act_api: report an oversized action dump instead of silently truncating it
    https://git.kernel.org/netdev/net-next/c/10a486c17dff

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



      parent reply	other threads:[~2026-10-20 20:10 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-13  8:54 [PATCH net-next v3 0/5] net/sched: reject oversized action dumps and cap unbounded entry lists Jamal Hadi Salim
2026-10-13  8:54 ` [PATCH net-next v3 1/5] net/sched: act_gate: reject oversized dumps instead of wrapping them Jamal Hadi Salim
2026-10-14  8:54   ` sashiko-bot
2026-10-14  9:56     ` Jamal Hadi Salim
2026-10-14  9:15   ` netdev-bot+sashiko
2026-10-13  8:54 ` [PATCH net-next v3 2/5] net/sched: act_api: keep an add that created its actions from failing Jamal Hadi Salim
2026-10-14  9:15   ` netdev-bot+sashiko
2026-10-13  8:54 ` [PATCH net-next v3 3/5] net/sched: act_gate: cap the number of scheduling entries Jamal Hadi Salim
2026-10-14  9:15   ` netdev-bot+sashiko
2026-10-13  8:54 ` [PATCH net-next v3 4/5] net/sched: sch_taprio: cap the number of schedule entries Jamal Hadi Salim
2026-10-14  9:15   ` netdev-bot+sashiko
2026-10-13  8:54 ` [PATCH net-next v3 5/5] net/sched: act_api: report an oversized action dump instead of silently truncating it Jamal Hadi Salim
2026-10-14  9:15   ` netdev-bot+sashiko
2026-10-14 10:02     ` Jamal Hadi Salim
2026-10-20 20:10 ` patchwork-bot+netdevbpf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=179252701452.186787.8173064049574810392.git-patchwork-notify@kernel.org \
    --to=patchwork-bot+netdevbpf@kernel.org \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=dcaratti@redhat.com \
    --cc=eadavis@qq.com \
    --cc=eddyz87@gmail.com \
    --cc=edumazet@kernel.org \
    --cc=emil@etsalapatis.com \
    --cc=horms@kernel.org \
    --cc=ihor.solodrai@linux.dev \
    --cc=jhs@mojatatu.com \
    --cc=jiri@resnulli.us \
    --cc=john.fastabend@gmail.com \
    --cc=jolsa@kernel.org \
    --cc=kuba@kernel.org \
    --cc=martin.lau@linux.dev \
    --cc=memxor@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=olteanv@gmail.com \
    --cc=p@1g4.org \
    --cc=pabeni@redhat.com \
    --cc=sashiko-bot@kernel.org \
    --cc=sdf@fomichev.me \
    --cc=song@kernel.org \
    --cc=victor@mojatatu.com \
    --cc=vinicius.gomes@intel.com \
    --cc=vladimir.oltean@nxp.com \
    --cc=yonghong.song@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.