All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tomasz Figa <tomasz.figa@gmail.com>
To: Kukjin Kim <kgene.kim@samsung.com>
Cc: linux-samsung-soc@vger.kernel.org,
	Giridhar Maruthy <giridhar.m@samsung.com>
Subject: Re: [PATCH] ARM: dts: Add watchdog in exynos5440-ssdk5440 device list
Date: Sat, 19 Jan 2013 11:40:51 +0100	[thread overview]
Message-ID: <1793091.ko9ZbaznTT@flatron> (raw)
In-Reply-To: <1358571651-22020-1-git-send-email-kgene.kim@samsung.com>

Hi Kukjin,

The commit message is a bit confusing, because it says that something is 
being added, while in fact the whole node is being removed.

Shouldn't it rather say something like:
ARM: dts: exynos5440-ssdk5440: Remove disabled status from watchdog node

Best regards,
Tomasz Figa

On Friday 18 of January 2013 21:00:51 Kukjin Kim wrote:
> From: Giridhar Maruthy <giridhar.m@samsung.com>
> 
> Signed-off-by: Giridhar Maruthy <giridhar.m@samsung.com>
> Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
> ---
>  arch/arm/boot/dts/exynos5440-ssdk5440.dts |    4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/exynos5440-ssdk5440.dts
> b/arch/arm/boot/dts/exynos5440-ssdk5440.dts index 81e2c96..5239d75
> 100644
> --- a/arch/arm/boot/dts/exynos5440-ssdk5440.dts
> +++ b/arch/arm/boot/dts/exynos5440-ssdk5440.dts
> @@ -36,10 +36,6 @@
>  		status = "disabled";
>  	};
> 
> -	watchdog {
> -		status = "disabled";
> -	};
> -
>  	rtc {
>  		status = "disabled";
>  	};

  reply	other threads:[~2013-01-19 10:40 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-19  5:00 [PATCH] ARM: dts: Add watchdog in exynos5440-ssdk5440 device list Kukjin Kim
2013-01-19 10:40 ` Tomasz Figa [this message]
2013-01-20 23:29   ` Kukjin Kim
2013-01-21  6:51   ` Tushar Behera
2013-01-21 13:09     ` Tomasz Figa
2013-01-23  2:36       ` Kukjin Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1793091.ko9ZbaznTT@flatron \
    --to=tomasz.figa@gmail.com \
    --cc=giridhar.m@samsung.com \
    --cc=kgene.kim@samsung.com \
    --cc=linux-samsung-soc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.