From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63912C433EF for ; Tue, 21 Jun 2022 04:13:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229761AbiFUENK (ORCPT ); Tue, 21 Jun 2022 00:13:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43402 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243817AbiFUENG (ORCPT ); Tue, 21 Jun 2022 00:13:06 -0400 Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DA8525FF1; Mon, 20 Jun 2022 21:13:01 -0700 (PDT) Received: by mail-wm1-x32d.google.com with SMTP id m16-20020a7bca50000000b0039c8a224c95so6577260wml.2; Mon, 20 Jun 2022 21:13:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gWNf4zISviT0O075eMDft6o66p0iSBmP3yoC2k9L30s=; b=f3qrhg5kivwoN62pkQbcd4DuX9n8K9cZ9BP+ptY1tWJ7tZgQg2er1cSs3AjXP+UnYt 6cRh3QvedL01Pw75eXfsUtFhueMSqxX6taL4E1ArDFBhODwSRhIgog7UVQhkPn3J8AQp zNN0wastumrL5Gq5bfrcqREF5fOFhezoDvKrdUlYlGK5bX42VKGqBdTBaP9jztvuKQfG a4AtS9szMHVcLXh7b+ClVSoLfANQKtf6voqXV4k1sQcynXBCA8WwIkaoaNWpZ7u6INe6 jyuTWFAxheiqlEEnosdoDxMd7fCNGPTpg3qSeX9eLpy2xH9Zi4GsIPX1mqQ4MgHlIGLP pxrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gWNf4zISviT0O075eMDft6o66p0iSBmP3yoC2k9L30s=; b=76gYYefFPp1liKfPXZtUCcsmNU1XrZpBAKXG5Oo29zu/gjfmn97mjL7na5hpVmixSA WdybxzKpO6FC/8FJijeMVuCTZUj/cJHLW0zrOB5rU2Fmwnk4lhoD/wgSGyoz7ZVQhd5Y sCs3x/tZ91eCNAngocMZTkT0aOm8BrlKalQ7BRRFuPM9CkREzJ4UljM1r4xd0896gVAs zFmWFdMpbcPxAdZnZ03N8eJkUN8ymV4+EZhfrW7/0L8i7ECi1JwWasUcyzrE5J3BzvPF Ec34NFVp+FuebY+x5aqwm3ifiNC/flqILeeTZAtQ0Rj1Qy4zmWogCZgnQyxSwNlthbK7 fCvA== X-Gm-Message-State: AOAM531cVaKHyFY2thC1SuYpy+cfJstbItKsLaxdbjvHzSLTxcqc+S+4 r72NkX0FkOrgdT8L07qKUpM= X-Google-Smtp-Source: ABdhPJy1EcK1Ls78Ofn6WTxbw21kuLZhIFxSHu84kK9NBQ1319q3BRU7LTTnK4saL8kgvjS2sRwCpA== X-Received: by 2002:a7b:cc94:0:b0:39c:4507:e806 with SMTP id p20-20020a7bcc94000000b0039c4507e806mr38807711wma.91.1655784780332; Mon, 20 Jun 2022 21:13:00 -0700 (PDT) Received: from kista.localnet (213-161-3-76.dynamic.telemach.net. [213.161.3.76]) by smtp.gmail.com with ESMTPSA id bt28-20020a056000081c00b0020fcc655e4asm14349200wrb.5.2022.06.20.21.12.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jun 2022 21:12:59 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Chen-Yu Tsai , Vinod Koul , Samuel Holland Cc: dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev Subject: Re: Re: [PATCH] dmaengine: sun6i: Set the maximum segment size Date: Tue, 21 Jun 2022 06:12:53 +0200 Message-ID: <1793109.atdPhlSkOF@kista> In-Reply-To: References: <20220617034209.57337-1-samuel@sholland.org> <3494277.R56niFO833@kista> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org Dne torek, 21. junij 2022 ob 02:20:11 CEST je Samuel Holland napisal(a): > Hi Jernej, >=20 > On 6/20/22 1:28 PM, Jernej =C5=A0krabec wrote: > > Dne petek, 17. junij 2022 ob 05:42:09 CEST je Samuel Holland napisal(a): > >> The sun6i DMA engine supports segment sizes up to 2^25-1 bytes. This is > >> explicitly stated in newer SoC documentation (H6, D1), and it is impli= ed > >> in older documentation by the 25-bit width of the "bytes left in the > >> current segment" register field. > >=20 > > At least A10 user manual says 128k max in description for Byte Counter= =20 > > register (0x100+N*0x20+0xC), although field size is defined as 23:0, bu= t=20 that's=20 > > still less than 2^25-1. A20 supports only 128k too according to manual.= =20 New=20 > > quirk should be introduced for this. >=20 > Thanks for checking this. A10 and A20 use a separate driver (sun4i-dma).= =20 That > driver will also benefit from setting the max segment size, so I will sen= d a > patch for it. >=20 > I think all of the variants supported by sun6i-dma have the same segment= =20 size > capability, so no quirk is needed here. Ah, yes. Then this patch is: Reviewed-by: Jernej Skrabec Best regards, Jernej >=20 > Regards, > Samuel >=20 > >> > >> Exposing the real segment size limit (instead of the 64k default) > >> reduces the number of SG list segments needed for a transaction. > >> > >> Signed-off-by: Samuel Holland > >> --- > >> Tested on A64, verified that the maximum ALSA PCM period increased, and > >> that audio playback still worked. > >> > >> drivers/dma/sun6i-dma.c | 3 +++ > >> 1 file changed, 3 insertions(+) > >> > >> diff --git a/drivers/dma/sun6i-dma.c b/drivers/dma/sun6i-dma.c > >> index b7557f437936..1425f87d97b7 100644 > >> --- a/drivers/dma/sun6i-dma.c > >> +++ b/drivers/dma/sun6i-dma.c > >> @@ -9,6 +9,7 @@ > >> =20 > >> #include > >> #include > >> +#include > >> #include > >> #include > >> #include > >> @@ -1334,6 +1335,8 @@ static int sun6i_dma_probe(struct platform_devic= e=20 > > *pdev) > >> INIT_LIST_HEAD(&sdc->pending); > >> spin_lock_init(&sdc->lock); > >> =20 > >> + dma_set_max_seg_size(&pdev->dev, DMA_BIT_MASK(25)); > >> + > >> dma_cap_set(DMA_PRIVATE, sdc->slave.cap_mask); > >> dma_cap_set(DMA_MEMCPY, sdc->slave.cap_mask); > >> dma_cap_set(DMA_SLAVE, sdc->slave.cap_mask); > >> --=20 > >> 2.35.1 > >> > >> > >=20 > >=20 >=20 >=20 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DC983C43334 for ; Tue, 21 Jun 2022 04:14:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3giTiDsliRK623Gt/6K1eaMyBJ9DxX86bdwB0xlSOOc=; b=x+bIxYjtVnnrsI rzk370mMkIEnl4Bz4IYJvtN+LgfSIK0LUOlsoUlW1ah50AFbbz0034wxy2ClrA4HARldpV5Rfmd9Q RDmU71yf26Hn8VOGg7unNtfn6fncFtIcLTr3TTpoTCv9r1q49OtLP1LN1fgDk7EQwf1nw5l/jgW7c YUWrpzoqOwq1SjeuJ4IGZFWM4m2hLR69KcgslUCuS35Ix5nWbU1rGYb1KKwr89es0Qv/rS4kct4iE BmF62WIaCTOrwJ5hQftBPN3ScHReY9tcZdRsgDrfGXd2nDavPaM05EKG8mXc/deaBI5TtVNY6bMkk JYewqsnjKC2xs/Drm7pQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o3VGF-003YU5-Vl; Tue, 21 Jun 2022 04:13:08 +0000 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o3VGC-003YQn-QX for linux-arm-kernel@lists.infradead.org; Tue, 21 Jun 2022 04:13:06 +0000 Received: by mail-wm1-x32e.google.com with SMTP id l126-20020a1c2584000000b0039c1a10507fso6580836wml.1 for ; Mon, 20 Jun 2022 21:13:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gWNf4zISviT0O075eMDft6o66p0iSBmP3yoC2k9L30s=; b=f3qrhg5kivwoN62pkQbcd4DuX9n8K9cZ9BP+ptY1tWJ7tZgQg2er1cSs3AjXP+UnYt 6cRh3QvedL01Pw75eXfsUtFhueMSqxX6taL4E1ArDFBhODwSRhIgog7UVQhkPn3J8AQp zNN0wastumrL5Gq5bfrcqREF5fOFhezoDvKrdUlYlGK5bX42VKGqBdTBaP9jztvuKQfG a4AtS9szMHVcLXh7b+ClVSoLfANQKtf6voqXV4k1sQcynXBCA8WwIkaoaNWpZ7u6INe6 jyuTWFAxheiqlEEnosdoDxMd7fCNGPTpg3qSeX9eLpy2xH9Zi4GsIPX1mqQ4MgHlIGLP pxrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gWNf4zISviT0O075eMDft6o66p0iSBmP3yoC2k9L30s=; b=bVnu5fk4+OSizqZEzoqBPMUHUEcQwjmy/0PB4BB5gqw7vb1qZ63XI6eAQcFIT9pkCB GjBPCIPJI3+aNtVrDt6sxUvkWt80zmOcbcqegqumt6e/MnulcnUBNrzLMMdmBmOCqowi eJxFwUovZhBDTtsFdmF/jwiNbhdXkVn7LSGL1BJ8IsT/xPMlLJKCjDR2UJlrb3N1qrEU F+lnFSw1VvPUYWgXMjo7RUwl2KOpxyGLMWIzZcG9ML3w2OGJor+58mISQKWJl8DVajAP vMvUeAslACtyjZxDcRsYLIK29T7TdFBhEtikPT7WL56ZqFVdFNVy3wB1M6iN75UNBWbg 3kgQ== X-Gm-Message-State: AOAM530aWW6hYr7Mzndcshd3mHwttN28mRpYIEISv4D3eJ4CMDcCydC8 BzIKAwfLOzp3oF/UGV5S6hw= X-Google-Smtp-Source: ABdhPJy1EcK1Ls78Ofn6WTxbw21kuLZhIFxSHu84kK9NBQ1319q3BRU7LTTnK4saL8kgvjS2sRwCpA== X-Received: by 2002:a7b:cc94:0:b0:39c:4507:e806 with SMTP id p20-20020a7bcc94000000b0039c4507e806mr38807711wma.91.1655784780332; Mon, 20 Jun 2022 21:13:00 -0700 (PDT) Received: from kista.localnet (213-161-3-76.dynamic.telemach.net. [213.161.3.76]) by smtp.gmail.com with ESMTPSA id bt28-20020a056000081c00b0020fcc655e4asm14349200wrb.5.2022.06.20.21.12.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jun 2022 21:12:59 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Chen-Yu Tsai , Vinod Koul , Samuel Holland Cc: dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev Subject: Re: Re: [PATCH] dmaengine: sun6i: Set the maximum segment size Date: Tue, 21 Jun 2022 06:12:53 +0200 Message-ID: <1793109.atdPhlSkOF@kista> In-Reply-To: References: <20220617034209.57337-1-samuel@sholland.org> <3494277.R56niFO833@kista> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220620_211304_921024_63E5682D X-CRM114-Status: GOOD ( 23.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org RG5lIHRvcmVrLCAyMS4ganVuaWogMjAyMiBvYiAwMjoyMDoxMSBDRVNUIGplIFNhbXVlbCBIb2xs YW5kIG5hcGlzYWwoYSk6Cj4gSGkgSmVybmVqLAo+IAo+IE9uIDYvMjAvMjIgMToyOCBQTSwgSmVy bmVqIMWga3JhYmVjIHdyb3RlOgo+ID4gRG5lIHBldGVrLCAxNy4ganVuaWogMjAyMiBvYiAwNTo0 MjowOSBDRVNUIGplIFNhbXVlbCBIb2xsYW5kIG5hcGlzYWwoYSk6Cj4gPj4gVGhlIHN1bjZpIERN QSBlbmdpbmUgc3VwcG9ydHMgc2VnbWVudCBzaXplcyB1cCB0byAyXjI1LTEgYnl0ZXMuIFRoaXMg aXMKPiA+PiBleHBsaWNpdGx5IHN0YXRlZCBpbiBuZXdlciBTb0MgZG9jdW1lbnRhdGlvbiAoSDYs IEQxKSwgYW5kIGl0IGlzIGltcGxpZWQKPiA+PiBpbiBvbGRlciBkb2N1bWVudGF0aW9uIGJ5IHRo ZSAyNS1iaXQgd2lkdGggb2YgdGhlICJieXRlcyBsZWZ0IGluIHRoZQo+ID4+IGN1cnJlbnQgc2Vn bWVudCIgcmVnaXN0ZXIgZmllbGQuCj4gPiAKPiA+IEF0IGxlYXN0IEExMCB1c2VyIG1hbnVhbCBz YXlzIDEyOGsgbWF4IGluIGRlc2NyaXB0aW9uIGZvciBCeXRlIENvdW50ZXIgCj4gPiByZWdpc3Rl ciAoMHgxMDArTioweDIwKzB4QyksIGFsdGhvdWdoIGZpZWxkIHNpemUgaXMgZGVmaW5lZCBhcyAy MzowLCBidXQgCnRoYXQncyAKPiA+IHN0aWxsIGxlc3MgdGhhbiAyXjI1LTEuIEEyMCBzdXBwb3J0 cyBvbmx5IDEyOGsgdG9vIGFjY29yZGluZyB0byBtYW51YWwuIApOZXcgCj4gPiBxdWlyayBzaG91 bGQgYmUgaW50cm9kdWNlZCBmb3IgdGhpcy4KPiAKPiBUaGFua3MgZm9yIGNoZWNraW5nIHRoaXMu IEExMCBhbmQgQTIwIHVzZSBhIHNlcGFyYXRlIGRyaXZlciAoc3VuNGktZG1hKS4gClRoYXQKPiBk cml2ZXIgd2lsbCBhbHNvIGJlbmVmaXQgZnJvbSBzZXR0aW5nIHRoZSBtYXggc2VnbWVudCBzaXpl LCBzbyBJIHdpbGwgc2VuZCBhCj4gcGF0Y2ggZm9yIGl0Lgo+IAo+IEkgdGhpbmsgYWxsIG9mIHRo ZSB2YXJpYW50cyBzdXBwb3J0ZWQgYnkgc3VuNmktZG1hIGhhdmUgdGhlIHNhbWUgc2VnbWVudCAK c2l6ZQo+IGNhcGFiaWxpdHksIHNvIG5vIHF1aXJrIGlzIG5lZWRlZCBoZXJlLgoKQWgsIHllcy4g VGhlbiB0aGlzIHBhdGNoIGlzOgpSZXZpZXdlZC1ieTogSmVybmVqIFNrcmFiZWMgPGplcm5lai5z a3JhYmVjQGdtYWlsLmNvbT4KCkJlc3QgcmVnYXJkcywKSmVybmVqCgo+IAo+IFJlZ2FyZHMsCj4g U2FtdWVsCj4gCj4gPj4KPiA+PiBFeHBvc2luZyB0aGUgcmVhbCBzZWdtZW50IHNpemUgbGltaXQg KGluc3RlYWQgb2YgdGhlIDY0ayBkZWZhdWx0KQo+ID4+IHJlZHVjZXMgdGhlIG51bWJlciBvZiBT RyBsaXN0IHNlZ21lbnRzIG5lZWRlZCBmb3IgYSB0cmFuc2FjdGlvbi4KPiA+Pgo+ID4+IFNpZ25l ZC1vZmYtYnk6IFNhbXVlbCBIb2xsYW5kIDxzYW11ZWxAc2hvbGxhbmQub3JnPgo+ID4+IC0tLQo+ ID4+IFRlc3RlZCBvbiBBNjQsIHZlcmlmaWVkIHRoYXQgdGhlIG1heGltdW0gQUxTQSBQQ00gcGVy aW9kIGluY3JlYXNlZCwgYW5kCj4gPj4gdGhhdCBhdWRpbyBwbGF5YmFjayBzdGlsbCB3b3JrZWQu Cj4gPj4KPiA+PiAgZHJpdmVycy9kbWEvc3VuNmktZG1hLmMgfCAzICsrKwo+ID4+ICAxIGZpbGUg Y2hhbmdlZCwgMyBpbnNlcnRpb25zKCspCj4gPj4KPiA+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9k bWEvc3VuNmktZG1hLmMgYi9kcml2ZXJzL2RtYS9zdW42aS1kbWEuYwo+ID4+IGluZGV4IGI3NTU3 ZjQzNzkzNi4uMTQyNWY4N2Q5N2I3IDEwMDY0NAo+ID4+IC0tLSBhL2RyaXZlcnMvZG1hL3N1bjZp LWRtYS5jCj4gPj4gKysrIGIvZHJpdmVycy9kbWEvc3VuNmktZG1hLmMKPiA+PiBAQCAtOSw2ICs5 LDcgQEAKPiA+PiAgCj4gPj4gICNpbmNsdWRlIDxsaW51eC9jbGsuaD4KPiA+PiAgI2luY2x1ZGUg PGxpbnV4L2RlbGF5Lmg+Cj4gPj4gKyNpbmNsdWRlIDxsaW51eC9kbWEtbWFwcGluZy5oPgo+ID4+ ICAjaW5jbHVkZSA8bGludXgvZG1hZW5naW5lLmg+Cj4gPj4gICNpbmNsdWRlIDxsaW51eC9kbWFw b29sLmg+Cj4gPj4gICNpbmNsdWRlIDxsaW51eC9pbnRlcnJ1cHQuaD4KPiA+PiBAQCAtMTMzNCw2 ICsxMzM1LDggQEAgc3RhdGljIGludCBzdW42aV9kbWFfcHJvYmUoc3RydWN0IHBsYXRmb3JtX2Rl dmljZSAKPiA+ICpwZGV2KQo+ID4+ICAJSU5JVF9MSVNUX0hFQUQoJnNkYy0+cGVuZGluZyk7Cj4g Pj4gIAlzcGluX2xvY2tfaW5pdCgmc2RjLT5sb2NrKTsKPiA+PiAgCj4gPj4gKwlkbWFfc2V0X21h eF9zZWdfc2l6ZSgmcGRldi0+ZGV2LCBETUFfQklUX01BU0soMjUpKTsKPiA+PiArCj4gPj4gIAlk bWFfY2FwX3NldChETUFfUFJJVkFURSwgc2RjLT5zbGF2ZS5jYXBfbWFzayk7Cj4gPj4gIAlkbWFf Y2FwX3NldChETUFfTUVNQ1BZLCBzZGMtPnNsYXZlLmNhcF9tYXNrKTsKPiA+PiAgCWRtYV9jYXBf c2V0KERNQV9TTEFWRSwgc2RjLT5zbGF2ZS5jYXBfbWFzayk7Cj4gPj4gLS0gCj4gPj4gMi4zNS4x Cj4gPj4KPiA+Pgo+ID4gCj4gPiAKPiAKPiAKCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgt YXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3Jn L21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=