All of lore.kernel.org
 help / color / mirror / Atom feed
From: patchwork-bot+netdevbpf@kernel.org
To: Fernando Fernandez Mancera <fmancera@suse.de>
Cc: netdev@vger.kernel.org, jacob.e.keller@intel.com,
	horms@kernel.org, pabeni@redhat.com, kuba@kernel.org,
	edumazet@kernel.org, davem@davemloft.net, jiri@resnulli.us,
	yangguikun19@qq.com
Subject: Re: [PATCH net] devlink: region: fix snapshot id leak on kernel-allocated ids
Date: Tue, 27 Oct 2026 22:50:05 +0000	[thread overview]
Message-ID: <179314140532.375317.5828428376782331028.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20261026174403.512-1-fmancera@suse.de>

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Mon, 26 Oct 2026 18:44:03 +0100 you wrote:
> When DEVLINK_CMD_REGION_NEW is issued without a snapshot id, the kernel
> allocates one with __devlink_region_snapshot_id_get(). That helper counts
> the caller as a user of the id, and the caller must release this hold
> once it is done.
> 
> devlink_nl_region_new_doit() never drops it. The refcount of the id goes
> 1 (allocation) -> 2 (snapshot created) and stays at 2. When the snapshot
> is deleted the count only drops to 1, so the id is never erased from
> the snapshot_ids xarray. The id then stays in use for the lifetime of
> the devlink instance: requesting a snapshot with that explicit id fails
> with -EEXIST, and there is no snapshot left to delete to clean it up.
> 
> [...]

Here is the summary with links:
  - [net] devlink: region: fix snapshot id leak on kernel-allocated ids
    https://git.kernel.org/netdev/net/c/ef8f0a1d888e

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



      parent reply	other threads:[~2026-10-27 22:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-26 17:44 [PATCH net] devlink: region: fix snapshot id leak on kernel-allocated ids Fernando Fernandez Mancera
2026-10-27 22:47 ` Jakub Kicinski
2026-10-27 22:50 ` patchwork-bot+netdevbpf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=179314140532.375317.5828428376782331028.git-patchwork-notify@kernel.org \
    --to=patchwork-bot+netdevbpf@kernel.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@kernel.org \
    --cc=fmancera@suse.de \
    --cc=horms@kernel.org \
    --cc=jacob.e.keller@intel.com \
    --cc=jiri@resnulli.us \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=yangguikun19@qq.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.