From: patchwork-bot+netdevbpf@kernel.org
To: Eric Dumazet <edumazet@kernel.org>
Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
willemb@google.com, horms@kernel.org, netdev@vger.kernel.org,
bpf@vger.kernel.org, andrew+netdev@lunn.ch, aconole@redhat.com,
echaudro@redhat.com, i.maximets@ovn.org, jhs@mojatatu.com,
jiri@resnulli.us, dev@openvswitch.org,
willemdebruijn.kernel@gmail.com, weir@nebusec.ai
Subject: Re: [PATCH net v2 0/5] net: fix eth_type_trans() crashes on skbs coming from the stack
Date: Thu, 29 Oct 2026 16:30:11 +0000 [thread overview]
Message-ID: <179329141129.559085.14393528345528530000.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20261028122703.2093730-1-edumazet@kernel.org>
Hello:
This series was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Wed, 28 Oct 2026 13:26:58 +0100 you wrote:
> eth_type_trans() assumes ETH_HLEN bytes are present in skb->head.
> NIC drivers always provide this, and they should keep using the fast
> version, without an extra pskb_may_pull().
>
> Devices looping skbs from their transmit path back to their receive
> path get skbs built by the stack instead. tc actions (act_vlan pop_eth,
> act_ife decode), BPF helpers (bpf_skb_change_head() before a redirect)
> or OVS actions (pop_eth followed by pop_mpls/pop_nsh) can leave fewer
> than ETH_HLEN bytes in the linear part, and eth_type_trans() then hits
> the BUG() in __skb_pull().
>
> [...]
Here is the summary with links:
- [net,v2,1/5] net: add eth_type_trans_careful()
https://git.kernel.org/netdev/net/c/2519a6fe7a8b
- [net,v2,2/5] loopback: use eth_type_trans_careful()
https://git.kernel.org/netdev/net/c/093a28998374
- [net,v2,3/5] net: use eth_type_trans_careful() in __dev_forward_skb2()
https://git.kernel.org/netdev/net/c/695e1408eb90
- [net,v2,4/5] openvswitch: use eth_type_trans_careful() in internal_dev_recv()
https://git.kernel.org/netdev/net/c/b55e5a0159c8
- [net,v2,5/5] net/sched: act_ife: do not consume the inner header on egress
https://git.kernel.org/netdev/net/c/498c631f9c6d
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2026-10-29 16:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-28 12:26 [PATCH net v2 0/5] net: fix eth_type_trans() crashes on skbs coming from the stack Eric Dumazet
2026-10-28 12:26 ` [PATCH net v2 1/5] net: add eth_type_trans_careful() Eric Dumazet
2026-10-28 12:27 ` [PATCH net v2 2/5] loopback: use eth_type_trans_careful() Eric Dumazet
2026-10-28 18:48 ` Willem de Bruijn
2026-10-28 12:27 ` [PATCH net v2 3/5] net: use eth_type_trans_careful() in __dev_forward_skb2() Eric Dumazet
2026-10-28 19:03 ` Willem de Bruijn
2026-10-28 12:27 ` [PATCH net v2 4/5] openvswitch: use eth_type_trans_careful() in internal_dev_recv() Eric Dumazet
2026-10-28 19:04 ` Willem de Bruijn
2026-10-28 12:27 ` [PATCH net v2 5/5] net/sched: act_ife: do not consume the inner header on egress Eric Dumazet
2026-10-28 17:34 ` [PATCH net v2 0/5] net: fix eth_type_trans() crashes on skbs coming from the stack Alexei Starovoitov
2026-10-28 19:31 ` Daniel Borkmann
2026-10-29 16:30 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179329141129.559085.14393528345528530000.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=aconole@redhat.com \
--cc=andrew+netdev@lunn.ch \
--cc=bpf@vger.kernel.org \
--cc=davem@davemloft.net \
--cc=dev@openvswitch.org \
--cc=echaudro@redhat.com \
--cc=edumazet@kernel.org \
--cc=horms@kernel.org \
--cc=i.maximets@ovn.org \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=weir@nebusec.ai \
--cc=willemb@google.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.