From: patchwork-bot+netdevbpf@kernel.org
To: Xia Yan <yanxia@cmss.chinamobile.com>
Cc: netdev@vger.kernel.org, kurt@linutronix.de, andrew@lunn.ch,
olteanv@gmail.com, richardcochran@gmail.com, edumazet@kernel.org,
kuba@kernel.org, pabeni@redhat.com, davem@davemloft.net,
Pavel.Zhigulin@kaspersky.com, linux-kernel@vger.kernel.org,
yana06070@163.com
Subject: Re: [PATCH net-next] net: dsa: hellcreek: fix device_node leak in hellcreek_led_setup()
Date: Wed, 11 Nov 2026 05:50:04 +0000 [thread overview]
Message-ID: <179437620468.720797.7079283265270004352.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <1793954912000.3200.3087525628285919529@cmss.chinamobile.com>
Hello:
This patch was applied to netdev/net-next.git (main)
by Dave Miller <davem@davem-thinkpadp1gen8.ibmlond.csb>:
On Fri, 06 Nov 2026 16:48:32 +0800 you wrote:
> hellcreek_led_setup() walks the two LED child nodes of the "leds" node
> with of_get_next_available_child(). The helper drops the reference on
> the child passed to it and takes one on the child it returns. After
> the second call the caller holds a reference on the second LED node.
>
> That reference is never dropped. The out: label only releases the
> "leds" node itself. Boards with both LED child nodes leak one
> device_node reference per probe, on the registration failures as well
> as on the success path.
>
> [...]
Here is the summary with links:
- [net-next] net: dsa: hellcreek: fix device_node leak in hellcreek_led_setup()
https://git.kernel.org/netdev/net-next/c/c4c470912125
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2026-11-11 5:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-06 8:48 [PATCH net-next] net: dsa: hellcreek: fix device_node leak in hellcreek_led_setup() Xia Yan
2026-11-06 8:51 ` netdev-bot+sinfo
2026-11-06 8:59 ` Xia Yan
2026-11-06 9:54 ` Kurt Kanzenbach
2026-11-11 5:50 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179437620468.720797.7079283265270004352.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=Pavel.Zhigulin@kaspersky.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=kuba@kernel.org \
--cc=kurt@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=yana06070@163.com \
--cc=yanxia@cmss.chinamobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.