From: patchwork-bot+netdevbpf@kernel.org
To: Jiahao Xu <xujiahao@cmss.chinamobile.com>
Cc: oliver@neukum.org, netdev@vger.kernel.org, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@kernel.org, kuba@kernel.org,
pabeni@redhat.com, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org,
syzbot+1994e2ecf323ed90f255@syzkaller.appspotmail.com
Subject: Re: [PATCH net v3] net: usb: cdc_ncm: don't underflow the NDP room check
Date: Thu, 12 Nov 2026 19:00:08 +0000 [thread overview]
Message-ID: <179451000897.594620.2574632461996033695.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20261111124156.637661-1-xujiahao@cmss.chinamobile.com>
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Wed, 11 Nov 2026 12:41:56 +0800 you wrote:
> cdc_ncm_ndp16() and cdc_ncm_ndp32() verify that the new NDP and the
> datagram fit into the NTB with an unsigned subtraction:
>
> if ((ctx->tx_curr_size - skb->len - reserve) < ctx->max_ndp_size)
> return NULL;
>
> Nothing guarantees that skb->len plus the reserve stays below
> tx_curr_size, and when it does not the subtraction wraps around to a
> huge value, the check passes, and the skb_put_zero() of max_ndp_size
> bytes that follows overruns the NTB:
>
> [...]
Here is the summary with links:
- [net,v3] net: usb: cdc_ncm: don't underflow the NDP room check
https://git.kernel.org/netdev/net/c/b507828c7b61
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2026-11-12 19:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-11 4:41 [PATCH net v3] net: usb: cdc_ncm: don't underflow the NDP room check Jiahao Xu
2026-11-12 19:00 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179451000897.594620.2574632461996033695.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oliver@neukum.org \
--cc=pabeni@redhat.com \
--cc=syzbot+1994e2ecf323ed90f255@syzkaller.appspotmail.com \
--cc=xujiahao@cmss.chinamobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.