From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A3220606A333 for ; Fri, 13 Nov 2026 04:06:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=Sql9G1eW; dkim=fail reason="signature verification failed" (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=EQtFcJ4B DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Cc:To:From:Subject:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=yEKgRuzaP0uZkjbp7dv28gGdg6XNAgNd+s8docfhCOw=; b=Sql9G1eWrzJZcG/YUnc44igTPo 1GbppXTRfdYXPLQzXNqy0h0DN9c1by0aRzK5lcZ4Gs0qquGRpL4No16yGomixEhJwHL60u3zAiCwV R1LVQjpPjoPPJuyHfJZzupCMd80RWPJe0ySRHgNSSSci5CwgUBuAhha5XK5osO+3xP/KbFNMQ11+N ZU+g5aiNCzpXkLvX8L0QmLTfWTPn2kV8Z3oi+njMqqBCFEwrfJdRiLLgejJ2BaNfSHF5HG5vI55mK zCPPqcDCnCKOYEW6XvypTVITvFjoYEVMnrlxEDIBsakLSjxHRnTW+nHPZ+McNsIuxXFI1/ER1PEKD lcG8rN2g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xRiYp-0000000BcjG-0ahI; Fri, 13 Nov 2026 04:06:47 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xRiYn-0000000Bciy-1AZI; Fri, 13 Nov 2026 04:06:45 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 7A40360D6A; Fri, 13 Nov 2026 04:06:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3A3101F000C4; Fri, 13 Nov 2026 04:06:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794542804; bh=tuA60olfOPNvdkAZ/j00xlMiIOiP361+dfqsaehGjQU=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=EQtFcJ4BNe2SbOwbVspWNP8nzBg2I1LK4KPzLE86/Oo4ST9cUm/rh6Y2WwU2MJ8mw A5PwkmP7v97L6m1rp0BydeG0TZ5cOafUO2FtcfxiIvQfPGhMmzWSWcugjhrOJSXaJ/ 6Zn9EUa/QujxJ21B0Dh8AP0j/CeqzXZpBPgXk7nNoE1ZbLQvcec8TEpmVRt1TV+v5y nSn68Z3ZBvlWdMKx3EoQdlxs1FLP3reZApzdK1VeZa9fhv9tX+qycxP1P3LHERxafI JMwAFK+Tp63qIHALdE8Uv4cxLK3h2EynuZRLEsOZd2nSJv1ljEv+UN+icl7tqO9gk7 6N+6w615OoOww== Subject: Re: [PATCH net-next v4 2/2] net: pcs: xpcs: make supported_interfaces authoritative From: netdev-bot+sashiko@kernel.org To: coiaprant@gmail.com Cc: kuba@kernel.org, pabeni@redhat.com, jiawenwu@trustnetic.com, mengyuanlou@net-swift.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@kernel.org, hkallweit1@gmail.com, linux@armlinux.org.uk, heiko@sntech.de, aleksandr.loktionov@intel.com, fabio.baltieri@gmail.com, netdev@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Date: Fri, 13 Nov 2026 04:06:42 +0000 Message-ID: <179454280276.2199510.48600645261637152@kernel.org> In-Reply-To: <20261110160554.918652-3-coiaprant@gmail.com> References: <20261110160554.918652-3-coiaprant@gmail.com> X-sashiko-severity: Medium X-Archived-By: MIME-Version: 1.0 X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" X-Spam-Status: No, score=-8.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MyBwb3RlbnRpYWwKaXNzdWUocykgdG8gY29uc2lkZXIuCgpDcml0aWNhbDogMCDCtyBIaWdoOiAw IMK3IE1lZGl1bTogMSDCtyBMb3c6IDIKCklmIHlvdSBiZWxpZXZlIG5vbmUgb2YgdGhlIGlzc3Vl cyBhcmUgbGVnaXRpbWF0ZSwgcGxlYXNlIHJlcGx5IHRvIGVhY2gKaXNzdWUgb2YgTWVkaXVtIHNl dmVyaXR5IG9yIGhpZ2hlciBhbmQgZXhwbGFpbiB3aHkgdGhlIEFJIGlzIHdyb25nLgpJZiBhbnkg b2YgdGhlbSBhcmUgbGVnaXRpbWF0ZSBhbmQgeW91IHBsYW4gdG8gcmVzcGluLCBwbGVhc2UgbGV0 IHBhdGNod29yawprbm93IGJ5IGluY2x1ZGluZyAicHctYm90OiBjciIgYXMgYSBzZXBhcmF0ZSBs aW5lIGF0IHRoZSBlbmQgb2YgeW91ciByZXBseQoob25lIHN1Y2ggcmVwbHkgcGVyIHNlcmllcyBp cyBlbm91Z2gpLgoKLSBbTWVkaXVtXSBUaGUgY29tbWl0IG1lc3NhZ2Ugb3ZlcnN0YXRlcyB3aGF0 IHRoZSBjb3JlIGh1bmsgZml4ZXMuCi0gW0xvd10gVGhlIGNvbW1pdCBtZXNzYWdlIGxlYXZlcyBv dXQgdGhlIGJlaGF2aW91ciBjaGFuZ2UgdGhhdCBhY3R1YWxseQogIG1hdHRlcnMuCi0gW0xvd10g eHBjc19ya19jcmVhdGUoKSBwdXRzIFBIWV9JTlRFUkZBQ0VfTU9ERV9RU0dNSUkgaW50byB0aGUg cGxhdGZvcm0KICBtYXNrLCBhbmQgaXRzIGNvbW1lbnQgc2F5cyAiVGhlIFJLMzU2OCBYUENTIHN1 cHBvcnRzIDEwMDBCQVNFLVgsIFNHTUlJ4oCmCgotLQoKbmV0OiBwY3M6IHhwY3M6IG1ha2Ugc3Vw cG9ydGVkX2ludGVyZmFjZXMgYXV0aG9yaXRhdGl2ZQoKVGhpcyBjb21taXQgbWFrZXMgeHBjc19m aW5kX2NvbXBhdCgpIHJldHVybiBOVUxMIGZvciBhbnkgaW50ZXJmYWNlIHRoYXQKaXMgbm90IHNl dCBpbiBwY3Muc3VwcG9ydGVkX2ludGVyZmFjZXMuIEl0IGFsc28gbmFycm93cyB0aGUgUm9ja2No aXAKWFBDUyBtYXNrIGluIHhwY3NfcmtfY3JlYXRlKCkuIEl0IGRvZXMgdGhpcyBieSBpbnRlcnNl Y3RpbmcgdGhlIG1hc2sKd2l0aCBhIHBsYXRmb3JtIG1hc2sgb2YgMTAwMEJBU0UtWCwgU0dNSUkg YW5kIFFTR01JSS4KCj4gSG93ZXZlciwgeHBjc19maW5kX2NvbXBhdCgpIG9ubHkgd2Fsa3MgZGVz Yy0+Y29tcGF0W10gYW5kIGRvZXMgbm90IGxvb2sKPiBhdCBwY3Muc3VwcG9ydGVkX2ludGVyZmFj ZXMuIElmIGEgY2FsbGVyIGV2ZXIgcGFzc2VzIGFuIGludGVyZmFjZQo+IG91dHNpZGUgdGhlIG1h c2ssIHRoZSBjb3JlIHdvdWxkIHN0aWxsIGZpbmQgYW5kIGNvbmZpZ3VyZSBhIGNvbXBhdAo+IGVu dHJ5IGZvciBpdCwgY29udHJhZGljdGluZyB0aGUgbWFzayB0aGUgZ2x1ZSBhbHJlYWR5IHNldC4g VGhpcyB3YXMgYQo+IGtub3duIGdhcDogdGhlIG1hc2sgd2FzIHdyaXR0ZW4gYnV0IG5ldmVyIGNv bnN1bHRlZCBieSB0aGUgY29yZS4KCltTZXZlcml0eTogTWVkaXVtXQpEb2VzIHRoaXMgZGVzY3Jp YmUgdGhlIGNvZGUgYXMgaXQgd2FzIGJlZm9yZSB0aGlzIHBhdGNoPwoKSW4gdGhlIGNvcmUsIG9u bHkgeHBjc19jcmVhdGUoKSB3cml0ZXMgcGNzLnN1cHBvcnRlZF9pbnRlcmZhY2VzLiBJdCBkb2Vz CnNvIHRocm91Z2ggeHBjc19nZXRfaW50ZXJmYWNlcygpLCB3aGljaCBidWlsZHMgdGhlIG1hc2sg ZnJvbSB0aGUgc2FtZQp0YWJsZSB0aGF0IHhwY3NfZmluZF9jb21wYXQoKSB3YWxrczoKCmRyaXZl cnMvbmV0L3Bjcy9wY3MteHBjcy5jOnhwY3NfZ2V0X2ludGVyZmFjZXMoKSB7Cglmb3IgKGNvbXBh dCA9IHhwY3MtPmRlc2MtPmNvbXBhdDsgY29tcGF0LT5zdXBwb3J0ZWQ7IGNvbXBhdCsrKQoJCV9f c2V0X2JpdChjb21wYXQtPmludGVyZmFjZSwgaW50ZXJmYWNlcyk7Cn0KCkZvciBldmVyeSBleGlz dGluZyB1c2VyLCBhIHNldCBiaXQgYW5kIGEgY29tcGF0IGVudHJ5IG1lYW4gdGhlIHNhbWUKdGhp bmcuIFRoZSBuZXcgdGVzdF9iaXQoKSBpbiB4cGNzX2ZpbmRfY29tcGF0KCkgdGhlcmVmb3JlIGNh bid0IHJlamVjdAphbnl0aGluZy4KCkJlZm9yZSB0aGlzIHBhdGNoLCB4cGNzX3JrX2NyZWF0ZSgp IGRpZG4ndCB0b3VjaCBwY3Muc3VwcG9ydGVkX2ludGVyZmFjZXMKZWl0aGVyLiBTbyBubyBtYXNr IGhhZCBiZWVuICJhbHJlYWR5IHNldCIgYnkgdGhlIGdsdWUuIFRoaXMgc2FtZSBwYXRjaAphZGRz IHRoZSBuYXJyb3dpbmcuCgpwaHlsaW5rIGFsc28gYWxyZWFkeSBjaGVja3MgdGhlIG1hc2sgYmVm b3JlIGl0IHVzZXMgdGhlIFBDUzoKCmRyaXZlcnMvbmV0L3BoeS9waHlsaW5rLmM6cGh5bGlua192 YWxpZGF0ZV9tYWNfYW5kX3BjcygpIHsKICAgIC4uLgoJCWlmICghcGh5X2ludGVyZmFjZV9lbXB0 eShwY3MtPnN1cHBvcnRlZF9pbnRlcmZhY2VzKSAmJgoJCSAgICAhdGVzdF9iaXQoc3RhdGUtPmlu dGVyZmFjZSwgcGNzLT5zdXBwb3J0ZWRfaW50ZXJmYWNlcykpIHsKCQkJcGh5bGlua19lcnIocGws ICJNQUMgcmV0dXJuZWQgUENTIHdoaWNoIGRvZXMgbm90IHN1cHBvcnQgJXNcbiIsCgkJCQkgICAg cGh5X21vZGVzKHN0YXRlLT5pbnRlcmZhY2UpKTsKCQkJcmV0dXJuIC1FSU5WQUw7CgkJfQogICAg Li4uCn0KClRoZSBvbmx5IHBhdGggdGhhdCBza2lwcyBwaHlsaW5rIHNlZW1zIHRvIGJlIHRoZSBl eHBvcnRlZAp4cGNzX2dldF9hbl9tb2RlKCkuIEl0IGlzIGNhbGxlZCBmcm9tIHN0bW1hY19pbml0 X3BoeSgpIHdpdGgKcGxhdC0+cGh5X2ludGVyZmFjZS4gT24gUksgdGhhdCBpcyBhbHdheXMgU0dN SUksIHdoaWNoIHN0YXlzIGluIHRoZQptYXNrLgoKQ291bGQgdGhlIGNvbW1pdCBtZXNzYWdlIHNh eSB0aGF0IHRoZSB4cGNzX2ZpbmRfY29tcGF0KCkgY2hhbmdlIGlzCmRlZmVuc2l2ZSwgYW5kIHRo YXQgdGhlIGJlaGF2aW91ciBjaGFuZ2UgY29tZXMgZnJvbSB0aGUgZ2x1ZSBuYXJyb3dpbmcKdGhl IG1hc2s/Cgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL25ldC9wY3MvcGNzLXhwY3MtcmsuYyBiL2Ry aXZlcnMvbmV0L3Bjcy9wY3MteHBjcy1yay5jCj4gaW5kZXggNmYwYTExMGUzMmQyNC4uYjE0YjU1 ZGJkMjZjYyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL25ldC9wY3MvcGNzLXhwY3MtcmsuYwo+ICsr KyBiL2RyaXZlcnMvbmV0L3Bjcy9wY3MteHBjcy1yay5jCgpbIC4uLiBdCgo+IEBAIC01MzYsNiAr NTM3LDE1IEBAIHN0cnVjdCBkd194cGNzICp4cGNzX3JrX2NyZWF0ZShzdHJ1Y3QgZGV2aWNlICpk ZXYsIHN0cnVjdCBkZXZpY2Vfbm9kZSAqcGNzLCBpbnQKPiAgCQlyZXR1cm4geHBjczsKPiAgCX0K PiAgCj4gKwkvKgo+ICsJICogVGhlIFJLMzU2OCBYUENTIHN1cHBvcnRzIDEwMDBCQVNFLVgsIFNH TUlJIGFuZCBRU0dNSUkuCj4gKwkgKi8KPiArCV9fc2V0X2JpdChQSFlfSU5URVJGQUNFX01PREVf MTAwMEJBU0VYLCBzdXBwb3J0ZWRfaW50ZXJmYWNlcyk7Cj4gKwlfX3NldF9iaXQoUEhZX0lOVEVS RkFDRV9NT0RFX1NHTUlJLCBzdXBwb3J0ZWRfaW50ZXJmYWNlcyk7Cj4gKwlfX3NldF9iaXQoUEhZ X0lOVEVSRkFDRV9NT0RFX1FTR01JSSwgc3VwcG9ydGVkX2ludGVyZmFjZXMpOwoKW1NldmVyaXR5 OiBMb3ddClNob3VsZCBRU0dNSUkgYmUgaW4gdGhpcyBtYXNrPwoKc3lub3BzeXNfeHBjc19jb21w YXRbXSBoYXMgbm8gUVNHTUlJIGVudHJ5LiBwaHlfaW50ZXJmYWNlX2FuZCgpIGFsd2F5cwpjbGVh cnMgdGhpcyBiaXQsIHNvIGl0IGlzIGRlYWQgY29kZSB0b2RheS4KClRoZSBjb21taXQgbWVzc2Fn ZSBzYXlzIHRoZSBnbHVlICJ3aWxsIGF1dG9tYXRpY2FsbHkgcGljayBpdCB1cCIgb25jZQp0aGUg Y29yZSBzdXBwb3J0cyBRU0dNSUkuIEhvd2V2ZXIsIG5vdGhpbmcgaW4gdGhlIFJLIGludGVncmF0 aW9uIHNlZW1zCnRvIGhhbmRsZSBRU0dNSUk6CgotIHBjcy14cGNzLXJrLmMgb25seSBjYWxscyBw aHlfaW5pdCgpIGFuZCBwaHlfcG93ZXJfb24oKSBvbiB0aGUgU2VyRGVzLgogIEl0IG5ldmVyIHNl dHMgYSBTZXJEZXMgbW9kZSBmb3IgZWFjaCBpbnRlcmZhY2UuCi0gcmtfZ21hY19wcm9iZSgpIG9u bHkgaW5zdGFsbHMgcmtfcGNzX2luaXQoKSBhbmQgcmtfc2VsZWN0X3BjcygpIHdoZW4KICBwbGF0 X2RhdC0+cGh5X2ludGVyZmFjZSBpcyBQSFlfSU5URVJGQUNFX01PREVfU0dNSUkuCi0gcmtfZ21h Y19jaGVja19vcHMoKSBhbmQgcmtfZ21hY19wb3dlcnVwKCkgb25seSBhY2NlcHQgUkdNSUkqLCBS TUlJCiAgYW5kIFNHTUlJLgoKQW5vdGhlciBpbnRlZ3JhdGlvbiBtaWdodCBsYXRlciBuZWVkIGEg UVNHTUlJIGVudHJ5IGluCnN5bm9wc3lzX3hwY3NfY29tcGF0W10uIEluIHRoYXQgY2FzZSB0aGUg Yml0IHdvdWxkIHN1cnZpdmUgaGVyZSwgYW5kCnN0bW1hY19waHlsaW5rX3NldHVwKCkgd291bGQg T1IgaXQgaW50byBwaHlsaW5rJ3Mgc3VwcG9ydGVkX2ludGVyZmFjZXMKZm9yIGR3bWFjLXJrLgoK V291bGQgcGh5bGluayB0aGVuIGJlIGFibGUgdG8gc2VsZWN0IFFTR01JSSwgZXZlbiB0aG91Z2gg bmVpdGhlciB0aGUKU2VyRGVzIG5vciB0aGUgTUFDIGdsdWUgaXMgc2V0IHVwIGZvciBpdD8KCj4g KwlwaHlfaW50ZXJmYWNlX2FuZCh4cGNzLT5wY3Muc3VwcG9ydGVkX2ludGVyZmFjZXMsIHhwY3Mt PnBjcy5zdXBwb3J0ZWRfaW50ZXJmYWNlcywKPiArCQkJICBzdXBwb3J0ZWRfaW50ZXJmYWNlcyk7 CgpbU2V2ZXJpdHk6IExvd10KU2hvdWxkIHRoZSBjb21taXQgbWVzc2FnZSBtZW50aW9uIHRoYXQg dGhpcyBuYXJyb3dpbmcgY2hhbmdlcyB0aGUKcGh5bGluayBjb25maWd1cmF0aW9uIG9mIGR3bWFj LXJrPwoKcmtfcGNzX2luaXQoKSBzdG9yZXMgdGhpcyBYUENTIGluIHByaXYtPmh3LT54cGNzLiBz dG1tYWNfcGh5bGlua19zZXR1cCgpCnRoZW4gT1JzIGl0cyBtYXNrIGludG8gcGh5bGluaydzIGlu dGVyZmFjZSBtYXNrczoKCmRyaXZlcnMvbmV0L2V0aGVybmV0L3N0bWljcm8vc3RtbWFjL3N0bW1h Y19tYWluLmM6c3RtbWFjX3BoeWxpbmtfc2V0dXAoKSB7CiAgICAuLi4KCWlmIChwY3MpCgkJcGh5 X2ludGVyZmFjZV9vcihjb25maWctPnN1cHBvcnRlZF9pbnRlcmZhY2VzLAoJCQkJIGNvbmZpZy0+ c3VwcG9ydGVkX2ludGVyZmFjZXMsCgkJCQkgcGNzLT5zdXBwb3J0ZWRfaW50ZXJmYWNlcyk7CiAg ICAuLi4KCQlpZiAocGNzKQoJCQlwaHlfaW50ZXJmYWNlX29yKGNvbmZpZy0+bHBpX2ludGVyZmFj ZXMsCgkJCQkJIGNvbmZpZy0+bHBpX2ludGVyZmFjZXMsCgkJCQkJIHBjcy0+c3VwcG9ydGVkX2lu dGVyZmFjZXMpOwogICAgLi4uCn0KClRoZSBscGlfaW50ZXJmYWNlcyB1cGRhdGUgb25seSBoYXBw ZW5zIHdoZW4gcHJpdi0+ZG1hX2NhcC5lZWUgaXMgc2V0CmFuZCBTVE1NQUNfRkxBR19FRUVfRElT QUJMRSBpcyBub3QuCgpCZWZvcmUgdGhpcyBwYXRjaCwgdGhlIGZ1bGwgc3lub3BzeXNfeHBjc19j b21wYXRbXSBzZXQgd2FzIGFkdmVydGlzZWQgdG8KcGh5bGluayBmb3IgZHdtYWMtcmsgYXMgYm90 aCBzdXBwb3J0ZWQgYW5kIExQSS1jYXBhYmxlLiBUaGF0IHNldCBpcwpVU1hHTUlJLCAxMEdLUiwg MjVHQkFTRVIsIFhMR01JSSwgNTBHQkFTRVIsIExBVUksIDEwMEdCQVNFUCwgMTBHQkFTRVIsClNH TUlJLCAxMDAwQkFTRVggYW5kIDI1MDBCQVNFWC4gQWZ0ZXIgdGhpcyBwYXRjaCwgYm90aCBtYXNr cyBzaHJpbmsgdG8KU0dNSUkgYW5kIDEwMDBCQVNFWC4KCnJrX3NlbGVjdF9wY3MoKSByZXR1cm5z IHRoZSBYUENTIGZvciBhbnkgaW50ZXJmYWNlLiBUaGF0IG1ha2VzIHRoaXMKbmFycm93aW5nIHRo ZSBwYXJ0IG9mIHRoZSBwYXRjaCB0aGF0IGFjdHVhbGx5IGNoYW5nZXMgYmVoYXZpb3VyLgoKVGhl IGNvbW1pdCBtZXNzYWdlIG9ubHkgZGVzY3JpYmVzIHRoZSB4cGNzX2ZpbmRfY29tcGF0KCkgY2hh bmdlLCBhbmQKc2F5czoKCiAgdGhlIE1BQyBzaWRlIGZvcmNlcyB0aGUgcGh5IG1vZGUsIHNvIHBo eWxpbmsgZG9lcyBub3Qgbm9ybWFsbHkgcGFzcyBhbgogIGludGVyZmFjZSBvdXRzaWRlIHRoZSBt YXNrLgoKQ291bGQgdGhlIG1lc3NhZ2UgYWxzbyBkZXNjcmliZSB0aGUgY2hhbmdlIHRvIHRoZSBk d21hYy1yayBwaHlsaW5rCnN1cHBvcnRlZF9pbnRlcmZhY2VzIGFuZCBscGlfaW50ZXJmYWNlcz8K Ci0tIApTYXNoaWtvIEFJIHJldmlldyDCtyBodHRwczovL25ldGRldi1haS5ib3RzLmxpbnV4LmRl di9zYXNoaWtvLyMvcGF0Y2hzZXQvMjAyNjExMTAxNjA1NTQuOTE4NjUyLTEtY29pYXByYW50JTQw Z21haWwuY29tCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpMaW51eC1yb2NrY2hpcCBtYWlsaW5nIGxpc3QKTGludXgtcm9ja2NoaXBAbGlzdHMuaW5mcmFk ZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4 LXJvY2tjaGlwCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794542804; b=GMD1UWwYJ9OFBnUvR5SOepF01r8wRcpKd4XkkIieTTCI8lPEDCKMcZVUEeWD8uA8j5Jk Kq2U/P2XUDv390nRBuXN0dhmddQ8cg1TMc0N4hHDMIJppv0ldcnEfd1QgQffEIOZ2owtH m4zpuTDkZO6QDm6JZn50RTrzTVpGlEB5/BXFgFFIlGyZqskNfGrlAAo12aJjQHoJzgzZY oPMxVGCtPOt6+hiOLhtIwo0zqxZrodu5WWbtKw7LNWmJXu/GwDPuSU2h1Qn5HuUzZ0UWE Bt5q9+Oh2Fs6ToTM6MPETRT0jVcies7/oudfFKzLG4dxA6qeLl72XcT6knd7+S4ffOA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794542804; h=Received:DKIM-Signature:Subject:From:To:Cc:Date:Message-ID: In-Reply-To:References:X-sashiko-severity:Content-Type: Content-Transfer-Encoding:MIME-Version; bh=tuA60olfOPNvdkAZ/j00xlMiIOiP361+dfqsaehGjQU=; b=pmZs5fo0G0VLW9RsroaI0MO5rwTPGP72EaR0OCnqCrx53gnCQ/NpLecP3Ie1Cz/FS/js I0G9sTLrlb810EXgn6q64bILw1iMRsjNCF4zd2Ycj5am286NcKZFeRLsvSoiMGv6AAW7T YkheB8pETnK3ltOAq2xkImbDb/gqW6efY6Q8NkHv3haB31Mp1lTo5VxfphZ+B8yd+k5HC 5fRwrlvf5+JILk1VxjKpuuhrvErazZFKZj3HMBa2oydaRepWWz6g9INYs3DREjgwqUQWd IQTOajt8oXhSA0Co6ipA2bMHMxif3DDBqt9MrpvONtXzNWLl1Jdu7uN4h8CaZ3CXfBw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=EQtFcJ4B; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9A9D3606A31C; Fri, 13 Nov 2026 04:06:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=EQtFcJ4B Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3A3101F000C4; Fri, 13 Nov 2026 04:06:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794542804; bh=tuA60olfOPNvdkAZ/j00xlMiIOiP361+dfqsaehGjQU=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=EQtFcJ4BNe2SbOwbVspWNP8nzBg2I1LK4KPzLE86/Oo4ST9cUm/rh6Y2WwU2MJ8mw A5PwkmP7v97L6m1rp0BydeG0TZ5cOafUO2FtcfxiIvQfPGhMmzWSWcugjhrOJSXaJ/ 6Zn9EUa/QujxJ21B0Dh8AP0j/CeqzXZpBPgXk7nNoE1ZbLQvcec8TEpmVRt1TV+v5y nSn68Z3ZBvlWdMKx3EoQdlxs1FLP3reZApzdK1VeZa9fhv9tX+qycxP1P3LHERxafI JMwAFK+Tp63qIHALdE8Uv4cxLK3h2EynuZRLEsOZd2nSJv1ljEv+UN+icl7tqO9gk7 6N+6w615OoOww== Subject: Re: [PATCH net-next v4 2/2] net: pcs: xpcs: make supported_interfaces authoritative From: netdev-bot+sashiko@kernel.org To: coiaprant@gmail.com Cc: kuba@kernel.org, pabeni@redhat.com, jiawenwu@trustnetic.com, mengyuanlou@net-swift.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@kernel.org, hkallweit1@gmail.com, linux@armlinux.org.uk, heiko@sntech.de, aleksandr.loktionov@intel.com, fabio.baltieri@gmail.com, netdev@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Date: Fri, 13 Nov 2026 04:06:42 +0000 Message-ID: <179454280276.2199510.48600645261637152@kernel.org> In-Reply-To: <20261110160554.918652-3-coiaprant@gmail.com> References: <20261110160554.918652-3-coiaprant@gmail.com> X-sashiko-severity: Medium Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Mailing-List: netdev@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Thank you for your contribution! Sashiko AI review found 3 potential issue(s) to consider. Critical: 0 · High: 0 · Medium: 1 · Low: 2 If you believe none of the issues are legitimate, please reply to each issue of Medium severity or higher and explain why the AI is wrong. If any of them are legitimate and you plan to respin, please let patchwork know by including "pw-bot: cr" as a separate line at the end of your reply (one such reply per series is enough). - [Medium] The commit message overstates what the core hunk fixes. - [Low] The commit message leaves out the behaviour change that actually matters. - [Low] xpcs_rk_create() puts PHY_INTERFACE_MODE_QSGMII into the platform mask, and its comment says "The RK3568 XPCS supports 1000BASE-X, SGMII… -- net: pcs: xpcs: make supported_interfaces authoritative This commit makes xpcs_find_compat() return NULL for any interface that is not set in pcs.supported_interfaces. It also narrows the Rockchip XPCS mask in xpcs_rk_create(). It does this by intersecting the mask with a platform mask of 1000BASE-X, SGMII and QSGMII. > However, xpcs_find_compat() only walks desc->compat[] and does not look > at pcs.supported_interfaces. If a caller ever passes an interface > outside the mask, the core would still find and configure a compat > entry for it, contradicting the mask the glue already set. This was a > known gap: the mask was written but never consulted by the core. [Severity: Medium] Does this describe the code as it was before this patch? In the core, only xpcs_create() writes pcs.supported_interfaces. It does so through xpcs_get_interfaces(), which builds the mask from the same table that xpcs_find_compat() walks: drivers/net/pcs/pcs-xpcs.c:xpcs_get_interfaces() { for (compat = xpcs->desc->compat; compat->supported; compat++) __set_bit(compat->interface, interfaces); } For every existing user, a set bit and a compat entry mean the same thing. The new test_bit() in xpcs_find_compat() therefore can't reject anything. Before this patch, xpcs_rk_create() didn't touch pcs.supported_interfaces either. So no mask had been "already set" by the glue. This same patch adds the narrowing. phylink also already checks the mask before it uses the PCS: drivers/net/phy/phylink.c:phylink_validate_mac_and_pcs() { ... if (!phy_interface_empty(pcs->supported_interfaces) && !test_bit(state->interface, pcs->supported_interfaces)) { phylink_err(pl, "MAC returned PCS which does not support %s\n", phy_modes(state->interface)); return -EINVAL; } ... } The only path that skips phylink seems to be the exported xpcs_get_an_mode(). It is called from stmmac_init_phy() with plat->phy_interface. On RK that is always SGMII, which stays in the mask. Could the commit message say that the xpcs_find_compat() change is defensive, and that the behaviour change comes from the glue narrowing the mask? > diff --git a/drivers/net/pcs/pcs-xpcs-rk.c b/drivers/net/pcs/pcs-xpcs-rk.c > index 6f0a110e32d24..b14b55dbd26cc 100644 > --- a/drivers/net/pcs/pcs-xpcs-rk.c > +++ b/drivers/net/pcs/pcs-xpcs-rk.c [ ... ] > @@ -536,6 +537,15 @@ struct dw_xpcs *xpcs_rk_create(struct device *dev, struct device_node *pcs, int > return xpcs; > } > > + /* > + * The RK3568 XPCS supports 1000BASE-X, SGMII and QSGMII. > + */ > + __set_bit(PHY_INTERFACE_MODE_1000BASEX, supported_interfaces); > + __set_bit(PHY_INTERFACE_MODE_SGMII, supported_interfaces); > + __set_bit(PHY_INTERFACE_MODE_QSGMII, supported_interfaces); [Severity: Low] Should QSGMII be in this mask? synopsys_xpcs_compat[] has no QSGMII entry. phy_interface_and() always clears this bit, so it is dead code today. The commit message says the glue "will automatically pick it up" once the core supports QSGMII. However, nothing in the RK integration seems to handle QSGMII: - pcs-xpcs-rk.c only calls phy_init() and phy_power_on() on the SerDes. It never sets a SerDes mode for each interface. - rk_gmac_probe() only installs rk_pcs_init() and rk_select_pcs() when plat_dat->phy_interface is PHY_INTERFACE_MODE_SGMII. - rk_gmac_check_ops() and rk_gmac_powerup() only accept RGMII*, RMII and SGMII. Another integration might later need a QSGMII entry in synopsys_xpcs_compat[]. In that case the bit would survive here, and stmmac_phylink_setup() would OR it into phylink's supported_interfaces for dwmac-rk. Would phylink then be able to select QSGMII, even though neither the SerDes nor the MAC glue is set up for it? > + phy_interface_and(xpcs->pcs.supported_interfaces, xpcs->pcs.supported_interfaces, > + supported_interfaces); [Severity: Low] Should the commit message mention that this narrowing changes the phylink configuration of dwmac-rk? rk_pcs_init() stores this XPCS in priv->hw->xpcs. stmmac_phylink_setup() then ORs its mask into phylink's interface masks: drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:stmmac_phylink_setup() { ... if (pcs) phy_interface_or(config->supported_interfaces, config->supported_interfaces, pcs->supported_interfaces); ... if (pcs) phy_interface_or(config->lpi_interfaces, config->lpi_interfaces, pcs->supported_interfaces); ... } The lpi_interfaces update only happens when priv->dma_cap.eee is set and STMMAC_FLAG_EEE_DISABLE is not. Before this patch, the full synopsys_xpcs_compat[] set was advertised to phylink for dwmac-rk as both supported and LPI-capable. That set is USXGMII, 10GKR, 25GBASER, XLGMII, 50GBASER, LAUI, 100GBASEP, 10GBASER, SGMII, 1000BASEX and 2500BASEX. After this patch, both masks shrink to SGMII and 1000BASEX. rk_select_pcs() returns the XPCS for any interface. That makes this narrowing the part of the patch that actually changes behaviour. The commit message only describes the xpcs_find_compat() change, and says: the MAC side forces the phy mode, so phylink does not normally pass an interface outside the mask. Could the message also describe the change to the dwmac-rk phylink supported_interfaces and lpi_interfaces? -- Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20261110160554.918652-1-coiaprant%40gmail.com