From: netdev-bot+sashiko@kernel.org
To: geliang@kernel.org
Cc: mptcp@lists.linux.dev, kuba@kernel.org
Subject: Re: [PATCH mptcp-next v27 8/8] mptcp: defer read_sock cleanup to mptcp_worker
Date: Mon, 16 Nov 2026 03:44:29 +0000 [thread overview]
Message-ID: <179480066912.3133.3494569668430304143@kernel.org> (raw)
In-Reply-To: <452510b9a13bce34222d39b12b6ca78bfe211e36.1794663678.git.tanggeliang@kylinos.cn>
Thank you for your contribution! Sashiko AI review found more severe
issue(s) in other patches of this series. This mail is only an FYI, in case
you want to address the nit picks below when you respin.
Low priority / nit picks for your consideration:
- [Low] The commit's author identity has no matching Signed-off-by.
--
mptcp: defer read_sock cleanup to mptcp_worker
This patch gets __mptcp_read_sock() ready to be called from BH context
for future MPTCP TLS support. When the caller does not own the socket
lock, mptcp_rcv_space_adjust() and mptcp_cleanup_rbuf() are deferred to
mptcp_worker() through msk->read_copied and MPTCP_WORK_READ_COMPLETE.
The backlog flush in mptcp_recv_skb() now runs only when
sock_owned_by_user() is true.
> Author: Geliang Tang <geliang@kernel.org>
[ ... ]
> Suggested-by: Paolo Abeni <pabeni@redhat.com>
> Signed-off-by: Geliang Tang <tanggeliang@kylinos.cn>
[Severity: Low]
This isn't a bug, but the author and sign-off emails don't match. The
author is Geliang Tang <geliang@kernel.org>, and the only
Signed-off-by is Geliang Tang <tanggeliang@kylinos.cn>.
checkpatch.pl reports this as a FROM_SIGN_OFF_MISMATCH warning
("From:/Signed-off-by: email address mismatch").
Could the author be changed to tanggeliang@kylinos.cn, or could a
Signed-off-by for geliang@kernel.org be added?
--
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/cover.1794663678.git.tanggeliang%40kylinos.cn
next prev parent reply other threads:[~2026-11-16 3:44 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-14 14:00 [PATCH mptcp-next v27 0/8] Reduce the differences between TCP and MPTCP for TLS usage Geliang Tang
2026-11-14 14:00 ` [PATCH mptcp-next v27 1/8] mptcp: fix TFO SIOCINQ overflow in mptcp_inq_hint Geliang Tang
2026-11-16 3:44 ` netdev-bot+sashiko
2026-11-14 14:00 ` [PATCH mptcp-next v27 2/8] selftests: mptcp: connect: check TFO SIOCINQ overflow Geliang Tang
2026-11-16 3:44 ` netdev-bot+sashiko
2026-11-14 14:00 ` [PATCH mptcp-next v27 3/8] mptcp: fix fallback dummy mapping anchor Geliang Tang
2026-11-14 14:01 ` [PATCH mptcp-next v27 4/8] mptcp: drop the mptcp_ooo_try_coalesce() helper Geliang Tang
2026-11-14 14:01 ` [PATCH mptcp-next v27 5/8] mptcp: drop the cant_coalesce CB field Geliang Tang
2026-11-16 3:44 ` netdev-bot+sashiko
2026-11-14 14:01 ` [PATCH mptcp-next v27 6/8] mptcp: remove CB offset field Geliang Tang
2026-11-14 14:29 ` sashiko-bot
2026-11-16 3:44 ` netdev-bot+sashiko
2026-11-14 14:01 ` [PATCH mptcp-next v27 7/8] mptcp: sync mptcp skb cb layout with tcp one Geliang Tang
2026-11-14 14:41 ` sashiko-bot
2026-11-16 3:44 ` netdev-bot+sashiko
2026-11-14 14:01 ` [PATCH mptcp-next v27 8/8] mptcp: defer read_sock cleanup to mptcp_worker Geliang Tang
2026-11-16 3:44 ` netdev-bot+sashiko [this message]
2026-11-14 15:52 ` [PATCH mptcp-next v27 0/8] Reduce the differences between TCP and MPTCP for TLS usage MPTCP CI
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179480066912.3133.3494569668430304143@kernel.org \
--to=netdev-bot+sashiko@kernel.org \
--cc=geliang@kernel.org \
--cc=kuba@kernel.org \
--cc=mptcp@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.