From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794857047; b=1wEG/Azd+OubK9QjBmCEEtYXBVOqBBHs5VMrYaVp5Yhr6+MRDgbXoB8wzc4N1b+2NAFL 3OV4Iy/llX/GQHUiuqPr9St767b+BvY4XFPMyCAhOtd3UyD9TkLM6I/EjCIsvOEBUf6tq 5LszBJVzVWCXgbv+A/v1c5lbCXjvoVxd7xR+P/3WqU5nQDi6IKhPcVpgh1XwtVzNQjbzv aDvqn1Ao6sVg3z9EOfyMcmK3yt6VXjUqDb0MEh1aiNDo8cqtkEfTx28fAgM+wutz5VJLy cSYVqNI/Oo0GcPSs3ir8fegE0JOaeVInT6jBVRFVtesg1c3pBRWubDPlcv6cxOdbhYg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794857047; h=Received:DKIM-Signature:Subject:From:To:Cc:Date:Message-ID: In-Reply-To:References:X-sashiko-severity:Content-Type: Content-Transfer-Encoding:MIME-Version; bh=B/UNoClSHX853aynsyAH0lzmqdVObyKe2mic7O4QnJA=; b=X4NpeBDgWJsb47Gw/PbBtRKvZZm3FbGK6umxCJVFawShzAj3WMlxcNVcLv020LU8kQCL 9Y8c9vEseLLEA38DXCCkH1/PNjcCOSJx4D9rkFraSHW4DiVTXqTAVN799DOlK6FzRMG+t Pfzs9Xb9BU0ExOVntWyfD5S66iRgP3DuQXD5vxb+QWc9epCryEtPO8RTN6U3SNBDNoW9O zpJae+TC0AWsUK1HP+TJnR/1gDU38GJkrmFOmJqUFqgvc2eCNLUReBG9qWHaX5UCc4sUG Iz6uY9V8w2HhwLvbOCcwxIsYDI2DlPOYVcPglNK9jqC6gWa7KoDO3SV64BmXepuHm9w== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=d0HnLTg4; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 90081606A31C; Mon, 16 Nov 2026 19:24:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=d0HnLTg4 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4A2581F000C4; Mon, 16 Nov 2026 19:24:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794857047; bh=B/UNoClSHX853aynsyAH0lzmqdVObyKe2mic7O4QnJA=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=d0HnLTg4UYS+02ZceRAq1SAzNv9teK0zSpw1hF4LeP1EhlGqen++8v6PBXbecHSFw 3tfT/JdKK2HfqN943WW7ERohLvHPz2k35pwbnEyR6oJa0XdSaa4A95ob9ukCjNnEIJ x1F1WPV4mN91DUB0iw+d5HLKxZZCkOPCvfayhB96LAPrDkFrgZLplx8yVsmU1UuDSx SBWZVN0zkFHNKTLqn89qNTrKHtsdj6TXWpaw8p867+kv6M3VwJ3bPv27WPjGtmLK7O OaZVOSiP2QLdEg8SgaSladmfoIDBPbfWP7FLasxyAJ884pZBY+4x7u/NXBbere48+K gBOugeETJ/5QQ== Subject: Re: [PATCH net] net: mdio: mux-meson-g12a: keep the MAC data path when switching MDIO From: netdev-bot+sashiko@kernel.org To: iav@iav.lv Cc: andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net, edumazet@kernel.org, kuba@kernel.org, pabeni@redhat.com, neil.armstrong@linaro.org, khilman@baylibre.com, jbrunet@baylibre.com, martin.blumenstingl@googlemail.com, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org Date: Mon, 16 Nov 2026 19:24:05 +0000 Message-ID: <179485704584.3136.17355463997361048256@kernel.org> In-Reply-To: <20261115-g12a-mux-data-path-v1-1-011dad738698@iav.lv> References: <20261115-g12a-mux-data-path-v1-1-011dad738698@iav.lv> X-sashiko-severity: Medium Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Mailing-List: netdev@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider. Critical: 0 · High: 0 · Medium: 1 · Low: 0 If you believe none of the issues are legitimate, please reply to each issue of Medium severity or higher and explain why the AI is wrong. If any of them are legitimate and you plan to respin, please let patchwork know by including "pw-bot: cr" as a separate line at the end of your reply (one such reply per series is enough). - [Medium] The patch only sets the internal-PHY data-path bits when it finds the internal PHY through the MAC's "phy-handle" property. -- net: mdio: mux-meson-g12a: keep the MAC data path when switching MDIO With this change, switching to the internal MDIO bus no longer sets USE_INTERNAL and RX_CLK_EPHY in ETH_PHY_CNTL2 unconditionally. Those two bits route the MAC data path and RX clock to the internal PHY. They are now set only when the MAC's phy-handle points at a PHY on the internal mux bus. The aim is to stop external-PHY boards from losing RX after suspend/resume, when phylib touches the unattached internal PHY. > diff --git a/drivers/net/mdio/mdio-mux-meson-g12a.c b/drivers/net/mdio/mdio-mux-meson-g12a.c > index 71c44385489d4..ed688d48eaf08 100644 > --- a/drivers/net/mdio/mdio-mux-meson-g12a.c > +++ b/drivers/net/mdio/mdio-mux-meson-g12a.c [ ... ] > @@ -169,10 +171,11 @@ static int g12a_enable_internal_mdio(struct g12a_mdio_mux *priv) > PHY_CNTL1_CLK_EN | > PHY_CNTL1_CLKFREQ; > writel(value, priv->regs + ETH_PHY_CNTL1); > - writel(PHY_CNTL2_USE_INTERNAL | > - PHY_CNTL2_SMI_SRC_MAC | > - PHY_CNTL2_RX_CLK_EPHY, > - priv->regs + ETH_PHY_CNTL2); > + > + cntl2 = PHY_CNTL2_SMI_SRC_MAC; > + if (priv->mac_uses_internal_phy) > + cntl2 |= PHY_CNTL2_USE_INTERNAL | PHY_CNTL2_RX_CLK_EPHY; > + writel(cntl2, priv->regs + ETH_PHY_CNTL2); [ ... ] > @@ -301,6 +304,41 @@ static int g12a_ephy_glue_clk_register(struct device *dev) > return 0; > } > > +/* Like dwmac-rk: the PHY named by the MAC's phy-handle decides the data path */ > +static bool g12a_mac_uses_internal_phy(struct device_node *mux_np) > +{ > + struct device_node *parent_bus, *mac, *phy, *phy_bus, *mux; > + bool internal = false; > + u32 reg; > + > + parent_bus = of_parse_phandle(mux_np, "mdio-parent-bus", 0); > + if (!parent_bus) > + return false; > + > + mac = of_get_parent(parent_bus); > + of_node_put(parent_bus); > + if (!mac) > + return false; > + > + phy = of_parse_phandle(mac, "phy-handle", 0); [Severity: Medium] Can this check pick a different PHY from the one stmmac actually attaches? Only "phy-handle" is read here. stmmac_init_phy() and phylink_fwnode_phy_connect() find the PHY through fwnode_get_phy_node(). On DT, that function also falls back to the legacy "phy" and "phy-device" properties: drivers/net/phy/phy_device.c:fwnode_get_phy_node() { ... phy_node = fwnode_find_reference(fwnode, "phy-handle", 0); if (!IS_ERR(phy_node) || is_acpi_node(fwnode)) return phy_node; phy_node = fwnode_find_reference(fwnode, "phy", 0); if (!IS_ERR(phy_node)) return phy_node; return fwnode_find_reference(fwnode, "phy-device", 0); } ethernet-controller.yaml still lists both names as deprecated aliases of phy-handle. Take a DT such as: ðmac { phy = <&internal_ephy>; phy-mode = "rmii"; }; Before this patch, stmmac attached internal_ephy, and every switch to the internal bus wrote USE_INTERNAL | SMI_SRC_MAC | RX_CLK_EPHY. After this patch, g12a_mdio_mux_probe() sets mac_uses_internal_phy to false. stmmac still attaches the EPHY over MDIO, but g12a_enable_internal_mdio() writes only SMI_SRC_MAC. The MAC data path and RX clock then stay on the external pins. Would RX on such a board stop working, even though the link can come up? Every in-tree internal-PHY DT (sei510, u200, fbx8am, sei610, sm1-a95xf3-air, sm1-x96-air, s4-aq222, s4-vim1s, c3 boards) appears to use phy-handle. So this would only hit out-of-tree or bootloader-supplied DTs that use the deprecated names. The comment refers to dwmac-rk. dwmac-rk has read only phy-handle from the start, though, so it never broke a working setup. Here a setup that used to work would break. Would fwnode_get_phy_node(of_fwnode_handle(mac)), or the same three-property fallback, keep the mux in step with the PHY stmmac attaches? > + of_node_put(mac); > + if (!phy) > + return false; [ ... ] > @@ -313,6 +351,7 @@ static int g12a_mdio_mux_probe(struct platform_device *pdev) > return -ENOMEM; > > platform_set_drvdata(pdev, priv); > + priv->mac_uses_internal_phy = g12a_mac_uses_internal_phy(dev->of_node); > > priv->regs = devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(priv->regs)) -- Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20261115-g12a-mux-data-path-v1-1-011dad738698%40iav.lv From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 24504606A31C for ; Mon, 16 Nov 2026 19:24:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=EJFwjKSh; dkim=fail reason="signature verification failed" (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=d0HnLTg4 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Cc:To:From:Subject:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=ujdU834mojZvWpSFeiTF51NwC6nYCdOxtKrk7cuWsI4=; b=EJFwjKShOzRm7gDlyD7xh9Tget sVj83yegccJiBWrRpwgT7G4xbf6AzjYBDTXWRZYUr3q1B5TzLzCW/NdzMkwaDQmVU8awWISJd5KsY XdfPgwwD2T6jLEkrGQsmcpuz2PV0H4+WT+Yh1AlyC8G4qks0m6Nt2B0IBarpEhMuP8Ee+ZFkvUy9g 0dL9+pOFQjdmZd4uiFZ1A6G/FlqtU0vGKwJ5hMgD4gNCkJkKl2UzBGEsdo8WwEC8iGzKGxU53Dvby m2eTP+FQgALF6YcloKVsIf9GQjZ1bjw1F1WUIJV33nOAkf/ijhqHwuF7FkdiFRN3DENTmeYL5AL/B w87OZobw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xT2JG-00000003kCQ-2A4G; Mon, 16 Nov 2026 19:24:10 +0000 Received: from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xT2JF-00000003kCF-1IDD; Mon, 16 Nov 2026 19:24:09 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 5D2496012A; Mon, 16 Nov 2026 19:24:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4A2581F000C4; Mon, 16 Nov 2026 19:24:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794857047; bh=B/UNoClSHX853aynsyAH0lzmqdVObyKe2mic7O4QnJA=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=d0HnLTg4UYS+02ZceRAq1SAzNv9teK0zSpw1hF4LeP1EhlGqen++8v6PBXbecHSFw 3tfT/JdKK2HfqN943WW7ERohLvHPz2k35pwbnEyR6oJa0XdSaa4A95ob9ukCjNnEIJ x1F1WPV4mN91DUB0iw+d5HLKxZZCkOPCvfayhB96LAPrDkFrgZLplx8yVsmU1UuDSx SBWZVN0zkFHNKTLqn89qNTrKHtsdj6TXWpaw8p867+kv6M3VwJ3bPv27WPjGtmLK7O OaZVOSiP2QLdEg8SgaSladmfoIDBPbfWP7FLasxyAJ884pZBY+4x7u/NXBbere48+K gBOugeETJ/5QQ== Subject: Re: [PATCH net] net: mdio: mux-meson-g12a: keep the MAC data path when switching MDIO From: netdev-bot+sashiko@kernel.org To: iav@iav.lv Cc: andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net, edumazet@kernel.org, kuba@kernel.org, pabeni@redhat.com, neil.armstrong@linaro.org, khilman@baylibre.com, jbrunet@baylibre.com, martin.blumenstingl@googlemail.com, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org Date: Mon, 16 Nov 2026 19:24:05 +0000 Message-ID: <179485704584.3136.17355463997361048256@kernel.org> In-Reply-To: <20261115-g12a-mux-data-path-v1-1-011dad738698@iav.lv> References: <20261115-g12a-mux-data-path-v1-1-011dad738698@iav.lv> X-sashiko-severity: Medium X-Archived-By: MIME-Version: 1.0 X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-amlogic" X-Spam-Status: No, score=-8.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MSBwb3RlbnRpYWwKaXNzdWUocykgdG8gY29uc2lkZXIuCgpDcml0aWNhbDogMCDCtyBIaWdoOiAw IMK3IE1lZGl1bTogMSDCtyBMb3c6IDAKCklmIHlvdSBiZWxpZXZlIG5vbmUgb2YgdGhlIGlzc3Vl cyBhcmUgbGVnaXRpbWF0ZSwgcGxlYXNlIHJlcGx5IHRvIGVhY2gKaXNzdWUgb2YgTWVkaXVtIHNl dmVyaXR5IG9yIGhpZ2hlciBhbmQgZXhwbGFpbiB3aHkgdGhlIEFJIGlzIHdyb25nLgpJZiBhbnkg b2YgdGhlbSBhcmUgbGVnaXRpbWF0ZSBhbmQgeW91IHBsYW4gdG8gcmVzcGluLCBwbGVhc2UgbGV0 IHBhdGNod29yawprbm93IGJ5IGluY2x1ZGluZyAicHctYm90OiBjciIgYXMgYSBzZXBhcmF0ZSBs aW5lIGF0IHRoZSBlbmQgb2YgeW91ciByZXBseQoob25lIHN1Y2ggcmVwbHkgcGVyIHNlcmllcyBp cyBlbm91Z2gpLgoKLSBbTWVkaXVtXSBUaGUgcGF0Y2ggb25seSBzZXRzIHRoZSBpbnRlcm5hbC1Q SFkgZGF0YS1wYXRoIGJpdHMgd2hlbiBpdAogIGZpbmRzIHRoZSBpbnRlcm5hbCBQSFkgdGhyb3Vn aCB0aGUgTUFDJ3MgInBoeS1oYW5kbGUiIHByb3BlcnR5LgoKLS0KCm5ldDogbWRpbzogbXV4LW1l c29uLWcxMmE6IGtlZXAgdGhlIE1BQyBkYXRhIHBhdGggd2hlbiBzd2l0Y2hpbmcgTURJTwoKV2l0 aCB0aGlzIGNoYW5nZSwgc3dpdGNoaW5nIHRvIHRoZSBpbnRlcm5hbCBNRElPIGJ1cyBubyBsb25n ZXIgc2V0cwpVU0VfSU5URVJOQUwgYW5kIFJYX0NMS19FUEhZIGluIEVUSF9QSFlfQ05UTDIgdW5j b25kaXRpb25hbGx5LiBUaG9zZSB0d28KYml0cyByb3V0ZSB0aGUgTUFDIGRhdGEgcGF0aCBhbmQg UlggY2xvY2sgdG8gdGhlIGludGVybmFsIFBIWS4gVGhleSBhcmUKbm93IHNldCBvbmx5IHdoZW4g dGhlIE1BQydzIHBoeS1oYW5kbGUgcG9pbnRzIGF0IGEgUEhZIG9uIHRoZSBpbnRlcm5hbAptdXgg YnVzLiBUaGUgYWltIGlzIHRvIHN0b3AgZXh0ZXJuYWwtUEhZIGJvYXJkcyBmcm9tIGxvc2luZyBS WCBhZnRlcgpzdXNwZW5kL3Jlc3VtZSwgd2hlbiBwaHlsaWIgdG91Y2hlcyB0aGUgdW5hdHRhY2hl ZCBpbnRlcm5hbCBQSFkuCgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL25ldC9tZGlvL21kaW8tbXV4 LW1lc29uLWcxMmEuYyBiL2RyaXZlcnMvbmV0L21kaW8vbWRpby1tdXgtbWVzb24tZzEyYS5jCj4g aW5kZXggNzFjNDQzODU0ODlkNC4uZWQ2ODhkNDhlYWYwOCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJz L25ldC9tZGlvL21kaW8tbXV4LW1lc29uLWcxMmEuYwo+ICsrKyBiL2RyaXZlcnMvbmV0L21kaW8v bWRpby1tdXgtbWVzb24tZzEyYS5jCgpbIC4uLiBdCgo+IEBAIC0xNjksMTAgKzE3MSwxMSBAQCBz dGF0aWMgaW50IGcxMmFfZW5hYmxlX2ludGVybmFsX21kaW8oc3RydWN0IGcxMmFfbWRpb19tdXgg KnByaXYpCj4gIAkJUEhZX0NOVEwxX0NMS19FTiB8Cj4gIAkJUEhZX0NOVEwxX0NMS0ZSRVE7Cj4g IAl3cml0ZWwodmFsdWUsIHByaXYtPnJlZ3MgKyBFVEhfUEhZX0NOVEwxKTsKPiAtCXdyaXRlbChQ SFlfQ05UTDJfVVNFX0lOVEVSTkFMIHwKPiAtCSAgICAgICBQSFlfQ05UTDJfU01JX1NSQ19NQUMg fAo+IC0JICAgICAgIFBIWV9DTlRMMl9SWF9DTEtfRVBIWSwKPiAtCSAgICAgICBwcml2LT5yZWdz ICsgRVRIX1BIWV9DTlRMMik7Cj4gKwo+ICsJY250bDIgPSBQSFlfQ05UTDJfU01JX1NSQ19NQUM7 Cj4gKwlpZiAocHJpdi0+bWFjX3VzZXNfaW50ZXJuYWxfcGh5KQo+ICsJCWNudGwyIHw9IFBIWV9D TlRMMl9VU0VfSU5URVJOQUwgfCBQSFlfQ05UTDJfUlhfQ0xLX0VQSFk7Cj4gKwl3cml0ZWwoY250 bDIsIHByaXYtPnJlZ3MgKyBFVEhfUEhZX0NOVEwyKTsKClsgLi4uIF0KCj4gQEAgLTMwMSw2ICsz MDQsNDEgQEAgc3RhdGljIGludCBnMTJhX2VwaHlfZ2x1ZV9jbGtfcmVnaXN0ZXIoc3RydWN0IGRl dmljZSAqZGV2KQo+ICAJcmV0dXJuIDA7Cj4gIH0KPiAgCj4gKy8qIExpa2UgZHdtYWMtcms6IHRo ZSBQSFkgbmFtZWQgYnkgdGhlIE1BQydzIHBoeS1oYW5kbGUgZGVjaWRlcyB0aGUgZGF0YSBwYXRo ICovCj4gK3N0YXRpYyBib29sIGcxMmFfbWFjX3VzZXNfaW50ZXJuYWxfcGh5KHN0cnVjdCBkZXZp Y2Vfbm9kZSAqbXV4X25wKQo+ICt7Cj4gKwlzdHJ1Y3QgZGV2aWNlX25vZGUgKnBhcmVudF9idXMs ICptYWMsICpwaHksICpwaHlfYnVzLCAqbXV4Owo+ICsJYm9vbCBpbnRlcm5hbCA9IGZhbHNlOwo+ ICsJdTMyIHJlZzsKPiArCj4gKwlwYXJlbnRfYnVzID0gb2ZfcGFyc2VfcGhhbmRsZShtdXhfbnAs ICJtZGlvLXBhcmVudC1idXMiLCAwKTsKPiArCWlmICghcGFyZW50X2J1cykKPiArCQlyZXR1cm4g ZmFsc2U7Cj4gKwo+ICsJbWFjID0gb2ZfZ2V0X3BhcmVudChwYXJlbnRfYnVzKTsKPiArCW9mX25v ZGVfcHV0KHBhcmVudF9idXMpOwo+ICsJaWYgKCFtYWMpCj4gKwkJcmV0dXJuIGZhbHNlOwo+ICsK PiArCXBoeSA9IG9mX3BhcnNlX3BoYW5kbGUobWFjLCAicGh5LWhhbmRsZSIsIDApOwoKW1NldmVy aXR5OiBNZWRpdW1dCkNhbiB0aGlzIGNoZWNrIHBpY2sgYSBkaWZmZXJlbnQgUEhZIGZyb20gdGhl IG9uZSBzdG1tYWMgYWN0dWFsbHkKYXR0YWNoZXM/CgpPbmx5ICJwaHktaGFuZGxlIiBpcyByZWFk IGhlcmUuIHN0bW1hY19pbml0X3BoeSgpIGFuZApwaHlsaW5rX2Z3bm9kZV9waHlfY29ubmVjdCgp IGZpbmQgdGhlIFBIWSB0aHJvdWdoIGZ3bm9kZV9nZXRfcGh5X25vZGUoKS4KT24gRFQsIHRoYXQg ZnVuY3Rpb24gYWxzbyBmYWxscyBiYWNrIHRvIHRoZSBsZWdhY3kgInBoeSIgYW5kCiJwaHktZGV2 aWNlIiBwcm9wZXJ0aWVzOgoKZHJpdmVycy9uZXQvcGh5L3BoeV9kZXZpY2UuYzpmd25vZGVfZ2V0 X3BoeV9ub2RlKCkgewoJLi4uCglwaHlfbm9kZSA9IGZ3bm9kZV9maW5kX3JlZmVyZW5jZShmd25v ZGUsICJwaHktaGFuZGxlIiwgMCk7CglpZiAoIUlTX0VSUihwaHlfbm9kZSkgfHwgaXNfYWNwaV9u b2RlKGZ3bm9kZSkpCgkJcmV0dXJuIHBoeV9ub2RlOwoJcGh5X25vZGUgPSBmd25vZGVfZmluZF9y ZWZlcmVuY2UoZndub2RlLCAicGh5IiwgMCk7CglpZiAoIUlTX0VSUihwaHlfbm9kZSkpCgkJcmV0 dXJuIHBoeV9ub2RlOwoJcmV0dXJuIGZ3bm9kZV9maW5kX3JlZmVyZW5jZShmd25vZGUsICJwaHkt ZGV2aWNlIiwgMCk7Cn0KCmV0aGVybmV0LWNvbnRyb2xsZXIueWFtbCBzdGlsbCBsaXN0cyBib3Ro IG5hbWVzIGFzIGRlcHJlY2F0ZWQgYWxpYXNlcyBvZgpwaHktaGFuZGxlLgoKVGFrZSBhIERUIHN1 Y2ggYXM6CgogICZldGhtYWMgeyBwaHkgPSA8JmludGVybmFsX2VwaHk+OyBwaHktbW9kZSA9ICJy bWlpIjsgfTsKCkJlZm9yZSB0aGlzIHBhdGNoLCBzdG1tYWMgYXR0YWNoZWQgaW50ZXJuYWxfZXBo eSwgYW5kIGV2ZXJ5IHN3aXRjaCB0byB0aGUKaW50ZXJuYWwgYnVzIHdyb3RlIFVTRV9JTlRFUk5B TCB8IFNNSV9TUkNfTUFDIHwgUlhfQ0xLX0VQSFkuCgpBZnRlciB0aGlzIHBhdGNoLCBnMTJhX21k aW9fbXV4X3Byb2JlKCkgc2V0cyBtYWNfdXNlc19pbnRlcm5hbF9waHkgdG8KZmFsc2UuIHN0bW1h YyBzdGlsbCBhdHRhY2hlcyB0aGUgRVBIWSBvdmVyIE1ESU8sIGJ1dApnMTJhX2VuYWJsZV9pbnRl cm5hbF9tZGlvKCkgd3JpdGVzIG9ubHkgU01JX1NSQ19NQUMuIFRoZSBNQUMgZGF0YSBwYXRoCmFu ZCBSWCBjbG9jayB0aGVuIHN0YXkgb24gdGhlIGV4dGVybmFsIHBpbnMuIFdvdWxkIFJYIG9uIHN1 Y2ggYSBib2FyZApzdG9wIHdvcmtpbmcsIGV2ZW4gdGhvdWdoIHRoZSBsaW5rIGNhbiBjb21lIHVw PwoKRXZlcnkgaW4tdHJlZSBpbnRlcm5hbC1QSFkgRFQgKHNlaTUxMCwgdTIwMCwgZmJ4OGFtLCBz ZWk2MTAsCnNtMS1hOTV4ZjMtYWlyLCBzbTEteDk2LWFpciwgczQtYXEyMjIsIHM0LXZpbTFzLCBj MyBib2FyZHMpIGFwcGVhcnMgdG8KdXNlIHBoeS1oYW5kbGUuIFNvIHRoaXMgd291bGQgb25seSBo aXQgb3V0LW9mLXRyZWUgb3IKYm9vdGxvYWRlci1zdXBwbGllZCBEVHMgdGhhdCB1c2UgdGhlIGRl cHJlY2F0ZWQgbmFtZXMuCgpUaGUgY29tbWVudCByZWZlcnMgdG8gZHdtYWMtcmsuIGR3bWFjLXJr IGhhcyByZWFkIG9ubHkgcGh5LWhhbmRsZSBmcm9tCnRoZSBzdGFydCwgdGhvdWdoLCBzbyBpdCBu ZXZlciBicm9rZSBhIHdvcmtpbmcgc2V0dXAuIEhlcmUgYSBzZXR1cCB0aGF0CnVzZWQgdG8gd29y ayB3b3VsZCBicmVhay4KCldvdWxkIGZ3bm9kZV9nZXRfcGh5X25vZGUob2ZfZndub2RlX2hhbmRs ZShtYWMpKSwgb3IgdGhlIHNhbWUKdGhyZWUtcHJvcGVydHkgZmFsbGJhY2ssIGtlZXAgdGhlIG11 eCBpbiBzdGVwIHdpdGggdGhlIFBIWSBzdG1tYWMKYXR0YWNoZXM/Cgo+ICsJb2Zfbm9kZV9wdXQo bWFjKTsKPiArCWlmICghcGh5KQo+ICsJCXJldHVybiBmYWxzZTsKClsgLi4uIF0KCj4gQEAgLTMx Myw2ICszNTEsNyBAQCBzdGF0aWMgaW50IGcxMmFfbWRpb19tdXhfcHJvYmUoc3RydWN0IHBsYXRm b3JtX2RldmljZSAqcGRldikKPiAgCQlyZXR1cm4gLUVOT01FTTsKPiAgCj4gIAlwbGF0Zm9ybV9z ZXRfZHJ2ZGF0YShwZGV2LCBwcml2KTsKPiArCXByaXYtPm1hY191c2VzX2ludGVybmFsX3BoeSA9 IGcxMmFfbWFjX3VzZXNfaW50ZXJuYWxfcGh5KGRldi0+b2Zfbm9kZSk7Cj4gIAo+ICAJcHJpdi0+ cmVncyA9IGRldm1fcGxhdGZvcm1faW9yZW1hcF9yZXNvdXJjZShwZGV2LCAwKTsKPiAgCWlmIChJ U19FUlIocHJpdi0+cmVncykpCgotLSAKU2FzaGlrbyBBSSByZXZpZXcgwrcgaHR0cHM6Ly9uZXRk ZXYtYWkuYm90cy5saW51eC5kZXYvc2FzaGlrby8jL3BhdGNoc2V0LzIwMjYxMTE1LWcxMmEtbXV4 LWRhdGEtcGF0aC12MS0xLTAxMWRhZDczODY5OCU0MGlhdi5sdgoKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYW1sb2dpYyBtYWlsaW5nIGxpc3QK bGludXgtYW1sb2dpY0BsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQu b3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYW1sb2dpYwo=