All of lore.kernel.org
 help / color / mirror / Atom feed
From: "WanRenyong" <wanry@yunsilicon.com>
To: "Stephen Hemminger" <stephen@networkplumber.org>
Cc: <dev@dpdk.org>, <nana@yunsilicon.com>, <qianr@yunsilicon.com>,
	 <zhangxx@yunsilicon.com>, <xudw@yunsilicon.com>
Subject: Re: [PATCH v2 0/3] net/xsc: fix issues reported by GCC analyzer
Date: Tue, 17 Nov 2026 14:39:22 +0800	[thread overview]
Message-ID: <1794897445.3@yunsilicon.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 694 bytes --]

On 2026-11-16 10:46 -0800, Stephen Hemminger wrote:
> Error: the leak is not fixed. xsc_dev_uninit() is only called from
> the probe error path in xsc_ethdev_init(), where the jumbo buffer
> can never have been allocated (rte_zmalloc'd xdev, port never
> started). The normal remove path is xsc_ethdev_uninit(), which does
> not call xsc_dev_uninit(); it frees xdev directly:
>
>         ret |= xsc_ethdev_close(eth_dev);
>         xsc_dev_pct_uninit(priv->xdev);
>         rte_free(priv->xdev);
>
> So the buffer still leaks on every device removal.

Hi Stephen,

Thanks for the review. Noted, I will send the next version of the series
shortly.

Thanks,
Renyong

[-- Attachment #2: Type: text/html, Size: 4405 bytes --]

             reply	other threads:[~2026-11-17  6:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17  6:39 WanRenyong [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-11-16  6:58 [PATCH v2 0/3] net/xsc: fix issues reported by GCC analyzer Renyong Wan
2026-11-16 18:46 ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1794897445.3@yunsilicon.com \
    --to=wanry@yunsilicon.com \
    --cc=dev@dpdk.org \
    --cc=nana@yunsilicon.com \
    --cc=qianr@yunsilicon.com \
    --cc=stephen@networkplumber.org \
    --cc=xudw@yunsilicon.com \
    --cc=zhangxx@yunsilicon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.