From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D8412606A8A0 for ; Tue, 17 Nov 2026 12:09:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=q39cQIQf; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=F8H75bw2 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version: Content-Transfer-Encoding:Content-Type:References:In-Reply-To:Message-ID:Date :Cc:To:From:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=56OkhrGtrgZLgIxtH1MefuUDKlgxUJ+RKCBMt2Ztnt4=; b=q39cQIQfekvIdaruOrWUJGrrGq ArIvWM2PC/3v88w1KppoaqZMJpknh/l5b8fcGx88gU2gEzlqw0soQu/P7d5ctHYsVOkxAbwbl5bmC 8hwznZfoT1x430SnOryj/t7rrEylNnwYGhS6kc5v5ZOgr0ldmHBPyPWQBOnGZpw4nbB//G3guKQXo O3NaXwX1jyRAjukO+masGKmHTF8hWM+p1eHFuLodhewo1x5IjQ3sQkRsZw7YxDEFfj6oyGEHHWdjz 5ACe2vGNBFr97lY77FOdYA3fRREvKRCLvEVWqgYG1ACn+aRsV9ydnhxJkk8AlQ1gmhszOAK2QM6Nq xmtWE5fg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xTHzb-00000005YZ0-1B5E; Tue, 17 Nov 2026 12:08:55 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xTHz9-00000005YO8-0Xyi; Tue, 17 Nov 2026 12:08:28 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id DB43D401CC; Tue, 17 Nov 2026 12:08:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6F7F61F000C4; Tue, 17 Nov 2026 12:08:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794917306; bh=56OkhrGtrgZLgIxtH1MefuUDKlgxUJ+RKCBMt2Ztnt4=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=F8H75bw2K23ed5fTh2YEovfZCCoE4Bwb3o10F2V8Lkznkbkz4kgHIqT9BNxdJPmpN gUHPsfe7ktO3deEyB2AndUcFsN3Bz381m95/n0Wlsa86O/GWUhnQ19m0MztvkpBlnC sLvki6RVtq9NbmGNUT8ZYv6sBGUWwcacWGuQX3j+vYcZIEw1Y8pKaWcfadEvXf9vCk TUDVU+4uEgVMC+6nwJWpyheorFKIGoYcjCxjv5YqCs1suxQbD7xuAt8T89yn17o/ni bIQJfgV//tk3VQ9I1fNqmZ6gb9dS9XxiniEoyYPTR8A6XfgTqds09TqqfGqMXu9pY6 RQx9UoiISPZIA== Subject: Re: [PATCH net v6 2/4] net: phy: keep the line of a postponed PHY interrupt balanced From: netdev-bot+sashiko@kernel.org To: iav@iav.lv Cc: andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net, edumazet@kernel.org, kuba@kernel.org, pabeni@redhat.com, maxime.chevallier@bootlin.com, lukas@wunner.de, rafael.j.wysocki@intel.com, wei.fang@nxp.com, niklas.soderlund@ragnatech.se, paul@pbarker.dev, florian.fainelli@broadcom.com, opendmb@gmail.com, Thangaraj.S@microchip.com, shenwei.wang@nxp.com, Haoning.CHENG@cn.bosch.com, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Date: Tue, 17 Nov 2026 12:08:24 +0000 Message-ID: <179491730493.3136.3230057770418919660@kernel.org> In-Reply-To: <20261113-b4-phylib-mac-pm-irq-v3-v6-2-05af2503cb23@iav.lv> References: <20261113-b4-phylib-mac-pm-irq-v3-v6-2-05af2503cb23@iav.lv> X-sashiko-severity: High Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Archived-By: MIME-Version: 1.0 X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" X-Spam-Status: No, score=-10.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider. Critical: 0 · High: 1 · Medium: 1 · Low: 0 If you believe none of the issues are legitimate, please reply to each issue of Medium severity or higher and explain why the AI is wrong. If any of them are legitimate and you plan to respin, please let patchwork know by including "pw-bot: cr" as a separate line at the end of your reply (one such reply per series is enough). - [High] phy_free_interrupt() decides once, from irq_has_action() right after this PHY's free_irq(), whether irq_rerun still owns a unit of… - [Medium] On a shared line, phy_free_interrupt() (drivers/net/phy/phy.c) keeps irq_rerun set and leaves the rebalance to resume. -- net: phy: keep the line of a postponed PHY interrupt balanced With this change, only the first postponed run of phy_interrupt() disables the PHY interrupt line. phy_free_interrupt() now clears irq_rerun when free_irq() leaves the line without users. It also adds irq_pm_lock to serialize phy_free_interrupt() against the rerun after resume, and moves the postpone/rerun logic into mdio_bus_phy_suspend_irq() and mdio_bus_phy_resume_irq(). > diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c > index 9af303d60bd6b..8e03c99fce8f5 100644 > --- a/drivers/net/phy/phy.c > +++ b/drivers/net/phy/phy.c [ ... ] > @@ -1430,8 +1430,11 @@ static irqreturn_t phy_interrupt(int irq, void *phy_dat) > pm_wakeup_dev_event(parent, 0, true); > } > > - phydev->irq_rerun = true; > - disable_irq_nosync(irq); > + /* Disable the line only once: an edge can rerun the thread. */ > + if (!phydev->irq_rerun) { > + phydev->irq_rerun = true; > + disable_irq_nosync(irq); > + } > return IRQ_HANDLED; > } > > @@ -1507,7 +1510,15 @@ EXPORT_SYMBOL(phy_request_interrupt); > void phy_free_interrupt(struct phy_device *phydev) > { > phy_disable_interrupts(phydev); > + > + mutex_lock(&phydev->irq_pm_lock); > free_irq(phydev->irq, phydev); > + /* free_irq() shuts down a line left without users and the next request > + * resets its depth; mdio_bus_phy_resume_irq() enables a shared line. > + */ > + if (!irq_has_action(phydev->irq)) > + phydev->irq_rerun = false; > + mutex_unlock(&phydev->irq_pm_lock); > } [Severity: High] Can irq_rerun go stale on a shared line here? Whether to keep irq_rerun is decided once, by irq_has_action() right after this PHY's free_irq(). If another user is still on the line, irq_rerun stays true. When that remaining user frees the line later, __free_irq() shuts the line down. The next request then goes through irq_startup(), which resets desc->depth to 0. Nothing clears the first PHY's irq_rerun at that point. Take two PHYs sharing one IRQF_SHARED line behind cpsw, which sets mac_managed_pm. A later patch in this series brings those PHYs under postponing: wakeup interrupt phy_interrupt(PHY0): irq_rerun0 = true, disable_irq_nosync() depth 1 phy_interrupt(PHY1): irq_rerun1 = true, disable_irq_nosync() depth 2 cpsw_suspend()->cpsw_ndo_stop()->phy_disconnect() phy_free_interrupt(PHY0): PHY1 still on line, irq_rerun0 stays true phy_free_interrupt(PHY1): line empty, shut down, irq_rerun1 = false cpsw_resume()->cpsw_ndo_open()->phy_request_interrupt() irq_startup() resets depth to 0, irq_rerun0 still true mdio_bus_phy_resume_irq(PHY0) enable_irq() at depth 0 Wouldn't this hit the "Unbalanced enable for IRQ" warning in __enable_irq()? That is the symptom the commit message says is fixed. The new guard in phy_interrupt() also seems to make a stale irq_rerun worse. Between the line restart and the PHY's resume, a postponed level-triggered interrupt now returns IRQ_HANDLED without being serviced or masked: if (!phydev->irq_rerun) { phydev->irq_rerun = true; disable_irq_nosync(irq); } return IRQ_HANDLED; The ONESHOT unmask would then keep firing it until that PHY resumes. Before this patch, such an interrupt disabled the line again, and resume balanced it. There is also a race. irq_has_action() runs after free_irq() has dropped desc->request_mutex, and irq_pm_lock is per phydev. So a request_irq() or free_irq() by another driver on the same line can change the answer between the two calls. Would it be possible to tie irq_rerun to the lifetime of the line, rather than to a snapshot taken at free time? > EXPORT_SYMBOL(phy_free_interrupt); > > diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c > index 1791d578f4dde..573eb234dc799 100644 > --- a/drivers/net/phy/phy_device.c > +++ b/drivers/net/phy/phy_device.c > @@ -332,6 +332,38 @@ static bool mdio_bus_phy_may_suspend(struct phy_device *phydev) [ ... ] > +/* Rerun interrupts which were postponed by phy_interrupt() > + * because they occurred during the system sleep transition. > + */ > +static __maybe_unused void mdio_bus_phy_resume_irq(struct phy_device *phydev) > +{ > + WRITE_ONCE(phydev->irq_suspended, false); > + if (!phy_interrupt_is_valid(phydev)) > + return; [Severity: Medium] The new comment in phy_free_interrupt() says "mdio_bus_phy_resume_irq() enables a shared line". Is that always true? This early return comes before irq_rerun is checked. phy_request_interrupt() sets phydev->irq to PHY_POLL in two failure cases: drivers/net/phy/phy.c:phy_request_interrupt() { ... if (err) { ... phydev->irq = PHY_POLL; } else { if (phy_enable_interrupts(phydev)) { ... phy_free_interrupt(phydev); phydev->irq = PHY_POLL; } } } Suppose a postponed interrupt took a disable on a shared line. Then phy_free_interrupt() runs during the sleep window while another user stays on the line, for example from cpsw_suspend() or stmmac_reset_subtask() through phy_disconnect(). irq_rerun is still true at that point. If the reopen then fails in one of these two ways, for instance because of an MDIO error while the bus is down, phydev->irq becomes PHY_POLL. In the second case, phy_free_interrupt() again keeps irq_rerun, because the other user is still on the line. mdio_bus_phy_resume_irq() then returns here without calling enable_irq(). Since phydev->irq is never set back to the old number, can anything ever balance that disable? It looks like the other users of the shared line would stay masked for good. > + > + mutex_lock(&phydev->irq_pm_lock); > + synchronize_irq(phydev->irq); > + if (phydev->irq_rerun) { > + phydev->irq_rerun = false; > + enable_irq(phydev->irq); > + irq_wake_thread(phydev->irq, phydev); > + } > + mutex_unlock(&phydev->irq_pm_lock); > +} [ ... ] -- Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20261113-b4-phylib-mac-pm-irq-v3-v6-0-05af2503cb23%40iav.lv From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6D7A7606A32F for ; Tue, 17 Nov 2026 12:08:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=yAbLbr98; dkim=fail reason="signature verification failed" (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=F8H75bw2 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Cc:To:From:Subject:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=BYH8SKqQ4rCbjZKE5XcQxbfP8asFUMuCdSnCMiO9soc=; b=yAbLbr98hAtSvN67mOzPcXy8Gr qQRpC9jFkIu5HGZB5hJUW6SpMRNeNdnMU8E2gfhN/OQxwNDHmCOuoBFvCVfkiwCaOgscKdyqrD+zD 8VRWJj+cVc0KGe5g5vq+aEao77Syy0c5ix1Bzx+hJYecPpC8bfq0JMj2WmxGtw6Pwb7GX/7ioD2Ki UcnVu3yj014nWh5ZQwP78/xfNBDBIHeq0/7Ikl2QI0pmcf+RCYDdj4zykBhAaO+WZVQ3YRfTcE9Km /52jL9lAHBA0xmrnBgVoIrPn0lAUZM5N+b2Wb36w4A8Gb9z3mE3FInUkBdWbUzvinFsIflIEqdhBx no94LMgw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xTHzb-00000005YZi-3k8K; Tue, 17 Nov 2026 12:08:55 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xTHz9-00000005YO8-0Xyi; Tue, 17 Nov 2026 12:08:28 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id DB43D401CC; Tue, 17 Nov 2026 12:08:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6F7F61F000C4; Tue, 17 Nov 2026 12:08:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794917306; bh=56OkhrGtrgZLgIxtH1MefuUDKlgxUJ+RKCBMt2Ztnt4=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=F8H75bw2K23ed5fTh2YEovfZCCoE4Bwb3o10F2V8Lkznkbkz4kgHIqT9BNxdJPmpN gUHPsfe7ktO3deEyB2AndUcFsN3Bz381m95/n0Wlsa86O/GWUhnQ19m0MztvkpBlnC sLvki6RVtq9NbmGNUT8ZYv6sBGUWwcacWGuQX3j+vYcZIEw1Y8pKaWcfadEvXf9vCk TUDVU+4uEgVMC+6nwJWpyheorFKIGoYcjCxjv5YqCs1suxQbD7xuAt8T89yn17o/ni bIQJfgV//tk3VQ9I1fNqmZ6gb9dS9XxiniEoyYPTR8A6XfgTqds09TqqfGqMXu9pY6 RQx9UoiISPZIA== Subject: Re: [PATCH net v6 2/4] net: phy: keep the line of a postponed PHY interrupt balanced From: netdev-bot+sashiko@kernel.org To: iav@iav.lv Cc: andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net, edumazet@kernel.org, kuba@kernel.org, pabeni@redhat.com, maxime.chevallier@bootlin.com, lukas@wunner.de, rafael.j.wysocki@intel.com, wei.fang@nxp.com, niklas.soderlund@ragnatech.se, paul@pbarker.dev, florian.fainelli@broadcom.com, opendmb@gmail.com, Thangaraj.S@microchip.com, shenwei.wang@nxp.com, Haoning.CHENG@cn.bosch.com, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Date: Tue, 17 Nov 2026 12:08:24 +0000 Message-ID: <179491730493.3136.3230057770418919660@kernel.org> In-Reply-To: <20261113-b4-phylib-mac-pm-irq-v3-v6-2-05af2503cb23@iav.lv> References: <20261113-b4-phylib-mac-pm-irq-v3-v6-2-05af2503cb23@iav.lv> X-sashiko-severity: High X-Archived-By: MIME-Version: 1.0 X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" X-Spam-Status: No, score=-8.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MiBwb3RlbnRpYWwKaXNzdWUocykgdG8gY29uc2lkZXIuCgpDcml0aWNhbDogMCDCtyBIaWdoOiAx IMK3IE1lZGl1bTogMSDCtyBMb3c6IDAKCklmIHlvdSBiZWxpZXZlIG5vbmUgb2YgdGhlIGlzc3Vl cyBhcmUgbGVnaXRpbWF0ZSwgcGxlYXNlIHJlcGx5IHRvIGVhY2gKaXNzdWUgb2YgTWVkaXVtIHNl dmVyaXR5IG9yIGhpZ2hlciBhbmQgZXhwbGFpbiB3aHkgdGhlIEFJIGlzIHdyb25nLgpJZiBhbnkg b2YgdGhlbSBhcmUgbGVnaXRpbWF0ZSBhbmQgeW91IHBsYW4gdG8gcmVzcGluLCBwbGVhc2UgbGV0 IHBhdGNod29yawprbm93IGJ5IGluY2x1ZGluZyAicHctYm90OiBjciIgYXMgYSBzZXBhcmF0ZSBs aW5lIGF0IHRoZSBlbmQgb2YgeW91ciByZXBseQoob25lIHN1Y2ggcmVwbHkgcGVyIHNlcmllcyBp cyBlbm91Z2gpLgoKLSBbSGlnaF0gcGh5X2ZyZWVfaW50ZXJydXB0KCkgZGVjaWRlcyBvbmNlLCBm cm9tIGlycV9oYXNfYWN0aW9uKCkgcmlnaHQKICBhZnRlciB0aGlzIFBIWSdzIGZyZWVfaXJxKCks IHdoZXRoZXIgaXJxX3JlcnVuIHN0aWxsIG93bnMgYSB1bml0IG9m4oCmCi0gW01lZGl1bV0gT24g YSBzaGFyZWQgbGluZSwgcGh5X2ZyZWVfaW50ZXJydXB0KCkgKGRyaXZlcnMvbmV0L3BoeS9waHku YykKICBrZWVwcyBpcnFfcmVydW4gc2V0IGFuZCBsZWF2ZXMgdGhlIHJlYmFsYW5jZSB0byByZXN1 bWUuCgotLQoKbmV0OiBwaHk6IGtlZXAgdGhlIGxpbmUgb2YgYSBwb3N0cG9uZWQgUEhZIGludGVy cnVwdCBiYWxhbmNlZAoKV2l0aCB0aGlzIGNoYW5nZSwgb25seSB0aGUgZmlyc3QgcG9zdHBvbmVk IHJ1biBvZiBwaHlfaW50ZXJydXB0KCkgZGlzYWJsZXMKdGhlIFBIWSBpbnRlcnJ1cHQgbGluZS4g cGh5X2ZyZWVfaW50ZXJydXB0KCkgbm93IGNsZWFycyBpcnFfcmVydW4gd2hlbgpmcmVlX2lycSgp IGxlYXZlcyB0aGUgbGluZSB3aXRob3V0IHVzZXJzLiBJdCBhbHNvIGFkZHMgaXJxX3BtX2xvY2sg dG8Kc2VyaWFsaXplIHBoeV9mcmVlX2ludGVycnVwdCgpIGFnYWluc3QgdGhlIHJlcnVuIGFmdGVy IHJlc3VtZSwgYW5kIG1vdmVzCnRoZSBwb3N0cG9uZS9yZXJ1biBsb2dpYyBpbnRvIG1kaW9fYnVz X3BoeV9zdXNwZW5kX2lycSgpIGFuZAptZGlvX2J1c19waHlfcmVzdW1lX2lycSgpLgoKPiBkaWZm IC0tZ2l0IGEvZHJpdmVycy9uZXQvcGh5L3BoeS5jIGIvZHJpdmVycy9uZXQvcGh5L3BoeS5jCj4g aW5kZXggOWFmMzAzZDYwYmQ2Yi4uOGUwM2M5OWZjZThmNSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJz L25ldC9waHkvcGh5LmMKPiArKysgYi9kcml2ZXJzL25ldC9waHkvcGh5LmMKClsgLi4uIF0KCj4g QEAgLTE0MzAsOCArMTQzMCwxMSBAQCBzdGF0aWMgaXJxcmV0dXJuX3QgcGh5X2ludGVycnVwdChp bnQgaXJxLCB2b2lkICpwaHlfZGF0KQo+ICAJCQkJcG1fd2FrZXVwX2Rldl9ldmVudChwYXJlbnQs IDAsIHRydWUpOwo+ICAJCX0KPiAgCj4gLQkJcGh5ZGV2LT5pcnFfcmVydW4gPSB0cnVlOwo+IC0J CWRpc2FibGVfaXJxX25vc3luYyhpcnEpOwo+ICsJCS8qIERpc2FibGUgdGhlIGxpbmUgb25seSBv bmNlOiBhbiBlZGdlIGNhbiByZXJ1biB0aGUgdGhyZWFkLiAqLwo+ICsJCWlmICghcGh5ZGV2LT5p cnFfcmVydW4pIHsKPiArCQkJcGh5ZGV2LT5pcnFfcmVydW4gPSB0cnVlOwo+ICsJCQlkaXNhYmxl X2lycV9ub3N5bmMoaXJxKTsKPiArCQl9Cj4gIAkJcmV0dXJuIElSUV9IQU5ETEVEOwo+ICAJfQo+ ICAKPiBAQCAtMTUwNyw3ICsxNTEwLDE1IEBAIEVYUE9SVF9TWU1CT0wocGh5X3JlcXVlc3RfaW50 ZXJydXB0KTsKPiAgdm9pZCBwaHlfZnJlZV9pbnRlcnJ1cHQoc3RydWN0IHBoeV9kZXZpY2UgKnBo eWRldikKPiAgewo+ICAJcGh5X2Rpc2FibGVfaW50ZXJydXB0cyhwaHlkZXYpOwo+ICsKPiArCW11 dGV4X2xvY2soJnBoeWRldi0+aXJxX3BtX2xvY2spOwo+ICAJZnJlZV9pcnEocGh5ZGV2LT5pcnEs IHBoeWRldik7Cj4gKwkvKiBmcmVlX2lycSgpIHNodXRzIGRvd24gYSBsaW5lIGxlZnQgd2l0aG91 dCB1c2VycyBhbmQgdGhlIG5leHQgcmVxdWVzdAo+ICsJICogcmVzZXRzIGl0cyBkZXB0aDsgbWRp b19idXNfcGh5X3Jlc3VtZV9pcnEoKSBlbmFibGVzIGEgc2hhcmVkIGxpbmUuCj4gKwkgKi8KPiAr CWlmICghaXJxX2hhc19hY3Rpb24ocGh5ZGV2LT5pcnEpKQo+ICsJCXBoeWRldi0+aXJxX3JlcnVu ID0gZmFsc2U7Cj4gKwltdXRleF91bmxvY2soJnBoeWRldi0+aXJxX3BtX2xvY2spOwo+ICB9Cgpb U2V2ZXJpdHk6IEhpZ2hdCgpDYW4gaXJxX3JlcnVuIGdvIHN0YWxlIG9uIGEgc2hhcmVkIGxpbmUg aGVyZT8KCldoZXRoZXIgdG8ga2VlcCBpcnFfcmVydW4gaXMgZGVjaWRlZCBvbmNlLCBieSBpcnFf aGFzX2FjdGlvbigpIHJpZ2h0IGFmdGVyCnRoaXMgUEhZJ3MgZnJlZV9pcnEoKS4gSWYgYW5vdGhl ciB1c2VyIGlzIHN0aWxsIG9uIHRoZSBsaW5lLCBpcnFfcmVydW4Kc3RheXMgdHJ1ZS4KCldoZW4g dGhhdCByZW1haW5pbmcgdXNlciBmcmVlcyB0aGUgbGluZSBsYXRlciwgX19mcmVlX2lycSgpIHNo dXRzIHRoZSBsaW5lCmRvd24uIFRoZSBuZXh0IHJlcXVlc3QgdGhlbiBnb2VzIHRocm91Z2ggaXJx X3N0YXJ0dXAoKSwgd2hpY2ggcmVzZXRzCmRlc2MtPmRlcHRoIHRvIDAuIE5vdGhpbmcgY2xlYXJz IHRoZSBmaXJzdCBQSFkncyBpcnFfcmVydW4gYXQgdGhhdCBwb2ludC4KClRha2UgdHdvIFBIWXMg c2hhcmluZyBvbmUgSVJRRl9TSEFSRUQgbGluZSBiZWhpbmQgY3Bzdywgd2hpY2ggc2V0cwptYWNf bWFuYWdlZF9wbS4gQSBsYXRlciBwYXRjaCBpbiB0aGlzIHNlcmllcyBicmluZ3MgdGhvc2UgUEhZ cyB1bmRlcgpwb3N0cG9uaW5nOgoKICB3YWtldXAgaW50ZXJydXB0CiAgICBwaHlfaW50ZXJydXB0 KFBIWTApOiBpcnFfcmVydW4wID0gdHJ1ZSwgZGlzYWJsZV9pcnFfbm9zeW5jKCkgIGRlcHRoIDEK ICAgIHBoeV9pbnRlcnJ1cHQoUEhZMSk6IGlycV9yZXJ1bjEgPSB0cnVlLCBkaXNhYmxlX2lycV9u b3N5bmMoKSAgZGVwdGggMgoKICBjcHN3X3N1c3BlbmQoKS0+Y3Bzd19uZG9fc3RvcCgpLT5waHlf ZGlzY29ubmVjdCgpCiAgICBwaHlfZnJlZV9pbnRlcnJ1cHQoUEhZMCk6IFBIWTEgc3RpbGwgb24g bGluZSwgaXJxX3JlcnVuMCBzdGF5cyB0cnVlCiAgICBwaHlfZnJlZV9pbnRlcnJ1cHQoUEhZMSk6 IGxpbmUgZW1wdHksIHNodXQgZG93biwgaXJxX3JlcnVuMSA9IGZhbHNlCgogIGNwc3dfcmVzdW1l KCktPmNwc3dfbmRvX29wZW4oKS0+cGh5X3JlcXVlc3RfaW50ZXJydXB0KCkKICAgIGlycV9zdGFy dHVwKCkgcmVzZXRzIGRlcHRoIHRvIDAsIGlycV9yZXJ1bjAgc3RpbGwgdHJ1ZQoKICBtZGlvX2J1 c19waHlfcmVzdW1lX2lycShQSFkwKQogICAgZW5hYmxlX2lycSgpIGF0IGRlcHRoIDAKCldvdWxk bid0IHRoaXMgaGl0IHRoZSAiVW5iYWxhbmNlZCBlbmFibGUgZm9yIElSUSIgd2FybmluZyBpbgpf X2VuYWJsZV9pcnEoKT8gVGhhdCBpcyB0aGUgc3ltcHRvbSB0aGUgY29tbWl0IG1lc3NhZ2Ugc2F5 cyBpcyBmaXhlZC4KClRoZSBuZXcgZ3VhcmQgaW4gcGh5X2ludGVycnVwdCgpIGFsc28gc2VlbXMg dG8gbWFrZSBhIHN0YWxlIGlycV9yZXJ1bgp3b3JzZS4gQmV0d2VlbiB0aGUgbGluZSByZXN0YXJ0 IGFuZCB0aGUgUEhZJ3MgcmVzdW1lLCBhIHBvc3Rwb25lZApsZXZlbC10cmlnZ2VyZWQgaW50ZXJy dXB0IG5vdyByZXR1cm5zIElSUV9IQU5ETEVEIHdpdGhvdXQgYmVpbmcgc2VydmljZWQKb3IgbWFz a2VkOgoKCQlpZiAoIXBoeWRldi0+aXJxX3JlcnVuKSB7CgkJCXBoeWRldi0+aXJxX3JlcnVuID0g dHJ1ZTsKCQkJZGlzYWJsZV9pcnFfbm9zeW5jKGlycSk7CgkJfQoJCXJldHVybiBJUlFfSEFORExF RDsKClRoZSBPTkVTSE9UIHVubWFzayB3b3VsZCB0aGVuIGtlZXAgZmlyaW5nIGl0IHVudGlsIHRo YXQgUEhZIHJlc3VtZXMuCkJlZm9yZSB0aGlzIHBhdGNoLCBzdWNoIGFuIGludGVycnVwdCBkaXNh YmxlZCB0aGUgbGluZSBhZ2FpbiwgYW5kIHJlc3VtZQpiYWxhbmNlZCBpdC4KClRoZXJlIGlzIGFs c28gYSByYWNlLiBpcnFfaGFzX2FjdGlvbigpIHJ1bnMgYWZ0ZXIgZnJlZV9pcnEoKSBoYXMgZHJv cHBlZApkZXNjLT5yZXF1ZXN0X211dGV4LCBhbmQgaXJxX3BtX2xvY2sgaXMgcGVyIHBoeWRldi4g U28gYSByZXF1ZXN0X2lycSgpIG9yCmZyZWVfaXJxKCkgYnkgYW5vdGhlciBkcml2ZXIgb24gdGhl IHNhbWUgbGluZSBjYW4gY2hhbmdlIHRoZSBhbnN3ZXIKYmV0d2VlbiB0aGUgdHdvIGNhbGxzLgoK V291bGQgaXQgYmUgcG9zc2libGUgdG8gdGllIGlycV9yZXJ1biB0byB0aGUgbGlmZXRpbWUgb2Yg dGhlIGxpbmUsIHJhdGhlcgp0aGFuIHRvIGEgc25hcHNob3QgdGFrZW4gYXQgZnJlZSB0aW1lPwoK PiAgRVhQT1JUX1NZTUJPTChwaHlfZnJlZV9pbnRlcnJ1cHQpOwo+ICAKPiBkaWZmIC0tZ2l0IGEv ZHJpdmVycy9uZXQvcGh5L3BoeV9kZXZpY2UuYyBiL2RyaXZlcnMvbmV0L3BoeS9waHlfZGV2aWNl LmMKPiBpbmRleCAxNzkxZDU3OGY0ZGRlLi41NzNlYjIzNGRjNzk5IDEwMDY0NAo+IC0tLSBhL2Ry aXZlcnMvbmV0L3BoeS9waHlfZGV2aWNlLmMKPiArKysgYi9kcml2ZXJzL25ldC9waHkvcGh5X2Rl dmljZS5jCj4gQEAgLTMzMiw2ICszMzIsMzggQEAgc3RhdGljIGJvb2wgbWRpb19idXNfcGh5X21h eV9zdXNwZW5kKHN0cnVjdCBwaHlfZGV2aWNlICpwaHlkZXYpCgpbIC4uLiBdCgo+ICsvKiBSZXJ1 biBpbnRlcnJ1cHRzIHdoaWNoIHdlcmUgcG9zdHBvbmVkIGJ5IHBoeV9pbnRlcnJ1cHQoKQo+ICsg KiBiZWNhdXNlIHRoZXkgb2NjdXJyZWQgZHVyaW5nIHRoZSBzeXN0ZW0gc2xlZXAgdHJhbnNpdGlv bi4KPiArICovCj4gK3N0YXRpYyBfX21heWJlX3VudXNlZCB2b2lkIG1kaW9fYnVzX3BoeV9yZXN1 bWVfaXJxKHN0cnVjdCBwaHlfZGV2aWNlICpwaHlkZXYpCj4gK3sKPiArCVdSSVRFX09OQ0UocGh5 ZGV2LT5pcnFfc3VzcGVuZGVkLCBmYWxzZSk7Cj4gKwlpZiAoIXBoeV9pbnRlcnJ1cHRfaXNfdmFs aWQocGh5ZGV2KSkKPiArCQlyZXR1cm47CgpbU2V2ZXJpdHk6IE1lZGl1bV0KClRoZSBuZXcgY29t bWVudCBpbiBwaHlfZnJlZV9pbnRlcnJ1cHQoKSBzYXlzICJtZGlvX2J1c19waHlfcmVzdW1lX2ly cSgpCmVuYWJsZXMgYSBzaGFyZWQgbGluZSIuIElzIHRoYXQgYWx3YXlzIHRydWU/CgpUaGlzIGVh cmx5IHJldHVybiBjb21lcyBiZWZvcmUgaXJxX3JlcnVuIGlzIGNoZWNrZWQuCnBoeV9yZXF1ZXN0 X2ludGVycnVwdCgpIHNldHMgcGh5ZGV2LT5pcnEgdG8gUEhZX1BPTEwgaW4gdHdvIGZhaWx1cmUg Y2FzZXM6Cgpkcml2ZXJzL25ldC9waHkvcGh5LmM6cGh5X3JlcXVlc3RfaW50ZXJydXB0KCkgewoJ Li4uCglpZiAoZXJyKSB7CgkJLi4uCgkJcGh5ZGV2LT5pcnEgPSBQSFlfUE9MTDsKCX0gZWxzZSB7 CgkJaWYgKHBoeV9lbmFibGVfaW50ZXJydXB0cyhwaHlkZXYpKSB7CgkJCS4uLgoJCQlwaHlfZnJl ZV9pbnRlcnJ1cHQocGh5ZGV2KTsKCQkJcGh5ZGV2LT5pcnEgPSBQSFlfUE9MTDsKCQl9Cgl9Cn0K ClN1cHBvc2UgYSBwb3N0cG9uZWQgaW50ZXJydXB0IHRvb2sgYSBkaXNhYmxlIG9uIGEgc2hhcmVk IGxpbmUuIFRoZW4KcGh5X2ZyZWVfaW50ZXJydXB0KCkgcnVucyBkdXJpbmcgdGhlIHNsZWVwIHdp bmRvdyB3aGlsZSBhbm90aGVyIHVzZXIgc3RheXMKb24gdGhlIGxpbmUsIGZvciBleGFtcGxlIGZy b20gY3Bzd19zdXNwZW5kKCkgb3Igc3RtbWFjX3Jlc2V0X3N1YnRhc2soKQp0aHJvdWdoIHBoeV9k aXNjb25uZWN0KCkuIGlycV9yZXJ1biBpcyBzdGlsbCB0cnVlIGF0IHRoYXQgcG9pbnQuCgpJZiB0 aGUgcmVvcGVuIHRoZW4gZmFpbHMgaW4gb25lIG9mIHRoZXNlIHR3byB3YXlzLCBmb3IgaW5zdGFu Y2UgYmVjYXVzZSBvZgphbiBNRElPIGVycm9yIHdoaWxlIHRoZSBidXMgaXMgZG93biwgcGh5ZGV2 LT5pcnEgYmVjb21lcyBQSFlfUE9MTC4gSW4gdGhlCnNlY29uZCBjYXNlLCBwaHlfZnJlZV9pbnRl cnJ1cHQoKSBhZ2FpbiBrZWVwcyBpcnFfcmVydW4sIGJlY2F1c2UgdGhlIG90aGVyCnVzZXIgaXMg c3RpbGwgb24gdGhlIGxpbmUuCgptZGlvX2J1c19waHlfcmVzdW1lX2lycSgpIHRoZW4gcmV0dXJu cyBoZXJlIHdpdGhvdXQgY2FsbGluZyBlbmFibGVfaXJxKCkuClNpbmNlIHBoeWRldi0+aXJxIGlz IG5ldmVyIHNldCBiYWNrIHRvIHRoZSBvbGQgbnVtYmVyLCBjYW4gYW55dGhpbmcgZXZlcgpiYWxh bmNlIHRoYXQgZGlzYWJsZT8gSXQgbG9va3MgbGlrZSB0aGUgb3RoZXIgdXNlcnMgb2YgdGhlIHNo YXJlZCBsaW5lCndvdWxkIHN0YXkgbWFza2VkIGZvciBnb29kLgoKPiArCj4gKwltdXRleF9sb2Nr KCZwaHlkZXYtPmlycV9wbV9sb2NrKTsKPiArCXN5bmNocm9uaXplX2lycShwaHlkZXYtPmlycSk7 Cj4gKwlpZiAocGh5ZGV2LT5pcnFfcmVydW4pIHsKPiArCQlwaHlkZXYtPmlycV9yZXJ1biA9IGZh bHNlOwo+ICsJCWVuYWJsZV9pcnEocGh5ZGV2LT5pcnEpOwo+ICsJCWlycV93YWtlX3RocmVhZChw aHlkZXYtPmlycSwgcGh5ZGV2KTsKPiArCX0KPiArCW11dGV4X3VubG9jaygmcGh5ZGV2LT5pcnFf cG1fbG9jayk7Cj4gK30KClsgLi4uIF0KCi0tIApTYXNoaWtvIEFJIHJldmlldyDCtyBodHRwczov L25ldGRldi1haS5ib3RzLmxpbnV4LmRldi9zYXNoaWtvLyMvcGF0Y2hzZXQvMjAyNjExMTMtYjQt cGh5bGliLW1hYy1wbS1pcnEtdjMtdjYtMC0wNWFmMjUwM2NiMjMlNDBpYXYubHYKCl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkxpbnV4LXJvY2tjaGlwIG1h aWxpbmcgbGlzdApMaW51eC1yb2NrY2hpcEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0 cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtcm9ja2NoaXAK