From: netdev-bot+sashiko@kernel.org
To: geliang@kernel.org
Cc: mptcp@lists.linux.dev, kuba@kernel.org
Subject: Re: [PATCH mptcp-next v8 4/7] mptcp: add sendmsg_locked to proto_ops
Date: Wed, 18 Nov 2026 01:05:46 +0000 [thread overview]
Message-ID: <179496394632.3133.4263841148082085477@kernel.org> (raw)
In-Reply-To: <2d180799564c49dc62ab876fbcb358670ece3a29.1794826541.git.geliang@kernel.org>
Thank you for your contribution! Sashiko AI review found more severe
issue(s) in other patches of this series. This mail is only an FYI, in case
you want to address the nit picks below when you respin.
Low priority / nit picks for your consideration:
- [Low] The patch adds `.sendmsg_locked = mptcp_sendmsg_locked` to
`mptcp_stream_ops` and `mptcp_v6_stream_ops`, but no in-tree caller…
- [Low] The commit author is 'Geliang Tang <geliang@kernel.org>', but the
only Signed-off-by is 'Geliang Tang <tanggeliang@kylinos.cn>'.
--
mptcp: add sendmsg_locked to proto_ops
This commit splits mptcp_sendmsg() into mptcp_sendmsg_locked(), which
expects the caller to hold the msk socket lock, and a small
mptcp_sendmsg() wrapper that takes the lock. It also sets
mptcp_sendmsg_locked() as the .sendmsg_locked hook in both
mptcp_stream_ops and mptcp_v6_stream_ops.
> Signed-off-by: Geliang Tang <tanggeliang@kylinos.cn>
[Severity: Low]
This isn't a bug, but the author is Geliang Tang <geliang@kernel.org>,
while the only sign-off uses tanggeliang@kylinos.cn. checkpatch.pl reports
this as FROM_SIGN_OFF_MISMATCH.
Could a Signed-off-by for the author address be added, or the author
address be changed to match?
> diff --git a/net/mptcp/protocol.c b/net/mptcp/protocol.c
> index a0ad28f5a3851..83abdf39c4e54 100644
> --- a/net/mptcp/protocol.c
> +++ b/net/mptcp/protocol.c
[ ... ]
> @@ -4832,6 +4842,7 @@ static const struct proto_ops mptcp_stream_ops = {
> .read_sock = mptcp_read_sock,
> .splice_read = mptcp_splice_read,
> .peek_len = mptcp_peek_len,
> + .sendmsg_locked = mptcp_sendmsg_locked,
> };
[Severity: Low]
Is there an in-tree caller that can reach this hook for an MPTCP socket?
The only generic caller of proto_ops->sendmsg_locked seems to be
sendmsg_locked() in net/core/skbuff.c. It is reached only through
__skb_send_sock(), from skb_send_sock_locked() and
skb_send_sock_locked_with_flags(). Only espintcp and ovpn call those
helpers.
ovpn_socket_attach() in drivers/net/ovpn/socket.c rejects any protocol
other than UDP and TCP:
if (sock->sk->sk_protocol == IPPROTO_UDP)
return ovpn_udp_socket_attach(ovpn_sock, sock, peer->ovpn);
else if (sock->sk->sk_protocol == IPPROTO_TCP)
return ovpn_tcp_socket_attach(ovpn_sock, peer);
return -EOPNOTSUPP;
espintcp needs the TCP ULP, and mptcp_setsockopt_sol_tcp() in
net/mptcp/sockopt.c refuses it:
case TCP_ULP:
return -EOPNOTSUPP;
As the commit message itself says, kTLS and sockmap still call
tcp_sendmsg_locked() directly.
The commit message also says:
However, certain upper layers need to call the sendmsg method while
the socket lock is already held.
Which upper layer does this refer to? I could not find anything in this
patch or in the rest of the series (app-limited tracking, the
mptcp_check_readable update, selftests) that calls .sendmsg_locked on an
msk. So the new entry here, and the matching one in mptcp_v6_stream_ops,
look unused.
Could the commit message name the intended consumer? Alternatively, could
this patch be merged together with the series that adds that consumer?
[ ... ]
--
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/cover.1794826541.git.geliang%40kernel.org
next prev parent reply other threads:[~2026-11-18 1:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 10:57 [PATCH mptcp-next v8 0/7] prepare interfaces for kTLS and sockmap support Geliang Tang
2026-11-16 10:57 ` [PATCH mptcp-net v8 1/7] mptcp: fix TFO SIOCINQ overflow in mptcp_inq_hint Geliang Tang
2026-11-18 1:05 ` netdev-bot+sashiko
2026-11-16 10:57 ` [PATCH mptcp-next v8 2/7] selftests: mptcp: connect: check TFO SIOCINQ overflow Geliang Tang
2026-11-18 1:05 ` netdev-bot+sashiko
2026-11-16 10:57 ` [PATCH mptcp-next v8 3/7] mptcp: implement peek_len for proto_ops Geliang Tang
2026-11-18 1:05 ` netdev-bot+sashiko
2026-11-16 10:57 ` [PATCH mptcp-next v8 4/7] mptcp: add sendmsg_locked to proto_ops Geliang Tang
2026-11-18 1:05 ` netdev-bot+sashiko [this message]
2026-11-16 10:57 ` [PATCH mptcp-next v8 5/7] mptcp: track app-limited state in mptcp_sendmsg Geliang Tang
2026-11-18 1:05 ` netdev-bot+sashiko
2026-11-16 10:57 ` [PATCH mptcp-next v8 6/7] selftests: mptcp: sockopt: check app_limited Geliang Tang
2026-11-18 1:05 ` netdev-bot+sashiko
2026-11-16 10:57 ` [PATCH mptcp-next v8 7/7] mptcp: update mptcp_check_readable Geliang Tang
2026-11-16 13:38 ` [PATCH mptcp-next v8 0/7] prepare interfaces for kTLS and sockmap support MPTCP CI
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179496394632.3133.4263841148082085477@kernel.org \
--to=netdev-bot+sashiko@kernel.org \
--cc=geliang@kernel.org \
--cc=kuba@kernel.org \
--cc=mptcp@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.