From: netdev-bot+sashiko@kernel.org
To: james.hilliard1@gmail.com
Cc: netdev@vger.kernel.org, maxime.chevallier@bootlin.com,
andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@kernel.org,
kuba@kernel.org, pabeni@redhat.com, mcoquelin.stm32@gmail.com,
alexandre.torgue@foss.st.com, wens@kernel.org,
jernej.skrabec@gmail.com, samuel@sholland.org,
clabbe.montjoie@gmail.com, linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net: stmmac: dwmac-sun8i: Honor the RX checksum offload setting
Date: Wed, 18 Nov 2026 04:00:29 +0000 [thread overview]
Message-ID: <179497442968.3136.18415990643273213851@kernel.org> (raw)
In-Reply-To: <20261115-submit-sun8i-emac-rx-checksum-v1-v1-1-f186d127b39f@gmail.com>
Thank you for your contribution! Sashiko AI review found 2 potential
issue(s) to consider.
Critical: 0 · High: 0 · Medium: 1 · Low: 1
If you believe none of the issues are legitimate, please reply to each
issue of Medium severity or higher and explain why the AI is wrong.
If any of them are legitimate and you plan to respin, please let patchwork
know by including "pw-bot: cr" as a separate line at the end of your reply
(one such reply per series is enough).
- [Medium] Clearing EMAC_RX_DO_CRC (EMAC_RX_CTL0 bit 27) whenever
NETIF_F_RXCSUM is off may also turn off the MAC's Ethernet FCS…
- [Low] When RX checksum offload is turned back on, frames the sun8i MAC
received while EMAC_RX_DO_CRC was clear can be marked…
--
net: stmmac: dwmac-sun8i: Honor the RX checksum offload setting
Before this patch, sun8i_dwmac_rx_ipc_enable() always set
EMAC_RX_DO_CRC. With the patch, it sets or clears the bit based on
hw->rx_csum, so that turning off RX checksum offload through ethtool
also turns off the hardware checksum engine.
> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c
> index 2ece7ba9dd73b..98cc7503bddeb 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c
> @@ -705,7 +705,10 @@ static int sun8i_dwmac_rx_ipc_enable(struct mac_device_info *hw)
> u32 v;
>
> v = readl(ioaddr + EMAC_RX_CTL0);
> - v |= EMAC_RX_DO_CRC;
> + if (hw->rx_csum)
> + v |= EMAC_RX_DO_CRC;
> + else
> + v &= ~EMAC_RX_DO_CRC;
[Severity: Medium]
Does clearing bit 27 of EMAC_RX_CTL0 also turn off the MAC's Ethernet
FCS check, and not only the IP/L4 checksum engine?
The bit is named after the CRC:
#define EMAC_RX_DO_CRC BIT(27)
The probe code says the hardware features were "copied from Allwinner
drivers". That code sets this bit with the comment "Enable CRC & IPv4
Header Checksum". The Allwinner manuals describe CHECK_CRC as "Calculate
CRC and check the IPv4 Header Checksum".
On this path, sun8i does not have the hardware strip the FCS.
stmmac_rx() removes it in software without checking it:
/* ACS is disabled; strip manually. */
if (likely(!(status & rx_not_ls)))
len -= ETH_FCS_LEN;
The only FCS check left is the hardware RDES0_CRC_ERROR bit, which
ndesc_get_rx_status() turns into discard_frame.
Suppose bit 27 does control CRC calculation. After "ethtool -K ethX rx
off", the path is stmmac_set_features() -> hw->rx_csum = 0 ->
sun8i_dwmac_rx_ipc_enable(). Frames with a corrupted FCS would then no
longer set RDES0_CRC_ERROR. They would reach the stack as good frames,
with the FCS silently stripped. That behaves like NETIF_F_RXALL rather
than "RX checksum offload off".
Is there a datasheet reference or a bad-FCS test showing that bit 27
gates only the L3/L4 checksum? If the hardware ties the two checks
together, a different approach may be needed. For example, keep bit 27
set and, when rx_csum is 0, stop discarding frames whose only error is
the IP or payload checksum.
[Severity: Low]
Can frames that arrive while EMAC_RX_DO_CRC is clear be marked as
checksum-verified once RX checksum offload is turned back on?
When "ethtool -K ethX rx on" runs, stmmac_set_features() publishes the
software flag before the MMIO write that re-enables the engine:
stmmac_set_features() {
...
if (features & NETIF_F_RXCSUM)
priv->hw->rx_csum = priv->plat->rx_coe;
else
priv->hw->rx_csum = 0;
...
stmmac_rx_ipc(priv, priv->hw);
...
}
NAPI is not disabled, RX DMA is not stopped and the ring is not drained.
Meanwhile, stmmac_rx() may run on another CPU and read the flag
directly:
int coe = priv->hw->rx_csum;
...
if (unlikely(!coe) || !stmmac_has_ip_ethertype(skb) ||
(status & csum_none))
skb_checksum_none_assert(skb);
else
skb->ip_summed = CHECKSUM_UNNECESSARY;
sun8i uses normal descriptors. ndesc_get_rx_status() never returns
csum_none, so nothing in the descriptor says whether the hardware
actually checked a given frame.
Any unchecked frame still in the RX ring would then be passed up as
CHECKSUM_UNNECESSARY. That covers frames received before the writel()
in sun8i_dwmac_rx_ipc_enable() and frames received just after it.
Before this patch, the bit was never cleared, so this state could not
happen on sun8i.
Swapping the two writes would narrow the window, but it would not cover
frames already in the ring. Would RX need to be quiesced or drained
across this transition?
> writel(v, ioaddr + EMAC_RX_CTL0);
>
> return 1;
--
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20261115-submit-sun8i-emac-rx-checksum-v1-v1-1-f186d127b39f%40gmail.com
prev parent reply other threads:[~2026-11-18 4:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 0:58 [PATCH net] net: stmmac: dwmac-sun8i: Honor the RX checksum offload setting James Hilliard
2026-11-16 1:03 ` netdev-bot+sinfo
2026-11-16 2:19 ` James Hilliard
2026-11-16 2:28 ` James Hilliard
2026-11-17 15:20 ` Maxime Chevallier
2026-11-17 15:26 ` Lorenzo Bianconi
2026-11-18 4:00 ` netdev-bot+sashiko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179497442968.3136.18415990643273213851@kernel.org \
--to=netdev-bot+sashiko@kernel.org \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew+netdev@lunn.ch \
--cc=clabbe.montjoie@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=james.hilliard1@gmail.com \
--cc=jernej.skrabec@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=maxime.chevallier@bootlin.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=samuel@sholland.org \
--cc=wens@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.