From: Abdifatah Suruur <suruurism@gmail.com>
To: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
Cc: linux-rdma@vger.kernel.org, Jason Gunthorpe <jgg@nvidia.com>,
Leon Romanovsky <leonro@nvidia.com>
Subject: Re: [PATCH 2/2] IB/hfi1: reject writable SUBCTXT_EGRBUF mmap
Date: Wed, 18 Nov 2026 16:36:51 +0300 [thread overview]
Message-ID: <179500901107.1415.1266627283580496093@gmail.com> (raw)
In-Reply-To: <20261118131948.28748-2-suruurism@gmail.com>
Hello,
Please drop patch 2/2 of this series ("IB/hfi1: reject writable SUBCTXT_EGRBUF mmap").
The automated review pointed out that uctxt->subctxt_rcvegrbuf is a
vmalloc_user() buffer that userspace subcontexts sharing a hardware
context intentionally map PROT_READ|PROT_WRITE: the process polling the
hardware receive queue forwards eager packets into it. Rejecting VM_WRITE
would break subcontext initialization, and the existing VM_MAYWRITE clear
is deliberate policy. My patch was wrong; I am withdrawing it.
Patch 1/2 (STATUS VM_MAYWRITE) is unaffected and stands on its own.
Sorry for the noise,
Abdifatah Suruur
suruurism@gmail.com
next prev parent reply other threads:[~2026-11-18 13:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 13:19 [PATCH 1/2] IB/hfi1: clear VM_MAYWRITE on read-only STATUS mmap Abdifatah Suruur
2026-11-18 13:19 ` [PATCH 2/2] IB/hfi1: reject writable SUBCTXT_EGRBUF mmap Abdifatah Suruur
2026-11-18 13:35 ` sashiko-bot
2026-11-18 13:36 ` Abdifatah Suruur [this message]
2026-11-18 13:24 ` [PATCH 1/2] IB/hfi1: clear VM_MAYWRITE on read-only STATUS mmap sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179500901107.1415.1266627283580496093@gmail.com \
--to=suruurism@gmail.com \
--cc=dennis.dalessandro@cornelisnetworks.com \
--cc=jgg@nvidia.com \
--cc=leonro@nvidia.com \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.