All of lore.kernel.org
 help / color / mirror / Atom feed
From: netdev-bot+sashiko@kernel.org
To: github@szelinsky.de
Cc: o.rempel@pengutronix.de, kory.maincent@bootlin.com,
	andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@kernel.org,
	kuba@kernel.org, pabeni@redhat.com, horms@kernel.org,
	broonie@kernel.org, lgirdwood@gmail.com,
	maxime.chevallier@bootlin.com, kyle.swenson@est.tech,
	ross@r-sc.ca, netdev-bot+sashiko@kernel.org,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v5 04/14] net: pse-pd: do not keep a failed IRQ in pcdev->irq
Date: Fri, 20 Nov 2026 06:41:47 +0000	[thread overview]
Message-ID: <179515690732.3136.5656168477825917127@kernel.org> (raw)
In-Reply-To: <20261118183957.2031311-5-github@szelinsky.de>

Thank you for your contribution! Sashiko AI review found 1 potential
issue(s) to consider.

Critical: 0 · High: 0 · Medium: 1 · Low: 0

If you believe none of the issues are legitimate, please reply to each
issue of Medium severity or higher and explain why the AI is wrong.
If any of them are legitimate and you plan to respin, please let patchwork
know by including "pw-bot: cr" as a separate line at the end of your reply
(one such reply per series is enough).

- [Medium] This patch keeps pcdev->irq accurate only when the IRQ request
  fails.

--

net: pse-pd: do not keep a failed IRQ in pcdev->irq

This patch clears pcdev->irq in devm_pse_irq_helper() when
devm_request_threaded_irq() fails. Without that, the failed probe's
pse_controller_unregister() calls disable_irq() on a line the controller
does not own. pcdev->irq is now set before the request because pse_isr()
can read it as soon as the IRQ is enabled.

> diff --git a/drivers/net/pse-pd/pse_core.c b/drivers/net/pse-pd/pse_core.c
> index 0cce17670d0b9..0894613515e0d 100644
> --- a/drivers/net/pse-pd/pse_core.c
> +++ b/drivers/net/pse-pd/pse_core.c
> @@ -1341,14 +1341,20 @@ int devm_pse_irq_helper(struct pse_controller_dev *pcdev, int irq,
>  	if (!h->notifs_mask)
>  		return -ENOMEM;
>  
> +	/* pse_isr() can run as soon as the IRQ is enabled, and
> +	 * pse_pw_d_is_sw_pw_control() reads pcdev->irq.
> +	 */
> +	pcdev->irq = irq;
>  	ret = devm_request_threaded_irq(dev, irq, NULL, pse_isr,
>  					IRQF_ONESHOT | irq_flags,
>  					irq_name, h);
> -	if (ret)
> +	if (ret) {
> +		pcdev->irq = 0;
>  		dev_err(pcdev->dev, "Failed to request IRQ %d\n", irq);
> +		return ret;
> +	}

[Severity: Medium]
This covers the failed request. Can pcdev->irq still go stale on a normal
unbind?

The only caller of devm_pse_irq_helper() is tps23881. It registers the
controller devres first and requests the IRQ after that:

drivers/net/pse-pd/tps23881.c:tps23881_i2c_probe() {
    ...
	ret = devm_pse_controller_register(dev, &priv->pcdev);
    ...
	return tps23881_setup_irq(priv, client->irq);
}

tps23881_setup_irq() then calls devm_pse_irq_helper(). Devres releases in
LIFO order, so on unbind or rmmod the teardown runs:

devres_release_all()
  devm_irq_release()
    free_irq()
  devm_pse_controller_release()
    pse_controller_unregister()

By that point pse_controller_unregister() no longer owns the line, but it
still does:

	if (pcdev->irq)
		disable_irq(pcdev->irq);

This is the same problem the commit message describes, except that the
stale pcdev->irq comes from devres teardown and not from a failed request.

Suppose another device requests the same line between free_irq() and
disable_irq(). __setup_irq() resets the depth to 0, and this disable_irq()
then leaves the line masked for that device, with no matching
enable_irq().

A future caller passing IRQF_SHARED through the exported irq_flags
argument would hit this on every unbind, because the other sharers stay on
the line after free_irq().

Could pcdev->irq also be cleared when the devm IRQ is released? One option
is a devm action registered before devm_request_threaded_irq() that resets
pcdev->irq. Then pse_controller_unregister() would skip disable_irq() on
this path too.

>  
> -	pcdev->irq = irq;
> -	return ret;
> +	return 0;
>  }
>  EXPORT_SYMBOL_GPL(devm_pse_irq_helper);

-- 
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20261118183957.2031311-1-github%40szelinsky.de

  reply	other threads:[~2026-11-20  6:41 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18 18:39 [PATCH net v5 00/14] net: pse-pd: assorted lifetime and error-path fixes Carlo Szelinsky
2026-11-18 18:39 ` [PATCH net v5 01/14] net: pse-pd: size the notification kfifo after defaulting nr_lines Carlo Szelinsky
2026-11-18 18:39 ` [PATCH net v5 02/14] net: pse-pd: remove dead pi_get_admin_state() checks Carlo Szelinsky
2026-11-18 18:39 ` [PATCH net v5 03/14] net: pse-pd: fix module refcount leak in pse_control_get_internal() Carlo Szelinsky
2026-11-18 18:39 ` [PATCH net v5 04/14] net: pse-pd: do not keep a failed IRQ in pcdev->irq Carlo Szelinsky
2026-11-20  6:41   ` netdev-bot+sashiko [this message]
2026-11-20  8:32     ` Carlo Szelinsky
2026-11-18 18:39 ` [PATCH net v5 05/14] net: pse-pd: do not reach a freed PHY from the notification worker Carlo Szelinsky
2026-11-20  6:41   ` netdev-bot+sashiko
2026-11-20  8:33     ` Carlo Szelinsky
2026-11-18 18:39 ` [PATCH net v5 06/14] net: pse-pd: check the PI state under the lock when setting a power limit Carlo Szelinsky
2026-11-20  6:41   ` netdev-bot+sashiko
2026-11-20  8:33     ` Carlo Szelinsky
2026-11-20  9:32       ` Kory Maincent
2026-11-20 10:08         ` Carlo Szelinsky
2026-11-18 18:39 ` [PATCH net v5 07/14] net: pse-pd: do not tie a shared power domain to its creator's devres Carlo Szelinsky
2026-11-20  6:41   ` netdev-bot+sashiko
2026-11-20  8:33     ` Carlo Szelinsky
2026-11-18 18:39 ` [PATCH net v5 08/14] net: pse-pd: stop async event sources before freeing PI data in unregister Carlo Szelinsky
2026-11-20  6:41   ` netdev-bot+sashiko
2026-11-20  8:33     ` Carlo Szelinsky
2026-11-18 18:39 ` [PATCH net v5 09/14] net: pse-pd: unregister from the controller list before freeing PI data Carlo Szelinsky
2026-11-18 18:39 ` [PATCH net v5 10/14] net: pse-pd: keep the PI data until the PI regulators are gone Carlo Szelinsky
2026-11-18 18:39 ` [PATCH net v5 11/14] net: pse-pd: free the notification kfifo when registration fails Carlo Szelinsky
2026-11-18 18:39 ` [PATCH net v5 12/14] net: pse-pd: use each PI's own supply handle for the power budget Carlo Szelinsky
2026-11-18 18:39 ` [PATCH net v5 13/14] net: pse-pd: pd692x0: release the manager power budget through devres Carlo Szelinsky
2026-11-18 18:39 ` [PATCH net v5 14/14] net: pse-pd: pd692x0: defer probe while a manager supply is unresolved Carlo Szelinsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=179515690732.3136.5656168477825917127@kernel.org \
    --to=netdev-bot+sashiko@kernel.org \
    --cc=andrew+netdev@lunn.ch \
    --cc=broonie@kernel.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@kernel.org \
    --cc=github@szelinsky.de \
    --cc=horms@kernel.org \
    --cc=kory.maincent@bootlin.com \
    --cc=kuba@kernel.org \
    --cc=kyle.swenson@est.tech \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maxime.chevallier@bootlin.com \
    --cc=netdev@vger.kernel.org \
    --cc=o.rempel@pengutronix.de \
    --cc=pabeni@redhat.com \
    --cc=ross@r-sc.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.