All of lore.kernel.org
 help / color / mirror / Atom feed
From: netdev-bot+sashiko@kernel.org
To: leonard@lausen.nl
Cc: netdev@vger.kernel.org, dsahern@kernel.org, idosch@nvidia.com,
	davem@davemloft.net, edumazet@kernel.org, kuba@kernel.org,
	pabeni@redhat.com, horms@kernel.org, pablo@netfilter.org,
	fw@strlen.de, phil@nwl.cc, shuah@kernel.org,
	daniel@iogearbox.net, netfilter-devel@vger.kernel.org,
	coreteam@netfilter.org, linux-kselftest@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v4 2/2] selftests: netfilter: cover IPv6 FIB prefix suppression
Date: Fri, 20 Nov 2026 11:10:52 +0000	[thread overview]
Message-ID: <179517305282.3136.16580929973360319234@kernel.org> (raw)
In-Reply-To: <20261117110813.9894-4-leonard@lausen.nl>

Thank you for your contribution! Sashiko AI review found more severe
issue(s) in other patches of this series. This mail is only an FYI, in case
you want to address the nit picks below when you respin.

Low priority / nit picks for your consideration:

- [Low] The new in-tree comment before the IPv6 prefix-suppression block
  in tools/testing/selftests/net/netfilter/nft_fib.sh says "The router's…

--

selftests: netfilter: cover IPv6 FIB prefix suppression

This adds IPv6 checks to nft_fib.sh for suppress_prefixlength 0. They
verify that a default route is suppressed while a more-specific route is
retained, and that blackhole, unreachable and prohibit routes (including
a blackhole nexthop object) stay terminal. The checks run after the
existing default-table tests.

The commit message says:

> The router's logging RPF rules have already been removed by then,
> allowing neighbour discovery during intentionally different reverse-route
> states.

The same statement appears as a comment in the patch, covered inline
below.

> diff --git a/tools/testing/selftests/net/netfilter/nft_fib.sh b/tools/testing/selftests/net/netfilter/nft_fib.sh
> index 04544905c2164..25e13197f0578 100755
> --- a/tools/testing/selftests/net/netfilter/nft_fib.sh
> +++ b/tools/testing/selftests/net/netfilter/nft_fib.sh

[ ... ]

> @@ -845,6 +889,52 @@ test_fib_type "default table"
>  ip netns exec "$nsrouter" nft delete table ip filter
>  ip netns exec "$nsrouter" nft delete table ip6 filter
>  
> +# Keep the earlier IPv6 checks on the path without custom rules.
> +# The router's logging RPF rules have already been removed here.

[Severity: Low]
Is this comment accurate? Earlier, the script calls
load_pbr_ruleset "$nsrouter", and that installs a logging RPF check in
table inet filter:

load_pbr_ruleset() {
    ...
table inet filter {
	chain forward {
		type filter hook forward priority raw;
		fib saddr . iif oif gt 0 accept
		log drop
	}
}
    ...
}

Between that load and this block, the only deletions are
"nft delete table ip filter" and "nft delete table ip6 filter", after
each test_fib_type call. Table inet filter is not flushed until the
"flush ruleset" in load_ruleset_vrf().

The prerouting nft_rpfilter logging rules from load_ruleset() are gone
at this point, since the earlier "nft flush ruleset" removed them. The
forward-hook "log drop" chain is still loaded, though.

The new probes (ping to dead:1::1) and neighbour discovery are delivered
locally and never reach the forward hook, so the checks still pass.
Could the comment, and the matching sentence in the commit message, say
that it is the prerouting nft_rpfilter rules that have been removed,
rather than all of the router's logging RPF rules?

> +if ip -net "$nsrouter" -6 rule add pref 100 to dead:1::99 table 128 \
> +	suppress_prefixlength 0; then

[ ... ]

-- 
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20261117110813.9894-2-leonard%40lausen.nl

  reply	other threads:[~2026-11-20 11:10 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17 11:08 [PATCH net v4 0/2] ipv6: Honor suppress_prefixlength in fib6_lookup() Leonard Lausen
2026-11-17 11:08 ` [PATCH net v4 1/2] " Leonard Lausen
2026-11-17 16:12   ` Ido Schimmel
2026-11-20 11:10   ` netdev-bot+sashiko
2026-11-20 15:35     ` Ido Schimmel
2026-11-17 11:08 ` [PATCH net v4 2/2] selftests: netfilter: cover IPv6 FIB prefix suppression Leonard Lausen
2026-11-20 11:10   ` netdev-bot+sashiko [this message]
2026-11-17 12:56 ` [PATCH net v4 0/2] ipv6: Honor suppress_prefixlength in fib6_lookup() Pablo Neira Ayuso
2026-11-17 13:01   ` Leonard Lausen
2026-11-17 13:07     ` Pablo Neira Ayuso
2026-11-17 15:24       ` Ido Schimmel
2026-11-17 16:30         ` Paolo Abeni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=179517305282.3136.16580929973360319234@kernel.org \
    --to=netdev-bot+sashiko@kernel.org \
    --cc=coreteam@netfilter.org \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=dsahern@kernel.org \
    --cc=edumazet@kernel.org \
    --cc=fw@strlen.de \
    --cc=horms@kernel.org \
    --cc=idosch@nvidia.com \
    --cc=kuba@kernel.org \
    --cc=leonard@lausen.nl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=pablo@netfilter.org \
    --cc=phil@nwl.cc \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.