From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795219343; b=PLQvxyHv8/mUQFjD3Auhst/w0P3R+Xg/ENaqVpUYy87Bdg+qoObZIWEY3biw4xT6imwQ n1/NqsRxbHg1Fc2pQuOpvPB+YCmDz+QIRP630gOPW+iEvHTk8+9H6pagyVCDBQwNvsNaW AXYa2CMkTb6nc+LDTUj7Y2RAUZML+4a88L3PeIuAUPVP3Ellm7G1sXzWIHxBar1Fa0TH/ JA3JAQY80wbVLKxZluoh1h9b4A9ViLtaABzqOlgLRRMUQWyWKQ+NBU3j8v7W3+iyifk0X qLbr9W0kACkUAThjBjzhWe8SwBQycM3NnRIXoLhT4HgdIDUvgE3fyZ31vLDeHVYwUQg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795219343; h=Received:DKIM-Signature:Subject:From:To:Cc:Date:Message-ID: In-Reply-To:References:X-sashiko-severity:Content-Type: Content-Transfer-Encoding:MIME-Version; bh=0y+Rk4QZ5e2oU+BGAt7OZ0CEJL8UV9kLFYC2q1exmHc=; b=YJ+xG9faq5Z5q10oIy2ome++Sh3nSqdsd1mynooZg+LI0pZjWyGrW+TALMdUkoUHBD0f MGGQodB2SfY8BjIptjKi53txflgHCe/Uf3jYLz+YhBejM3pzRLSe1WPTwYjB5LjirOmBO fB3nPNyPlQ/m0pswS+luf6F6G/Vpb2RcMSVrY2A87+k3BVE0+ZFXFk9e80gNOF9KOE0J0 VukEh68MBw6GAkSRc5UMQyu2+ycaOC/18szvzjdIc8RrlWQeIqsfmWfdeZTua7xp1SiIs 0V0qro5m+LHAyOGL5OSJrHhUqc2vPtvQHnC6UDios0VREG06qZr1sfVqcfnyOkdtHUw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=AKnihBNY; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7FEE3606A69E; Sat, 21 Nov 2026 00:02:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=AKnihBNY Received: by smtp.kernel.org (Postfix) with ESMTPSA id 228B11F000C6; Sat, 21 Nov 2026 00:02:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1795219343; bh=0y+Rk4QZ5e2oU+BGAt7OZ0CEJL8UV9kLFYC2q1exmHc=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=AKnihBNYdu9yh7d470oL2RjLqPx/DHRyy+z955BkgmlOBVb7JYUtqNZeG2ZXlO30m TDnS6Qv+3Dw/OKZw0uFT237BQjql17DRC4Nf3uPmouzdXNQpjk5ZiwYUTd+dUMJ+Q8 6zWfuOumf2VMvUppu8ZKAsnxrhjxtC0jYG8dcGwDcvgGEoUAoDpIQfRtMJVb6PVOnR ZDsU1+6B/ne44sQNVPOHLfmGSgmlhz8LgqYXycIsqA7nF+jYmk0MkhCIoj8DE+ceuu f3AswRHZ9cK3ENEe9oSn/VeGZIUFLpBLpZWRqoP1gyecVfzrz4ya+tLURYDRJ3pN9s 9wujozKqWS6Jw== Subject: Re: [PATCH net v10 07/10] can: rockchip_canfd: serialize TX with bus-off and restart From: netdev-bot+sashiko@kernel.org To: 1579567540@qq.com Cc: mkl@pengutronix.de, kernel@pengutronix.de, mailhol@kernel.org, heiko@sntech.de, socketcan@hartkopp.net, davem@davemloft.net, edumazet@kernel.org, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, corbet@lwn.net, skhan@linuxfoundation.org, rdunlap@infradead.org, wg@grandegger.com, linux-can@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, stable@vger.kernel.org Date: Sat, 21 Nov 2026 00:02:21 +0000 Message-ID: <179521934168.3131.3588718854244956629@kernel.org> In-Reply-To: <20261119-rockchip-canfd-restart-close-v10-7-df23913aa33a@qq.com> References: <20261119-rockchip-canfd-restart-close-v10-7-df23913aa33a@qq.com> X-sashiko-severity: Low Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Thank you for your contribution! Sashiko AI review found more severe issue(s) in other patches of this series. This mail is only an FYI, in case you want to address the nit picks below when you respin. Low priority / nit picks for your consideration: - [Low] In struct rkcanfd_priv (drivers/net/can/rockchip/rockchip_canfd.h), the patch replaces the… Pre-existing issues: - [Low] At this commit, priv->tc is read with no lock from the hardirq handler, via rkcanfd_skb_set_timestamp() -> timecounter_cyc2time(), on… -- can: rockchip_canfd: serialize TX with bus-off and restart This patch uses tx_lock and a new tx_enabled flag to drain TX and RX-side echo users before CAN_STATE_BUS_OFF is published, and it drops consumed RX FIFO entries while TX is disabled. Before reinitializing the controller, restart masks device interrupts, suspends the shared IRQ handler through irq_suspended and synchronize_irq(), and drains the timestamp work. Link: https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20261111-rockchip-canfd-restart-close-v9-0-6643f3825ba3%40qq.com > diff --git a/drivers/net/can/rockchip/rockchip_canfd-timestamp.c b/drivers/net/can/rockchip/rockchip_canfd-timestamp.c > index 72774cd2f94b7..ad582afbbd682 100644 > --- a/drivers/net/can/rockchip/rockchip_canfd-timestamp.c > +++ b/drivers/net/can/rockchip/rockchip_canfd-timestamp.c > @@ -37,6 +37,11 @@ static void rkcanfd_timestamp_work(struct work_struct *work) > schedule_delayed_work(&priv->timestamp, priv->work_delay_jiffies); > } > > +void rkcanfd_timestamp_work_init(struct rkcanfd_priv *priv) > +{ > + INIT_DELAYED_WORK(&priv->timestamp, rkcanfd_timestamp_work); > +} > + [Severity: Low] This isn't a bug introduced by this patch, but can priv->tc be updated here while the IRQ handler is reading it? rkcanfd_timestamp_work() updates the timecounter without taking a lock: rkcanfd_timestamp_work() { priv = container_of(delayed_work, struct rkcanfd_priv, timestamp); timecounter_read(&priv->tc); schedule_delayed_work(&priv->timestamp, priv->work_delay_jiffies); } The hardirq handler reads the same timecounter, also without a lock. It does this on the RX, TX-done and error-skb paths through rkcanfd_skb_set_timestamp(): ns = timecounter_cyc2time(&priv->tc, timestamp); timecounter_read() writes cycle_last, frac and nsec as separate stores. Suppose the worker runs on one CPU while the CAN IRQ converts a timestamp on another. Can the conversion then combine a new cycle_last with an old nsec and produce a wrong hardware timestamp? Separately, the bus-off path in rkcanfd_chip_stop() only does a non-sync cancel: rkcanfd_timestamp_stop(priv); __rkcanfd_chip_stop(priv, state); Here rkcanfd_timestamp_stop() is cancel_delayed_work(). If the worker is already running, it can re-arm itself and keep reading the counter while the controller is in reset. This patch adds rkcanfd_timestamp_stop_sync() only on the restart path. That covers timecounter_init(), but not these two cases. Both appear to be fixed later in this series: "can: rockchip_canfd: serialize timecounter timestamp conversion" holds timestamp_lock around timecounter_cyc2time(), timecounter_read() and timecounter_init(). "can: rockchip_canfd: prevent timestamp work from rearming after bus-off" uses disable_delayed_work() and a timestamp_active flag. > diff --git a/drivers/net/can/rockchip/rockchip_canfd.h b/drivers/net/can/rockchip/rockchip_canfd.h > index 077dd57d42de9..8fdb59025bfaf 100644 > --- a/drivers/net/can/rockchip/rockchip_canfd.h > +++ b/drivers/net/can/rockchip/rockchip_canfd.h > @@ -475,7 +475,7 @@ struct rkcanfd_priv { > struct can_rx_offload offload; > struct net_device *ndev; > > - /* Protect running TX/RX echo state, queue updates and TX commands. */ > + /* Serialize TX submission/completion with bus-off and restart. */ > spinlock_t tx_lock; [ ... ] > @@ -485,6 +485,9 @@ struct rkcanfd_priv { > u32 reg_int_mask_default; > struct rkcanfd_devtype_data devtype_data; > > + bool tx_enabled; > + bool irq_suspended; > + [Severity: Low] This isn't a bug, but the new tx_lock comment covers less than the lock actually protects. tx_lock still serializes TX command writes. rkcanfd_start_xmit_write_cmd() asserts it because rkcanfd_start_xmit() and the RX-side rkcanfd_xmit_retry() share the erratum-12 MODE/CMD/MODE sequence: rkcanfd_start_xmit_write_cmd() { lockdep_assert_held(&priv->tx_lock); if (priv->devtype_data.quirks & RKCANFD_QUIRK_RK3568_ERRATUM_12) rkcanfd_write(priv, RKCANFD_REG_MODE, priv->reg_mode_default | ... } The lock also still covers the echo ring and the queue/BQL updates in rkcanfd_tx_tail_is_eff(), rkcanfd_get_effective_tx_free(), rkcanfd_rxstx_filter() and rkcanfd_handle_tx_done_one(). Could the comment keep listing the TX command and echo ring duties? Also, nothing says how the two new fields are synchronized. tx_enabled is only accessed under tx_lock. irq_suspended takes no lock and relies on the WRITE_ONCE()/smp_store_release() and smp_load_acquire() pairing plus synchronize_irq(). Would a short note on each field help? At the end of the series the tx_lock comment is still narrow, and the later tx_retry_enabled and tx_retry_pending fields have no comment either. -- Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20261119-rockchip-canfd-restart-close-v10-0-df23913aa33a%40qq.com From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D364D606A6BA for ; Sat, 21 Nov 2026 00:02:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=Jw4yGWAe; dkim=fail reason="signature verification failed" (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=AKnihBNY DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Cc:To:From:Subject:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=XV9lBCbvbvzTYRIwKP61rgsC3FN9VJGru1z4w9xOBT0=; b=Jw4yGWAeMSeiP/vbRWM135g+zR 6J0ALek3qS2HBPbM7DLb85Jbb1LxxBAX1aMQlA2RBfENBvxpicrsbvVX0ILtS5/ECO3/zC8fNw+SN vZ3f7DbYZp11Hug8rVRLa4tUGmNgTxl9kXpY0VSb0FYEPKzoT69LCOTBGydE7TYSrNn1nH3Tl3EvA pcKSvX5bx1dZQfXsMDuKjj97kp/+8xRovsIRlzVsxZJRGtGpCJtu0T6/kZvh9qXCCuuOBTj+ZBm5L CV6F4lPdud13MGx0tBIb2iEYsXKhCVc9elPOapFZo9ZEnYtyvh0hfTd4w6L2q5r49MdTGs7Ehy3Yx ZH8pY8VA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xUYYz-0000000GShu-1wcs; Sat, 21 Nov 2026 00:02:41 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xUYYi-0000000GSby-34ZB; Sat, 21 Nov 2026 00:02:25 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 7956142DCF; Sat, 21 Nov 2026 00:02:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 228B11F000C6; Sat, 21 Nov 2026 00:02:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1795219343; bh=0y+Rk4QZ5e2oU+BGAt7OZ0CEJL8UV9kLFYC2q1exmHc=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=AKnihBNYdu9yh7d470oL2RjLqPx/DHRyy+z955BkgmlOBVb7JYUtqNZeG2ZXlO30m TDnS6Qv+3Dw/OKZw0uFT237BQjql17DRC4Nf3uPmouzdXNQpjk5ZiwYUTd+dUMJ+Q8 6zWfuOumf2VMvUppu8ZKAsnxrhjxtC0jYG8dcGwDcvgGEoUAoDpIQfRtMJVb6PVOnR ZDsU1+6B/ne44sQNVPOHLfmGSgmlhz8LgqYXycIsqA7nF+jYmk0MkhCIoj8DE+ceuu f3AswRHZ9cK3ENEe9oSn/VeGZIUFLpBLpZWRqoP1gyecVfzrz4ya+tLURYDRJ3pN9s 9wujozKqWS6Jw== Subject: Re: [PATCH net v10 07/10] can: rockchip_canfd: serialize TX with bus-off and restart From: netdev-bot+sashiko@kernel.org To: 1579567540@qq.com Cc: mkl@pengutronix.de, kernel@pengutronix.de, mailhol@kernel.org, heiko@sntech.de, socketcan@hartkopp.net, davem@davemloft.net, edumazet@kernel.org, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, corbet@lwn.net, skhan@linuxfoundation.org, rdunlap@infradead.org, wg@grandegger.com, linux-can@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, stable@vger.kernel.org Date: Sat, 21 Nov 2026 00:02:21 +0000 Message-ID: <179521934168.3131.3588718854244956629@kernel.org> In-Reply-To: <20261119-rockchip-canfd-restart-close-v10-7-df23913aa33a@qq.com> References: <20261119-rockchip-canfd-restart-close-v10-7-df23913aa33a@qq.com> X-sashiko-severity: Low X-Archived-By: MIME-Version: 1.0 X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" X-Spam-Status: No, score=-8.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg bW9yZSBzZXZlcmUKaXNzdWUocykgaW4gb3RoZXIgcGF0Y2hlcyBvZiB0aGlzIHNlcmllcy4gVGhp cyBtYWlsIGlzIG9ubHkgYW4gRllJLCBpbiBjYXNlCnlvdSB3YW50IHRvIGFkZHJlc3MgdGhlIG5p dCBwaWNrcyBiZWxvdyB3aGVuIHlvdSByZXNwaW4uCgpMb3cgcHJpb3JpdHkgLyBuaXQgcGlja3Mg Zm9yIHlvdXIgY29uc2lkZXJhdGlvbjoKCi0gW0xvd10gSW4gc3RydWN0IHJrY2FuZmRfcHJpdgog IChkcml2ZXJzL25ldC9jYW4vcm9ja2NoaXAvcm9ja2NoaXBfY2FuZmQuaCksIHRoZSBwYXRjaCBy ZXBsYWNlcyB0aGXigKYKClByZS1leGlzdGluZyBpc3N1ZXM6Ci0gW0xvd10gQXQgdGhpcyBjb21t aXQsIHByaXYtPnRjIGlzIHJlYWQgd2l0aCBubyBsb2NrIGZyb20gdGhlIGhhcmRpcnEKICBoYW5k bGVyLCB2aWEgcmtjYW5mZF9za2Jfc2V0X3RpbWVzdGFtcCgpIC0+IHRpbWVjb3VudGVyX2N5YzJ0 aW1lKCksIG9u4oCmCgotLQoKY2FuOiByb2NrY2hpcF9jYW5mZDogc2VyaWFsaXplIFRYIHdpdGgg YnVzLW9mZiBhbmQgcmVzdGFydAoKVGhpcyBwYXRjaCB1c2VzIHR4X2xvY2sgYW5kIGEgbmV3IHR4 X2VuYWJsZWQgZmxhZyB0byBkcmFpbiBUWCBhbmQgUlgtc2lkZQplY2hvIHVzZXJzIGJlZm9yZSBD QU5fU1RBVEVfQlVTX09GRiBpcyBwdWJsaXNoZWQsIGFuZCBpdCBkcm9wcyBjb25zdW1lZCBSWApG SUZPIGVudHJpZXMgd2hpbGUgVFggaXMgZGlzYWJsZWQuIEJlZm9yZSByZWluaXRpYWxpemluZyB0 aGUgY29udHJvbGxlciwKcmVzdGFydCBtYXNrcyBkZXZpY2UgaW50ZXJydXB0cywgc3VzcGVuZHMg dGhlIHNoYXJlZCBJUlEgaGFuZGxlciB0aHJvdWdoCmlycV9zdXNwZW5kZWQgYW5kIHN5bmNocm9u aXplX2lycSgpLCBhbmQgZHJhaW5zIHRoZSB0aW1lc3RhbXAgd29yay4KCkxpbms6IGh0dHBzOi8v bmV0ZGV2LWFpLmJvdHMubGludXguZGV2L3Nhc2hpa28vIy9wYXRjaHNldC8yMDI2MTExMS1yb2Nr Y2hpcC1jYW5mZC1yZXN0YXJ0LWNsb3NlLXY5LTAtNjY0M2YzODI1YmEzJTQwcXEuY29tCgo+IGRp ZmYgLS1naXQgYS9kcml2ZXJzL25ldC9jYW4vcm9ja2NoaXAvcm9ja2NoaXBfY2FuZmQtdGltZXN0 YW1wLmMgYi9kcml2ZXJzL25ldC9jYW4vcm9ja2NoaXAvcm9ja2NoaXBfY2FuZmQtdGltZXN0YW1w LmMKPiBpbmRleCA3Mjc3NGNkMmY5NGI3Li5hZDU4MmFmYmJkNjgyIDEwMDY0NAo+IC0tLSBhL2Ry aXZlcnMvbmV0L2Nhbi9yb2NrY2hpcC9yb2NrY2hpcF9jYW5mZC10aW1lc3RhbXAuYwo+ICsrKyBi L2RyaXZlcnMvbmV0L2Nhbi9yb2NrY2hpcC9yb2NrY2hpcF9jYW5mZC10aW1lc3RhbXAuYwo+IEBA IC0zNyw2ICszNywxMSBAQCBzdGF0aWMgdm9pZCBya2NhbmZkX3RpbWVzdGFtcF93b3JrKHN0cnVj dCB3b3JrX3N0cnVjdCAqd29yaykKPiAgCXNjaGVkdWxlX2RlbGF5ZWRfd29yaygmcHJpdi0+dGlt ZXN0YW1wLCBwcml2LT53b3JrX2RlbGF5X2ppZmZpZXMpOwo+ICB9Cj4gIAo+ICt2b2lkIHJrY2Fu ZmRfdGltZXN0YW1wX3dvcmtfaW5pdChzdHJ1Y3QgcmtjYW5mZF9wcml2ICpwcml2KQo+ICt7Cj4g KwlJTklUX0RFTEFZRURfV09SSygmcHJpdi0+dGltZXN0YW1wLCBya2NhbmZkX3RpbWVzdGFtcF93 b3JrKTsKPiArfQo+ICsKCltTZXZlcml0eTogTG93XQpUaGlzIGlzbid0IGEgYnVnIGludHJvZHVj ZWQgYnkgdGhpcyBwYXRjaCwgYnV0IGNhbiBwcml2LT50YyBiZSB1cGRhdGVkCmhlcmUgd2hpbGUg dGhlIElSUSBoYW5kbGVyIGlzIHJlYWRpbmcgaXQ/Cgpya2NhbmZkX3RpbWVzdGFtcF93b3JrKCkg dXBkYXRlcyB0aGUgdGltZWNvdW50ZXIgd2l0aG91dCB0YWtpbmcgYSBsb2NrOgoKcmtjYW5mZF90 aW1lc3RhbXBfd29yaygpIHsKCXByaXYgPSBjb250YWluZXJfb2YoZGVsYXllZF93b3JrLCBzdHJ1 Y3QgcmtjYW5mZF9wcml2LCB0aW1lc3RhbXApOwoJdGltZWNvdW50ZXJfcmVhZCgmcHJpdi0+dGMp OwoKCXNjaGVkdWxlX2RlbGF5ZWRfd29yaygmcHJpdi0+dGltZXN0YW1wLCBwcml2LT53b3JrX2Rl bGF5X2ppZmZpZXMpOwp9CgpUaGUgaGFyZGlycSBoYW5kbGVyIHJlYWRzIHRoZSBzYW1lIHRpbWVj b3VudGVyLCBhbHNvIHdpdGhvdXQgYSBsb2NrLiBJdApkb2VzIHRoaXMgb24gdGhlIFJYLCBUWC1k b25lIGFuZCBlcnJvci1za2IgcGF0aHMgdGhyb3VnaApya2NhbmZkX3NrYl9zZXRfdGltZXN0YW1w KCk6CgoJbnMgPSB0aW1lY291bnRlcl9jeWMydGltZSgmcHJpdi0+dGMsIHRpbWVzdGFtcCk7Cgp0 aW1lY291bnRlcl9yZWFkKCkgd3JpdGVzIGN5Y2xlX2xhc3QsIGZyYWMgYW5kIG5zZWMgYXMgc2Vw YXJhdGUgc3RvcmVzLgpTdXBwb3NlIHRoZSB3b3JrZXIgcnVucyBvbiBvbmUgQ1BVIHdoaWxlIHRo ZSBDQU4gSVJRIGNvbnZlcnRzIGEgdGltZXN0YW1wCm9uIGFub3RoZXIuIENhbiB0aGUgY29udmVy c2lvbiB0aGVuIGNvbWJpbmUgYSBuZXcgY3ljbGVfbGFzdCB3aXRoIGFuIG9sZApuc2VjIGFuZCBw cm9kdWNlIGEgd3JvbmcgaGFyZHdhcmUgdGltZXN0YW1wPwoKU2VwYXJhdGVseSwgdGhlIGJ1cy1v ZmYgcGF0aCBpbiBya2NhbmZkX2NoaXBfc3RvcCgpIG9ubHkgZG9lcyBhIG5vbi1zeW5jCmNhbmNl bDoKCglya2NhbmZkX3RpbWVzdGFtcF9zdG9wKHByaXYpOwoJX19ya2NhbmZkX2NoaXBfc3RvcChw cml2LCBzdGF0ZSk7CgpIZXJlIHJrY2FuZmRfdGltZXN0YW1wX3N0b3AoKSBpcyBjYW5jZWxfZGVs YXllZF93b3JrKCkuIElmIHRoZSB3b3JrZXIgaXMKYWxyZWFkeSBydW5uaW5nLCBpdCBjYW4gcmUt YXJtIGl0c2VsZiBhbmQga2VlcCByZWFkaW5nIHRoZSBjb3VudGVyIHdoaWxlCnRoZSBjb250cm9s bGVyIGlzIGluIHJlc2V0LgoKVGhpcyBwYXRjaCBhZGRzIHJrY2FuZmRfdGltZXN0YW1wX3N0b3Bf c3luYygpIG9ubHkgb24gdGhlIHJlc3RhcnQgcGF0aC4KVGhhdCBjb3ZlcnMgdGltZWNvdW50ZXJf aW5pdCgpLCBidXQgbm90IHRoZXNlIHR3byBjYXNlcy4KCkJvdGggYXBwZWFyIHRvIGJlIGZpeGVk IGxhdGVyIGluIHRoaXMgc2VyaWVzOgoKICAiY2FuOiByb2NrY2hpcF9jYW5mZDogc2VyaWFsaXpl IHRpbWVjb3VudGVyIHRpbWVzdGFtcCBjb252ZXJzaW9uIiBob2xkcwogIHRpbWVzdGFtcF9sb2Nr IGFyb3VuZCB0aW1lY291bnRlcl9jeWMydGltZSgpLCB0aW1lY291bnRlcl9yZWFkKCkgYW5kCiAg dGltZWNvdW50ZXJfaW5pdCgpLgoKICAiY2FuOiByb2NrY2hpcF9jYW5mZDogcHJldmVudCB0aW1l c3RhbXAgd29yayBmcm9tIHJlYXJtaW5nIGFmdGVyCiAgYnVzLW9mZiIgdXNlcyBkaXNhYmxlX2Rl bGF5ZWRfd29yaygpIGFuZCBhIHRpbWVzdGFtcF9hY3RpdmUgZmxhZy4KCj4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvbmV0L2Nhbi9yb2NrY2hpcC9yb2NrY2hpcF9jYW5mZC5oIGIvZHJpdmVycy9uZXQv Y2FuL3JvY2tjaGlwL3JvY2tjaGlwX2NhbmZkLmgKPiBpbmRleCAwNzdkZDU3ZDQyZGU5Li44ZmRi NTkwMjViZmFmIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvbmV0L2Nhbi9yb2NrY2hpcC9yb2NrY2hp cF9jYW5mZC5oCj4gKysrIGIvZHJpdmVycy9uZXQvY2FuL3JvY2tjaGlwL3JvY2tjaGlwX2NhbmZk LmgKPiBAQCAtNDc1LDcgKzQ3NSw3IEBAIHN0cnVjdCBya2NhbmZkX3ByaXYgewo+ICAJc3RydWN0 IGNhbl9yeF9vZmZsb2FkIG9mZmxvYWQ7Cj4gIAlzdHJ1Y3QgbmV0X2RldmljZSAqbmRldjsKPiAg Cj4gLQkvKiBQcm90ZWN0IHJ1bm5pbmcgVFgvUlggZWNobyBzdGF0ZSwgcXVldWUgdXBkYXRlcyBh bmQgVFggY29tbWFuZHMuICovCj4gKwkvKiBTZXJpYWxpemUgVFggc3VibWlzc2lvbi9jb21wbGV0 aW9uIHdpdGggYnVzLW9mZiBhbmQgcmVzdGFydC4gKi8KPiAgCXNwaW5sb2NrX3QgdHhfbG9jazsK ClsgLi4uIF0KCj4gQEAgLTQ4NSw2ICs0ODUsOSBAQCBzdHJ1Y3QgcmtjYW5mZF9wcml2IHsKPiAg CXUzMiByZWdfaW50X21hc2tfZGVmYXVsdDsKPiAgCXN0cnVjdCBya2NhbmZkX2RldnR5cGVfZGF0 YSBkZXZ0eXBlX2RhdGE7Cj4gIAo+ICsJYm9vbCB0eF9lbmFibGVkOwo+ICsJYm9vbCBpcnFfc3Vz cGVuZGVkOwo+ICsKCltTZXZlcml0eTogTG93XQpUaGlzIGlzbid0IGEgYnVnLCBidXQgdGhlIG5l dyB0eF9sb2NrIGNvbW1lbnQgY292ZXJzIGxlc3MgdGhhbiB0aGUgbG9jawphY3R1YWxseSBwcm90 ZWN0cy4KCnR4X2xvY2sgc3RpbGwgc2VyaWFsaXplcyBUWCBjb21tYW5kIHdyaXRlcy4gcmtjYW5m ZF9zdGFydF94bWl0X3dyaXRlX2NtZCgpCmFzc2VydHMgaXQgYmVjYXVzZSBya2NhbmZkX3N0YXJ0 X3htaXQoKSBhbmQgdGhlIFJYLXNpZGUKcmtjYW5mZF94bWl0X3JldHJ5KCkgc2hhcmUgdGhlIGVy cmF0dW0tMTIgTU9ERS9DTUQvTU9ERSBzZXF1ZW5jZToKCnJrY2FuZmRfc3RhcnRfeG1pdF93cml0 ZV9jbWQoKSB7Cglsb2NrZGVwX2Fzc2VydF9oZWxkKCZwcml2LT50eF9sb2NrKTsKCglpZiAocHJp di0+ZGV2dHlwZV9kYXRhLnF1aXJrcyAmIFJLQ0FORkRfUVVJUktfUkszNTY4X0VSUkFUVU1fMTIp CgkJcmtjYW5mZF93cml0ZShwcml2LCBSS0NBTkZEX1JFR19NT0RFLCBwcml2LT5yZWdfbW9kZV9k ZWZhdWx0IHwKCS4uLgp9CgpUaGUgbG9jayBhbHNvIHN0aWxsIGNvdmVycyB0aGUgZWNobyByaW5n IGFuZCB0aGUgcXVldWUvQlFMIHVwZGF0ZXMgaW4KcmtjYW5mZF90eF90YWlsX2lzX2VmZigpLCBy a2NhbmZkX2dldF9lZmZlY3RpdmVfdHhfZnJlZSgpLApya2NhbmZkX3J4c3R4X2ZpbHRlcigpIGFu ZCBya2NhbmZkX2hhbmRsZV90eF9kb25lX29uZSgpLgoKQ291bGQgdGhlIGNvbW1lbnQga2VlcCBs aXN0aW5nIHRoZSBUWCBjb21tYW5kIGFuZCBlY2hvIHJpbmcgZHV0aWVzPwoKQWxzbywgbm90aGlu ZyBzYXlzIGhvdyB0aGUgdHdvIG5ldyBmaWVsZHMgYXJlIHN5bmNocm9uaXplZC4gdHhfZW5hYmxl ZCBpcwpvbmx5IGFjY2Vzc2VkIHVuZGVyIHR4X2xvY2suIGlycV9zdXNwZW5kZWQgdGFrZXMgbm8g bG9jayBhbmQgcmVsaWVzIG9uIHRoZQpXUklURV9PTkNFKCkvc21wX3N0b3JlX3JlbGVhc2UoKSBh bmQgc21wX2xvYWRfYWNxdWlyZSgpIHBhaXJpbmcgcGx1cwpzeW5jaHJvbml6ZV9pcnEoKS4KCldv dWxkIGEgc2hvcnQgbm90ZSBvbiBlYWNoIGZpZWxkIGhlbHA/IEF0IHRoZSBlbmQgb2YgdGhlIHNl cmllcyB0aGUKdHhfbG9jayBjb21tZW50IGlzIHN0aWxsIG5hcnJvdywgYW5kIHRoZSBsYXRlciB0 eF9yZXRyeV9lbmFibGVkIGFuZAp0eF9yZXRyeV9wZW5kaW5nIGZpZWxkcyBoYXZlIG5vIGNvbW1l bnQgZWl0aGVyLgoKLS0gClNhc2hpa28gQUkgcmV2aWV3IMK3IGh0dHBzOi8vbmV0ZGV2LWFpLmJv dHMubGludXguZGV2L3Nhc2hpa28vIy9wYXRjaHNldC8yMDI2MTExOS1yb2NrY2hpcC1jYW5mZC1y ZXN0YXJ0LWNsb3NlLXYxMC0wLWRmMjM5MTNhYTMzYSU0MHFxLmNvbQoKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTGludXgtcm9ja2NoaXAgbWFpbGluZyBs aXN0CkxpbnV4LXJvY2tjaGlwQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJh ZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1yb2NrY2hpcAo=