From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795219347; b=5LmtD4Vhn6oX7j0G8iJFYs+BUrcJwS+n6BRitVgxnKXLJRq/GPr7cRdHsem7EIOpk1tj l51kobC1rRnvhqIHERnCYb1fOtAO9A+gYSNQ5ZZtxre1GAjcqwYQwwpbMUdjSFiUTMzME uPhs6ifln72jJMKxNchLbiUojV8HQNrJRygL+oGkgxL9OMYEeWJlyMzDTBqLyuzKO8/3J iMHISQbLtOu64SMnJrt0bzCe++o5iwMZRjfLl9gQfTT3WWKBlGEeRmm4HU+w6PUT24qrC a0BBNIpH8sMirtHH4WHMYhi0V5T0d/weJRz9zxjdTFSv1rsf9m2oHHtefNQHX9bvJXA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795219347; h=Received:DKIM-Signature:Subject:From:To:Cc:Date:Message-ID: In-Reply-To:References:X-sashiko-severity:Content-Type: Content-Transfer-Encoding:MIME-Version; bh=vVTWkhfLiH/QsLki+tG2g1OrDcp1ntC4ATOpIndsvv4=; b=U/V7Nj5o7L0mIj4FWyBJpl0j4T6rcHR86zeuDlREcQtBm0/drnd78H7AoJtlE1QuC9ua STXHCDovH0ziTlG2OInwLGOLdu8bP5vaAGpi+GyCym+UJNFPsrBBJtewWPp+6Czs2YVRD AS1BS7xoWxKjIjtzjFQw9Ax2ToeSsENxSyRCBOQwHE/oRgYOtYsaukFQRGomLfxN6BlaU /My/mhh8Kdi7qmSMBzMlTjvYpFYrs69Ok94sHbp9QFKoOV+9h0rNkQHqeNy5IwJk1wt4k 0XJW/5ja+0+s4fKUUyEPHCmduz9ygBXXVhw549wojIj4OVjYAdUMv8jFRRrMf/El1KA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=W9rz7AwU; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB46960A2602; Sat, 21 Nov 2026 00:02:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=W9rz7AwU Received: by smtp.kernel.org (Postfix) with ESMTPSA id 639661F000C6; Sat, 21 Nov 2026 00:02:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1795219347; bh=vVTWkhfLiH/QsLki+tG2g1OrDcp1ntC4ATOpIndsvv4=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=W9rz7AwUeMWreMrPywL+G/eoSE/ac2EveLkjzau1+l0PpgXWjbqzH2KWAYN5hxD/0 evRhjZHWufSyBIVEzlrjwmfIRXPIpt4QTk1ivutvkXBvV4bFQhJFI/26GRbX5pvHM3 EluX44uvrajwnxDAhlXrXaS9HMrM07H3/Ou6qQO3hPenvRQtCRv06l9uXteA/pLViA O/TGDLSTfnS2YI04Br/iLpk4mLydKXSfwv1M7WJajGUA6OHjBWCG6swUWr+dJKhQ0M WnI7u47mSRhMBbQggvz7GW8gE4F4+V8Q9YuTyV9In9Zwsf4s7HMXNClCq0SxgZhO/E eRAYjIXBkfH8A== Subject: Re: [PATCH net v10 10/10] can: rockchip_canfd: serialize timecounter timestamp conversion From: netdev-bot+sashiko@kernel.org To: 1579567540@qq.com Cc: mkl@pengutronix.de, kernel@pengutronix.de, mailhol@kernel.org, heiko@sntech.de, socketcan@hartkopp.net, davem@davemloft.net, edumazet@kernel.org, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, corbet@lwn.net, skhan@linuxfoundation.org, rdunlap@infradead.org, wg@grandegger.com, linux-can@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, stable@vger.kernel.org Date: Sat, 21 Nov 2026 00:02:25 +0000 Message-ID: <179521934595.3131.13988876249908602124@kernel.org> In-Reply-To: <20261119-rockchip-canfd-restart-close-v10-10-df23913aa33a@qq.com> References: <20261119-rockchip-canfd-restart-close-v10-10-df23913aa33a@qq.com> X-sashiko-severity: Low Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Mailing-List: linux-can@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Thank you for your contribution! Sashiko AI review found more severe issue(s) in other patches of this series. This mail is only an FYI, in case you want to address the nit picks below when you respin. Low priority / nit picks for your consideration: - [Low] The patch is tagged `Cc: stable@vger.kernel.org` with `Fixes: 4e1a18bab124 ("can: rockchip_canfd: add hardware timestamping… -- can: rockchip_canfd: serialize timecounter timestamp conversion This commit holds priv->timestamp_lock around timecounter_cyc2time() in rkcanfd_skb_set_timestamp(). That serializes the RX, TX completion and error-frame timestamp conversion against timecounter_read() in the timestamp worker. The comment on timestamp_lock in struct rkcanfd_priv is also changed to say it protects tc and timestamp_active. > Hold timestamp_lock across timecounter_cyc2time(), using the same lock > as timecounter_read() and timecounter_init(). Keep the SKB timestamp > assignment outside the critical section. [ ... ] > Fixes: 4e1a18bab124 ("can: rockchip_canfd: add hardware timestamping support") > Cc: stable@vger.kernel.org [Severity: Low] Should the stable tag mention that this depends on the earlier patch in the series, "can: rockchip_canfd: prevent timestamp work from rearming after bus-off"? The timestamp_lock and timestamp_active members of struct rkcanfd_priv are not in 4e1a18bab124. The earlier patch adds them. It also puts timecounter_read() in rkcanfd_timestamp_work() and timecounter_init() in rkcanfd_timestamp_start() under the lock: spin_lock_irqsave(&priv->timestamp_lock, flags); if (priv->timestamp_active) timecounter_read(&priv->tc); spin_unlock_irqrestore(&priv->timestamp_lock, flags); If this patch is picked on its own for a stable kernel that only has 4e1a18bab124, it will not build. A backporter could add just the lock to get it building. timecounter_read() and timecounter_init() would still not take that lock, so the race would stay open. Other patches in the series list their stable prerequisites, for example "# prerequisite for the Rockchip restart/close fix". Would something like this work here? Cc: stable@vger.kernel.org # depends on "can: rockchip_canfd: prevent timestamp work from rearming after bus-off" -- Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20261119-rockchip-canfd-restart-close-v10-0-df23913aa33a%40qq.com From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 14209606A6BD for ; Sat, 21 Nov 2026 00:03:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=Dw73Q8mv; dkim=fail reason="signature verification failed" (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=W9rz7AwU DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Cc:To:From:Subject:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=ip/Yj6yqpJjpnEHxwP0KNjluTIqouPCdNJ/Cwk6eKjs=; b=Dw73Q8mv0WD1Ed7RRHY1LR3Tsq NSQPSnfyggs4K5YplERbCqbEYfFnvacdWVX22fpy8wvDRlwFGA1iEPrL6qlmdshuZ3IeBYEapDMaz qok13r8Y0jDoWFh3ksx3evyvs6vktQwcEBrPtq/80gGedvnzS52qbMOJasAdEZJtZXznlsMqAapv7 aBbBYNK2MZgad7YHRc2KO1DdBSA0zlIiQXKxpLRFwEYf8yzNwgodDRra9AEFJiu8DlLyyrphCVaID mTbP4Bs85CZnfVC0pED1IEqZFi6NQ0sdbk7ItWTU4SW3HuEXt+BZfYb8DoecWfmlmL9+u2AkfengW 54TSeZrg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xUYZK-0000000GStB-2hZd; Sat, 21 Nov 2026 00:03:02 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xUYYl-0000000GSdM-3uAP; Sat, 21 Nov 2026 00:02:28 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 9C8C5411C8; Sat, 21 Nov 2026 00:02:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 639661F000C6; Sat, 21 Nov 2026 00:02:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1795219347; bh=vVTWkhfLiH/QsLki+tG2g1OrDcp1ntC4ATOpIndsvv4=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=W9rz7AwUeMWreMrPywL+G/eoSE/ac2EveLkjzau1+l0PpgXWjbqzH2KWAYN5hxD/0 evRhjZHWufSyBIVEzlrjwmfIRXPIpt4QTk1ivutvkXBvV4bFQhJFI/26GRbX5pvHM3 EluX44uvrajwnxDAhlXrXaS9HMrM07H3/Ou6qQO3hPenvRQtCRv06l9uXteA/pLViA O/TGDLSTfnS2YI04Br/iLpk4mLydKXSfwv1M7WJajGUA6OHjBWCG6swUWr+dJKhQ0M WnI7u47mSRhMBbQggvz7GW8gE4F4+V8Q9YuTyV9In9Zwsf4s7HMXNClCq0SxgZhO/E eRAYjIXBkfH8A== Subject: Re: [PATCH net v10 10/10] can: rockchip_canfd: serialize timecounter timestamp conversion From: netdev-bot+sashiko@kernel.org To: 1579567540@qq.com Cc: mkl@pengutronix.de, kernel@pengutronix.de, mailhol@kernel.org, heiko@sntech.de, socketcan@hartkopp.net, davem@davemloft.net, edumazet@kernel.org, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, corbet@lwn.net, skhan@linuxfoundation.org, rdunlap@infradead.org, wg@grandegger.com, linux-can@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, stable@vger.kernel.org Date: Sat, 21 Nov 2026 00:02:25 +0000 Message-ID: <179521934595.3131.13988876249908602124@kernel.org> In-Reply-To: <20261119-rockchip-canfd-restart-close-v10-10-df23913aa33a@qq.com> References: <20261119-rockchip-canfd-restart-close-v10-10-df23913aa33a@qq.com> X-sashiko-severity: Low X-Archived-By: MIME-Version: 1.0 X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg bW9yZSBzZXZlcmUKaXNzdWUocykgaW4gb3RoZXIgcGF0Y2hlcyBvZiB0aGlzIHNlcmllcy4gVGhp cyBtYWlsIGlzIG9ubHkgYW4gRllJLCBpbiBjYXNlCnlvdSB3YW50IHRvIGFkZHJlc3MgdGhlIG5p dCBwaWNrcyBiZWxvdyB3aGVuIHlvdSByZXNwaW4uCgpMb3cgcHJpb3JpdHkgLyBuaXQgcGlja3Mg Zm9yIHlvdXIgY29uc2lkZXJhdGlvbjoKCi0gW0xvd10gVGhlIHBhdGNoIGlzIHRhZ2dlZCBgQ2M6 IHN0YWJsZUB2Z2VyLmtlcm5lbC5vcmdgIHdpdGggYEZpeGVzOgogIDRlMWExOGJhYjEyNCAoImNh bjogcm9ja2NoaXBfY2FuZmQ6IGFkZCBoYXJkd2FyZSB0aW1lc3RhbXBpbmfigKYKCi0tCgpjYW46 IHJvY2tjaGlwX2NhbmZkOiBzZXJpYWxpemUgdGltZWNvdW50ZXIgdGltZXN0YW1wIGNvbnZlcnNp b24KClRoaXMgY29tbWl0IGhvbGRzIHByaXYtPnRpbWVzdGFtcF9sb2NrIGFyb3VuZCB0aW1lY291 bnRlcl9jeWMydGltZSgpIGluCnJrY2FuZmRfc2tiX3NldF90aW1lc3RhbXAoKS4gVGhhdCBzZXJp YWxpemVzIHRoZSBSWCwgVFggY29tcGxldGlvbiBhbmQKZXJyb3ItZnJhbWUgdGltZXN0YW1wIGNv bnZlcnNpb24gYWdhaW5zdCB0aW1lY291bnRlcl9yZWFkKCkgaW4gdGhlCnRpbWVzdGFtcCB3b3Jr ZXIuIFRoZSBjb21tZW50IG9uIHRpbWVzdGFtcF9sb2NrIGluIHN0cnVjdCBya2NhbmZkX3ByaXYg aXMKYWxzbyBjaGFuZ2VkIHRvIHNheSBpdCBwcm90ZWN0cyB0YyBhbmQgdGltZXN0YW1wX2FjdGl2 ZS4KCj4gSG9sZCB0aW1lc3RhbXBfbG9jayBhY3Jvc3MgdGltZWNvdW50ZXJfY3ljMnRpbWUoKSwg dXNpbmcgdGhlIHNhbWUgbG9jawo+IGFzIHRpbWVjb3VudGVyX3JlYWQoKSBhbmQgdGltZWNvdW50 ZXJfaW5pdCgpLiBLZWVwIHRoZSBTS0IgdGltZXN0YW1wCj4gYXNzaWdubWVudCBvdXRzaWRlIHRo ZSBjcml0aWNhbCBzZWN0aW9uLgoKWyAuLi4gXQoKPiBGaXhlczogNGUxYTE4YmFiMTI0ICgiY2Fu OiByb2NrY2hpcF9jYW5mZDogYWRkIGhhcmR3YXJlIHRpbWVzdGFtcGluZyBzdXBwb3J0IikKPiBD Yzogc3RhYmxlQHZnZXIua2VybmVsLm9yZwoKW1NldmVyaXR5OiBMb3ddClNob3VsZCB0aGUgc3Rh YmxlIHRhZyBtZW50aW9uIHRoYXQgdGhpcyBkZXBlbmRzIG9uIHRoZSBlYXJsaWVyIHBhdGNoIGlu CnRoZSBzZXJpZXMsICJjYW46IHJvY2tjaGlwX2NhbmZkOiBwcmV2ZW50IHRpbWVzdGFtcCB3b3Jr IGZyb20gcmVhcm1pbmcKYWZ0ZXIgYnVzLW9mZiI/CgpUaGUgdGltZXN0YW1wX2xvY2sgYW5kIHRp bWVzdGFtcF9hY3RpdmUgbWVtYmVycyBvZiBzdHJ1Y3QgcmtjYW5mZF9wcml2IGFyZQpub3QgaW4g NGUxYTE4YmFiMTI0LiBUaGUgZWFybGllciBwYXRjaCBhZGRzIHRoZW0uIEl0IGFsc28gcHV0cwp0 aW1lY291bnRlcl9yZWFkKCkgaW4gcmtjYW5mZF90aW1lc3RhbXBfd29yaygpIGFuZCB0aW1lY291 bnRlcl9pbml0KCkgaW4KcmtjYW5mZF90aW1lc3RhbXBfc3RhcnQoKSB1bmRlciB0aGUgbG9jazoK CiAgICBzcGluX2xvY2tfaXJxc2F2ZSgmcHJpdi0+dGltZXN0YW1wX2xvY2ssIGZsYWdzKTsKICAg IGlmIChwcml2LT50aW1lc3RhbXBfYWN0aXZlKQogICAgICAgIHRpbWVjb3VudGVyX3JlYWQoJnBy aXYtPnRjKTsKICAgIHNwaW5fdW5sb2NrX2lycXJlc3RvcmUoJnByaXYtPnRpbWVzdGFtcF9sb2Nr LCBmbGFncyk7CgpJZiB0aGlzIHBhdGNoIGlzIHBpY2tlZCBvbiBpdHMgb3duIGZvciBhIHN0YWJs ZSBrZXJuZWwgdGhhdCBvbmx5IGhhcwo0ZTFhMThiYWIxMjQsIGl0IHdpbGwgbm90IGJ1aWxkLiBB IGJhY2twb3J0ZXIgY291bGQgYWRkIGp1c3QgdGhlIGxvY2sgdG8KZ2V0IGl0IGJ1aWxkaW5nLiB0 aW1lY291bnRlcl9yZWFkKCkgYW5kIHRpbWVjb3VudGVyX2luaXQoKSB3b3VsZCBzdGlsbApub3Qg dGFrZSB0aGF0IGxvY2ssIHNvIHRoZSByYWNlIHdvdWxkIHN0YXkgb3Blbi4KCk90aGVyIHBhdGNo ZXMgaW4gdGhlIHNlcmllcyBsaXN0IHRoZWlyIHN0YWJsZSBwcmVyZXF1aXNpdGVzLCBmb3IgZXhh bXBsZQoiIyBwcmVyZXF1aXNpdGUgZm9yIHRoZSBSb2NrY2hpcCByZXN0YXJ0L2Nsb3NlIGZpeCIu IFdvdWxkIHNvbWV0aGluZyBsaWtlCnRoaXMgd29yayBoZXJlPwoKICAgIENjOiBzdGFibGVAdmdl ci5rZXJuZWwub3JnICMgZGVwZW5kcyBvbiAiY2FuOiByb2NrY2hpcF9jYW5mZDogcHJldmVudCB0 aW1lc3RhbXAgd29yayBmcm9tIHJlYXJtaW5nIGFmdGVyIGJ1cy1vZmYiCgotLSAKU2FzaGlrbyBB SSByZXZpZXcgwrcgaHR0cHM6Ly9uZXRkZXYtYWkuYm90cy5saW51eC5kZXYvc2FzaGlrby8jL3Bh dGNoc2V0LzIwMjYxMTE5LXJvY2tjaGlwLWNhbmZkLXJlc3RhcnQtY2xvc2UtdjEwLTAtZGYyMzkx M2FhMzNhJTQwcXEuY29tCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpMaW51eC1yb2NrY2hpcCBtYWlsaW5nIGxpc3QKTGludXgtcm9ja2NoaXBAbGlzdHMu aW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2xpbnV4LXJvY2tjaGlwCg==