All of lore.kernel.org
 help / color / mirror / Atom feed
From: netdev-bot+sashiko@kernel.org
To: subash.a.kasiviswanathan@oss.qualcomm.com
Cc: sean.tranchetti@oss.qualcomm.com, andrew+netdev@lunn.ch,
	davem@davemloft.net, edumazet@kernel.org, kuba@kernel.org,
	pabeni@redhat.com, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v5 2/5] net: qualcomm: rmnet: Size the first device from the requested data format
Date: Sat, 21 Nov 2026 07:04:02 +0000	[thread overview]
Message-ID: <179524464231.3135.13518069516506821127@kernel.org> (raw)
In-Reply-To: <20261117060737.2764327-3-subash.a.kasiviswanathan@oss.qualcomm.com>

Thank you for your contribution! Sashiko AI review found more severe
issue(s) in other patches of this series. This mail is only an FYI, in case
you want to address the nit picks below when you respin.

Low priority / nit picks for your consideration:

- [Low] The commit message understates what the patch changes.

--

net: qualcomm: rmnet: Size the first device from the requested data format

This commit moves the IFLA_RMNET_FLAGS merge in rmnet_newlink() so it
runs before rmnet_vnd_newlink(), and passes the resulting data format
down. The new device's MTU is then computed from the egress headroom of
the requested format, not from the format already stored in the port.

> net: qualcomm: rmnet: Size the first device from the requested data format
>
> rmnet_newlink() sizes the first rmnet device from the data format
> currently stored in the port, before the requested IFLA_RMNET_FLAGS
> have been applied. The MTU therefore does not match the egress header
> overhead of the format which ends up being used.

[Severity: Low]
This isn't a bug, but is the "first device" wording narrower than what
the patch does?

The reordering in rmnet_newlink() in
drivers/net/ethernet/qualcomm/rmnet/rmnet_config.c is not limited to the
case where port->nr_rmnet_devs == 0. Every newlink now merges
IFLA_RMNET_FLAGS into the local data_format first, then sizes its device
from it:

	err = rmnet_vnd_newlink(mux_id, dev, port, real_dev, ep, extack,
				data_format);

Before this patch, a second or later device on the same real_dev got its
initial MTU from the port-wide format left by the previous newlink.

After this patch, that device is sized from its own requested flags. If
no flags are given, it is sized from RMNET_FLAGS_INGRESS_DEAGGREGATION
alone. Its default MTU can therefore differ by the size of the checksum
header (no checksum vs CKSUMV4/V5).

The message also doesn't say that port->data_format is a single setting
for the whole port, and that every newlink overwrites it.

Could the subject and body say that every device created through
rmnet_newlink() is affected, not only the first one?

-- 
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20261117060737.2764327-1-subash.a.kasiviswanathan%40oss.qualcomm.com

  reply	other threads:[~2026-11-21  7:04 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17  6:07 [PATCH net v5 0/5] net: qualcomm: rmnet: Update MTU handling during format changes Subash Abhinov Kasiviswanathan
2026-11-17  6:07 ` [PATCH net v5 1/5] net: qualcomm: rmnet: Account for V5 checksum header in headroom Subash Abhinov Kasiviswanathan
2026-11-17  6:07 ` [PATCH net v5 2/5] net: qualcomm: rmnet: Size the first device from the requested data format Subash Abhinov Kasiviswanathan
2026-11-21  7:04   ` netdev-bot+sashiko [this message]
2026-11-17  6:07 ` [PATCH net v5 3/5] net: qualcomm: rmnet: Fix MTU underflow and clamp to the maximum packet size Subash Abhinov Kasiviswanathan
2026-11-21  7:04   ` netdev-bot+sashiko
2026-11-17  6:07 ` [PATCH net v5 4/5] net: qualcomm: rmnet: Publish data format and mux_id only after the MTU update Subash Abhinov Kasiviswanathan
2026-11-17  6:07 ` [PATCH net v5 5/5] net: qualcomm: rmnet: Resize endpoints with dev_set_mtu() and restore on failure Subash Abhinov Kasiviswanathan
2026-11-21  7:04   ` netdev-bot+sashiko
2026-11-21 15:51     ` subash.a.kasiviswanathan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=179524464231.3135.13518069516506821127@kernel.org \
    --to=netdev-bot+sashiko@kernel.org \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=sean.tranchetti@oss.qualcomm.com \
    --cc=subash.a.kasiviswanathan@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.