From mboxrd@z Thu Jan 1 00:00:00 1970 From: laurent.pinchart@ideasonboard.com (Laurent Pinchart) Date: Tue, 09 Jan 2018 14:29:58 +0200 Subject: [PATCH 01/19] drm/fourcc: Add a function to tell if the format embeds alpha In-Reply-To: References: Message-ID: <1796930.sWoKI78acY@avalon> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Maxime, Thank you for the patch. On Tuesday, 9 January 2018 12:56:20 EET Maxime Ripard wrote: > There's a bunch of drivers that duplicate the same function to know if a > particular format embeds an alpha component or not. > > Let's create a helper to avoid duplicating that logic. > > Cc: Boris Brezillon > Cc: Eric Anholt > Cc: Inki Dae > Cc: Joonyoung Shim > Cc: Kyungmin Park > Cc: Laurent Pinchart > Cc: Mark Yao > Cc: Seung-Woo Kim > Signed-off-by: Maxime Ripard > --- > drivers/gpu/drm/drm_fourcc.c | 43 +++++++++++++++++++++++++++++++++++++- > include/drm/drm_fourcc.h | 1 +- > 2 files changed, 44 insertions(+) > > diff --git a/drivers/gpu/drm/drm_fourcc.c b/drivers/gpu/drm/drm_fourcc.c > index 9c0152df45ad..6e6227d6a46b 100644 > --- a/drivers/gpu/drm/drm_fourcc.c > +++ b/drivers/gpu/drm/drm_fourcc.c > @@ -348,3 +348,46 @@ int drm_format_plane_height(int height, uint32_t > format, int plane) return height / info->vsub; > } > EXPORT_SYMBOL(drm_format_plane_height); > + > +/** > + * drm_format_has_alpha - get whether the format embeds an alpha component > + * @format: pixel format (DRM_FORMAT_*) > + * > + * Returns: > + * true if the format embeds an alpha component, false otherwise. > + */ > +bool drm_format_has_alpha(uint32_t format) > +{ > + switch (format) { > + case DRM_FORMAT_ARGB4444: > + case DRM_FORMAT_ABGR4444: > + case DRM_FORMAT_RGBA4444: > + case DRM_FORMAT_BGRA4444: > + case DRM_FORMAT_ARGB1555: > + case DRM_FORMAT_ABGR1555: > + case DRM_FORMAT_RGBA5551: > + case DRM_FORMAT_BGRA5551: > + case DRM_FORMAT_ARGB8888: > + case DRM_FORMAT_ABGR8888: > + case DRM_FORMAT_RGBA8888: > + case DRM_FORMAT_BGRA8888: > + case DRM_FORMAT_ARGB2101010: > + case DRM_FORMAT_ABGR2101010: > + case DRM_FORMAT_RGBA1010102: > + case DRM_FORMAT_BGRA1010102: > + case DRM_FORMAT_AYUV: > + case DRM_FORMAT_XRGB8888_A8: > + case DRM_FORMAT_XBGR8888_A8: > + case DRM_FORMAT_RGBX8888_A8: > + case DRM_FORMAT_BGRX8888_A8: > + case DRM_FORMAT_RGB888_A8: > + case DRM_FORMAT_BGR888_A8: > + case DRM_FORMAT_RGB565_A8: > + case DRM_FORMAT_BGR565_A8: > + return true; > + > + default: > + return false; > + } > +} > +EXPORT_SYMBOL(drm_format_has_alpha); How about adding the information to struct drm_format_info instead ? drm_format_has_alpha() could then be implemented as bool drm_format_has_alpha(uint32_t format) { const struct drm_format_info *info; info = drm_format_info(format); return info ? info->has_alpha : false; } although drivers should really use the drm_framebuffer::format field directly in most cases, so the helper might not be needed at all. > diff --git a/include/drm/drm_fourcc.h b/include/drm/drm_fourcc.h > index 6942e84b6edd..e08fc22c5f78 100644 > --- a/include/drm/drm_fourcc.h > +++ b/include/drm/drm_fourcc.h > @@ -69,5 +69,6 @@ int drm_format_vert_chroma_subsampling(uint32_t format); > int drm_format_plane_width(int width, uint32_t format, int plane); > int drm_format_plane_height(int height, uint32_t format, int plane); > const char *drm_get_format_name(uint32_t format, struct drm_format_name_buf > *buf); > +bool drm_format_has_alpha(uint32_t format); > > #endif /* __DRM_FOURCC_H__ */ -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH 01/19] drm/fourcc: Add a function to tell if the format embeds alpha Date: Tue, 09 Jan 2018 14:29:58 +0200 Message-ID: <1796930.sWoKI78acY@avalon> References: Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from galahad.ideasonboard.com (galahad.ideasonboard.com [IPv6:2001:4b98:dc2:45:216:3eff:febb:480d]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0294E6E0A4 for ; Tue, 9 Jan 2018 12:29:28 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org Cc: Thomas Petazzoni , Boris Brezillon , Seung-Woo Kim , linux-kernel@vger.kernel.org, Kyungmin Park , Chen-Yu Tsai , Daniel Vetter , Maxime Ripard , thomas@vitsch.nl, linux-arm-kernel@lists.infradead.org, Mark Yao List-Id: dri-devel@lists.freedesktop.org SGkgTWF4aW1lLAoKVGhhbmsgeW91IGZvciB0aGUgcGF0Y2guCgpPbiBUdWVzZGF5LCA5IEphbnVh cnkgMjAxOCAxMjo1NjoyMCBFRVQgTWF4aW1lIFJpcGFyZCB3cm90ZToKPiBUaGVyZSdzIGEgYnVu Y2ggb2YgZHJpdmVycyB0aGF0IGR1cGxpY2F0ZSB0aGUgc2FtZSBmdW5jdGlvbiB0byBrbm93IGlm IGEKPiBwYXJ0aWN1bGFyIGZvcm1hdCBlbWJlZHMgYW4gYWxwaGEgY29tcG9uZW50IG9yIG5vdC4K PiAKPiBMZXQncyBjcmVhdGUgYSBoZWxwZXIgdG8gYXZvaWQgZHVwbGljYXRpbmcgdGhhdCBsb2dp Yy4KPiAKPiBDYzogQm9yaXMgQnJlemlsbG9uIDxib3Jpcy5icmV6aWxsb25AZnJlZS1lbGVjdHJv bnMuY29tPgo+IENjOiBFcmljIEFuaG9sdCA8ZXJpY0BhbmhvbHQubmV0Pgo+IENjOiBJbmtpIERh ZSA8aW5raS5kYWVAc2Ftc3VuZy5jb20+Cj4gQ2M6IEpvb255b3VuZyBTaGltIDxqeTA5MjIuc2hp bUBzYW1zdW5nLmNvbT4KPiBDYzogS3l1bmdtaW4gUGFyayA8a3l1bmdtaW4ucGFya0BzYW1zdW5n LmNvbT4KPiBDYzogTGF1cmVudCBQaW5jaGFydCA8bGF1cmVudC5waW5jaGFydEBpZGVhc29uYm9h cmQuY29tPgo+IENjOiBNYXJrIFlhbyA8bWFyay55YW9Acm9jay1jaGlwcy5jb20+Cj4gQ2M6IFNl dW5nLVdvbyBLaW0gPHN3MDMxMi5raW1Ac2Ftc3VuZy5jb20+Cj4gU2lnbmVkLW9mZi1ieTogTWF4 aW1lIFJpcGFyZCA8bWF4aW1lLnJpcGFyZEBmcmVlLWVsZWN0cm9ucy5jb20+Cj4gLS0tCj4gIGRy aXZlcnMvZ3B1L2RybS9kcm1fZm91cmNjLmMgfCA0MyArKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrLQo+ICBpbmNsdWRlL2RybS9kcm1fZm91cmNjLmggICAgIHwgIDEgKy0KPiAg MiBmaWxlcyBjaGFuZ2VkLCA0NCBpbnNlcnRpb25zKCspCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZl cnMvZ3B1L2RybS9kcm1fZm91cmNjLmMgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2ZvdXJjYy5jCj4g aW5kZXggOWMwMTUyZGY0NWFkLi42ZTYyMjdkNmE0NmIgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9n cHUvZHJtL2RybV9mb3VyY2MuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fZm91cmNjLmMK PiBAQCAtMzQ4LDMgKzM0OCw0NiBAQCBpbnQgZHJtX2Zvcm1hdF9wbGFuZV9oZWlnaHQoaW50IGhl aWdodCwgdWludDMyX3QKPiBmb3JtYXQsIGludCBwbGFuZSkgcmV0dXJuIGhlaWdodCAvIGluZm8t PnZzdWI7Cj4gIH0KPiAgRVhQT1JUX1NZTUJPTChkcm1fZm9ybWF0X3BsYW5lX2hlaWdodCk7Cj4g Kwo+ICsvKioKPiArICogZHJtX2Zvcm1hdF9oYXNfYWxwaGEgLSBnZXQgd2hldGhlciB0aGUgZm9y bWF0IGVtYmVkcyBhbiBhbHBoYSBjb21wb25lbnQKPiArICogQGZvcm1hdDogcGl4ZWwgZm9ybWF0 IChEUk1fRk9STUFUXyopCj4gKyAqCj4gKyAqIFJldHVybnM6Cj4gKyAqIHRydWUgaWYgdGhlIGZv cm1hdCBlbWJlZHMgYW4gYWxwaGEgY29tcG9uZW50LCBmYWxzZSBvdGhlcndpc2UuCj4gKyAqLwo+ ICtib29sIGRybV9mb3JtYXRfaGFzX2FscGhhKHVpbnQzMl90IGZvcm1hdCkKPiArewo+ICsJc3dp dGNoIChmb3JtYXQpIHsKPiArCWNhc2UgRFJNX0ZPUk1BVF9BUkdCNDQ0NDoKPiArCWNhc2UgRFJN X0ZPUk1BVF9BQkdSNDQ0NDoKPiArCWNhc2UgRFJNX0ZPUk1BVF9SR0JBNDQ0NDoKPiArCWNhc2Ug RFJNX0ZPUk1BVF9CR1JBNDQ0NDoKPiArCWNhc2UgRFJNX0ZPUk1BVF9BUkdCMTU1NToKPiArCWNh c2UgRFJNX0ZPUk1BVF9BQkdSMTU1NToKPiArCWNhc2UgRFJNX0ZPUk1BVF9SR0JBNTU1MToKPiAr CWNhc2UgRFJNX0ZPUk1BVF9CR1JBNTU1MToKPiArCWNhc2UgRFJNX0ZPUk1BVF9BUkdCODg4ODoK PiArCWNhc2UgRFJNX0ZPUk1BVF9BQkdSODg4ODoKPiArCWNhc2UgRFJNX0ZPUk1BVF9SR0JBODg4 ODoKPiArCWNhc2UgRFJNX0ZPUk1BVF9CR1JBODg4ODoKPiArCWNhc2UgRFJNX0ZPUk1BVF9BUkdC MjEwMTAxMDoKPiArCWNhc2UgRFJNX0ZPUk1BVF9BQkdSMjEwMTAxMDoKPiArCWNhc2UgRFJNX0ZP Uk1BVF9SR0JBMTAxMDEwMjoKPiArCWNhc2UgRFJNX0ZPUk1BVF9CR1JBMTAxMDEwMjoKPiArCWNh c2UgRFJNX0ZPUk1BVF9BWVVWOgo+ICsJY2FzZSBEUk1fRk9STUFUX1hSR0I4ODg4X0E4Ogo+ICsJ Y2FzZSBEUk1fRk9STUFUX1hCR1I4ODg4X0E4Ogo+ICsJY2FzZSBEUk1fRk9STUFUX1JHQlg4ODg4 X0E4Ogo+ICsJY2FzZSBEUk1fRk9STUFUX0JHUlg4ODg4X0E4Ogo+ICsJY2FzZSBEUk1fRk9STUFU X1JHQjg4OF9BODoKPiArCWNhc2UgRFJNX0ZPUk1BVF9CR1I4ODhfQTg6Cj4gKwljYXNlIERSTV9G T1JNQVRfUkdCNTY1X0E4Ogo+ICsJY2FzZSBEUk1fRk9STUFUX0JHUjU2NV9BODoKPiArCQlyZXR1 cm4gdHJ1ZTsKPiArCj4gKwlkZWZhdWx0Ogo+ICsJCXJldHVybiBmYWxzZTsKPiArCX0KPiArfQo+ ICtFWFBPUlRfU1lNQk9MKGRybV9mb3JtYXRfaGFzX2FscGhhKTsKCkhvdyBhYm91dCBhZGRpbmcg dGhlIGluZm9ybWF0aW9uIHRvIHN0cnVjdCBkcm1fZm9ybWF0X2luZm8gaW5zdGVhZCA/IApkcm1f Zm9ybWF0X2hhc19hbHBoYSgpIGNvdWxkIHRoZW4gYmUgaW1wbGVtZW50ZWQgYXMKCmJvb2wgZHJt X2Zvcm1hdF9oYXNfYWxwaGEodWludDMyX3QgZm9ybWF0KQp7Cgljb25zdCBzdHJ1Y3QgZHJtX2Zv cm1hdF9pbmZvICppbmZvOwoKCWluZm8gPSBkcm1fZm9ybWF0X2luZm8oZm9ybWF0KTsKCXJldHVy biBpbmZvID8gaW5mby0+aGFzX2FscGhhIDogZmFsc2U7Cn0KCmFsdGhvdWdoIGRyaXZlcnMgc2hv dWxkIHJlYWxseSB1c2UgdGhlIGRybV9mcmFtZWJ1ZmZlcjo6Zm9ybWF0IGZpZWxkIGRpcmVjdGx5 IAppbiBtb3N0IGNhc2VzLCBzbyB0aGUgaGVscGVyIG1pZ2h0IG5vdCBiZSBuZWVkZWQgYXQgYWxs LgoKPiBkaWZmIC0tZ2l0IGEvaW5jbHVkZS9kcm0vZHJtX2ZvdXJjYy5oIGIvaW5jbHVkZS9kcm0v ZHJtX2ZvdXJjYy5oCj4gaW5kZXggNjk0MmU4NGI2ZWRkLi5lMDhmYzIyYzVmNzggMTAwNjQ0Cj4g LS0tIGEvaW5jbHVkZS9kcm0vZHJtX2ZvdXJjYy5oCj4gKysrIGIvaW5jbHVkZS9kcm0vZHJtX2Zv dXJjYy5oCj4gQEAgLTY5LDUgKzY5LDYgQEAgaW50IGRybV9mb3JtYXRfdmVydF9jaHJvbWFfc3Vi c2FtcGxpbmcodWludDMyX3QgZm9ybWF0KTsKPiAgaW50IGRybV9mb3JtYXRfcGxhbmVfd2lkdGgo aW50IHdpZHRoLCB1aW50MzJfdCBmb3JtYXQsIGludCBwbGFuZSk7Cj4gIGludCBkcm1fZm9ybWF0 X3BsYW5lX2hlaWdodChpbnQgaGVpZ2h0LCB1aW50MzJfdCBmb3JtYXQsIGludCBwbGFuZSk7Cj4g IGNvbnN0IGNoYXIgKmRybV9nZXRfZm9ybWF0X25hbWUodWludDMyX3QgZm9ybWF0LCBzdHJ1Y3Qg ZHJtX2Zvcm1hdF9uYW1lX2J1Zgo+ICpidWYpOwo+ICtib29sIGRybV9mb3JtYXRfaGFzX2FscGhh KHVpbnQzMl90IGZvcm1hdCk7Cj4gCj4gICNlbmRpZiAvKiBfX0RSTV9GT1VSQ0NfSF9fICovCgot LSAKUmVnYXJkcywKCkxhdXJlbnQgUGluY2hhcnQKCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxp c3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752488AbeAIM3b (ORCPT + 1 other); Tue, 9 Jan 2018 07:29:31 -0500 Received: from galahad.ideasonboard.com ([185.26.127.97]:56159 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755518AbeAIM32 (ORCPT ); Tue, 9 Jan 2018 07:29:28 -0500 From: Laurent Pinchart To: dri-devel@lists.freedesktop.org Cc: Maxime Ripard , Chen-Yu Tsai , Daniel Vetter , Jani Nikula , Sean Paul , Thomas Petazzoni , Boris Brezillon , Seung-Woo Kim , linux-kernel@vger.kernel.org, Kyungmin Park , Mark Yao , linux-arm-kernel@lists.infradead.org, thomas@vitsch.nl Subject: Re: [PATCH 01/19] drm/fourcc: Add a function to tell if the format embeds alpha Date: Tue, 09 Jan 2018 14:29:58 +0200 Message-ID: <1796930.sWoKI78acY@avalon> Organization: Ideas on Board Oy In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: Hi Maxime, Thank you for the patch. On Tuesday, 9 January 2018 12:56:20 EET Maxime Ripard wrote: > There's a bunch of drivers that duplicate the same function to know if a > particular format embeds an alpha component or not. > > Let's create a helper to avoid duplicating that logic. > > Cc: Boris Brezillon > Cc: Eric Anholt > Cc: Inki Dae > Cc: Joonyoung Shim > Cc: Kyungmin Park > Cc: Laurent Pinchart > Cc: Mark Yao > Cc: Seung-Woo Kim > Signed-off-by: Maxime Ripard > --- > drivers/gpu/drm/drm_fourcc.c | 43 +++++++++++++++++++++++++++++++++++++- > include/drm/drm_fourcc.h | 1 +- > 2 files changed, 44 insertions(+) > > diff --git a/drivers/gpu/drm/drm_fourcc.c b/drivers/gpu/drm/drm_fourcc.c > index 9c0152df45ad..6e6227d6a46b 100644 > --- a/drivers/gpu/drm/drm_fourcc.c > +++ b/drivers/gpu/drm/drm_fourcc.c > @@ -348,3 +348,46 @@ int drm_format_plane_height(int height, uint32_t > format, int plane) return height / info->vsub; > } > EXPORT_SYMBOL(drm_format_plane_height); > + > +/** > + * drm_format_has_alpha - get whether the format embeds an alpha component > + * @format: pixel format (DRM_FORMAT_*) > + * > + * Returns: > + * true if the format embeds an alpha component, false otherwise. > + */ > +bool drm_format_has_alpha(uint32_t format) > +{ > + switch (format) { > + case DRM_FORMAT_ARGB4444: > + case DRM_FORMAT_ABGR4444: > + case DRM_FORMAT_RGBA4444: > + case DRM_FORMAT_BGRA4444: > + case DRM_FORMAT_ARGB1555: > + case DRM_FORMAT_ABGR1555: > + case DRM_FORMAT_RGBA5551: > + case DRM_FORMAT_BGRA5551: > + case DRM_FORMAT_ARGB8888: > + case DRM_FORMAT_ABGR8888: > + case DRM_FORMAT_RGBA8888: > + case DRM_FORMAT_BGRA8888: > + case DRM_FORMAT_ARGB2101010: > + case DRM_FORMAT_ABGR2101010: > + case DRM_FORMAT_RGBA1010102: > + case DRM_FORMAT_BGRA1010102: > + case DRM_FORMAT_AYUV: > + case DRM_FORMAT_XRGB8888_A8: > + case DRM_FORMAT_XBGR8888_A8: > + case DRM_FORMAT_RGBX8888_A8: > + case DRM_FORMAT_BGRX8888_A8: > + case DRM_FORMAT_RGB888_A8: > + case DRM_FORMAT_BGR888_A8: > + case DRM_FORMAT_RGB565_A8: > + case DRM_FORMAT_BGR565_A8: > + return true; > + > + default: > + return false; > + } > +} > +EXPORT_SYMBOL(drm_format_has_alpha); How about adding the information to struct drm_format_info instead ? drm_format_has_alpha() could then be implemented as bool drm_format_has_alpha(uint32_t format) { const struct drm_format_info *info; info = drm_format_info(format); return info ? info->has_alpha : false; } although drivers should really use the drm_framebuffer::format field directly in most cases, so the helper might not be needed at all. > diff --git a/include/drm/drm_fourcc.h b/include/drm/drm_fourcc.h > index 6942e84b6edd..e08fc22c5f78 100644 > --- a/include/drm/drm_fourcc.h > +++ b/include/drm/drm_fourcc.h > @@ -69,5 +69,6 @@ int drm_format_vert_chroma_subsampling(uint32_t format); > int drm_format_plane_width(int width, uint32_t format, int plane); > int drm_format_plane_height(int height, uint32_t format, int plane); > const char *drm_get_format_name(uint32_t format, struct drm_format_name_buf > *buf); > +bool drm_format_has_alpha(uint32_t format); > > #endif /* __DRM_FOURCC_H__ */ -- Regards, Laurent Pinchart