Re: Re: [perf PATCH] Use pclose() instead of fclose() on pipe stream

[Thomas Jarosch <thomas.jarosch@intra2net.com>]

Hi Arnaldo,

On Friday, 11. January 2013 01:16:03 you wrote:
> > Also fix descriptor leak on error
> > 
> > Signed-off-by: Thomas Jarosch <thomas.jarosch@intra2net.com>
> > ---
> > 
> >  tools/perf/util/sort.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> After applying this:
> 
>     CC /home/acme/git/build/perf/util/cpumap.o
> cc1: warnings being treated as errors
> util/sort.c: In function ‘hist_entry__srcline_snprintf’:
> util/sort.c:254: error: ‘fp’ may be used uninitialized in this function
> make: *** [/home/acme/git/build/perf/util/sort.o] Error 1

Alright, looks like I've messed up the "early" error path.
The "FILE *fp" pointer needs to be initialized to NULL.

Should I send another patch or do you want to fix it on the fly?

What about the other patch
"[perf PATCH] Fix possible (unlikely) buffer overflow"

?

Cheers,
Thomas