From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Tahhan, Maryam" <maryam.tahhan@intel.com>
Cc: dev@dpdk.org, "Nemeth, Balazs" <balazs.nemeth@intel.com>
Subject: Re: [PATCH v2 1/1] ixgbe: Fix phy errors in stats->ierrors
Date: Thu, 23 Jul 2015 15:00:21 +0200 [thread overview]
Message-ID: <1798990.EYfMvRFpM3@xps13> (raw)
In-Reply-To: <86228AFD5BCD8E4EBFD2B90117B5E81E10E67623@SHSMSX103.ccr.corp.intel.com>
> > > Fixes: f6bf669b990004dc69231476d9fcf0b80574e568. Bug fix to remove
> > > (rxnfgpc - hw_stats->gprc) which does not account for phy errors.
> > > hw_stats->gprc is the Number of good (non-erred) Rx packets (from the
> > > network) that pass L2 filtering and has a legal length as defined by
> > > LongPacketEnable. While rxnfgpc is the Number of good (non-erred with
> > legal
> > > length) Rx packets (from the network) regardless of packet filtering and
> > receive
> > > enablement. Thus hw_stats->gprc can be > rxnfgpc and this calculation
> > should
> > > be removed from the calculation of ierrors.
> > > Validated with testpmd by sending packets to the interface without
> > forwarding
> > > enabled - packets should be dropped and the error counters incremented.
> > >
> > > v2:
> > > - specified the commit that this bug fix fixes.
> > >
> > > Signed-off-by: Maryam Tahhan <maryam.tahhan@intel.com>
> > Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
> Tested-by: Marvin Liu <yong.liu@intel.com>
Applied, thanks
prev parent reply other threads:[~2015-07-23 13:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-20 12:28 [PATCH v2 1/1] ixgbe: Fix phy errors in stats->ierrors Maryam Tahhan
2015-07-20 12:48 ` Balazs Nemeth
2015-07-21 5:41 ` Lu, Wenzhuo
2015-07-21 12:41 ` Liu, Yong
2015-07-23 13:00 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1798990.EYfMvRFpM3@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=balazs.nemeth@intel.com \
--cc=dev@dpdk.org \
--cc=maryam.tahhan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.