From: Bruno Haible <bruno@clisp.org>
To: linux-man@vger.kernel.org, Alejandro Colomar <alx@kernel.org>
Subject: Re: [PATCH v3 1/2] man/man3/strto[u]l.3: BUGS: Signed numbers and white space are not rejected
Date: Sun, 23 Mar 2025 11:27:53 +0100 [thread overview]
Message-ID: <1799725.K4a6FZZPjd@nimes> (raw)
In-Reply-To: <3c456a1a01d34385e7c92e5847fc8a22f4b48460.1742689797.git.alx@kernel.org>
Thanks for theses BUGS sections, Alejandro.
> +.SS White space
> +These functions silently accept leading white space.
> +One should call
> +.BR isspace (3)
> +before
> +.BR strtol ()
> +to reject white space.
Just a question of wording, but it would be more straightforward to read
when written like this:
+.SS White space
+These functions silently accept leading white space.
+In situations where rejecting white space is desired instead, call
+.BR isspace (3)
+before
+.BR strtol ().
(As usual, presenting the "why" and "what" before the "how" is nicer. [1])
> +One should call
> +.BR isalnum (3)
> +before
> +.BR strtoul ()
> +to reject white space and/or a sign.
Likewise here. It is more straightforward when written like this:
+To reject white space and/or a sign, call
+.BR isalnum (3)
+before
+.BR strtoul ().
Bruno
[1] https://gitlab.com/ghwiki/gnow-how/-/wikis/Documentation/Writing
next prev parent reply other threads:[~2025-03-23 10:28 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-21 20:41 [PATCH v1] man/man3/strtoul.3: BUGS: Signed numbers are not rejected Alejandro Colomar
2025-03-21 21:31 ` Bruno Haible
2025-03-21 22:21 ` Alejandro Colomar
2025-03-21 22:18 ` [PATCH v2 0/2] strto[u]l(3) BUGS and CAVEATS Alejandro Colomar
2025-03-21 22:18 ` [PATCH v2 1/2] man/man3/strto[u]l.3: BUGS: Signed numbers and white space are not rejected Alejandro Colomar
2025-03-21 22:18 ` [PATCH v2 2/2] man/man3/strtol.3: CAVEATS: Clarify how to perform range checks Alejandro Colomar
2025-03-23 0:30 ` [PATCH v3 0/2] strto[u]l.3: BUGS and CAVEATS Alejandro Colomar
2025-03-23 0:30 ` [PATCH v3 1/2] man/man3/strto[u]l.3: BUGS: Signed numbers and white space are not rejected Alejandro Colomar
2025-03-23 10:27 ` Bruno Haible [this message]
2025-03-23 11:15 ` Alejandro Colomar
2025-03-23 0:30 ` [PATCH v3 2/2] man/man3/strtol.3: CAVEATS: Clarify how to perform range checks Alejandro Colomar
2025-03-23 11:43 ` [PATCH v4 0/2] strto[u]l.3: BUGS and CAVEATS Alejandro Colomar
2025-03-23 11:43 ` [PATCH v4 1/2] man/man3/strto[u]l.3: BUGS: Signed numbers and white space are not rejected Alejandro Colomar
2025-03-23 13:20 ` Bruno Haible
2025-03-23 14:00 ` Alejandro Colomar
2025-03-23 15:52 ` Bruno Haible
2025-03-23 16:55 ` Alejandro Colomar
2025-03-23 17:03 ` Alejandro Colomar
2025-03-23 17:11 ` Bruno Haible
2025-03-23 18:35 ` Alejandro Colomar
2025-03-23 18:55 ` Alejandro Colomar
2025-03-23 19:26 ` Bruno Haible
2025-03-23 19:47 ` Alejandro Colomar
2025-03-23 11:43 ` [PATCH v4 2/2] man/man3/strtol.3: CAVEATS: Clarify how to perform range checks Alejandro Colomar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1799725.K4a6FZZPjd@nimes \
--to=bruno@clisp.org \
--cc=alx@kernel.org \
--cc=linux-man@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.