From mboxrd@z Thu Jan  1 00:00:00 1970
From: Akio Takebe <takebe_akio@jp.fujitsu.com>
Subject: [Patch] fix checking strtab length in xc_core.c
Date: Mon, 10 Sep 2007 21:16:23 +0900
Message-ID: <17C7F3A466F613takebe_akio@jp.fujitsu.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="Boundary-dsqGrYHIRCIa2CHazMnSj"
Return-path: <xen-devel-bounces@lists.xensource.com>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: xen-devel <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

--Boundary-dsqGrYHIRCIa2CHazMnSj
Content-Type: text/plain; charset=iso-2022-jp
Content-Transfer-Encoding: 7bit
Content-Description: Mail message body

Hi,

I don't understard the meaning of the following check in xc_core.c.
Is this correct patch?

Signed-off-by: Akio Takebe <takebe_akio@jp.fujitsu.com>

diff -r 9071521d4864 tools/libxc/xc_core.c
--- a/tools/libxc/xc_core.c	Fri Sep 07 11:39:10 2007 +0100
+++ b/tools/libxc/xc_core.c	Tue Sep 11 06:13:55 2007 +0900
@@ -107,7 +107,7 @@ xc_core_strtab_get(struct xc_core_strtab
     if ( strtab->current + len > strtab->max )
     {
         char *tmp;
-        if ( strtab->max * 2 < strtab->max )
+        if ( strtab->current + len > strtab->max * 2 )
         {
             PERROR("too long string table");
             errno = ENOMEM;

Best Regards,

Akio Takebe
--Boundary-dsqGrYHIRCIa2CHazMnSj
Content-Type: application/octet-stream;
 name="fix_xc_core_strtab_len.patch"
Content-Disposition: attachment;
 filename="fix_xc_core_strtab_len.patch"
Content-Transfer-Encoding: base64

ZGlmZiAtciA5MDcxNTIxZDQ4NjQgdG9vbHMvbGlieGMveGNfY29yZS5jCi0tLSBhL3Rvb2xz
L2xpYnhjL3hjX2NvcmUuYwlGcmkgU2VwIDA3IDExOjM5OjEwIDIwMDcgKzAxMDAKKysrIGIv
dG9vbHMvbGlieGMveGNfY29yZS5jCVR1ZSBTZXAgMTEgMDY6MTM6NTUgMjAwNyArMDkwMApA
QCAtMTA3LDcgKzEwNyw3IEBAIHhjX2NvcmVfc3RydGFiX2dldChzdHJ1Y3QgeGNfY29yZV9z
dHJ0YWIKICAgICBpZiAoIHN0cnRhYi0+Y3VycmVudCArIGxlbiA+IHN0cnRhYi0+bWF4ICkK
ICAgICB7CiAgICAgICAgIGNoYXIgKnRtcDsKLSAgICAgICAgaWYgKCBzdHJ0YWItPm1heCAq
IDIgPCBzdHJ0YWItPm1heCApCisgICAgICAgIGlmICggc3RydGFiLT5jdXJyZW50ICsgbGVu
ID4gc3RydGFiLT5tYXggKiAyICkKICAgICAgICAgewogICAgICAgICAgICAgUEVSUk9SKCJ0
b28gbG9uZyBzdHJpbmcgdGFibGUiKTsKICAgICAgICAgICAgIGVycm5vID0gRU5PTUVNOwo=

--Boundary-dsqGrYHIRCIa2CHazMnSj
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

--Boundary-dsqGrYHIRCIa2CHazMnSj--