From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, PDS_BAD_THREAD_QP_64,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8F05C48BCF for ; Sat, 12 Jun 2021 14:44:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B465D613AD for ; Sat, 12 Jun 2021 14:44:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231380AbhFLOqb (ORCPT ); Sat, 12 Jun 2021 10:46:31 -0400 Received: from so254-9.mailgun.net ([198.61.254.9]:40212 "EHLO so254-9.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231165AbhFLOqa (ORCPT ); Sat, 12 Jun 2021 10:46:30 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1623509070; h=Content-Transfer-Encoding: Content-Type: MIME-Version: Message-ID: Date: Subject: In-Reply-To: References: Cc: To: From: Reply-To: Sender; bh=RhtvN2QTW0JZFH6Rjd3vbX9yOl+YFdfv0SB17b2868c=; b=eHQjgFG3YEl+bYnfVmZWGTf+2DhM9d0MLqbdvNN7JhKtxnubR7IcusMz6ejwHzJgw4z6+CWp CZbsNOe+VnG1R793sEjgpyxj7Vrd0E2BzRXlJ8iCR5nPrXlmad8Ly2T7ykXjZkr47is9Yk+d UkyzG5zTsyYrpnOLunYpTxvfeuM= X-Mailgun-Sending-Ip: 198.61.254.9 X-Mailgun-Sid: WyIyMzg3MiIsICJsaW51eC1idHJmc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n06.prod.us-west-2.postgun.com with SMTP id 60c4c838ed59bf69ccbbf388 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Sat, 12 Jun 2021 14:44:08 GMT Sender: bcain=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id BFE3EC4323A; Sat, 12 Jun 2021 14:44:07 +0000 (UTC) Received: from BCAIN (104-54-226-75.lightspeed.austtx.sbcglobal.net [104.54.226.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bcain) by smtp.codeaurora.org (Postfix) with ESMTPSA id EAC33C433D3; Sat, 12 Jun 2021 14:44:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org EAC33C433D3 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=bcain@codeaurora.org Reply-To: From: "Brian Cain" To: "'Christophe Leroy'" , "'Chris Mason'" Cc: "'Josef Bacik'" , "'David Sterba'" , , , "'linux-btrfs'" , References: <185278AF-1D87-432D-87E9-C86B3223113E@fb.com> In-Reply-To: Subject: RE: [PATCH] btrfs: Disable BTRFS on platforms having 256K pages Date: Sat, 12 Jun 2021 09:44:05 -0500 Message-ID: <17a401d75f99$662cdc50$328694f0$@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Microsoft Outlook 16.0 Content-Language: en-us Thread-Index: AQFXZSsKSQYV21VAkXhEQlQXq32SZQKLFB0ZAuYFiEqr5N8nYA== Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org > -----Original Message----- > From: Christophe Leroy ... > Le 10/06/2021 =C3=A0 15:54, Chris Mason a =C3=A9crit : > > > >> On Jun 10, 2021, at 1:23 AM, Christophe Leroy > wrote: > >> > >> With a config having PAGE_SIZE set to 256K, BTRFS build fails > >> with the following message > >> > >> include/linux/compiler_types.h:326:38: error: call to > '__compiletime_assert_791' declared with attribute error: BUILD_BUG_ON > failed: (BTRFS_MAX_COMPRESSED % PAGE_SIZE) !=3D 0 > >> > >> BTRFS_MAX_COMPRESSED being 128K, BTRFS cannot support platforms > with > >> 256K pages at the time being. > >> > >> There are two platforms that can select 256K pages: > >> - hexagon > >> - powerpc > >> > >> Disable BTRFS when 256K page size is selected. > >> > > > > We=E2=80=99ll have other subpage blocksize concerns with 256K pages, = but this > BTRFS_MAX_COMPRESSED #define is arbitrary. It=E2=80=99s just trying = to have an > upper bound on the amount of memory we=E2=80=99ll need to uncompress a = single > page=E2=80=99s worth of random reads. > > > > We could change it to max(PAGE_SIZE, 128K) or just bump to 256K. > > >=20 > But if 256K is problematic in other ways, is it worth bumping > BTRFS_MAX_COMPRESSED to 256K ? >=20 > David, in below mail, said that 256K support would require deaper = changes. So > disabling BTRFS > support seems the easiest solution for the time being, at least for = Stable (I > forgot the Fixes: tag > and the CC: to stable). >=20 > On powerpc, 256k pages is a corner case, it requires customised = binutils, so I > don't think disabling > BTRFS is a issue there. For hexagon I don't know. Larger page sizes like this are typical for hexagon. Disabling btrfs on = hexagon seems appropriate. -Brian From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Brian Cain" Subject: RE: [PATCH] btrfs: Disable BTRFS on platforms having 256K pages Date: Sat, 12 Jun 2021 09:44:05 -0500 Message-ID: <17a401d75f99$662cdc50$328694f0$@codeaurora.org> References: <185278AF-1D87-432D-87E9-C86B3223113E@fb.com> Reply-To: bcain@codeaurora.org Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Return-path: DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1623509055; h=Content-Transfer-Encoding: Content-Type: MIME-Version: Message-ID: Date: Subject: In-Reply-To: References: Cc: To: From: Reply-To: Sender; bh=RhtvN2QTW0JZFH6Rjd3vbX9yOl+YFdfv0SB17b2868c=; b=k0HU4kB5Cyx6FrM/UIBPtCIku1SKtbNjdCm9wl6ykARbxvMzDtHf5oqEpfpOJe17LrWSELhO OsEP+QVb+qX6QF4AFBPSkjfzRj+kgdlWXtNsFguU9/dT3Cp9FtzFU6WxOpqM5sIzToBLH9NY qG3COBjl82y1Nzt2ZNaMMdzX88M= In-Reply-To: Content-Language: en-us List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+glppe-linuxppc-embedded-2=m.gmane-mx.org@lists.ozlabs.org Sender: "Linuxppc-dev" Content-Type: text/plain; charset="utf-8" To: 'Christophe Leroy' , 'Chris Mason' Cc: linux-hexagon@vger.kernel.org, 'Josef Bacik' , linux-kernel@vger.kernel.org, 'David Sterba' , linuxppc-dev@lists.ozlabs.org, 'linux-btrfs' > -----Original Message----- > From: Christophe Leroy ... > Le 10/06/2021 =C3=A0 15:54, Chris Mason a =C3=A9crit : > > > >> On Jun 10, 2021, at 1:23 AM, Christophe Leroy > wrote: > >> > >> With a config having PAGE_SIZE set to 256K, BTRFS build fails > >> with the following message > >> > >> include/linux/compiler_types.h:326:38: error: call to > '__compiletime_assert_791' declared with attribute error: BUILD_BUG_ON > failed: (BTRFS_MAX_COMPRESSED % PAGE_SIZE) !=3D 0 > >> > >> BTRFS_MAX_COMPRESSED being 128K, BTRFS cannot support platforms > with > >> 256K pages at the time being. > >> > >> There are two platforms that can select 256K pages: > >> - hexagon > >> - powerpc > >> > >> Disable BTRFS when 256K page size is selected. > >> > > > > We=E2=80=99ll have other subpage blocksize concerns with 256K pages, = but this > BTRFS_MAX_COMPRESSED #define is arbitrary. It=E2=80=99s just trying = to have an > upper bound on the amount of memory we=E2=80=99ll need to uncompress a = single > page=E2=80=99s worth of random reads. > > > > We could change it to max(PAGE_SIZE, 128K) or just bump to 256K. > > >=20 > But if 256K is problematic in other ways, is it worth bumping > BTRFS_MAX_COMPRESSED to 256K ? >=20 > David, in below mail, said that 256K support would require deaper = changes. So > disabling BTRFS > support seems the easiest solution for the time being, at least for = Stable (I > forgot the Fixes: tag > and the CC: to stable). >=20 > On powerpc, 256k pages is a corner case, it requires customised = binutils, so I > don't think disabling > BTRFS is a issue there. For hexagon I don't know. Larger page sizes like this are typical for hexagon. Disabling btrfs on = hexagon seems appropriate. -Brian