From: Andrey Grodzovsky <Andrey.Grodzovsky@amd.com>
To: Eric Engestrom <eric.engestrom@imgtec.com>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH libdrm 2/7] tests/amdgpu: add parentheses to make operation priority explicit
Date: Fri, 26 Jan 2018 08:26:15 -0500 [thread overview]
Message-ID: <17b15987-bb75-4fca-7813-52a4c4a57fce@amd.com> (raw)
In-Reply-To: <20180126113244.26946-2-eric.engestrom@imgtec.com>
On 01/26/2018 06:32 AM, Eric Engestrom wrote:
> While at it, align with the other half on the next line.
>
> Cc: Andrey Grodzovsky <andrey.grodzovsky@amd.com>
> Signed-off-by: Eric Engestrom <eric.engestrom@imgtec.com>
> ---
> Andrey, is that `0xfffffffc` right? It looks weird to me to be
> discarding the bottom two bits.
That correct according to the PM4 packet spec,
(e.g.
http://amd-dev.wpengine.netdna-cdn.com/wordpress/media/2013/10/si_programming_guide_v2.pdf
2.9.4 WRITE_DATA, DST_ADDR_LO field, when destination is memory the bits
range is [31:2] for 32 bit addresses
and [31:3] for 64 bit addresses) Those 2 bits are always 0 in this case
anyway.
Thanks,
Andrey
> ---
> tests/amdgpu/basic_tests.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/amdgpu/basic_tests.c b/tests/amdgpu/basic_tests.c
> index 0f75e8961bb7c0c9ecd9..6ee0aa3b044aeffc6adf 100644
> --- a/tests/amdgpu/basic_tests.c
> +++ b/tests/amdgpu/basic_tests.c
> @@ -1608,7 +1608,7 @@ static void amdgpu_sync_dependency_test(void)
> j = i;
> ptr[i++] = PACKET3(PACKET3_WRITE_DATA, 3);
> ptr[i++] = WRITE_DATA_DST_SEL(5) | WR_CONFIRM;
> - ptr[i++] = 0xfffffffc & ib_result_mc_address + DATA_OFFSET * 4;
> + ptr[i++] = 0xfffffffc & (ib_result_mc_address + DATA_OFFSET * 4);
> ptr[i++] = (0xffffffff00000000 & (ib_result_mc_address + DATA_OFFSET * 4)) >> 32;
> ptr[i++] = 99;
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-01-26 13:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-26 11:32 [PATCH libdrm 1/7] remove unnecessary empty statements Eric Engestrom
2018-01-26 11:32 ` [PATCH libdrm 2/7] tests/amdgpu: add parentheses to make operation priority explicit Eric Engestrom
2018-01-26 13:26 ` Andrey Grodzovsky [this message]
2018-01-26 16:50 ` Eric Engestrom
2018-01-26 11:32 ` [PATCH libdrm 3/7] tests/amdgpu: drop unused variables Eric Engestrom
2018-01-26 11:32 ` [PATCH libdrm 4/7] tests/amdgpu: fix bad sign comparisons Eric Engestrom
2018-01-26 11:38 ` Christian König
2018-01-26 17:15 ` Eric Engestrom
2018-01-26 17:17 ` Christian König
2018-01-26 11:32 ` [PATCH libdrm 5/7] tests/util: fix signed/unsigned comparisons Eric Engestrom
2018-01-26 11:32 ` [PATCH libdrm 6/7] tests/util: drop unused parameters Eric Engestrom
2018-01-26 11:32 ` [PATCH libdrm 7/7] tests/etnaviv: drop unused `return 0` Eric Engestrom
2018-01-26 11:35 ` [PATCH libdrm 1/7] remove unnecessary empty statements Christian König
2018-01-26 17:44 ` Emil Velikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17b15987-bb75-4fca-7813-52a4c4a57fce@amd.com \
--to=andrey.grodzovsky@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=eric.engestrom@imgtec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.