From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA922C43463 for ; Fri, 18 Sep 2020 16:15:49 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5300220659 for ; Fri, 18 Sep 2020 16:15:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="pffhIUhK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5300220659 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=yEaqHrZNGsi6TRMMGSpfgEDou2BB4sOBi2J2tEu72ag=; b=pffhIUhKnA+U2Ohoqr3WomHWn wHtdhSkduInYkoAahherIaqvlxPW7/H61hQDC61SS2uqnMd4YxqUg43UIwLsOFzLH3ixfEJ2jmMBf uNzIjJ/SIc88uUIaNgfym02StM8/XwMLc/WqW41sm2T6z94tzwPfgSyoRE2sajvDokJnbIscqKIhy PqVs7ZNv9RhIMaxvbAf/N2tcpbJtQI3EiVI3YqNovnI52DS/7ptykcEeElu7BsIH6QJKSXSLvFJfh VSEeJrePQTkysBLI0navjMb64pIdUSWDvdU9F2rJ9EpNMjJfE4t473MYSTY2lwYw9/zoRTGJbARWv d7ONQN/jA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kJJ1U-0000GA-NS; Fri, 18 Sep 2020 16:14:08 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kJJ1C-00005c-Gr for linux-arm-kernel@lists.infradead.org; Fri, 18 Sep 2020 16:13:56 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 771D330E; Fri, 18 Sep 2020 09:13:48 -0700 (PDT) Received: from [172.16.1.113] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 49FE53F73B; Fri, 18 Sep 2020 09:13:47 -0700 (PDT) Subject: Re: [PATCH v4 10/15] drivers/firmware/sdei: Cleanup on cross call function To: Gavin Shan , linux-arm-kernel@lists.infradead.org References: <20200730014531.310465-1-gshan@redhat.com> <20200730014531.310465-11-gshan@redhat.com> From: James Morse Message-ID: <17c1bcce-61b4-bafd-6ed1-e5e67dfdac6c@arm.com> Date: Fri, 18 Sep 2020 17:13:31 +0100 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200730014531.310465-11-gshan@redhat.com> Content-Language: en-GB X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200918_121350_720754_5C553DB7 X-CRM114-Status: GOOD ( 17.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, catalin.marinas@arm.com, will@kernel.org, shan.gavin@gmail.com, Jonathan.Cameron@huawei.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Gavin, On 30/07/2020 02:45, Gavin Shan wrote: > This applies cleanup on the cross call functions, no functional > changes are introduced: > * Refactor CROSSCALL_INIT to use "do { ... } while (0)" to be > compatible with scripts/checkpatch.pl What does this mean? > * Use smp_call_func_t for @fn argument in sdei_do_cross_call() > * Remove unnecessary space before @event in sdei_do_cross_call() > diff --git a/drivers/firmware/arm_sdei.c b/drivers/firmware/arm_sdei.c > index c8e894098c56..5560c8880631 100644 > --- a/drivers/firmware/arm_sdei.c > +++ b/drivers/firmware/arm_sdei.c > @@ -78,11 +78,15 @@ struct sdei_crosscall_args { > int first_error; > }; > > -#define CROSSCALL_INIT(arg, event) (arg.event = event, \ > - arg.first_error = 0, \ > - atomic_set(&arg.errors, 0)) > - > -static inline int sdei_do_cross_call(void *fn, struct sdei_event * event) > +#define CROSSCALL_INIT(arg, event) \ > + do { \ > + arg.event = event; \ > + arg.first_error = 0; \ > + atomic_set(&arg.errors, 0); \ > + } while (0) Huh, I'm surprised I didn't write it like that the first time! > +static inline int sdei_do_cross_call(smp_call_func_t fn, > + struct sdei_event *event) > { > struct sdei_crosscall_args arg; With some kind of motivation for the change, instead of "checkpatch made me do it": Reviewed-by: James Morse Thanks, James _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel