From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B00DC433DB for ; Mon, 25 Jan 2021 05:56:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5C3C822581 for ; Mon, 25 Jan 2021 05:56:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727063AbhAYFzI (ORCPT ); Mon, 25 Jan 2021 00:55:08 -0500 Received: from mail-1.ca.inter.net ([208.85.220.69]:44648 "EHLO mail-1.ca.inter.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727062AbhAYFyx (ORCPT ); Mon, 25 Jan 2021 00:54:53 -0500 Received: from localhost (offload-3.ca.inter.net [208.85.220.70]) by mail-1.ca.inter.net (Postfix) with ESMTP id 9AD752EA02B; Mon, 25 Jan 2021 00:54:00 -0500 (EST) Received: from mail-1.ca.inter.net ([208.85.220.69]) by localhost (offload-3.ca.inter.net [208.85.220.70]) (amavisd-new, port 10024) with ESMTP id OOyMIAvLmBhD; Mon, 25 Jan 2021 00:39:59 -0500 (EST) Received: from [192.168.48.23] (host-104-157-204-209.dyn.295.ca [104.157.204.209]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: dgilbert@interlog.com) by mail-1.ca.inter.net (Postfix) with ESMTPSA id E0B542EA012; Mon, 25 Jan 2021 00:53:59 -0500 (EST) Reply-To: dgilbert@interlog.com Subject: Re: linux-next: build failure after merge of the scsi-mkp tree To: Stephen Rothwell , "Martin K. Petersen" Cc: Linux Kernel Mailing List , Linux Next Mailing List References: <20210125151310.20e71400@canb.auug.org.au> From: Douglas Gilbert Message-ID: <17ccd90b-8616-1f20-ad5d-e250834c02fe@interlog.com> Date: Mon, 25 Jan 2021 00:53:59 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210125151310.20e71400@canb.auug.org.au> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-CA Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-next@vger.kernel.org On 2021-01-24 11:13 p.m., Stephen Rothwell wrote: > Hi all, > > After merging the scsi-mkp tree, today's linux-next build (powerpc > ppc64_defconfig) failed like this: > > drivers/scsi/sg.c: In function 'sg_find_srp_by_id': > drivers/scsi/sg.c:2908:4: error: expected '}' before 'else' > 2908 | else > | ^~~~ > drivers/scsi/sg.c:2902:16: warning: unused variable 'cptp' [-Wunused-variable] > 2902 | const char *cptp = "pack_id="; > | ^~~~ > drivers/scsi/sg.c:2896:5: error: label 'good' used but not defined > 2896 | goto good; > | ^~~~ > drivers/scsi/sg.c: At top level: > drivers/scsi/sg.c:2913:2: error: expected identifier or '(' before 'return' > 2913 | return NULL; > | ^~~~~~ > drivers/scsi/sg.c:2914:5: error: expected '=', ',', ';', 'asm' or '__attribute__' before ':' token > 2914 | good: > | ^ > drivers/scsi/sg.c:2917:2: error: expected identifier or '(' before 'return' > 2917 | return srp; > | ^~~~~~ > drivers/scsi/sg.c:2918:1: error: expected identifier or '(' before '}' token > 2918 | } > | ^ > drivers/scsi/sg.c: In function 'sg_find_srp_by_id': > drivers/scsi/sg.c:2912:2: error: control reaches end of non-void function [-Werror=return-type] > 2912 | } > | ^ > > Caused by commit > > 7323ad3618b6 ("scsi: sg: Replace rq array with xarray") > > SG_LOG() degenerates to "{}" in some configs ... > > I have used the scsi-mkp tree from next-20210122 for today. > Hi, I sent a new patchset to the linux-scsi list about 4 hours ago to fix that. Doug Gilbert