From: "DooHyun Hwang" <dh0421.hwang@samsung.com>
To: "'Bart Van Assche'" <bvanassche@acm.org>,
<linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<alim.akhtar@samsung.com>, <avri.altman@wdc.com>,
<James.Bottomley@HansenPartnership.com>,
<martin.petersen@oracle.com>, <peter.wang@mediatek.com>,
<manivannan.sadhasivam@linaro.org>, <quic_mnaresh@quicinc.com>
Cc: <grant.jung@samsung.com>, <jt77.jang@samsung.com>,
<junwoo80.lee@samsung.com>, <jangsub.yi@samsung.com>,
<sh043.lee@samsung.com>, <cw9316.lee@samsung.com>,
<sh8267.baek@samsung.com>, <wkon.kim@samsung.com>
Subject: RE: [PATCH 1/2] scsi: ufs: Add an enum for ufs_trace to check ufs cmd error
Date: Tue, 2 Sep 2025 10:09:39 +0900 [thread overview]
Message-ID: <17db01dc1ba6$41d37350$c57a59f0$@samsung.com> (raw)
In-Reply-To: <27882582-58b8-4ac2-9596-3602098e7c1d@acm.org>
On 9/1/25 7:4 AM, Bart Van Assche wrote:
> On 8/31/25 6:31 PM, DooHyun Hwang wrote:
> > UFS_CMD_ERR stands for "completion error".
>
> No it doesn't. In the UFS driver and also in many other driver "cmd"
> stands for "command" and not for "completion". Please change the
> "UFS_CMD_ERR" enum label.
>
> Bart.
I'm sorry. There was a misunderstanding in my previous comment.
The UFS_CMD_ERR stands for "command completion error."
I wanted to make it consistent with the other enums.
For example, query errors are defined as UFS_QUERY_ERR,
and Task Management errors are defined as UFS_TM_ERR.
I hope to use UFS_CMD_ERR for the same classification purposes
as UFS_CMD_SEND or UFS_CMD_COMP.
Therefore, UFS_CMD_ERR can be used for logging SCSI or UIC commands.
Thank you.
DooHyun Hwang.
next prev parent reply other threads:[~2025-09-02 1:09 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20250417023415epcas1p47da6d269afcb5d1807004c9b708675a5@epcas1p4.samsung.com>
2025-04-17 2:34 ` [PATCH 0/2] scsi: ufs: Add an enum for ufs_trace_str_t to check uic cmd error DooHyun Hwang
2025-04-17 2:34 ` [PATCH 1/2] scsi: ufs: Add an enum for ufs_trace to check ufs " DooHyun Hwang
2025-04-17 4:59 ` Avri Altman
2025-04-17 8:21 ` DooHyun Hwang
2025-08-29 15:15 ` Bart Van Assche
2025-09-01 1:31 ` DooHyun Hwang
2025-09-01 14:03 ` Bart Van Assche
2025-09-02 1:09 ` DooHyun Hwang [this message]
2025-09-02 16:34 ` Bart Van Assche
2025-09-03 6:39 ` DooHyun Hwang
2025-09-03 15:56 ` Bart Van Assche
2025-09-08 7:43 ` DooHyun Hwang
2025-09-08 15:27 ` Bart Van Assche
2025-04-17 2:34 ` [PATCH 2/2] scsi: ufs: core: Add a trace function calling when uic command error occurs DooHyun Hwang
2025-04-17 21:35 ` Bart Van Assche
2025-04-18 4:48 ` DooHyun Hwang
2025-04-22 12:48 ` Peter Wang (王信友)
2025-04-23 6:45 ` DooHyun Hwang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='17db01dc1ba6$41d37350$c57a59f0$@samsung.com' \
--to=dh0421.hwang@samsung.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=bvanassche@acm.org \
--cc=cw9316.lee@samsung.com \
--cc=grant.jung@samsung.com \
--cc=jangsub.yi@samsung.com \
--cc=jt77.jang@samsung.com \
--cc=junwoo80.lee@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=martin.petersen@oracle.com \
--cc=peter.wang@mediatek.com \
--cc=quic_mnaresh@quicinc.com \
--cc=sh043.lee@samsung.com \
--cc=sh8267.baek@samsung.com \
--cc=wkon.kim@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.