From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Agner Subject: Re: fsl-dcu not works on latest "drm-next" Date: Fri, 03 Jun 2016 15:52:01 -0700 Message-ID: <17f0bd63a0efebefb30f10ff208da9bd@agner.ch> References: <20160525104103.GV8206@sirena.org.uk> <2397536.bIp6BuhYPD@ws-stein> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail.kmu-office.ch (mail.kmu-office.ch [IPv6:2a02:418:6a02::a2]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1C60C6E2FF for ; Fri, 3 Jun 2016 22:56:03 +0000 (UTC) In-Reply-To: <2397536.bIp6BuhYPD@ws-stein> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Alexander Stein , Meng Yi Cc: airlied@redhat.com, Mark Brown , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gMjAxNi0wNS0yNiAwMjoxMSwgQWxleGFuZGVyIFN0ZWluIHdyb3RlOgo+IE9uIFRodXJzZGF5 IDI2IE1heSAyMDE2IDA4OjIzOjQyLCBNZW5nIFlpIHdyb3RlOgo+PiBIaSBNYXJrLAo+Pgo+PiA+ IFlvdSd2ZSBub3Qgc3BlY2lmaWNhbGx5IGRlc2NyaWJlZCB0aGUgcHJvYmxlbSBoZXJlIC0gd2hh dCBhcmUgdGhlCj4+ID4gZW5kaWFubmVzc2VzIG9mIGJvdGggdGhlIENQVSBhbmQgdGhlIGRldmlj ZSB5b3UncmUgdGFsa2luZyB0bz8gIFdoYXQKPj4gPiBzcGVjaWZpY2FsbHkgaXMgdGhlIGVuZGlh bmVzcyBwcm9ibGVtIHlvdSBhcmUgc2VlaW5nLCB3aGF0IGFyZSB5b3Ugc2VlaW5nCj4+ID4gYW5k IHdoYXQgZG8geW91IGV4cGVjdCB0byBzZWU/Cj4+Cj4+IFRoZSBDUFUgaXMgbGl0dGxlIGVuZGlh biBhbmQgdGhlIGRldmljZSBEQ1UgaXMgYmlnIGVuZGlhbiwgc3BlY2lmaWVkCj4+IGJpZy1lbmRp YW4gaW4gRFRTLAo+Pgo+PiBBbmQgaGVyZSBpcyBteSBEVFMgYW5kIHJlZ21hcF9jb25maWcsCj4+ Cj4+IFNwZWNpZmllZCAiYmlnLWVuZGlhbiIgaW4gRFRTLAo+Pgo+PiAgICAgICAgIGRjdTogZGN1 QDJjZTAwMDAgewo+PiAgICAgICAgICAgICBjb21wYXRpYmxlID0gImZzbCxsczEwMjFhLWRjdSI7 Cj4+ICAgICAgICAgICAgIHJlZyA9IDwweDAgMHgyY2UwMDAwIDB4MCAweDEwMDAwPjsKPj4gICAg ICAgICAgICAgaW50ZXJydXB0cyA9IDxHSUNfU1BJIDE3MiBJUlFfVFlQRV9MRVZFTF9ISUdIPjsK Pj4gICAgICAgICAgICAgY2xvY2tzID0gPCZwbGF0Zm9ybV9jbGsgMD47Cj4+ICAgICAgICAgICAg IGNsb2NrLW5hbWVzID0gImRjdSI7Cj4+ICAgICAgICAgICAgIGJpZy1lbmRpYW47Cj4+ICAgICAg ICAgICAgIHN0YXR1cyA9ICJkaXNhYmxlZCI7Cj4+ICAgICAgICAgfTsKPj4KPj4gSSBjYW4ndCB0 ZWxsIHRoZSBkaWZmZXJlbmNlIG9mICJyZWdfZm9ybWF0X2VuZGlhbiIgYW5kICIgdmFsX2Zvcm1h dF9lbmRpYW4KPj4gIiwgc28gSSBoYWQgdHJpZWQgZm91ciBjb25kaXRpb25zLiBBbmQgYWxsIGZh aWxlZC4KPj4KPj4gc3RhdGljIGNvbnN0IHN0cnVjdCByZWdtYXBfY29uZmlnIGZzbF9kY3VfcmVn bWFwX2NvbmZpZyA9IHsKPj4gICAgIC5yZWdfYml0cyA9IDMyLAo+PiAgICAgLnJlZ19zdHJpZGUg PSA0LAo+PiAgICAgLnZhbF9iaXRzID0gMzIsCj4+ICAgICAuY2FjaGVfdHlwZSA9IFJFR0NBQ0hF X1JCVFJFRSwKPiAKPiBUaGlzIG5lZWRzIHRvIGJlIGEgZmxhdCBjYWNoZS4gU2VlCj4gaHR0cHM6 Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvYXJjaGl2ZXMvZHJpLWRldmVsLzIwMTYtSmFudWFyeS8w OTkxMjEuaHRtbAo+IG9yIGh0dHBzOi8vbGttbC5vcmcvbGttbC8yMDE2LzMvMjQvMjgxCj4gbWF4 X3JlZ2lzdGVyIGFsc28gbmVlZHMgYW4gYXBwcm9wcmlhdGUgdmFsdWUuCgpPaywgc2luY2UgdGhl IGNvbXBsZXRlIHNldCB3aGljaCBzd2l0Y2hlcyB0byB0aGUgYXRvbWljIGhlbHBlciBpcyBub3QK c3RhYmxlIG1hdGVyaWFsIChhbmQgYWxzbyB3b24ndCBtYWtlIGl0IGludG8gNC43IGFueW1vcmUp LCBJIGNyZWF0ZWQgYQpzZXBlcmF0ZSBidWdmaXggbm93OgpodHRwczovL2xpc3RzLmZyZWVkZXNr dG9wLm9yZy9hcmNoaXZlcy9kcmktZGV2ZWwvMjAxNi1KdW5lLzEwOTYyNS5odG1sCgpXaGF0IEkg ZG9uJ3QgcXVpdGUgZ2V0IHlldCBpcyB0aGUgUkVHQ0FDSEVfRkxBVCBpbmZsdWVuY2luZyB0aGUK ZW5kaWFubmVzcyBiZWhhdmlvcj8KCklmIGl0IGlzLCBNZW5nLCBjYW4geW91IHRlc3QgYWdhaW4g d2l0aCB2NC43LXJjMSArIHRoZSBGTEFUIGNhY2hlIHBhdGNoCmFib3ZlPwoKLS0KU3RlZmFuCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBt YWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3Rz LmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932279AbcFCW4G (ORCPT ); Fri, 3 Jun 2016 18:56:06 -0400 Received: from mail.kmu-office.ch ([178.209.48.109]:47425 "EHLO mail.kmu-office.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752164AbcFCW4D (ORCPT ); Fri, 3 Jun 2016 18:56:03 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Date: Fri, 03 Jun 2016 15:52:01 -0700 From: Stefan Agner To: Alexander Stein , Meng Yi Cc: linux-kernel@vger.kernel.org, Mark Brown , dri-devel@lists.freedesktop.org, David Airlie , airlied@redhat.com Subject: Re: fsl-dcu not works on latest "drm-next" In-Reply-To: <2397536.bIp6BuhYPD@ws-stein> References: <20160525104103.GV8206@sirena.org.uk> <2397536.bIp6BuhYPD@ws-stein> Message-ID: <17f0bd63a0efebefb30f10ff208da9bd@agner.ch> User-Agent: Roundcube Webmail/1.1.3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016-05-26 02:11, Alexander Stein wrote: > On Thursday 26 May 2016 08:23:42, Meng Yi wrote: >> Hi Mark, >> >> > You've not specifically described the problem here - what are the >> > endiannesses of both the CPU and the device you're talking to? What >> > specifically is the endianess problem you are seeing, what are you seeing >> > and what do you expect to see? >> >> The CPU is little endian and the device DCU is big endian, specified >> big-endian in DTS, >> >> And here is my DTS and regmap_config, >> >> Specified "big-endian" in DTS, >> >> dcu: dcu@2ce0000 { >> compatible = "fsl,ls1021a-dcu"; >> reg = <0x0 0x2ce0000 0x0 0x10000>; >> interrupts = ; >> clocks = <&platform_clk 0>; >> clock-names = "dcu"; >> big-endian; >> status = "disabled"; >> }; >> >> I can't tell the difference of "reg_format_endian" and " val_format_endian >> ", so I had tried four conditions. And all failed. >> >> static const struct regmap_config fsl_dcu_regmap_config = { >> .reg_bits = 32, >> .reg_stride = 4, >> .val_bits = 32, >> .cache_type = REGCACHE_RBTREE, > > This needs to be a flat cache. See > https://lists.freedesktop.org/archives/dri-devel/2016-January/099121.html > or https://lkml.org/lkml/2016/3/24/281 > max_register also needs an appropriate value. Ok, since the complete set which switches to the atomic helper is not stable material (and also won't make it into 4.7 anymore), I created a seperate bugfix now: https://lists.freedesktop.org/archives/dri-devel/2016-June/109625.html What I don't quite get yet is the REGCACHE_FLAT influencing the endianness behavior? If it is, Meng, can you test again with v4.7-rc1 + the FLAT cache patch above? -- Stefan