From: Jens Axboe <axboe@kernel.dk>
To: Chaitanya Kulkarni <kch@nvidia.com>,
linux-block@vger.kernel.org, linux-bcache@vger.kernel.org
Cc: josef@toxicpanda.com, minchan@kernel.org,
senozhatsky@chromium.org, colyli@suse.de,
kent.overstreet@gmail.com, dlemoal@kernel.org,
johannes.thumshirn@wdc.com, bvanassche@acm.org,
vincent.fu@samsung.com, akinobu.mita@gmail.com,
shinichiro.kawasaki@wdc.com, nbd@other.debian.org
Subject: Re: [PATCH 0/5] block/drivers: don't clear the flag that is not set
Date: Mon, 24 Apr 2023 10:39:30 -0600 [thread overview]
Message-ID: <17f55b16-cc5f-a585-baa3-2a39cb5e9cf3@kernel.dk> (raw)
In-Reply-To: <20230424073023.38935-1-kch@nvidia.com>
On 4/24/23 1:30?AM, Chaitanya Kulkarni wrote:
> Hi,
>
> The drivers in this patch-series tries to clear the
> QUEUE_FLAG_ADD_RANDOM that is not set at all in the queue allocation
> and initialization path in :-
Just roll this into one, as it should be a non-functional change since
we don't default to ADD_RANDOM with MQ ops. And then change the title to
something meaningful, ala:
block/drivers: remove dead clear of QUEUE_FLAG_ADD_RANDOM
or something like that, as your title currently makes very little sense
(eg it's hard to parse and it doesn't really say what is being done).
--
Jens Axboe
prev parent reply other threads:[~2023-04-24 16:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20230424092940epcas5p3407002e7d5c79593ffbafc38f2b49e51@epcas5p3.samsung.com>
2023-04-24 7:30 ` [PATCH 0/5] block/drivers: don't clear the flag that is not set Chaitanya Kulkarni
2023-04-24 7:30 ` [PATCH 1/5] null_blk: " Chaitanya Kulkarni
2023-04-24 7:30 ` [PATCH 2/5] brd: " Chaitanya Kulkarni
2023-04-24 7:30 ` [PATCH 3/5] nbd: " Chaitanya Kulkarni
2023-04-24 7:30 ` [PATCH 4/5] zram: " Chaitanya Kulkarni
2023-04-24 7:30 ` [PATCH 5/5] bcache: " Chaitanya Kulkarni
2023-04-24 10:19 ` [PATCH 5/5] bcache: don't clear the flag that is not set^[ Coly Li
2023-04-24 9:26 ` [PATCH 0/5] block/drivers: don't clear the flag that is not set Nitesh Shetty
2023-04-24 10:25 ` Chaitanya Kulkarni
2023-04-24 10:40 ` Nitesh Shetty
2023-04-24 16:39 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17f55b16-cc5f-a585-baa3-2a39cb5e9cf3@kernel.dk \
--to=axboe@kernel.dk \
--cc=akinobu.mita@gmail.com \
--cc=bvanassche@acm.org \
--cc=colyli@suse.de \
--cc=dlemoal@kernel.org \
--cc=johannes.thumshirn@wdc.com \
--cc=josef@toxicpanda.com \
--cc=kch@nvidia.com \
--cc=kent.overstreet@gmail.com \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=minchan@kernel.org \
--cc=nbd@other.debian.org \
--cc=senozhatsky@chromium.org \
--cc=shinichiro.kawasaki@wdc.com \
--cc=vincent.fu@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.