From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Stephan Gerhold <stephan@gerhold.net>, Mark Brown <broonie@kernel.org>
Cc: Liam Girdwood <liam.r.girdwood@linux.intel.com>,
Hans de Goede <hdegoede@redhat.com>,
alsa-devel@alsa-project.org, Jie Yang <yang.jie@linux.intel.com>
Subject: Re: [PATCH v2 1/3] ASoC: Intel: sst: Simplify is_byt_cr()
Date: Wed, 2 Jan 2019 14:44:33 -0600 [thread overview]
Message-ID: <17ff00a4-efcf-56b8-33bc-e2b20df787f3@linux.intel.com> (raw)
In-Reply-To: <20190102193904.50123-1-stephan@gerhold.net>
On 1/2/19 1:39 PM, Stephan Gerhold wrote:
> is_byt_cr() and its usage can be simplified by returning the bool
> directly, instead of through a pointer. This works because the
> return value is just treated as bytcr = false and is not used
> otherwise.
>
> This patch also removes the extra check of
> IS_ENABLED(CONFIG_IOSF_MBI) in favor of checking
> iosf_mbi_available() directly. The header already takes care
> of returning false if the config option is not enabled.
>
> No functional change.
>
> Signed-off-by: Stephan Gerhold <stephan@gerhold.net>
Nice cleanup!
All 3 patches
Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
The next step will be to move this helper to a common library at some
point, we'll need it for SOF as well.
next prev parent reply other threads:[~2019-01-02 20:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-02 19:39 [PATCH v2 1/3] ASoC: Intel: sst: Simplify is_byt_cr() Stephan Gerhold
2019-01-02 19:39 ` [PATCH v2 2/3] ASoC: Intel: sst: Fallback to BYT-CR if IRQ 5 is missing Stephan Gerhold
2019-01-04 17:08 ` Applied "ASoC: Intel: sst: Fallback to BYT-CR if IRQ 5 is missing" to the asoc tree Mark Brown
2019-01-07 12:25 ` Mark Brown
2019-01-07 12:30 ` Mark Brown
2019-01-02 19:39 ` [PATCH v2 3/3] ASoC: Intel: bytcr_rt5640: Add quirks for ASUS MeMO Pad 7 (ME176C) Stephan Gerhold
2019-01-02 20:44 ` Pierre-Louis Bossart [this message]
2019-01-04 17:08 ` Applied "ASoC: Intel: sst: Simplify is_byt_cr()" to the asoc tree Mark Brown
2019-01-07 12:30 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17ff00a4-efcf-56b8-33bc-e2b20df787f3@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=hdegoede@redhat.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=stephan@gerhold.net \
--cc=yang.jie@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.