From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3E5D63D65 for ; Thu, 8 Sep 2022 16:26:35 +0000 (UTC) Received: by mail-wm1-f52.google.com with SMTP id d12-20020a05600c34cc00b003a83d20812fso2210456wmq.1 for ; Thu, 08 Sep 2022 09:26:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=8G+gH/ZdR26aobBAiGz/oS5rrDj2ImSoc83kpV+wRO0=; b=Lv282Mf3K67NvyFxRebxNkdvzGhqee8D1XGpHHcftviyakUdO3xMzoYCg+7ZenogQZ CKFxMJlR8ohcfzJVgJ57xMj+pbdL51FR0qbpIGo3Gn7u/LGkCdtiR3Z3qO4qVPAn9E/o noppHKRaRu9xab32KqAAnEjlRkS7oZuRh5NQ9fvmOpGIv+HKAwY6qibOxLkU/jA3+PD8 1bP5t0dP6u+9zEyBjlP0V8W0yl3RqFf9NckOSqRXIlOPIgU24m6Yl1X9Xx/PMk5z2DXG 4TxqycZgZG+FXA1teIK6bNRkUpVxIl3aH/qXlJDeBwQFV2uO5kizVoGD+EIcpARKVPsh teuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=8G+gH/ZdR26aobBAiGz/oS5rrDj2ImSoc83kpV+wRO0=; b=ldK27Bcpie/sYr26/DOatNzv8XCKaK3C/WU9vEA2QL+cq/2bGWpCWFvMAI7vQnozBw zlzkxSuyIj+m3NjdSOFK2+lxaYGEPWdc+iJ9jTw5qCntcZe61paRjxQ8IoVQes+lKP02 m6RZzJe52wb+J8fAwxGAPf71SR/yLJQ1xE/zFOZ3qxN29jUFh6MGtcS5e/N0YPHGkFhC jrbr0rItv0pYXeyeDgE2Ob5PXshcq0pvjYXonx0bZShGBnfzWKwmirkHeNxNVQP/KzY5 Zy5e0HKQvSxscjggroSfHNxPgAaweDCI+aQdyd4iXjYJ+retEuW8hh2ZhulMIzDHEB7U wqhg== X-Gm-Message-State: ACgBeo2uXYu/3yfIhu+ejJiO0aFQm/kD4iTl1mcGv8Ek7MpAqT+I/Rdv OxI+kUwHZQNUNAYUvh2n5y0= X-Google-Smtp-Source: AA6agR5g4fKQwejx0X+xvVpuFLeBu2IKV+p52yPrFDR1V4MFUXBQpznlKeIiBMa6kmzuxVxNcu+yvA== X-Received: by 2002:a05:600c:1c8f:b0:3b2:541c:dd34 with SMTP id k15-20020a05600c1c8f00b003b2541cdd34mr2737551wms.155.1662654393411; Thu, 08 Sep 2022 09:26:33 -0700 (PDT) Received: from kista.localnet (82-149-1-172.dynamic.telemach.net. [82.149.1.172]) by smtp.gmail.com with ESMTPSA id d22-20020a1c7316000000b003a5bd5ea215sm2973670wmb.37.2022.09.08.09.26.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Sep 2022 09:26:32 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: =?ISO-8859-1?Q?Cl=E9ment_P=E9ron?= Cc: Chen-Yu Tsai , Samuel Holland , Rob Herring , Krzysztof Kozlowski , devicetree , linux-arm-kernel , linux-sunxi@lists.linux.dev, linux-kernel , dri-devel Subject: Re: Re: [PATCH v4 3/5] arm64: dts: allwinner: h6: Add GPU OPP table Date: Thu, 08 Sep 2022 18:26:31 +0200 Message-ID: <1800669.atdPhlSkOF@kista> In-Reply-To: References: <20220906153034.153321-1-peron.clem@gmail.com> <12048299.O9o76ZdvQC@kista> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Dne torek, 06. september 2022 ob 21:26:34 CEST je Cl=C3=A9ment P=C3=A9ron n= apisal(a): > Hi Jernej, >=20 > On Tue, 6 Sept 2022 at 21:10, Jernej =C5=A0krabec =20 wrote: > > Dne torek, 06. september 2022 ob 17:30:32 CEST je Cl=C3=A9ment P=C3=A9r= on=20 napisal(a): > > > Add an Operating Performance Points table for the GPU to > > > enable Dynamic Voltage & Frequency Scaling on the H6. > > >=20 > > > The voltage range is set with minimal voltage set to the target > > > and the maximal voltage set to 1.2V. This allow DVFS framework to > > > work properly on board with fixed regulator. > > >=20 > > > Signed-off-by: Cl=C3=A9ment P=C3=A9ron > > > --- > > >=20 > > > .../boot/dts/allwinner/sun50i-h6-gpu-opp.dtsi | 87 +++++++++++++++++= ++ > > > 1 file changed, 87 insertions(+) > > > create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-h6-gpu-opp.d= tsi > > >=20 > > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-gpu-opp.dtsi > > > b/arch/arm64/boot/dts/allwinner/sun50i-h6-gpu-opp.dtsi new file mode > > > 100644 > > > index 000000000000..b48049c4fc85 > > > --- /dev/null > > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-gpu-opp.dtsi > > > @@ -0,0 +1,87 @@ > > > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > > > +// Copyright (C) 2022 Cl=C3=A9ment P=C3=A9ron > > > + > > > +/ { > > > + gpu_opp_table: opp-table-gpu { > > > + compatible =3D "operating-points-v2"; > > > + > > > + opp-216000000 { > > > + opp-hz =3D /bits/ 64 <216000000>; > > > + opp-microvolt =3D <810000 810000 1200000>; > > > + }; > > > + > > > + opp-264000000 { > > > + opp-hz =3D /bits/ 64 <264000000>; > > > + opp-microvolt =3D <810000 810000 1200000>; > > > + }; > >=20 > > As mentioned in clock patch review, rates below 288 MHz are deemed > > unstable on GPU PLL by vendor GPU kernel driver. At least in the BSP > > version that I have. Did you test these points? If not, better to drop > > them. >=20 > I changed the governor to userspace and set the freq to 216MHz / 264MHz > Run glmark2 and didn't observe any glitch nor issue. >=20 > I'm not sure if it's enough to say it's stable but I didn't observe > any strange behavior. Ok then. =46orgot to ask, where did you get 1.2 V as an upper limit? H6 datasheet li= sts=20 max. GPU voltage as 1.08 V. Best regards, Jernej >=20 > Regards, > Clement >=20 > > Best regards, > > Jernej > >=20 > > > + > > > + opp-312000000 { > > > + opp-hz =3D /bits/ 64 <312000000>; > > > + opp-microvolt =3D <810000 810000 1200000>; > > > + }; > > > + > > > + opp-336000000 { > > > + opp-hz =3D /bits/ 64 <336000000>; > > > + opp-microvolt =3D <810000 810000 1200000>; > > > + }; > > > + > > > + opp-360000000 { > > > + opp-hz =3D /bits/ 64 <360000000>; > > > + opp-microvolt =3D <820000 820000 1200000>; > > > + }; > > > + > > > + opp-384000000 { > > > + opp-hz =3D /bits/ 64 <384000000>; > > > + opp-microvolt =3D <830000 830000 1200000>; > > > + }; > > > + > > > + opp-408000000 { > > > + opp-hz =3D /bits/ 64 <408000000>; > > > + opp-microvolt =3D <840000 840000 1200000>; > > > + }; > > > + > > > + opp-420000000 { > > > + opp-hz =3D /bits/ 64 <420000000>; > > > + opp-microvolt =3D <850000 850000 1200000>; > > > + }; > > > + > > > + opp-432000000 { > > > + opp-hz =3D /bits/ 64 <432000000>; > > > + opp-microvolt =3D <860000 860000 1200000>; > > > + }; > > > + > > > + opp-456000000 { > > > + opp-hz =3D /bits/ 64 <456000000>; > > > + opp-microvolt =3D <870000 870000 1200000>; > > > + }; > > > + > > > + opp-504000000 { > > > + opp-hz =3D /bits/ 64 <504000000>; > > > + opp-microvolt =3D <890000 890000 1200000>; > > > + }; > > > + > > > + opp-540000000 { > > > + opp-hz =3D /bits/ 64 <540000000>; > > > + opp-microvolt =3D <910000 910000 1200000>; > > > + }; > > > + > > > + opp-576000000 { > > > + opp-hz =3D /bits/ 64 <576000000>; > > > + opp-microvolt =3D <930000 930000 1200000>; > > > + }; > > > + > > > + opp-624000000 { > > > + opp-hz =3D /bits/ 64 <624000000>; > > > + opp-microvolt =3D <950000 950000 1200000>; > > > + }; > > > + > > > + opp-756000000 { > > > + opp-hz =3D /bits/ 64 <756000000>; > > > + opp-microvolt =3D <1040000 1040000 1200000>; > > > + }; > > > + }; > > > +}; > > > + > > > +&gpu { > > > + operating-points-v2 =3D <&gpu_opp_table>; > > > +}; > > > -- > > > 2.34.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DFA93C38145 for ; Thu, 8 Sep 2022 16:27:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=XjOQeIymzgAXAlr022aQHa05L/rWURQXTndOpXCe9BY=; b=qcyx7yP/+CfTxK PCFAgSQuLitLfvjtlxogU0kipKyeTfOPvjTVyK4EwWypKwzYUxA6un3q7KM9i3DGHfMQ4gfXS887/ MLa0lCiQeCvevcRb4A72DSg82MWSveIxasblgXRTgBreAMbgwP161Zb2uQP51q1fsSDDFrSDYTRCT z1VIVN35V6EO1/Y5S48WREkRMAwXBnFT+w3cChDNZn0n4xyW+7Ath/0iSWMoi9IQvWboSQdAAdquL TaflOb5n8sll8inwkmZa4DrK6istTU4XV0kdDLrMBvNimGazLXeKqwjgkJs6U34T/CgaVC4erSCJ9 cr1ytkibzho7GimBMvig==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oWKMQ-005lvC-Io; Thu, 08 Sep 2022 16:26:38 +0000 Received: from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oWKMN-005ltP-K2 for linux-arm-kernel@lists.infradead.org; Thu, 08 Sep 2022 16:26:37 +0000 Received: by mail-wm1-x32a.google.com with SMTP id n17-20020a05600c3b9100b003b3235574dbso1766797wms.2 for ; Thu, 08 Sep 2022 09:26:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=8G+gH/ZdR26aobBAiGz/oS5rrDj2ImSoc83kpV+wRO0=; b=Lv282Mf3K67NvyFxRebxNkdvzGhqee8D1XGpHHcftviyakUdO3xMzoYCg+7ZenogQZ CKFxMJlR8ohcfzJVgJ57xMj+pbdL51FR0qbpIGo3Gn7u/LGkCdtiR3Z3qO4qVPAn9E/o noppHKRaRu9xab32KqAAnEjlRkS7oZuRh5NQ9fvmOpGIv+HKAwY6qibOxLkU/jA3+PD8 1bP5t0dP6u+9zEyBjlP0V8W0yl3RqFf9NckOSqRXIlOPIgU24m6Yl1X9Xx/PMk5z2DXG 4TxqycZgZG+FXA1teIK6bNRkUpVxIl3aH/qXlJDeBwQFV2uO5kizVoGD+EIcpARKVPsh teuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=8G+gH/ZdR26aobBAiGz/oS5rrDj2ImSoc83kpV+wRO0=; b=EXN31TYtkrZOPDiB+vwu1A6khxe79ytiT+svQXA5d8FP6E5zyItIBAwDZNAJ6FMtCC LoU6hYjIZhBV8RVd9koI06vB/OsuZk3pFbIUn9rMlKDY4D6i8tO+BWHR729vCJmqijBk j1ImR4717mUZoDnKJr2mokEoQ1FK+t9PyHsxwMaHPXjjX5JUrOUitoZ2VerV3JQcQhNi 3oG5Xwp7FwrdzqG/rErYruVBhLx7z6vRnD2DpujiT+V19LVJJOTxENMxXUoUuEXqcB7W f+4Rw88b5cRqbmj/30Tu/Gdozy5QRtG/efUwVb95/dlqyjVOSGQ5/iUpiixtulm9W314 mCLQ== X-Gm-Message-State: ACgBeo1eJAgefCaqirX9kSQ9Z35r7Cm/93aED9xK3BF8At8ptsJ7u0rT Mm8qmzHIcSRZ5snCkyIlrT8= X-Google-Smtp-Source: AA6agR5g4fKQwejx0X+xvVpuFLeBu2IKV+p52yPrFDR1V4MFUXBQpznlKeIiBMa6kmzuxVxNcu+yvA== X-Received: by 2002:a05:600c:1c8f:b0:3b2:541c:dd34 with SMTP id k15-20020a05600c1c8f00b003b2541cdd34mr2737551wms.155.1662654393411; Thu, 08 Sep 2022 09:26:33 -0700 (PDT) Received: from kista.localnet (82-149-1-172.dynamic.telemach.net. [82.149.1.172]) by smtp.gmail.com with ESMTPSA id d22-20020a1c7316000000b003a5bd5ea215sm2973670wmb.37.2022.09.08.09.26.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Sep 2022 09:26:32 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: =?ISO-8859-1?Q?Cl=E9ment_P=E9ron?= Cc: Chen-Yu Tsai , Samuel Holland , Rob Herring , Krzysztof Kozlowski , devicetree , linux-arm-kernel , linux-sunxi@lists.linux.dev, linux-kernel , dri-devel Subject: Re: Re: [PATCH v4 3/5] arm64: dts: allwinner: h6: Add GPU OPP table Date: Thu, 08 Sep 2022 18:26:31 +0200 Message-ID: <1800669.atdPhlSkOF@kista> In-Reply-To: References: <20220906153034.153321-1-peron.clem@gmail.com> <12048299.O9o76ZdvQC@kista> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220908_092635_685676_1D42F963 X-CRM114-Status: GOOD ( 26.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org RG5lIHRvcmVrLCAwNi4gc2VwdGVtYmVyIDIwMjIgb2IgMjE6MjY6MzQgQ0VTVCBqZSBDbMOpbWVu dCBQw6lyb24gbmFwaXNhbChhKToKPiBIaSBKZXJuZWosCj4gCj4gT24gVHVlLCA2IFNlcHQgMjAy MiBhdCAyMToxMCwgSmVybmVqIMWga3JhYmVjIDxqZXJuZWouc2tyYWJlY0BnbWFpbC5jb20+IAp3 cm90ZToKPiA+IERuZSB0b3JlaywgMDYuIHNlcHRlbWJlciAyMDIyIG9iIDE3OjMwOjMyIENFU1Qg amUgQ2zDqW1lbnQgUMOpcm9uIApuYXBpc2FsKGEpOgo+ID4gPiBBZGQgYW4gT3BlcmF0aW5nIFBl cmZvcm1hbmNlIFBvaW50cyB0YWJsZSBmb3IgdGhlIEdQVSB0bwo+ID4gPiBlbmFibGUgRHluYW1p YyBWb2x0YWdlICYgRnJlcXVlbmN5IFNjYWxpbmcgb24gdGhlIEg2Lgo+ID4gPiAKPiA+ID4gVGhl IHZvbHRhZ2UgcmFuZ2UgaXMgc2V0IHdpdGggbWluaW1hbCB2b2x0YWdlIHNldCB0byB0aGUgdGFy Z2V0Cj4gPiA+IGFuZCB0aGUgbWF4aW1hbCB2b2x0YWdlIHNldCB0byAxLjJWLiBUaGlzIGFsbG93 IERWRlMgZnJhbWV3b3JrIHRvCj4gPiA+IHdvcmsgcHJvcGVybHkgb24gYm9hcmQgd2l0aCBmaXhl ZCByZWd1bGF0b3IuCj4gPiA+IAo+ID4gPiBTaWduZWQtb2ZmLWJ5OiBDbMOpbWVudCBQw6lyb24g PHBlcm9uLmNsZW1AZ21haWwuY29tPgo+ID4gPiAtLS0KPiA+ID4gCj4gPiA+ICAuLi4vYm9vdC9k dHMvYWxsd2lubmVyL3N1bjUwaS1oNi1ncHUtb3BwLmR0c2kgfCA4NyArKysrKysrKysrKysrKysr KysrCj4gPiA+ICAxIGZpbGUgY2hhbmdlZCwgODcgaW5zZXJ0aW9ucygrKQo+ID4gPiAgY3JlYXRl IG1vZGUgMTAwNjQ0IGFyY2gvYXJtNjQvYm9vdC9kdHMvYWxsd2lubmVyL3N1bjUwaS1oNi1ncHUt b3BwLmR0c2kKPiA+ID4gCj4gPiA+IGRpZmYgLS1naXQgYS9hcmNoL2FybTY0L2Jvb3QvZHRzL2Fs bHdpbm5lci9zdW41MGktaDYtZ3B1LW9wcC5kdHNpCj4gPiA+IGIvYXJjaC9hcm02NC9ib290L2R0 cy9hbGx3aW5uZXIvc3VuNTBpLWg2LWdwdS1vcHAuZHRzaSBuZXcgZmlsZSBtb2RlCj4gPiA+IDEw MDY0NAo+ID4gPiBpbmRleCAwMDAwMDAwMDAwMDAuLmI0ODA0OWM0ZmM4NQo+ID4gPiAtLS0gL2Rl di9udWxsCj4gPiA+ICsrKyBiL2FyY2gvYXJtNjQvYm9vdC9kdHMvYWxsd2lubmVyL3N1bjUwaS1o Ni1ncHUtb3BwLmR0c2kKPiA+ID4gQEAgLTAsMCArMSw4NyBAQAo+ID4gPiArLy8gU1BEWC1MaWNl bnNlLUlkZW50aWZpZXI6IChHUEwtMi4wKyBPUiBNSVQpCj4gPiA+ICsvLyBDb3B5cmlnaHQgKEMp IDIwMjIgQ2zDqW1lbnQgUMOpcm9uIDxwZXJvbi5jbGVtQGdtYWlsLmNvbT4KPiA+ID4gKwo+ID4g PiArLyB7Cj4gPiA+ICsgICAgIGdwdV9vcHBfdGFibGU6IG9wcC10YWJsZS1ncHUgewo+ID4gPiAr ICAgICAgICAgICAgIGNvbXBhdGlibGUgPSAib3BlcmF0aW5nLXBvaW50cy12MiI7Cj4gPiA+ICsK PiA+ID4gKyAgICAgICAgICAgICBvcHAtMjE2MDAwMDAwIHsKPiA+ID4gKyAgICAgICAgICAgICAg ICAgICAgIG9wcC1oeiA9IC9iaXRzLyA2NCA8MjE2MDAwMDAwPjsKPiA+ID4gKyAgICAgICAgICAg ICAgICAgICAgIG9wcC1taWNyb3ZvbHQgPSA8ODEwMDAwIDgxMDAwMCAxMjAwMDAwPjsKPiA+ID4g KyAgICAgICAgICAgICB9Owo+ID4gPiArCj4gPiA+ICsgICAgICAgICAgICAgb3BwLTI2NDAwMDAw MCB7Cj4gPiA+ICsgICAgICAgICAgICAgICAgICAgICBvcHAtaHogPSAvYml0cy8gNjQgPDI2NDAw MDAwMD47Cj4gPiA+ICsgICAgICAgICAgICAgICAgICAgICBvcHAtbWljcm92b2x0ID0gPDgxMDAw MCA4MTAwMDAgMTIwMDAwMD47Cj4gPiA+ICsgICAgICAgICAgICAgfTsKPiA+IAo+ID4gQXMgbWVu dGlvbmVkIGluIGNsb2NrIHBhdGNoIHJldmlldywgcmF0ZXMgYmVsb3cgMjg4IE1IeiBhcmUgZGVl bWVkCj4gPiB1bnN0YWJsZSBvbiBHUFUgUExMIGJ5IHZlbmRvciBHUFUga2VybmVsIGRyaXZlci4g QXQgbGVhc3QgaW4gdGhlIEJTUAo+ID4gdmVyc2lvbiB0aGF0IEkgaGF2ZS4gRGlkIHlvdSB0ZXN0 IHRoZXNlIHBvaW50cz8gSWYgbm90LCBiZXR0ZXIgdG8gZHJvcAo+ID4gdGhlbS4KPiAKPiBJIGNo YW5nZWQgdGhlIGdvdmVybm9yIHRvIHVzZXJzcGFjZSBhbmQgc2V0IHRoZSBmcmVxIHRvIDIxNk1I eiAvIDI2NE1Iego+IFJ1biBnbG1hcmsyIGFuZCBkaWRuJ3Qgb2JzZXJ2ZSBhbnkgZ2xpdGNoIG5v ciBpc3N1ZS4KPiAKPiBJJ20gbm90IHN1cmUgaWYgaXQncyBlbm91Z2ggdG8gc2F5IGl0J3Mgc3Rh YmxlIGJ1dCBJIGRpZG4ndCBvYnNlcnZlCj4gYW55IHN0cmFuZ2UgYmVoYXZpb3IuCgpPayB0aGVu LgoKRm9yZ290IHRvIGFzaywgd2hlcmUgZGlkIHlvdSBnZXQgMS4yIFYgYXMgYW4gdXBwZXIgbGlt aXQ/IEg2IGRhdGFzaGVldCBsaXN0cyAKbWF4LiBHUFUgdm9sdGFnZSBhcyAxLjA4IFYuCgpCZXN0 IHJlZ2FyZHMsCkplcm5lagoKPiAKPiBSZWdhcmRzLAo+IENsZW1lbnQKPiAKPiA+IEJlc3QgcmVn YXJkcywKPiA+IEplcm5lago+ID4gCj4gPiA+ICsKPiA+ID4gKyAgICAgICAgICAgICBvcHAtMzEy MDAwMDAwIHsKPiA+ID4gKyAgICAgICAgICAgICAgICAgICAgIG9wcC1oeiA9IC9iaXRzLyA2NCA8 MzEyMDAwMDAwPjsKPiA+ID4gKyAgICAgICAgICAgICAgICAgICAgIG9wcC1taWNyb3ZvbHQgPSA8 ODEwMDAwIDgxMDAwMCAxMjAwMDAwPjsKPiA+ID4gKyAgICAgICAgICAgICB9Owo+ID4gPiArCj4g PiA+ICsgICAgICAgICAgICAgb3BwLTMzNjAwMDAwMCB7Cj4gPiA+ICsgICAgICAgICAgICAgICAg ICAgICBvcHAtaHogPSAvYml0cy8gNjQgPDMzNjAwMDAwMD47Cj4gPiA+ICsgICAgICAgICAgICAg ICAgICAgICBvcHAtbWljcm92b2x0ID0gPDgxMDAwMCA4MTAwMDAgMTIwMDAwMD47Cj4gPiA+ICsg ICAgICAgICAgICAgfTsKPiA+ID4gKwo+ID4gPiArICAgICAgICAgICAgIG9wcC0zNjAwMDAwMDAg ewo+ID4gPiArICAgICAgICAgICAgICAgICAgICAgb3BwLWh6ID0gL2JpdHMvIDY0IDwzNjAwMDAw MDA+Owo+ID4gPiArICAgICAgICAgICAgICAgICAgICAgb3BwLW1pY3Jvdm9sdCA9IDw4MjAwMDAg ODIwMDAwIDEyMDAwMDA+Owo+ID4gPiArICAgICAgICAgICAgIH07Cj4gPiA+ICsKPiA+ID4gKyAg ICAgICAgICAgICBvcHAtMzg0MDAwMDAwIHsKPiA+ID4gKyAgICAgICAgICAgICAgICAgICAgIG9w cC1oeiA9IC9iaXRzLyA2NCA8Mzg0MDAwMDAwPjsKPiA+ID4gKyAgICAgICAgICAgICAgICAgICAg IG9wcC1taWNyb3ZvbHQgPSA8ODMwMDAwIDgzMDAwMCAxMjAwMDAwPjsKPiA+ID4gKyAgICAgICAg ICAgICB9Owo+ID4gPiArCj4gPiA+ICsgICAgICAgICAgICAgb3BwLTQwODAwMDAwMCB7Cj4gPiA+ ICsgICAgICAgICAgICAgICAgICAgICBvcHAtaHogPSAvYml0cy8gNjQgPDQwODAwMDAwMD47Cj4g PiA+ICsgICAgICAgICAgICAgICAgICAgICBvcHAtbWljcm92b2x0ID0gPDg0MDAwMCA4NDAwMDAg MTIwMDAwMD47Cj4gPiA+ICsgICAgICAgICAgICAgfTsKPiA+ID4gKwo+ID4gPiArICAgICAgICAg ICAgIG9wcC00MjAwMDAwMDAgewo+ID4gPiArICAgICAgICAgICAgICAgICAgICAgb3BwLWh6ID0g L2JpdHMvIDY0IDw0MjAwMDAwMDA+Owo+ID4gPiArICAgICAgICAgICAgICAgICAgICAgb3BwLW1p Y3Jvdm9sdCA9IDw4NTAwMDAgODUwMDAwIDEyMDAwMDA+Owo+ID4gPiArICAgICAgICAgICAgIH07 Cj4gPiA+ICsKPiA+ID4gKyAgICAgICAgICAgICBvcHAtNDMyMDAwMDAwIHsKPiA+ID4gKyAgICAg ICAgICAgICAgICAgICAgIG9wcC1oeiA9IC9iaXRzLyA2NCA8NDMyMDAwMDAwPjsKPiA+ID4gKyAg ICAgICAgICAgICAgICAgICAgIG9wcC1taWNyb3ZvbHQgPSA8ODYwMDAwIDg2MDAwMCAxMjAwMDAw PjsKPiA+ID4gKyAgICAgICAgICAgICB9Owo+ID4gPiArCj4gPiA+ICsgICAgICAgICAgICAgb3Bw LTQ1NjAwMDAwMCB7Cj4gPiA+ICsgICAgICAgICAgICAgICAgICAgICBvcHAtaHogPSAvYml0cy8g NjQgPDQ1NjAwMDAwMD47Cj4gPiA+ICsgICAgICAgICAgICAgICAgICAgICBvcHAtbWljcm92b2x0 ID0gPDg3MDAwMCA4NzAwMDAgMTIwMDAwMD47Cj4gPiA+ICsgICAgICAgICAgICAgfTsKPiA+ID4g Kwo+ID4gPiArICAgICAgICAgICAgIG9wcC01MDQwMDAwMDAgewo+ID4gPiArICAgICAgICAgICAg ICAgICAgICAgb3BwLWh6ID0gL2JpdHMvIDY0IDw1MDQwMDAwMDA+Owo+ID4gPiArICAgICAgICAg ICAgICAgICAgICAgb3BwLW1pY3Jvdm9sdCA9IDw4OTAwMDAgODkwMDAwIDEyMDAwMDA+Owo+ID4g PiArICAgICAgICAgICAgIH07Cj4gPiA+ICsKPiA+ID4gKyAgICAgICAgICAgICBvcHAtNTQwMDAw MDAwIHsKPiA+ID4gKyAgICAgICAgICAgICAgICAgICAgIG9wcC1oeiA9IC9iaXRzLyA2NCA8NTQw MDAwMDAwPjsKPiA+ID4gKyAgICAgICAgICAgICAgICAgICAgIG9wcC1taWNyb3ZvbHQgPSA8OTEw MDAwIDkxMDAwMCAxMjAwMDAwPjsKPiA+ID4gKyAgICAgICAgICAgICB9Owo+ID4gPiArCj4gPiA+ ICsgICAgICAgICAgICAgb3BwLTU3NjAwMDAwMCB7Cj4gPiA+ICsgICAgICAgICAgICAgICAgICAg ICBvcHAtaHogPSAvYml0cy8gNjQgPDU3NjAwMDAwMD47Cj4gPiA+ICsgICAgICAgICAgICAgICAg ICAgICBvcHAtbWljcm92b2x0ID0gPDkzMDAwMCA5MzAwMDAgMTIwMDAwMD47Cj4gPiA+ICsgICAg ICAgICAgICAgfTsKPiA+ID4gKwo+ID4gPiArICAgICAgICAgICAgIG9wcC02MjQwMDAwMDAgewo+ ID4gPiArICAgICAgICAgICAgICAgICAgICAgb3BwLWh6ID0gL2JpdHMvIDY0IDw2MjQwMDAwMDA+ Owo+ID4gPiArICAgICAgICAgICAgICAgICAgICAgb3BwLW1pY3Jvdm9sdCA9IDw5NTAwMDAgOTUw MDAwIDEyMDAwMDA+Owo+ID4gPiArICAgICAgICAgICAgIH07Cj4gPiA+ICsKPiA+ID4gKyAgICAg ICAgICAgICBvcHAtNzU2MDAwMDAwIHsKPiA+ID4gKyAgICAgICAgICAgICAgICAgICAgIG9wcC1o eiA9IC9iaXRzLyA2NCA8NzU2MDAwMDAwPjsKPiA+ID4gKyAgICAgICAgICAgICAgICAgICAgIG9w cC1taWNyb3ZvbHQgPSA8MTA0MDAwMCAxMDQwMDAwIDEyMDAwMDA+Owo+ID4gPiArICAgICAgICAg ICAgIH07Cj4gPiA+ICsgICAgIH07Cj4gPiA+ICt9Owo+ID4gPiArCj4gPiA+ICsmZ3B1IHsKPiA+ ID4gKyAgICAgb3BlcmF0aW5nLXBvaW50cy12MiA9IDwmZ3B1X29wcF90YWJsZT47Cj4gPiA+ICt9 Owo+ID4gPiAtLQo+ID4gPiAyLjM0LjEKCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJt LWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21h aWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4A386C38145 for ; Thu, 8 Sep 2022 16:26:40 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 777DC10EB59; Thu, 8 Sep 2022 16:26:38 +0000 (UTC) Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0981310EB59 for ; Thu, 8 Sep 2022 16:26:35 +0000 (UTC) Received: by mail-wm1-x32e.google.com with SMTP id bd26-20020a05600c1f1a00b003a5e82a6474so2206827wmb.4 for ; Thu, 08 Sep 2022 09:26:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=8G+gH/ZdR26aobBAiGz/oS5rrDj2ImSoc83kpV+wRO0=; b=Lv282Mf3K67NvyFxRebxNkdvzGhqee8D1XGpHHcftviyakUdO3xMzoYCg+7ZenogQZ CKFxMJlR8ohcfzJVgJ57xMj+pbdL51FR0qbpIGo3Gn7u/LGkCdtiR3Z3qO4qVPAn9E/o noppHKRaRu9xab32KqAAnEjlRkS7oZuRh5NQ9fvmOpGIv+HKAwY6qibOxLkU/jA3+PD8 1bP5t0dP6u+9zEyBjlP0V8W0yl3RqFf9NckOSqRXIlOPIgU24m6Yl1X9Xx/PMk5z2DXG 4TxqycZgZG+FXA1teIK6bNRkUpVxIl3aH/qXlJDeBwQFV2uO5kizVoGD+EIcpARKVPsh teuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=8G+gH/ZdR26aobBAiGz/oS5rrDj2ImSoc83kpV+wRO0=; b=q3vMLjhNu+qCotXUAdjZ/8BeBqbMGtKiausUka0MJLQs6F2qtp94tPqIggF4X1wu6/ a8ydmAo6BQo5nnxP8TuYj795K/GDqTXBO3S7WgSZNbCcSTYDjd/JjqCXjvToJG+j8LuD FbgDY1TYBsnGKqkYruso0mGUOocUF+w1J0Ba9UX4YYIe/j1G/z4oN7W95gM+kLk2ERWN ++6BUOmVBdcPYrcL5rUFp2IpSB8iLweuUbB9T/4L2fNCtev99K+qwPsv/nY4UxxGq1iD GCmsWAVZBuQrQtTmZkan2esCs4CTaE5vQ3gyc73LE9dw3Mhlg2aH2WQHi496JqLscp6/ HBFw== X-Gm-Message-State: ACgBeo2l5P4q6Dq0m9L4EwEkzK56Ow/ltxkmmgcXV9ISPZuJTuiheB1b at4wb6kduiLo+hUYBNLjF8ApGhWaE0Zc8Q== X-Google-Smtp-Source: AA6agR5g4fKQwejx0X+xvVpuFLeBu2IKV+p52yPrFDR1V4MFUXBQpznlKeIiBMa6kmzuxVxNcu+yvA== X-Received: by 2002:a05:600c:1c8f:b0:3b2:541c:dd34 with SMTP id k15-20020a05600c1c8f00b003b2541cdd34mr2737551wms.155.1662654393411; Thu, 08 Sep 2022 09:26:33 -0700 (PDT) Received: from kista.localnet (82-149-1-172.dynamic.telemach.net. [82.149.1.172]) by smtp.gmail.com with ESMTPSA id d22-20020a1c7316000000b003a5bd5ea215sm2973670wmb.37.2022.09.08.09.26.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Sep 2022 09:26:32 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: =?ISO-8859-1?Q?Cl=E9ment_P=E9ron?= Subject: Re: Re: [PATCH v4 3/5] arm64: dts: allwinner: h6: Add GPU OPP table Date: Thu, 08 Sep 2022 18:26:31 +0200 Message-ID: <1800669.atdPhlSkOF@kista> In-Reply-To: References: <20220906153034.153321-1-peron.clem@gmail.com> <12048299.O9o76ZdvQC@kista> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree , Samuel Holland , linux-kernel , dri-devel , Chen-Yu Tsai , Rob Herring , Krzysztof Kozlowski , linux-sunxi@lists.linux.dev, linux-arm-kernel Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Dne torek, 06. september 2022 ob 21:26:34 CEST je Cl=C3=A9ment P=C3=A9ron n= apisal(a): > Hi Jernej, >=20 > On Tue, 6 Sept 2022 at 21:10, Jernej =C5=A0krabec =20 wrote: > > Dne torek, 06. september 2022 ob 17:30:32 CEST je Cl=C3=A9ment P=C3=A9r= on=20 napisal(a): > > > Add an Operating Performance Points table for the GPU to > > > enable Dynamic Voltage & Frequency Scaling on the H6. > > >=20 > > > The voltage range is set with minimal voltage set to the target > > > and the maximal voltage set to 1.2V. This allow DVFS framework to > > > work properly on board with fixed regulator. > > >=20 > > > Signed-off-by: Cl=C3=A9ment P=C3=A9ron > > > --- > > >=20 > > > .../boot/dts/allwinner/sun50i-h6-gpu-opp.dtsi | 87 +++++++++++++++++= ++ > > > 1 file changed, 87 insertions(+) > > > create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-h6-gpu-opp.d= tsi > > >=20 > > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-gpu-opp.dtsi > > > b/arch/arm64/boot/dts/allwinner/sun50i-h6-gpu-opp.dtsi new file mode > > > 100644 > > > index 000000000000..b48049c4fc85 > > > --- /dev/null > > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-gpu-opp.dtsi > > > @@ -0,0 +1,87 @@ > > > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > > > +// Copyright (C) 2022 Cl=C3=A9ment P=C3=A9ron > > > + > > > +/ { > > > + gpu_opp_table: opp-table-gpu { > > > + compatible =3D "operating-points-v2"; > > > + > > > + opp-216000000 { > > > + opp-hz =3D /bits/ 64 <216000000>; > > > + opp-microvolt =3D <810000 810000 1200000>; > > > + }; > > > + > > > + opp-264000000 { > > > + opp-hz =3D /bits/ 64 <264000000>; > > > + opp-microvolt =3D <810000 810000 1200000>; > > > + }; > >=20 > > As mentioned in clock patch review, rates below 288 MHz are deemed > > unstable on GPU PLL by vendor GPU kernel driver. At least in the BSP > > version that I have. Did you test these points? If not, better to drop > > them. >=20 > I changed the governor to userspace and set the freq to 216MHz / 264MHz > Run glmark2 and didn't observe any glitch nor issue. >=20 > I'm not sure if it's enough to say it's stable but I didn't observe > any strange behavior. Ok then. =46orgot to ask, where did you get 1.2 V as an upper limit? H6 datasheet li= sts=20 max. GPU voltage as 1.08 V. Best regards, Jernej >=20 > Regards, > Clement >=20 > > Best regards, > > Jernej > >=20 > > > + > > > + opp-312000000 { > > > + opp-hz =3D /bits/ 64 <312000000>; > > > + opp-microvolt =3D <810000 810000 1200000>; > > > + }; > > > + > > > + opp-336000000 { > > > + opp-hz =3D /bits/ 64 <336000000>; > > > + opp-microvolt =3D <810000 810000 1200000>; > > > + }; > > > + > > > + opp-360000000 { > > > + opp-hz =3D /bits/ 64 <360000000>; > > > + opp-microvolt =3D <820000 820000 1200000>; > > > + }; > > > + > > > + opp-384000000 { > > > + opp-hz =3D /bits/ 64 <384000000>; > > > + opp-microvolt =3D <830000 830000 1200000>; > > > + }; > > > + > > > + opp-408000000 { > > > + opp-hz =3D /bits/ 64 <408000000>; > > > + opp-microvolt =3D <840000 840000 1200000>; > > > + }; > > > + > > > + opp-420000000 { > > > + opp-hz =3D /bits/ 64 <420000000>; > > > + opp-microvolt =3D <850000 850000 1200000>; > > > + }; > > > + > > > + opp-432000000 { > > > + opp-hz =3D /bits/ 64 <432000000>; > > > + opp-microvolt =3D <860000 860000 1200000>; > > > + }; > > > + > > > + opp-456000000 { > > > + opp-hz =3D /bits/ 64 <456000000>; > > > + opp-microvolt =3D <870000 870000 1200000>; > > > + }; > > > + > > > + opp-504000000 { > > > + opp-hz =3D /bits/ 64 <504000000>; > > > + opp-microvolt =3D <890000 890000 1200000>; > > > + }; > > > + > > > + opp-540000000 { > > > + opp-hz =3D /bits/ 64 <540000000>; > > > + opp-microvolt =3D <910000 910000 1200000>; > > > + }; > > > + > > > + opp-576000000 { > > > + opp-hz =3D /bits/ 64 <576000000>; > > > + opp-microvolt =3D <930000 930000 1200000>; > > > + }; > > > + > > > + opp-624000000 { > > > + opp-hz =3D /bits/ 64 <624000000>; > > > + opp-microvolt =3D <950000 950000 1200000>; > > > + }; > > > + > > > + opp-756000000 { > > > + opp-hz =3D /bits/ 64 <756000000>; > > > + opp-microvolt =3D <1040000 1040000 1200000>; > > > + }; > > > + }; > > > +}; > > > + > > > +&gpu { > > > + operating-points-v2 =3D <&gpu_opp_table>; > > > +}; > > > -- > > > 2.34.1