From: Simon Wunderlich <sw@simonwunderlich.de>
To: b.a.t.m.a.n@lists.open-mesh.org, Sven Eckelmann <sven@narfation.org>
Cc: "Linus Lüssing" <linus.luessing@c0d3.blue>
Subject: Re: [PATCH v7 0/3] Implementation of a Stateless Multicast Packet Type
Date: Wed, 08 Nov 2023 15:25:42 +0100 [thread overview]
Message-ID: <1801046.3VsfAaAtOV@prime> (raw)
In-Reply-To: <2193621.Icojqenx9y@sven-l14>
On Sunday, September 24, 2023 12:47:34 PM CET Sven Eckelmann wrote:
> @Simon, can you please also check the remaining code changes? To quickly
> identify modifications, you can use
>
> pipx install b4
> # in you batman-adv repo
> b4 diff -- 20230907010910.22427-2-linus.luessing@c0d3.blue
Sorry for the delay, this actually slipped through the cracks on my end ...
thanks Sven for reminding.
I've checked especially against the points I raised last time. I think
batadv_mcast_forw_shrink_pack_dests() looks much better now.
batadv_mcast_forw_scrub_dests() is still quite hard to comprehend, but better
than before - and good enough to be adopted in my opinion. We'll make sure to
direct bug reports from that to Linus in any case. ;)
So I'd give for this series:
Acked-by: Simon Wunderlich <sw@simonwunderlich.de>
Thank you!
Simon
next prev parent reply other threads:[~2023-11-08 14:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-07 1:09 [PATCH v7 0/3] Implementation of a Stateless Multicast Packet Type Linus Lüssing
2023-09-07 1:09 ` [PATCH v7 1/3] batman-adv: mcast: implement multicast packet reception and forwarding Linus Lüssing
2023-09-07 1:09 ` [PATCH v7 2/3] batman-adv: mcast: implement multicast packet generation Linus Lüssing
2023-09-07 1:09 ` [PATCH v7 3/3] batman-adv: mcast: shrink tracker packet after scrubbing Linus Lüssing
2023-09-24 10:47 ` [PATCH v7 0/3] Implementation of a Stateless Multicast Packet Type Sven Eckelmann
2023-11-08 14:25 ` Simon Wunderlich [this message]
2023-11-15 11:00 ` Sven Eckelmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1801046.3VsfAaAtOV@prime \
--to=sw@simonwunderlich.de \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=linus.luessing@c0d3.blue \
--cc=sven@narfation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.