From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v4 08/10] drivers/raw: support for rawdev testcases Date: Wed, 31 Jan 2018 15:01:46 +0100 Message-ID: <1801450.3p9ufv1Kd3@xps> References: <20180130145710.24757-1-shreyansh.jain@nxp.com> <20180131091318.7894-1-shreyansh.jain@nxp.com> <20180131091318.7894-9-shreyansh.jain@nxp.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Cc: dev@dpdk.org, hemant.agrawal@nxp.com, fiona.trahe@intel.com, rosen.xu@intel.com To: Shreyansh Jain Return-path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 77C381B7A2 for ; Wed, 31 Jan 2018 15:02:33 +0100 (CET) In-Reply-To: <20180131091318.7894-9-shreyansh.jain@nxp.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 31/01/2018 10:13, Shreyansh Jain: > Patch introduces rawdev unit testcase for validation against the > Skeleton rawdev dummy PMD implementation. >=20 > Test cases are added along with the skeleton driver implementation. > It can be enabled by using vdev argument to any DPDK binary: >=20 > --vdev=3D"rawdev_skeleton,self_test=3D1" >=20 > In case 'self_test=3D1' is not provided, autotest doesn't execute the > test cases but the vdev is still available for application use. >=20 > Signed-off-by: Shreyansh Jain More compilation errors on 32-bit: drivers/raw/skeleton_rawdev/skeleton_rawdev_test.c:277:50: error: cast from pointer to integer of different size [-Werror=3Dpointer-to-int-ca= st] ret =3D rte_rawdev_set_attr(TEST_DEV_ID, "Test2", (uint64_t)dummy_value); drivers/raw/skeleton_rawdev/skeleton_rawdev_test.c:283:19: error: format =E2=80=98%lu=E2=80=99 expects argument of type =E2=80=98long unsigne= d int=E2=80=99, but argument 6 has type =E2=80=98uint64_t {aka long long un= signed int}=E2=80=99 [-Werror=3Dformat=3D] ret_value); skeleton_rawdev.o: In function `skeleton_rawdev_probe': skeleton_rawdev.c:(.text+0x75c): undefined reference to `rte_kvargs_parse' skeleton_rawdev.c:(.text+0x782): undefined reference to `rte_kvargs_process' skeleton_rawdev.c:(.text+0x799): undefined reference to `rte_kvargs_free' skeleton_rawdev.c:(.text+0x814): undefined reference to `rte_kvargs_free' =46ixed: =2D-- a/drivers/raw/skeleton_rawdev/skeleton_rawdev_test.c +++ b/drivers/raw/skeleton_rawdev/skeleton_rawdev_test.c @@ -274,18 +274,18 @@ test_rawdev_attr_set_get(void) RTE_TEST_ASSERT(1, "Unable to allocate memory (dummy_value)= "); =20 *dummy_value =3D 200; =2D ret =3D rte_rawdev_set_attr(TEST_DEV_ID, "Test2", (uint64_t)dummy= _value); + ret =3D rte_rawdev_set_attr(TEST_DEV_ID, "Test2", (uintptr_t)dummy_= value); =20 /* Check if attributes have been set */ ret =3D rte_rawdev_get_attr(TEST_DEV_ID, "Test1", &ret_value); RTE_TEST_ASSERT_EQUAL(ret_value, 100, =2D "Attribute (Test1) not set correctly (%lu)", + "Attribute (Test1) not set correctly (%" PRIu= 64 ")", ret_value); =20 ret_value =3D 0; ret =3D rte_rawdev_get_attr(TEST_DEV_ID, "Test2", &ret_value); =2D RTE_TEST_ASSERT_EQUAL(*((int *)ret_value), 200, =2D "Attribute (Test2) not set correctly (%lu)", + RTE_TEST_ASSERT_EQUAL(*((int *)(uintptr_t)ret_value), 200, + "Attribute (Test2) not set correctly (%" PRIu= 64 ")", ret_value); And in previous patch: =2D-- a/drivers/raw/skeleton_rawdev/Makefile +++ b/drivers/raw/skeleton_rawdev/Makefile @@ -14,6 +14,7 @@ CFLAGS +=3D $(WERROR_FLAGS) LDLIBS +=3D -lrte_eal LDLIBS +=3D -lrte_rawdev LDLIBS +=3D -lrte_bus_vdev +LDLIBS +=3D -lrte_kvargs