From: David Howells <dhowells@redhat.com>
To: Matthew Garrett <mjg59@google.com>
Cc: dhowells@redhat.com, linux-fsdevel@vger.kernel.org,
Alexander Viro <viro@zeniv.linux.org.uk>,
stable@vger.kernel.org
Subject: Re: [PATCH V2] Fix mounting with MS_I_VERSION
Date: Wed, 18 Oct 2017 22:43:31 +0100 [thread overview]
Message-ID: <18015.1508363011@warthog.procyon.org.uk> (raw)
In-Reply-To: <20171018205626.25391-1-mjg59@google.com>
Matthew Garrett <mjg59@google.com> wrote:
> commit e462ec50cb5fa ("VFS: Differentiate mount flags (MS_*) from
> internal superblock flags") reworked the flags that are passed through
> do mount, and in the process dropped MS_I_VERSION. Confusingly, things
> continue working if the i_version mount option is used because that's
> directly passed to ext4 which interprets it, while iversion is turned
> into MS_I_VERSION and dropped on the floor. This breaks IMA and EVM and
> my heart. Pass SB_I_VERSION through, and update the consumers to use it
> instead of MS_I_VERSION.
>
> Signed-off-by: Matthew Garrett <mjg59@google.com>
> Cc: David Howells <dhowells@redhat.com>
> Cc: Alexander Viro <viro@zeniv.linux.org.uk>
> Cc: stable@vger.kernel.org
Reviewed-by: David Howells <dhowells@redhat.com>
next prev parent reply other threads:[~2017-10-18 21:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-18 20:56 [PATCH V2] Fix mounting with MS_I_VERSION Matthew Garrett
2017-10-18 21:43 ` David Howells [this message]
2017-10-18 22:52 ` Al Viro
2017-10-18 22:53 ` Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18015.1508363011@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=mjg59@google.com \
--cc=stable@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.