All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Tim E. Real" <termtech@rogers.com>
To: linux-media@vger.kernel.org
Subject: SAA7134 driver reports zero frame rate
Date: Sat, 16 Nov 2013 18:19:32 -0500	[thread overview]
Message-ID: <1802041.4NDiOr0LmV@col-desktop> (raw)

The SAA7134 driver causes libav to crash because the
 driver reports zero frame rate.
Thus it is virtually impossible to do any recording.

About a year ago I debugged and found I had to do this,
 (but it was not enough, more fixes would be needed):

In libav/libavdevice/v4l2.c :

static int v4l2_set_parameters(AVFormatContext *s1, AVFormatParameters *ap)
{
...
    s1->streams[0]->codec->time_base.den = tpf->denominator;
    s1->streams[0]->codec->time_base.num = tpf->numerator;

    // By Tim. BUG: The saa7134 driver (at least) reports zero framerate, 
    //  causing abort in rescale. So just force it.
    if(s1->streams[0]->codec->time_base.den == 0 || 
        s1->streams[0]->codec->time_base.num == 0)
    {
      s1->streams[0]->codec->time_base.num = 1;
      s1->streams[0]->codec->time_base.den = 30;
    }
      
    s->timeout = 100 +
        av_rescale_q(1, s1->streams[0]->codec->time_base,
                        (AVRational){1, 1000});

    return 0;
}

I looked at the SAA7134 module parameters but couldn't seem to
 find anything to help. 

Does anyone know how to make the module work so it sets a proper 
 frame rate, or if this problem been fixed recently?

Thanks for your help.
Tim.


             reply	other threads:[~2013-11-16 23:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-16 23:19 Tim E. Real [this message]
2013-11-17  3:21 ` SAA7134 driver reports zero frame rate Devin Heitmueller
2013-11-18  3:23   ` Tim E. Real

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1802041.4NDiOr0LmV@col-desktop \
    --to=termtech@rogers.com \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.