From: Krzysztof Kozlowski <krzk@kernel.org>
To: Arthur Kiyanovski <akiyano@amazon.com>,
Guangshuo Li <lgs201920130244@gmail.com>
Cc: David Arinzon <darinzon@amazon.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Ioana Ciornei <ioana.ciornei@nxp.com>,
Sang-Heon Jeon <ekffu200098@gmail.com>,
Dawei Feng <dawei.feng@seu.edu.cn>,
Amit Bernstein <amitbern@amazon.com>,
Netanel Belgazal <netanel@annapurnalabs.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH v2 1/2] net: ena: fix PHC cleanup on probe failure
Date: Tue, 22 Sep 2026 00:02:35 +0200 [thread overview]
Message-ID: <1804a859-371f-4bfa-ba48-d5cd26819cd3@kernel.org> (raw)
In-Reply-To: <179001756287.8372.475254242129499819.b4-review@b4>
On 21/09/2026 21:06, Arthur Kiyanovski wrote:
> On Mon, 21 Sep 2026 23:42:01 +0800, Guangshuo Li <lgs201920130244@gmail.com> wrote:
>> ena_probe() initializes the PHC as part of ena_device_init(), but the
>> probe failure path does not destroy it before freeing the PHC private
>> data.
>>
>> The normal removal path calls ena_phc_destroy() through
>> ena_destroy_device() before ena_phc_free(). However, if probe fails
>> after ena_device_init() succeeds, the error path reaches ena_phc_free()
>
> This part:
>
>> without unregistering the PTP clock or destroying the device PHC
>> resources.
>
> is inaccurate, see my explanation bellow.
>
Don't waste your time. This is AI slop agent posting (one of 500 more of
postings where agent does not care about replies).
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-09-21 22:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-21 15:42 [PATCH v2 0/2] net: ena: fix resource cleanup on probe failure Guangshuo Li
2026-09-21 15:42 ` [PATCH v2 1/2] net: ena: fix PHC " Guangshuo Li
2026-09-21 19:06 ` Arthur Kiyanovski
2026-09-21 22:02 ` Krzysztof Kozlowski [this message]
2026-09-22 2:12 ` Guangshuo Li
2026-09-23 6:42 ` netdev-bot+sashiko
2026-09-21 15:42 ` [PATCH v2 2/2] net: ena: fix MMIO read buffer leak " Guangshuo Li
2026-09-24 17:10 ` [PATCH v2 0/2] net: ena: fix resource cleanup " patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1804a859-371f-4bfa-ba48-d5cd26819cd3@kernel.org \
--to=krzk@kernel.org \
--cc=akiyano@amazon.com \
--cc=amitbern@amazon.com \
--cc=andrew+netdev@lunn.ch \
--cc=darinzon@amazon.com \
--cc=davem@davemloft.net \
--cc=dawei.feng@seu.edu.cn \
--cc=edumazet@google.com \
--cc=ekffu200098@gmail.com \
--cc=ioana.ciornei@nxp.com \
--cc=kuba@kernel.org \
--cc=lgs201920130244@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netanel@annapurnalabs.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.