From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 2/7] drm/omap: remove extra drm_gem_free_mmap_offset() call
Date: Sun, 13 Dec 2015 22:33:21 +0200 [thread overview]
Message-ID: <1805804.h5HYxpivd9@avalon> (raw)
In-Reply-To: <1449675491-9184-3-git-send-email-tomi.valkeinen@ti.com>
Hi Tomi,
Thank you for the patch.
On Wednesday 09 December 2015 17:38:06 Tomi Valkeinen wrote:
> drm_gem_object_release() calls drm_gem_free_mmap_offset(), so there's no
> need to call drm_gem_free_mmap_offset() in omap_gem_free_object().
>
> This patch removes the extra drm_gem_free_mmap_offset() call, and should
> have no side effects.
>
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
See "[PATCH 11/15] drm: omapdrm: gem: Don't free mmap offset twice" from my
dmabuf import series ;-)
> ---
> drivers/gpu/drm/omapdrm/omap_gem.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/omapdrm/omap_gem.c
> b/drivers/gpu/drm/omapdrm/omap_gem.c index 7ed08fdc4c42..f9ddbf53345c
> 100644
> --- a/drivers/gpu/drm/omapdrm/omap_gem.c
> +++ b/drivers/gpu/drm/omapdrm/omap_gem.c
> @@ -1282,8 +1282,6 @@ void omap_gem_free_object(struct drm_gem_object *obj)
> list_del(&omap_obj->mm_list);
> spin_unlock(&priv->list_lock);
>
> - drm_gem_free_mmap_offset(obj);
> -
> /* this means the object is still pinned.. which really should
> * not happen. I think..
> */
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2015-12-14 1:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-09 15:38 [PATCH 0/7] drm/omap: misc patches Tomi Valkeinen
2015-12-09 15:38 ` [PATCH 1/7] drm/omap: ensure all displays have been probed Tomi Valkeinen
2015-12-13 20:30 ` Laurent Pinchart
2015-12-16 15:45 ` Tomi Valkeinen
2015-12-09 15:38 ` [PATCH 2/7] drm/omap: remove extra drm_gem_free_mmap_offset() call Tomi Valkeinen
2015-12-13 20:33 ` Laurent Pinchart [this message]
2015-12-09 15:38 ` [PATCH 3/7] drm/omap: Use bitmaps for TILER placement Tomi Valkeinen
2015-12-09 15:38 ` [PATCH 4/7] drm/omap: remove unused plugin defines Tomi Valkeinen
2015-12-13 20:34 ` Laurent Pinchart
2015-12-09 15:38 ` [PATCH 5/7] drm/omap: set DRIVER_ATOMIC for omapdrm Tomi Valkeinen
2015-12-13 20:34 ` Laurent Pinchart
2015-12-09 15:38 ` [PATCH 6/7] drm/omap: remove obsolete manager assignment Tomi Valkeinen
2015-12-09 15:38 ` [PATCH 7/7] drm/omap: fix fbdev pix format to support all platforms Tomi Valkeinen
2015-12-13 20:35 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1805804.h5HYxpivd9@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.