From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7341BC54E67 for ; Thu, 14 Mar 2024 14:46:21 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.693311.1081227 (Exim 4.92) (envelope-from ) id 1rkmLP-0000zr-OT; Thu, 14 Mar 2024 14:46:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 693311.1081227; Thu, 14 Mar 2024 14:46:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rkmLP-0000zk-LW; Thu, 14 Mar 2024 14:46:07 +0000 Received: by outflank-mailman (input) for mailman id 693311; Thu, 14 Mar 2024 14:46:06 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rkmLO-0000ze-6Y for xen-devel@lists.xenproject.org; Thu, 14 Mar 2024 14:46:06 +0000 Received: from mail-qv1-xf2f.google.com (mail-qv1-xf2f.google.com [2607:f8b0:4864:20::f2f]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 94547899-e211-11ee-a1ee-f123f15fe8a2; Thu, 14 Mar 2024 15:46:03 +0100 (CET) Received: by mail-qv1-xf2f.google.com with SMTP id 6a1803df08f44-69145fc4265so5622496d6.1 for ; Thu, 14 Mar 2024 07:46:03 -0700 (PDT) Received: from [10.80.67.149] (default-46-102-197-194.interdsl.co.uk. [46.102.197.194]) by smtp.gmail.com with ESMTPSA id pt10-20020a056214048a00b00690494d2766sm524966qvb.96.2024.03.14.07.45.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 14 Mar 2024 07:46:00 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 94547899-e211-11ee-a1ee-f123f15fe8a2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=google; t=1710427561; x=1711032361; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=15TzI8ow3cv04JT6Ed7qn1VR0mROIfYxoNQPdLk0wik=; b=HOvj4qZKLZeLh0itABrkcxPA/4emWhwUA8tWDFhoQkgiPdVxgsDupjFdx3FLreDnyw wWo36SZJ8ha1JrAGuvA2YNt2sMcbSs8CIzr1+9zpF9bqJv9Z/ERPckO88ubjCFqXc2YY Asq6mG6+WGoAwtCSfMHRzjUJbxUhaOlurRwWw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710427561; x=1711032361; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=15TzI8ow3cv04JT6Ed7qn1VR0mROIfYxoNQPdLk0wik=; b=wc9uneP/Z77kEj/i6MBCw5T7Hd19uSxp9yfOaZuKHcreu+6a1vKWJ9LizHcvckO7vi cLz1lqTmRNMgBIcvYcly3n0pVNbrDnG/iZSJDwAB7A1RAZzLV7MbE0oDz70iWdIPje// f14MBoEOx72/WaEM0iSl3zbk/HekXs9neU8PvnfvvYbMsBXejN2E/LMnhvkUKuCGP64i 4zgUHfjEXCObAhKb7lvOMeonL7qc7s/Jwe2tKB6lWvkeAoaFXPkKuJEGEVInpHmcfvHl CkDM2y3EblbInl5uC1BVCaib9lC0MPh5PB6dryzHUhMSCIQSR+ZRarjn5cENUe2kNlRk zd0A== X-Gm-Message-State: AOJu0YxDbjQwjzbEDv1SZCJf7ms+Gok6C9Y7Tlf30b9Npf7idUK3MWE5 ft/XzJ4FBjSrUnc8kPhA9vyHLJQypiYC1qEtkDFTsxnygrBI26ExDtShYC6bnz5+W/DOJqpZF2n F X-Google-Smtp-Source: AGHT+IFMynwX6WM8JR/g9D3bHh2WUMiBrBKQmFWE+LqBAS/qc0SmP9KGY3XSGnrb8xtB9gh/cu71jQ== X-Received: by 2002:a0c:dd91:0:b0:691:2153:55ba with SMTP id v17-20020a0cdd91000000b00691215355bamr2160530qvk.45.1710427561080; Thu, 14 Mar 2024 07:46:01 -0700 (PDT) Message-ID: <1805b028-e21f-448f-bf94-2156092e40a5@citrix.com> Date: Thu, 14 Mar 2024 14:45:57 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [RISCV] [PATCH 0/7] xen/bitops: Reduce the mess, starting with ffs() Content-Language: en-GB To: Xen-devel Cc: Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Wei Liu , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Bertrand Marquis , Michal Orzel , Oleksii Kurochko , Shawn Anastasio , "consulting @ bugseng . com" , Simone Ballarin , Federico Serafini , Nicola Vetrini References: <20240313172716.2325427-1-andrew.cooper3@citrix.com> From: Andrew Cooper Autocrypt: addr=andrew.cooper3@citrix.com; keydata= xsFNBFLhNn8BEADVhE+Hb8i0GV6mihnnr/uiQQdPF8kUoFzCOPXkf7jQ5sLYeJa0cQi6Penp VtiFYznTairnVsN5J+ujSTIb+OlMSJUWV4opS7WVNnxHbFTPYZVQ3erv7NKc2iVizCRZ2Kxn srM1oPXWRic8BIAdYOKOloF2300SL/bIpeD+x7h3w9B/qez7nOin5NzkxgFoaUeIal12pXSR Q354FKFoy6Vh96gc4VRqte3jw8mPuJQpfws+Pb+swvSf/i1q1+1I4jsRQQh2m6OTADHIqg2E ofTYAEh7R5HfPx0EXoEDMdRjOeKn8+vvkAwhviWXTHlG3R1QkbE5M/oywnZ83udJmi+lxjJ5 YhQ5IzomvJ16H0Bq+TLyVLO/VRksp1VR9HxCzItLNCS8PdpYYz5TC204ViycobYU65WMpzWe LFAGn8jSS25XIpqv0Y9k87dLbctKKA14Ifw2kq5OIVu2FuX+3i446JOa2vpCI9GcjCzi3oHV e00bzYiHMIl0FICrNJU0Kjho8pdo0m2uxkn6SYEpogAy9pnatUlO+erL4LqFUO7GXSdBRbw5 gNt25XTLdSFuZtMxkY3tq8MFss5QnjhehCVPEpE6y9ZjI4XB8ad1G4oBHVGK5LMsvg22PfMJ ISWFSHoF/B5+lHkCKWkFxZ0gZn33ju5n6/FOdEx4B8cMJt+cWwARAQABzSlBbmRyZXcgQ29v cGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPsLBegQTAQgAJAIbAwULCQgHAwUVCgkI CwUWAgMBAAIeAQIXgAUCWKD95wIZAQAKCRBlw/kGpdefoHbdD/9AIoR3k6fKl+RFiFpyAhvO 59ttDFI7nIAnlYngev2XUR3acFElJATHSDO0ju+hqWqAb8kVijXLops0gOfqt3VPZq9cuHlh IMDquatGLzAadfFx2eQYIYT+FYuMoPZy/aTUazmJIDVxP7L383grjIkn+7tAv+qeDfE+txL4 SAm1UHNvmdfgL2/lcmL3xRh7sub3nJilM93RWX1Pe5LBSDXO45uzCGEdst6uSlzYR/MEr+5Z JQQ32JV64zwvf/aKaagSQSQMYNX9JFgfZ3TKWC1KJQbX5ssoX/5hNLqxMcZV3TN7kU8I3kjK mPec9+1nECOjjJSO/h4P0sBZyIUGfguwzhEeGf4sMCuSEM4xjCnwiBwftR17sr0spYcOpqET ZGcAmyYcNjy6CYadNCnfR40vhhWuCfNCBzWnUW0lFoo12wb0YnzoOLjvfD6OL3JjIUJNOmJy RCsJ5IA/Iz33RhSVRmROu+TztwuThClw63g7+hoyewv7BemKyuU6FTVhjjW+XUWmS/FzknSi dAG+insr0746cTPpSkGl3KAXeWDGJzve7/SBBfyznWCMGaf8E2P1oOdIZRxHgWj0zNr1+ooF /PzgLPiCI4OMUttTlEKChgbUTQ+5o0P080JojqfXwbPAyumbaYcQNiH1/xYbJdOFSiBv9rpt TQTBLzDKXok86M7BTQRS4TZ/ARAAkgqudHsp+hd82UVkvgnlqZjzz2vyrYfz7bkPtXaGb9H4 Rfo7mQsEQavEBdWWjbga6eMnDqtu+FC+qeTGYebToxEyp2lKDSoAsvt8w82tIlP/EbmRbDVn 7bhjBlfRcFjVYw8uVDPptT0TV47vpoCVkTwcyb6OltJrvg/QzV9f07DJswuda1JH3/qvYu0p vjPnYvCq4NsqY2XSdAJ02HrdYPFtNyPEntu1n1KK+gJrstjtw7KsZ4ygXYrsm/oCBiVW/OgU g/XIlGErkrxe4vQvJyVwg6YH653YTX5hLLUEL1NS4TCo47RP+wi6y+TnuAL36UtK/uFyEuPy wwrDVcC4cIFhYSfsO0BumEI65yu7a8aHbGfq2lW251UcoU48Z27ZUUZd2Dr6O/n8poQHbaTd 6bJJSjzGGHZVbRP9UQ3lkmkmc0+XCHmj5WhwNNYjgbbmML7y0fsJT5RgvefAIFfHBg7fTY/i kBEimoUsTEQz+N4hbKwo1hULfVxDJStE4sbPhjbsPCrlXf6W9CxSyQ0qmZ2bXsLQYRj2xqd1 bpA+1o1j2N4/au1R/uSiUFjewJdT/LX1EklKDcQwpk06Af/N7VZtSfEJeRV04unbsKVXWZAk uAJyDDKN99ziC0Wz5kcPyVD1HNf8bgaqGDzrv3TfYjwqayRFcMf7xJaL9xXedMcAEQEAAcLB XwQYAQgACQUCUuE2fwIbDAAKCRBlw/kGpdefoG4XEACD1Qf/er8EA7g23HMxYWd3FXHThrVQ HgiGdk5Yh632vjOm9L4sd/GCEACVQKjsu98e8o3ysitFlznEns5EAAXEbITrgKWXDDUWGYxd pnjj2u+GkVdsOAGk0kxczX6s+VRBhpbBI2PWnOsRJgU2n10PZ3mZD4Xu9kU2IXYmuW+e5KCA vTArRUdCrAtIa1k01sPipPPw6dfxx2e5asy21YOytzxuWFfJTGnVxZZSCyLUO83sh6OZhJkk b9rxL9wPmpN/t2IPaEKoAc0FTQZS36wAMOXkBh24PQ9gaLJvfPKpNzGD8XWR5HHF0NLIJhgg 4ZlEXQ2fVp3XrtocHqhu4UZR4koCijgB8sB7Tb0GCpwK+C4UePdFLfhKyRdSXuvY3AHJd4CP 4JzW0Bzq/WXY3XMOzUTYApGQpnUpdOmuQSfpV9MQO+/jo7r6yPbxT7CwRS5dcQPzUiuHLK9i nvjREdh84qycnx0/6dDroYhp0DFv4udxuAvt1h4wGwTPRQZerSm4xaYegEFusyhbZrI0U9tJ B8WrhBLXDiYlyJT6zOV2yZFuW47VrLsjYnHwn27hmxTC/7tvG3euCklmkn9Sl9IAKFu29RSo d5bD8kMSCYsTqtTfT6W4A3qHGvIDta3ptLYpIAOD2sY3GYq2nf3Bbzx81wZK14JdDDHUX2Rs 6+ahAA== In-Reply-To: <20240313172716.2325427-1-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 13/03/2024 5:27 pm, Andrew Cooper wrote: > Start cleaning it up with ffs() and friends. Across the board, this adds: > > * Functioning bitops without arch-specific asm It turns out that RISC-V doesn't have a CLZ instruction in the base ISA.  As a consequence, __builtin_ffs() emits a library call to ffs() on GCC, or a de Bruijn sequence on Clang. The optional Zbb extension adds a CLZ instruction, after which __builtin_ffs() emits a very simple sequence. This leaves us with several options. 1) Put generic_ffs() back in, although if we do this then it's going to be out-of-line in lib/ where it can be mostly ignored. 2) Require Zbb for Xen. 3) Alternative it up with Zbb or generic_ffs(). I've got half a mind to do 1) irrespective.  It's mostly just shuffling logic out of bitops.h into lib/. I also think we should do option 2 for RISCV.  Given the instruction groups that H does mandate, it's unrealistic to expect that such a chip wouldn't support Zbb/etc. Also, getting full alternatives working is yet-more work that's not trivial at this point in RISCV's development.  I think it is entirely reasonable to avoid this work for now, and make it a problem for anyone who has an H-capable Zbb-incapable system.  (with a strong implication that this is work that probably never needs to be done.) ~Andrew