Re: [PATCH 1/1] drm/i915/uc: Turn on GuC/HuC auto mode again

[Martin Peres <martin.peres@linux.intel.com>]

On 18/08/2019 18:51, Michal Wajdeczko wrote:
> We hope that now all issues related to missing uC firmwares
> are fixed and that driver can continue to load without GuC
> or HuC firmware available and running:
> 
>  - missing or corrupted HuC firmware has no impact to driver
>    load (clients should continue to use HUC_STATUS to check
>    if HuC firmware was loaded and authenticated)
> 
>  - missing or corrupted GuC firmware has no impact to driver
>    load (unless GuC firmware blob was overridden by the user
>    or GuC submission was requested or GuC was previously
>    enabled on this system without reboot - then we will mark
>    GPU as wedged and continue with KMS only)

Please hold merging this patch, as many more items need to be crossed
off before such a patch can land.

Such items include:

 - Assess all the existing GUC-related bugs, and prove they won't
suddenly get seen by more users
 - add fault injection to the FW loading path
 - add IGT tests to make sure driver behaves well on different FW
loading errors

Martin

> 
> References: commit f774f0964919 ("drm/i915/guc: Turn on GuC/HuC auto mode")
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
> ---
>  drivers/gpu/drm/i915/i915_params.c | 2 +-
>  drivers/gpu/drm/i915/i915_params.h | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c
> index 296452f9efe4..b4f481e1e6b6 100644
> --- a/drivers/gpu/drm/i915/i915_params.c
> +++ b/drivers/gpu/drm/i915/i915_params.c
> @@ -146,7 +146,7 @@ i915_param_named_unsafe(edp_vswing, int, 0400,
>  i915_param_named_unsafe(enable_guc, int, 0400,
>  	"Enable GuC load for GuC submission and/or HuC load. "
>  	"Required functionality can be selected using bitmask values. "
> -	"(-1=auto, 0=disable [default], 1=GuC submission, 2=HuC load)");
> +	"(-1=auto [default], 0=disable, 1=GuC submission, 2=HuC load)");
>  
>  i915_param_named(guc_log_level, int, 0400,
>  	"GuC firmware logging level. Requires GuC to be loaded. "
> diff --git a/drivers/gpu/drm/i915/i915_params.h b/drivers/gpu/drm/i915/i915_params.h
> index d29ade3b7de6..5736c55694fe 100644
> --- a/drivers/gpu/drm/i915/i915_params.h
> +++ b/drivers/gpu/drm/i915/i915_params.h
> @@ -54,7 +54,7 @@ struct drm_printer;
>  	param(int, disable_power_well, -1) \
>  	param(int, enable_ips, 1) \
>  	param(int, invert_brightness, 0) \
> -	param(int, enable_guc, 0) \
> +	param(int, enable_guc, -1) \
>  	param(int, guc_log_level, -1) \
>  	param(char *, guc_firmware_path, NULL) \
>  	param(char *, huc_firmware_path, NULL) \
> 
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx